[05:27:18] Anybody home? I have a technical question regarding Github [05:28:42] Just ask, maybe someone will answer later. [05:32:22] I forked a repository on Github and made a patch https://github.com/WikiDiscoverer/jquery.uls/pull/1/files [05:32:47] This is related to Universal Language Selector (ULS) [05:33:22] hmm [05:33:25] so is this patch sufficient or do I need to do something more before it can be merged? [05:33:30] you made a pull request against your own repository I think [05:34:27] legoktm: Yes, I don't know whether I can switch it to the master repostiory because I'm not a member of the Wikimedia organisation in Github [05:35:03] TheDiscoverer: https://github.com/wikimedia/jquery.uls/pull/247 [05:35:04] legoktm: So i think I can't create a branch on the master repository [05:35:36] TheDiscoverer: it's a bit confusing, you would have made your edit in your fork, and then you go back to the main wikimedia repository and click "submit pull request" from there [05:35:41] but I did it for you [05:35:57] legoktm: so I could have done it myself? [05:35:59] yes [05:36:03] legoktm: thanks [05:36:55] legoktm: ok I have another one, let me try to do it myself https://github.com/WikiDiscoverer/jquery.ime/pull/1/files [05:37:23] on https://github.com/wikimedia/jquery.ime click "new pull request" [05:38:17] legoktm: then? [05:38:34] does it not bring up your fork? [05:38:54] you should just need to pick the branch you created [05:40:22] legoktm: is this it? https://github.com/wikimedia/jquery.ime/pull/459 [05:40:35] yep, nice! [05:41:21] legoktm: Thanks a lot! :) :) :) My first Github pull requests [05:41:43] np and congrats! [05:42:21] legoktm: this has been pending for a year just for this simple patch! https://phabricator.wikimedia.org/T137222 [05:50:06] legoktm: Thanks and have a nice day! Goodbbye! :) [05:50:10] o/ [07:56:16] [[Tech]]; ArchiverBot; Bot: Archiving 6 threads (older than 30 days) to [[Tech/Archives/2016]], [[Tech/Archives/2015]].; https://meta.wikimedia.org/w/index.php?diff=16269324&oldid=16268389&rcid=8901861 [13:29:48] I updated https://www.mediawiki.org/wiki/Events/FOSDEM/2017 [18:47:43] https://opensource.googleblog.com/2017/01/announcing-google-code-in-2016-winners.html