[00:32:46] <Johnbot>	 Hello ToBeCloud
[00:32:58] <ToBeCloud>	 Hi Johnbot :) 
[00:33:03] <Yvette>	 TimStarling: https://phabricator.wikimedia.org/T150417#2895236
[00:36:19] <Johnbot>	 Hello qchris
[00:42:38] <Johnbot>	 Hello cmjohnson and aude_
[00:48:07] <Johnbot>	 Hello trobotham
[00:48:10] <TimStarling>	 Yvette: in MW we've tried to make lots of things localizable, but the idea with lua was to adopt existing solutions
[00:48:50] <TimStarling>	 maybe Johnbot can have a +q, that is a pretty obnoxious script
[00:51:23] <TimStarling>	 Yvette: the standard solution for code is pretty clear
[00:52:45] <TimStarling>	 that is, keywords and other platform things are in english, comments, variables and other local identifiers are in the local language
[00:53:42] <TimStarling>	 many of the languages that we use have inventors that didn't speak english as a first language, but they all use fixed english keywords
[01:07:18] <Yvette>	 TimStarling: Would you call ParserFunctions code? Should we remove localization from it?
[01:07:35] <Yvette>	 I forgot about https://github.com/wikimedia/mediawiki-extensions-ParserFunctions/blob/master/ParserFunctions.i18n.magic.php
[01:08:20] <Yvette>	 Maybe we just call ParserFunctions deprecated and this can be one of the reasons why. ;-)
[01:09:30] <TimStarling>	 I don't think it's relevant whether it is code or not
[01:09:42] <TimStarling>	 and no, I don't think it should be deprecated
[01:13:11] <Yvette>	 All right.
[01:48:26] <TimStarling>	 how can there be so many diff preferences in gerrit, but none to remove those stupid fake scrollbars?
[01:49:08] <TimStarling>	 now, not only do you have 2000px of horizontal scrolling, the scrollbars are removed and the overflow is hidden
[01:49:21] <TimStarling>	 the only way to search for something from the diff page is to get a wider monitor
[02:13:36] <quiddity>	 TimStarling, I tried turning on "Line Wrapping" in the prefs, and that helped a bit, on some example diffs I had open. Do you have a particularly extreme example handy? If it's unfixable via prefs, maybe someone can hack together a greasemonkey/stylish script to fix it...
[02:14:30] <TimStarling>	 if the code is too wide, you get a (fake) horizontal scroll bar
[02:14:49] <TimStarling>	 the problem is that the UI header at the top is too wide
[02:14:54] <bd808>	 Its CodeMIrror
[02:15:04] <TimStarling>	 but I'm on to a more interesting gerrit bug now
[02:15:10] <bd808>	 it messes with everything :/
[02:15:23] <TimStarling>	 what is CodeMirror?
[02:16:01] <bd808>	 the thing that makes all of gerrit's scrollbars fake
[02:16:30] <bd808>	 they added it for online editing and then decided to use it in the diff view too
[02:16:40] <quiddity>	 I was comparing these 2 (with horizontal scrollbars visible/vanished in background): http://imagizer.imageshack.com/img921/5708/a5qjtM.png
[02:16:42] <quiddity>	 vs http://imagizer.imageshack.com/img923/8545/wnNHzr.png
[02:17:29] <TimStarling>	 the more interesting bug is the fact that unified diffs are showing the wrong content
[02:17:51] <TimStarling>	 I am seeing lines from the LHS appear as if they are on the RHS, which is kind of concerning
[02:18:25] <TimStarling>	 see line 451 of https://gerrit.wikimedia.org/r/#/c/327112/9/includes/parser/BlockLevelPass.php,unified
[02:18:59] <TimStarling>	 you see there is a duplicated comment "# Nothing else interesting to find; abort!", once with an extra tab, once with the right number of tabs
[02:19:02] <TimStarling>	 the first comment is from the LHS
[02:19:39] <TimStarling>	 the bug also causes the line numbers to be incorrect
[02:19:57] <TimStarling>	 "# Nothing else interesting to find; abort!" is actually on line 450
[02:20:09] <bd808>	 I don't see it duplicated interestingly enough
[02:20:51] <TimStarling>	 time for trying different browsers I guess
[02:21:33] <TimStarling>	 have you got intraline differences enabled?
[02:21:55] <bd808>	 ys
[02:21:58] <bd808>	 *yes
[02:23:53] <bd808>	 pasted a screen shot here -- https://phabricator.wikimedia.org/P4666
[02:24:24] <bd808>	 I have a bunch of css hacks for gerrit that may change something. not sure
[02:25:17] <bd808>	 css hacks are here -- https://github.com/bd808/userscripts/blob/gh-pages/wmfgerrit.user.css
[02:29:45] <TimStarling>	 ok, so I started the same version of firefox with an empty profile and -no-remote
[02:30:02] <TimStarling>	 and set up the exact same diff preferences, and the bug is still not reproduced
[02:41:12] <TimStarling>	 log out on browser 1, no bug, log back in, bug returns
[02:58:14] <TimStarling>	 ok, some progress
[02:58:22] <TimStarling>	 this is not how I imagined spending my afternoon
[02:58:48] <TimStarling>	 when you enable/disable "ignore whitespace", the diff is persistently corrupted
[02:58:57] <TimStarling>	 in some random way
[03:09:02] <TimStarling>	 it looks like you have to set that option in your preferences and then load a diff page
[03:27:14] <TimStarling>	 tgr, or anyone else online who has a gerrit account, can you help to confirm this bug?
[03:27:43] <TimStarling>	 in your gerrit preferences, under "diff", select ignore whitespace = all
[03:27:52] <TimStarling>	 then visit https://gerrit.wikimedia.org/r/#/c/327112/9/includes/parser/BlockLevelPass.php,unified
[03:29:00] <TimStarling>	 at RHS line 451-457 there should be duplicated content
[03:31:45] <tgr>	 TimStarling: I don't see it
[03:31:57] <TimStarling>	 ok, thanks
[03:33:40] <tgr>	 TimStarling: do you mean the "# We're nested" comment line? that does show up twice in the added lines, but with slightly different content
[03:34:36] <tgr>	 and break 2 is removed twice, so yeah, there is some duplication
[03:35:01] <tgr>	 or rather, a coloring error I suppose
[03:36:04] <TimStarling>	 ok
[03:36:10] <TimStarling>	 I'll do a screenshot of what I see
[03:37:00] <tgr>	 TimStarling: https://phab.wmfusercontent.org/file/data/hieiomfj762tl3ylq2sy/PHID-FILE-w7dmcchsahg63xsqefzb/gerrit_diff_no-whitespace.png
[03:38:10] <tgr>	 https://phab.wmfusercontent.org/file/data/qjkdowbcztbcyqbcirz4/PHID-FILE-algb6cdphbrbx7sgpxm6/gerrit_diff_prefs.png
[03:38:28] <TimStarling>	 yeah, that is broken in a slightly different way, but definitely broken
[03:38:49] <TimStarling>	 http://tstarling.com/stuff/diff-fail.png
[03:38:59] <TimStarling>	 that's what I get
[03:39:24] <TimStarling>	 what exactly you get probably depends on other diff preferences, like context lines
[03:40:29] <tgr>	 on the bright side, gerrit is about to get another UI revamp so soon everything will be broken in different ways!
[03:40:40] <TimStarling>	 yay
[03:42:08] <tgr>	 wow, even the line numbers are completely different between the two screenshots
[03:42:23] <tgr>	 I wonder what would happen to inline comments
[03:55:54] <TimStarling>	 filed https://bugs.chromium.org/p/gerrit/issues/detail?id=5191
[07:56:00] <snitch>	 [[Tech]]; ArchiverBot; Bot: Archiving 1 thread (older than 30 days) to [[Tech/Archives/2016]].; https://meta.wikimedia.org/w/index.php?diff=16178025&oldid=16169897&rcid=8717955
[09:42:21] <Urbanecm>	 Hi all, where I can ask a question about Education program extension?
[09:45:03] <Nemo_bis>	 Urbanecm: on its talk page?
[09:46:51] <Urbanecm>	 Nemo_bis, thanks. 
[22:45:11] <bd808>	 If anyone is tired of reviewing PHP code and would like a change of pace, lots of fun python/django code for folks to review -- https://gerrit.wikimedia.org/r/#/q/status:open+project:labs/striker