[00:11:33] I have a question [00:11:51] if I include a user.css or .js which is a redirect to actual code [00:11:54] does it still work? [00:12:35] Try it? [00:12:54] I am a bit unsure how to tes it... Hmm [00:13:07] I have an idea [00:15:46] it doesnt seem to work, is that expected? [00:16:15] https://meta.wikimedia.org/wiki/User:%E3%81%A8%E3%81%82%E3%82%8B%E7%99%BD%E3%81%84%E7%8C%AB/global.js is this correct? [00:19:39] is it really hard to get a straigh forward answer [00:28:09] Reedy I am already quite tired of arguing that double redirects should be resolved, not kept. Could you cut me some slack here? [00:28:22] I don't know [00:28:29] I'm not being a dick [00:28:29] -_- [00:28:35] I did not say you were. [00:28:37] The simplest answer to many questions is to try it [00:28:41] We have a history man :) [00:28:56] I tried it and it did not seem to work. [00:29:22] which raises the question that redirected .js and probably .css pages are unhelpful. [00:29:38] Which was more of a statement than question. [00:30:04] I'd presume they wouldn't [00:30:16] Cause MW isn't parsing wikitext [00:31:15] Yeah [00:34:51] hi [00:35:31] Hi lbertolotti [00:36:51] marktraceur, do you somethin about templates_ [00:37:06] lbertolotti: I know something, maybe not much, but go ahead and ask :) [00:37:51] https://en.wikipedia.org/wiki/Template:Selected_picture [00:38:10] if you look at this template from the wikipedia app [00:38:27] you will see that there is something wrong with the centering [00:38:29] of the picture [00:38:50] lbertolotti: I don't have the WP app currently, sorry. Someone else may need to help you confirm. [00:39:31] the thing is [00:39:45] some of the coding people regularly use for web pages [00:39:52] doesn't work well with the wikipedia app [00:40:01] Mobile is special [00:40:43] well I left a note at the talk page [00:40:52] https://www.amazon.co.uk/CSS-AWESOME-Funny-Novelty-Programmers/dp/B00EZ3Y5RW [00:40:54] maybe someone will take a look at that [00:40:59] See also ^ [00:41:12] I have the app what needs confirmed [00:41:25] Zppix: See the link above...Template:Selected picture [00:41:40] Ok [00:43:09] Its poorly formatted [00:43:38] And centering is shit [00:45:51] Zppix, so what you think can be done [00:45:52] ? [00:46:09] there has to be some sort of solution [00:46:29] Someone with template dev knowledge around? [00:46:50] the point is [00:47:14] there must be someone who understands how the app reads the code [00:48:38] Try the mobile team [00:48:44] They exist for a reason [00:51:08] what channel is that? [00:51:27] -mobile! [00:51:28] ? [00:56:51] I'm there [01:29:01] well nobody said anything in wikipedia-mobile [01:29:17] File a task and wait? [01:31:01] lbertolotti: there are many people, across many timezones in our IRC channels, you won't always receive a instant response [01:31:37] I've waited 20 min [01:32:00] I thought IRC channel was a way talking in real time [01:42:06] lbertolotti: it is, assuming the people are at their computers and are available [01:42:07] lbertolotti: IRC is usually asynchronous [01:42:24] lbertolotti: The people who usually work on the mobile app are, I think, mostly SF-based and have pretty regular hours [01:42:24] I see [01:43:16] So SF is a kind of development center? [01:44:37] lbertolotti: The Wikimedia Foundation, which employs many of the people who develop the app, is headquartered there. We have employees across the world, but SF is a heavy centre, yes. [02:42:05] ToAruShiroiNeko: you need the magic /*#REDIRECT*/ comment in front of the mw.loader.load call [14:30:59] Can someone help me out with a module? I need it to display a different plural depending on the type of page it's on. [20:31:32] wm-bot is restarting. [23:13:11] who is bored and wants to help me (and the enwiki community) with a SQL query? [23:14:46] musikanimal: How bored must this person be? [23:15:18] hmm, maybe 10 minutes at most if you're really good? which I know you are... :) [23:15:25] What're you trying to do? [23:16:11] trying to identify editors who qualify to be "grandfathered" into the "new page patroller" right [23:16:31] this new user group was just introduced, and we don't want to make the qualified folks have to request it [23:16:36] What's the criteria? [23:17:03] let make sure I get it exactly right [23:18:19] 200 manual patrols (either as a page curation review or native patrol) since 1 January 2016, and no blocks during that time [23:18:45] I've tried several things but have no gotten the full list yet [23:19:06] it seems the pagetriage_log table is missing data, as it's supposed to track both normal patrols and page curation reviews [23:19:25] so it's probably better to go off of the normal logging table, and somehow make sure you capture "manual" patrols [23:20:38] https://quarry.wmflabs.org/query/13778 <~ this does what we want (minus checking blocks), but log_action='patrol' doesn't restrict it to manual patrols [23:20:40] As far as I can see... patrolled is only logged in the recentchanges table [23:21:28] The blocks part should be easy.. [23:21:30] hmm no there's a log_type = 'patrol' in the logging table [23:21:44] I think you have to use log_params to restrict it to manual patrols [23:22:09] but that column is a string, and it's unclear how to query it efficiently [23:23:03] You can't query log_params efficiently [23:23:23] how does it work at Special:Log/patrol ? there you can restrict to "manual" [23:23:40] not sure how to find that SQL [23:24:02] '6:bool:auto', [23:24:06] '6::auto' => '6:bool:auto', [23:24:11] That'd be what you're looking for in params [23:24:38] let's see how we get to t hat page [23:25:23] musikanimal: the block part of the sql query is easy enough [23:25:46] yeah, and if we want we can just get the patrol part and loop through to figure out if they've been blockd [23:25:51] that's a fast query [23:26:03] should be able to do it all in one [23:26:09] dunno how it'd look in a query planner though [23:26:13] but explain should tell us [23:26:50] also restrict log_namespace to 0 [23:27:46] I'm trying to work out how the Log/patrol does it [23:28:07] I guess it's PatrolLog class [23:28:32] Except, that's for recording [23:30:13] musikanimal: so [23:30:15] for auto [23:30:15] AND log_type = 'patrol' AND log_action = 'autopatrol' [23:30:33] right, we want log_action = 'patrol' though [23:30:33] for manual [23:30:34] AND log_type = 'patrol' AND log_action = 'patrol' [23:30:39] yeah [23:30:50] that doesn't seem to do it, for some reason https://quarry.wmflabs.org/query/13778 [23:31:07] doesn't seem to do what? [23:31:26] or maybe it's a bug... [23:31:28] https://en.wikipedia.org/w/index.php?title=Special%3ALog&type=patrol&user=ClueBot+NG&page=&year=&month=-1&tagfilter=&subtype=patrol [23:31:31] That's what MW is doing locally [23:31:32] SELECT /* IndexPager::buildQueryInfo (LogPager) 10.0.0.39 */ log_id,log_type,log_action,log_timestamp,log_user,log_user_text,log_namespace,log_title,log_comment,log_params,log_deleted,user_id,user_name,user_editcount,(SELECT GROUP_CONCAT(ct_tag SEPARATOR ',') FROM `mw_change_tag` WHERE ct_log_id=log_id ) AS `ts_tags` FROM `mw_logging` LEFT JOIN `mw_user` ON ((log_user=user_id)) WHERE (log_type NOT IN ('titleblacklist',' [23:31:32] petition','suppress')) AND log_type = 'patrol' AND log_action = 'patrol' ORDER BY log_timestamp DESC LIMIT 51 [23:31:38] ClueBot NG has made zero "manual" patrols [23:32:01] ^ SQL from local dev wiki when filtering by... manual [23:32:24] if you use Special:Log/patrol for ClueBot_NG and set it to "manual", you see "ClueBot_NG ... automatically marked revision ..." [23:32:50] it should be "User ... marked revision ... as patrolled" [23:32:53] like https://en.wikipedia.org/w/index.php?title=Special%3ALog&type=patrol&user=MusikAnimal&page=&year=&month=-1&tagfilter=&subtype=patrol [23:33:36] Well, that sounds like some bug in MW [23:33:41] yeah [23:33:57] Or, no offence meant, some misunderstanding on how patrol works [23:34:03] FWIW, I have no idea about patrol [23:34:19] I could have it all wrong too [23:34:32] heh :) [23:34:38] File a task about it, someone will soon tell you [23:34:52] it's a bit odd that when you select "manual", some say "automatic" and others do not [23:35:01] There's probably some reason [23:35:13] musikanimal: ok, so we can do the query based on what MW does for those cases... And know we're filtering correctly [23:35:16] I would go by https://quarry.wmflabs.org/query/13778 and loop through but there's 9.479 results [23:36:17] I will file a phab though [23:46:26] musikanimal: https://quarry.wmflabs.org/query/13787 and https://quarry.wmflabs.org/query/13788 [23:47:38] nice, that brings down the total by about 500, which is an improvement [23:47:49] I would do WHERE log_type = 'patrol' AND log_action = 'patrol' AND log_timestamp > '20160101000000' too [23:47:56] so you're obviously following an index [23:48:07] right [23:48:19] depends if mysql is feeling smart [23:48:51] I wonder if it'd be better to force it to use type_action [23:49:27] https://phabricator.wikimedia.org/T149756 [23:50:06] type_action? where does that live? [23:50:40] it's an index on the table [23:51:14] It seems, even doing USE INDEX (type_action) uses a temporary [23:51:31] Key 'type_action' doesn't exist in table 'logging' [23:51:35] Meh, no worky on querry [23:52:17] oh, not in replicas perhaps? I didn't think logging had a type_action column [23:53:24] it might be with the views that labs exposes [23:56:23] well thank you for your help Reedy ! I'm going to assume the worst that we can't efficiently get the list we want [23:56:37] musikanimal: It doesn't take that long [23:56:42] So I wouldn't worry about it [23:58:25] musikanimal: You could get away with running that on a production slave tbh [23:59:02] well we're still not getting the data we want either way [23:59:36] I think these days people tend to run those against the analytics database servers instead [23:59:40] I believe it is in fact a bug, perhaps in that PatrolLog class