[01:22:31] can someone guide me how to push an extension project to phabricator via git [01:23:30] or link me the relevant irc channel for this question [01:28:33] Cant [01:28:37] Push to phab [01:28:41] Only gerrit [01:28:49] Which goes to phab [01:34:03] okay [01:34:24] What extension [01:34:26] ? [01:36:20] https://phabricator.wikimedia.org/diffusion/1904/ [01:36:36] also this : https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/StlHandler [01:37:21] just wondering if they are linked cause the gerrit one was created several months ago and phab proiject just recently [01:37:28] Yes [01:37:40] Actually wait [01:39:39] Authentication seems to fail anyway when pushing [01:40:41] Ssh or http [01:41:33] http [01:41:55] Anom or just http [01:42:00] Anonymous [01:42:45] it asks for user and pass [01:42:52] and then says auth fails [01:43:20] Pushing to Phabricator? Hold on. [01:45:04] You have to use a public key it looks like. [01:45:08] Matthew_: 99% sure your unable unless your an phab admin [01:45:15] https://secure.phabricator.com/book/phabricator/article/diffusion_hosting/ [01:45:54] Or they could have disabled it. [01:46:39] i have a public key on gerrit set up [01:48:03] my idea was to relocate my ext from github to gerrit/phab [01:48:12] What about mediawiki HarriA [01:48:33] worry? [01:48:36] sorry [01:48:38] ? [01:49:09] Mediawiki.wikimedia.org [01:49:14] Sorry [01:49:18] Mediawiki.org [01:50:04] im not sure what you mean [01:51:24] You have to put a key in user settings there aswell [01:53:47] okay [01:54:01] i don't see the option under preferences there though [01:55:37] should be openstack [01:58:41] openstack? [01:59:22] lol guys, don't misinform ppl ;) [01:59:51] I'll be honest I'm confused. [02:00:35] Sorry its wikitech [02:00:59] Im doing 35 things at the time i cant think [02:03:02] to be clear , HarriA , you wan't to just push a change to a review branch, or trying to claim maintainership of the repo in case this is your extension? [02:03:16] the latter [02:04:52] both go through this https://www.mediawiki.org/wiki/Gerrit/Tutorial though. You need to set your ssh keys in wikitech and gerrit to access repos. Fir the latter let me look some more manuals [02:06:20] Oh wait. You already own that submodule repo, so should be good to go : https://gerrit.wikimedia.org/r/#/admin/groups/1197,members [02:06:48] i was onan say yeah, i have worked with git before [02:07:09] anyway, i added the key to wikitech, but still giving me Permission denied (publickey). fatal: Could not read from remote repository. [02:08:12] Just set your keys, and follow the tutorial . You have to set the same key in https://gerrit.wikimedia.org/r/#/settings/ssh-keys also [02:09:04] had the key in gerrit already from some earlier time [02:09:23] let me consult with the tutorial tho too,. its getting late... [02:12:28] Both wikitech and Gerrit. Also https://phabricator.wikimedia.org/settings/user/HarriA/page/ssh/ too for proper attribution/showing of profile on commits that are synced to diffusion [02:14:10] Otherwise diffusion commits show gerrit style attribution (user ) [02:19:26] fatal: unable to access 'https://phabricator.wikimedia.org/diffusion/1904/extension-stlhandler.git/': The requested URL returned error: 403 [02:20:04] Use gerrit not phab [02:21:25] i didnt specify it [02:21:27] at all [02:22:19] installed gitreview, used git add . and then git review -R [02:22:41] git commit was before the las one also tho [02:24:15] The clone url is at https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/StlHandler [02:24:38] yeah [02:24:47] but i dint specify the url at all [02:25:05] how did it know to try toi push to phab url [02:26:46] as the tutorial says , you clone the repo first and only then pull/make-changes/commit/send-to-review [02:27:53] that is if your gitconfig is already correctly configured with your settings [02:28:46] should be [02:28:48] but [02:28:48] Cloning into 'StlHandler'... Permission denied (publickey). [02:29:02] i fail at everything possible it seems [02:30:06] git remote show origin [02:30:25] you see correct fetch/push urls? [02:31:23] i see only fatal: 'origin' does not appear to be a git repository [02:31:23] should be ssh://youruser@... [02:32:02] did you cloned your repo lol [02:32:41] fromthe gerrit page above, not from the anonymous http url that is hown in phabricator [02:32:54] s* [02:33:16] yeah, it gave me the [02:33:17] Cloning into 'StlHandler'... Permission denied (publickey). fatal: Could not read from remote repository. [02:33:22] publickeay error [02:33:36] although i have added my key to gerrit and wikitech [02:37:15] and did you add your username and email to git config as the tutorial says? [02:38:24] Yes [02:38:27] Oh wait [02:38:28] Nvm [02:38:38] I forgot who was needing help [02:38:40] Lol [02:39:55] :D [02:40:12] but yes, i added the config lines again jsut to be on the safe side [02:40:25] you seem to be missing your key in your git lol [02:40:28] https://www.mediawiki.org/wiki/Gerrit/Tutorial#Add_SSH_key_to_use_with_Git [02:42:23] eval `ssh-agent` [02:42:53] in git bash yes [02:43:29] next steps in this section ^ [02:43:51] to verify if the connection works [02:44:22] doesnt [02:44:35] $ ssh -p 29418 HarriA@gerrit.wikimedia.org Permission denied (publickey). [02:44:52] at this point im sure wiki doesnt like me [02:45:28] Have you added your private key to the ssh agent as it says there? [02:46:42] yeah, did every part there [02:47:17] You know (or not?) any ssh server uses the public key that you add to it, to authenticate your private key from the client connection [02:47:34] Did you add the correct key? [02:49:37] well, i added the only one i have [02:49:48] on the folder which i had created [02:53:36] HarriA, try "ssh -p 29418 harria@gerrit.wikimedia.org" [02:56:21] hmm, that gave me welcome emssage now [02:56:45] so you just need to use the correct username [02:57:05] "harria" for uid logins, "HarriA" for cn/sn logins [02:57:11] ok [02:57:15] will try to remember [02:57:21] yeah, before i used uppercase [03:02:22] woopdee-freaking-doo [03:02:47] ? [03:04:11] well it uploaded [03:04:16] that was my joy message [03:04:41] uh lol yes you have to use the shell instance account name in the git itself and the clone/pull/fetch/push/etc urls [03:05:45] thanks anyway! hope i didn't waste too much of your precious time. But next time when someone asks, you at least have a checklist to ask now [03:07:00] don't worry lol [03:08:15] so how and when does it link to phab [03:08:51] When merged [03:08:54] On gerrit [03:08:59] And automatic [03:09:26] ok. so i need reviewers now [03:09:31] correct? [03:09:50] Not if you own the repo [03:10:08] i guess i do [03:10:18] so ill need to merge it somehow [03:10:21] myself [03:10:24] Just wait someone will be around to review [03:10:31] okay [03:10:43] You cant unless repo admins give you that access righr [03:10:46] Right* [03:11:26] [06:08] so how and when does it link to phab [03:11:32] Automatically [03:11:49] my repo admin should be myself? or global repo admins you mean? [03:11:49] I already answered that lol [03:12:25] By repo admins i mean like people who can config the repo settings [03:12:37] ..when you merge your commit https://gerrit.wikimedia.org/r/#/c/317379/ [03:12:46] Only them and owner and whoever they set with merge rights can merge changes [03:13:08] Zppix He is the owner [03:13:17] Oh [03:13:22] Then ya [03:13:25] U can merge it [03:13:50] Just click reply and make code review and verfied 2 then click done then click merge [03:14:00] On gerrit [03:14:06] Zppix https://gerrit.wikimedia.org/r/#/admin/groups/1197,members [03:16:35] so projet page shows merged, should be good to go right? [03:16:43] HarriA once you merge the change (cr +2, done, merge) it gets automatically synced to diffusion etc [03:17:19] as the current head [03:17:44] yeah, thanks [03:18:25] https://phabricator.wikimedia.org/tag/mediawiki-extensions-stlhandler/ is a project tho, not a diffusion [03:19:50] nevermind, here's the link https://phabricator.wikimedia.org/diffusion/1904/ [03:19:59] Sync takes some minutes [03:20:32] Phab daemons [03:20:52] those damn demons... [03:20:55] Not realtime lol [03:21:06] figured [03:21:16] still nice to confirm [03:21:43] Alirght, that's all for me, thanks guys [03:27:13] uh lol his repo does not have a diffision callsign tho [03:28:30] Who made it [03:48:05] arseny92: diffision no longer needs call signs from my understanding [03:50:12] My repo and diffision was made yesterday and has one [04:10:33] Zppix https://phabricator.wikimedia.org/diffusion/1904/manage/basics/ [04:10:47] ? [04:11:29] [06:28] Who made it [04:11:37] See repo history [04:11:55] Chris [11:35:53] Is http://stats.wikimedia.org down? [11:36:18] Oh it finally loaded [14:33:55] hi [14:34:16] For some reason, pageview statistics stopped working [14:49:07] any quarry gurus here? [15:34:12] ToAruShiroiNeko: define guru, I might be able to help? [15:34:57] I am trying to compile a list based on special double redirects [15:35:09] pages not stoked out [15:35:17] but for all mediawiki wikis [16:01:10] anyone? [16:23:01] myrcx does that make sense: [16:23:02] hi [16:23:04] ? [16:23:08] hello yannf [16:23:13] is there a known thumbnail issue? [16:23:34] or cache issue? [16:24:07] https://fr.wikipedia.org/wiki/Liste_de_dirigeantes_politiques <- I don't see the images [16:24:18] other people have confimed [16:24:22] *r [16:24:23] Oh, that has been reported here https://phabricator.wikimedia.org/T148917 [16:24:46] ok thanks [16:25:04] Could you please add your input there [16:25:16] Since that will help with prioritising the task [16:26:42] done [16:27:30] thanks [16:31:52] https://upload.wikimedia.org/wikipedia/commons/thumb/e/e5/CFK_y_Angela_Merkel_2.jpg/220px-CFK_y_Angela_Merkel_2.jpg [16:32:05] broken thumb here [16:32:12] That image loads for me [16:33:33] not for me, even after purging the page and the image several times :/ [16:35:06] Oh, we are talking about it in #wikimedia-operations [16:35:14] It may just need a purge server side. [16:38:54] yannf is there a disccusion on en.wp.org about this [16:39:08] could you add the link to the disccusion on the task if there is one please? [16:40:51] paladox, I don't know any discussion on wiki about this [16:41:11] Oh, but where di the other people confirm the problem [16:41:12] other people have confimed [16:41:17] ? [16:41:24] on IRC [16:41:34] #wikipedia-en [16:41:57] Oh. [18:50:42] paladox: Hi, I see you've added input on https://phabricator.wikimedia.org/T148917 :) Thanks! [18:50:59] Yep, your welcome :) [18:57:07] bblack: If there's anything I could check on my computer to make a comment on, just let me know... [18:59:18] Josve05a: can you try a different network? as in, if you're using home wifi, switch to tethered through a phone, or ? [18:59:30] there's some possibilty it's related to some protection offer by a local router as well [18:59:31] sure [19:00:00] (haven't changed anything with my router in years...but will try anyways) [19:00:18] it really depends how "smart" the router is trying to be :) [19:00:36] bblack but my router has been changed settings rise since i got it a year ago [19:00:38] well, it is like 6-7 years old... [19:00:47] lots of things have changed on our end, and in new UAs like Safari10, Chrome, Edge (esp preview builds), etc [19:00:51] Only setting i changed is to allow outside access into my pc to test ssh [19:01:14] the risk is that some "protection" things in routers or anti-virus or anti-malware could be tripped up by the very new connection/protocol details they aren't prepared for [19:01:40] bblack could microsoft defender be a problem? [19:02:01] I had to switch to it due to a bug in the recent windows 10 insider update that broke 3rd party anti virus [19:02:05] theoretically anything of the sort could be, but I don't really have any modern experience with Windows platforms to know for sure [19:02:24] does defender try to inspect HTTPS connections and stop things on the wire? [19:02:31] Not sure [19:03:15] Not sure if norton is more advanced then microsoft defender [19:03:33] but ui wise, norton is, norton does look more advanced, and less strict about access to outside world [19:03:52] it seems to be common to many such tools these days: to interfere with TLS (HTTPS) protocol stuff in the name of scanning your traffic to prevent various malware [19:04:02] bblack: Not seeing it (yet) with my phones hotspot...might be beacuse of slowed connection, becasue the iamges loads much slower and not "direct done" load... [19:04:20] oh wait [19:04:24] strike that [19:04:27] seeing it... [19:04:49] Josve05a: youre case is extra interesting because we'd tend to assume chrome-on-chromebook is a pretty clean and up to date client... [19:04:50] bblack i can reproduce this on an iphone [19:05:03] an iphone dosen't have any anti virus stuff running [19:05:05] https://upload.wikimedia.org/wikipedia/commons/thumb/4/4e/%24kopsko_Kal%E2%82%AC_%2838%29.JPG/120px-%24kopsko_Kal%E2%82%AC_%2838%29.JPG example...works when opening, but not when first seeing in caetegory on commons [19:05:27] bblack switching to 4g, loads the images [19:05:37] Josve05a: so you can't ever open a single image by itself and get the repro... only when it's one of the (possibly many) thumbnails referenced within a wiki page? [19:05:50] strange as i have never had a problem with my router. [19:06:04] bblack: only on 'first encounter' [19:06:14] when trying to reload, or opening, it works again [19:06:34] (so, to answer your question, yes) [19:07:02] it's very puzzling [19:07:31] to recap what I've said elsewhere... we seem to get enough similar reports that we can't write it off as a one-off bad client or singular local issue [19:07:41] bblack it also happends over 4g too [19:07:48] but at the same time, there's not widespread-enough reports to consider it some kind of widespread breakage, either [19:07:51] just did wifi, then did a reload onto 4g [19:07:52] HHVM-memory leak? [19:08:01] just haven't been able to pin down what the common factor is [19:08:15] hhvm isn't involved in upload.wikimedia.org traffic at all [19:08:22] hmm [19:08:27] it only happends to some images, and dosen't happen to all the pages. [19:08:47] sporadically, as I said in the title :p ... [19:09:19] paladox I assume is US-based? Josve05a in the EU? [19:09:25] bblack: Sweden [19:09:34] bblack i am uk, but am from us. [19:09:45] ok so both EU-based as far as our infra goes [19:09:53] Yep [19:09:59] bblack: Should I do a ping of somekind, or tracepath? [19:10:15] probably won't help [19:10:37] can you even get a CLI on the chromebook? it's been a while since I used one, but I remember them having some bash shell for dev/debug stuff [19:11:33] well, yes, it does have a crosh terminal, but it is very limited (ping, tracepath) if not on developer branch (which I can't be, due to school...) [19:12:33] ok [19:14:10] doing a refresh on 4g works [19:14:41] But i doint see how it could be the router, though i have access to the new bt smart hub / bt home hub [19:17:06] bblack: Not sure if this is helpful at all... [19:17:09] https://www.irccloud.com/pastebin/4c4SmCN0/ [19:18:04] oops, hadn't finnished... [19:18:15] brb [19:18:52] https://www.irccloud.com/pastebin/HyhKfZyu/ [19:19:17] Correct link! https://www.irccloud.com/pastebin/m5oVpduq/ [19:24:01] (we need somekind of debugging tool on tollabs so we can generate all necessary info and just copy to tickets...like useragents, ping results, etc...) [19:25:38] I was looking for some kind of possible network issues in the EU in general, but haven't found any real reports yet [19:25:44] I assume all other major sites work fine? [19:27:42] bblack: yeah, exceept for that stupid DDoS attack a few days ago which tookdown twitter, netflix etc. I've not noticed any issues... [19:27:47] took down* [19:28:04] I regularly see abnormally long DNS lookups for upload.wikimedia.org fwiw (5, 10 seconds), even from webpagetest [19:28:55] perhaps DNS cache infra is getting hit? [19:29:30] that wouldn't explain or be related to the image loading issues above, though [19:30:11] Hmm http://dnssec-debugger.verisignlabs.com/upload.wikimedia.org [19:30:39] we don't do DNSSEC [19:36:29] it's still pretty easy to reproduce at this point, right? [19:37:40] yeah, just browse to pages of "Large" file-categories...after 3-10 pages you'll find a page with broken thumbnails... [19:37:51] through* [19:42:31] try now? I have an experimental change in place, just for upload.wikimedia.org traffic in the EU, to rule out one area. [19:44:11] (FTR: I've disabled x25519 key exchange, in case that's tripping up some middlebox that examines or proxies TLS) [19:45:16] bblack: depends...do I need to do a purge/clear cache...?Because I'm still seing it [19:46:45] probably wouldn't hurt to restart any/everything, but I donno [19:47:19] I doubt clearing browser cache (of cached images, I mean) does much, but there are other properties of the connection that it's hard to tell whether they're still affecting things without a full restart of a browser. [19:48:57] ok, trying in incognito mode on restarted connections/browsers etc. while logged out, still shows the broken thumbs, but only on wikipages....never on uplaod.wikimeida.org directly.. [19:49:52] that's... very odd [19:50:09] but when this happens, there are console messages about reset reconnections or bad ssl record mac, etc? [19:50:22] or are they just "missing" more like a 404/500/503? [19:53:58] the former ^ [19:54:04] ok [19:54:10] reverting my temp change now [20:00:09] /8/8 [20:00:37] yeah I donno [20:01:01] for other debugging reasons (but convenient now, too), I've had enwiki, commons, and upload all mapped to the EU servers for my laptop since sometime last week [20:01:10] and I can't repro on any of the linked caegories full of images, etc [20:01:21] (with Chromium/53 on Linux) [20:02:21] bblack: have you tried to browse through multiple pages of large categories? (I.e. not just the first page, and perhaps not of categories already linked and "purged") I jut have to go through like 3 pages to find broken thumbs... [20:02:35] just* [20:03:13] yeah I'm going to try a bit harder in various ways... [20:05:07] Josve05a: maybe you could get a traffic capture? [20:06:17] hm? How? (lol, I am not a techie...) [20:06:36] wireshark? [20:07:18] ok I've managed to get a local repro heh [20:07:22] nope, on Chromebook... [20:07:24] oh, fine [20:07:37] Chromium/53-on-Linux, from the US -> esams, for upload.wikimedia.org [20:07:38] Josve05a: I don't know how much you can do on Chromebook… [20:07:52] nothing...you can't do anything on chromebooks :p [20:08:25] what was the issue, bblack ? [20:08:38] in my case, I got the errors on something like the final ~64 images in https://commons.wikimedia.org/w/index.php?title=Category:Media_with_locations&filefrom=%22+Dogsbody%22+%2C+The+Broadleys+%2C+Claycross+%286331958120%29.jpg#mw-category-media [20:09:00] at first I was able to load that whole category fine, it took several reload attempts before I hit it [20:09:23] only the last 9 load for me :O [20:09:23] on the failing attempt, many images were ok, and then there's a point in the middle where after that point all the images failed to load (the last ~64 images) [20:09:36] and console is full of net::ERR_SSL_BAD_RECORD_MAC_ALERT [20:09:57] all of those loads fine for my here now [20:10:17] I see Failed to load resource: net::ERR_CONNECTION_RESET [20:10:24] on Chrome 52, though [20:11:01] I'm on 53.0.2785.154 [20:11:10] (Chrome) [20:11:44] I think it can be either one [20:11:44] I think the connection gets reset abruptly/uncleanly, and depending on the wind it can either give the actual connection reset, or just TLS failures from TLS getting broken mid-stream (hence bad record mac) [20:12:42] indeed, I am seeing RST, ACK packets from 91.198.174.208 [20:12:50] or just RST [20:13:21] right [20:13:36] and wireshark is showing "Ignored Unknown Record" a few lines above [20:13:41] it's still hard for me to repro. I'm trying to get it to happen a second time but no luck yet [21:02:49] I am back [21:03:05] bblack im now on a different router but from same isp [21:03:08] bt smart hub [21:03:25] as the name suggest it is not that smart with firewalling