[07:55:35] <snitch>	 [[Tech]]; ArchiverBot; Bot: Archiving 1 thread (older than 30 days) to [[Tech/Archives/2016]].; https://meta.wikimedia.org/w/index.php?diff=15891687&oldid=15888056&rcid=8246354
[16:22:58] <Krenair>	 hey Krinkle
[16:23:09] <Krenair>	 On VE load on meta I'm seeing Exception in module-execute in module ext.popups.schemaPopups:
[16:23:15] <Krenair>	 TypeError: Cannot read property 'get' of undefined
[16:23:21] <Krenair>	 at Object.mw.popups.getEnabledState
[16:25:26] <Krenair>	 we have a mw.popups.getEnabledState
[16:25:32] <Krenair>	 but Object.mw.popups.getEnabledState?
[16:36:03] <legoktm>	 https://blog.wikimedia.de/2016/09/08/i-dont-have-to-find-tasks-tasks-are-coming-to-me-being-a-volunteer-developer-for-wikimedia-projects-an-interview-with-tpt/
[18:17:41] * robla starts reading the blog post linked here by lego a couple of hours ago
[19:10:20] <Krinkle>	 Krenair: https://github.com/wikimedia/mediawiki-extensions-Popups/blob/7975fde74520d302995474e8fd6a7b0b5e6bd8bf/resources/ext.popups.core.js#L237
[19:10:47] <Krinkle>	 Krenair: Oh, that's just the browse's way of guessing and giving it a reasonably unique name that contains some of the aspects of how it was defined.
[19:10:47] <Krenair>	 yes
[19:11:11] <Krinkle>	 It's not meant to be an exact global identifier
[19:11:21] <Krenair>	 I think the problem line in that case was the line below, but it was the Object. part I was interested in
[19:11:29] <Krenair>	 ah
[19:56:12] <Krinkle>	 Krenair: Yeah, the stack always refers to the function it was executing. with .get() being undefined, it wasn't executing that.
[19:56:50] <Krinkle>	 Ah, you mean get of storage, not of config
[19:56:54] <Krinkle>	 Yeah, that makes sense
[19:56:56] <Krenair>	 mw.storage was undefined
[19:56:57] <Krinkle>	 config shouldn't be undefined.
[19:57:02] <Krenair>	 it didn't have the correct dependency
[19:57:06] <Krinkle>	 Yeah
[19:57:09] <Krenair>	 I looked it up - config is set before RL modules are run in startup.js
[19:57:32] <Krinkle>	 Yeah
[19:57:33] <Krinkle>	 https://github.com/wikimedia/mediawiki-extensions-Popups/commit/765aa40cc1da52efb269775d9c96a8742f0a4bd2
[19:57:37] <Krinkle>	 That seems to add the dependency thoug
[19:57:51] <Krinkle>	 Maybe it missed a module that uses it?
[19:58:02] <Krinkle>	 It removes it twice and adds it once
[19:58:03] <Krinkle>	 hm
[19:58:05] <Krinkle>	 anyhow
[20:00:39] <Krenair>	 Krinkle, it added the dependency to desktopTarget instead of core
[20:01:11] <Krinkle>	 Krenair: And something started loading core directly instead?
[20:01:25] <Krenair>	 something like that
[21:44:47] <musikanimal>	 Krinkle: could this be related to why the JS is going in and out on enwiki (and I think meta too)?
[21:45:01] <Krinkle>	 musikanimal: in and out?
[21:45:09] <musikanimal>	 not just popups, any user script seems to be working at one moment and not the next
[21:45:31] <musikanimal>	 we were talking about in -admin, and I saw this at VPT: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Linkclassifier_disappeared
[21:46:43] <musikanimal>	 I just got this error in popups: `Uncaught TypeError: Cannot read property 'isVisible' of undefined`
[21:47:03] <musikanimal>	 hit refresh then popups works again
[21:48:22] <musikanimal>	 did something change recently?
[21:48:57] <musikanimal>	 just got `TypeError: mw.Api is not a constructor`, again I hit refresh it goes all is well
[21:49:38] <musikanimal>	 I would say it's perhaps related to ResourceLoader but we're seeing user scripts breaking too
[22:19:49] <Krinkle>	 Krenair: I'm still getting TypeError get undefined from popups on enwiki
[22:19:57] <Krinkle>	 I can help backport/CR
[22:21:02] <Krenair>	 I put a patch in gerrit
[22:21:13] <Krenair>	 last SWAT of the week is in 30 mins
[22:25:39] <Krinkle>	 k
[22:39:43] <Krenair>	 Krinkle, actually, you were a reviewer on the patch
[22:44:45] <Krenair>	 Krinkle, so you should've seen it in your inbox