[14:45:20] https://joinup.ec.europa.eu/community/eu-fossa/og_page/code-review-log [16:46:56] [[Tech]]; Techyan; /* Set Up a Looking Glass Page */ new section; https://meta.wikimedia.org/w/index.php?diff=15877617&oldid=15870703&rcid=8222052 [18:19:50] hello, about the new Special:BotPasswords, I should be able to use that in place of my normal password, right? only problem is my bot looks at the abuse filter logs, and I guess that permission isn't supported https://en.wikipedia.org/wiki/Special:ListGrants [18:20:48] I might have already created a phab for this, actually... [18:21:25] ah, https://phabricator.wikimedia.org/T126756 [18:21:49] ok nvm, will resume discussion there :) [19:24:30] musikanimal: switching your bot to OAuth is actually even better than using bot passwords. [19:24:51] bot passwords are nice for folks who can't for some reason use OAuth [19:26:20] for sure, that's my bigger plan, but a lot of work to update the framework I'm using [19:26:24] Requestor-only grants are now automatically approved, so you can get the creds for OAuth setup by creating a request at https://meta.wikimedia.org/wiki/Special:OAuthConsumerRegistration/propose using your bot's account [19:27:05] musikanimal: just port your biz logic to pywikibot ;) [19:34:32] hehe [21:46:56] bd808: looks like OAuth doesn't support the `abusefilter-view` permission either! this is a must for my bot [21:47:20] ouch. [21:47:35] I wonder who the best candidate for https://phabricator.wikimedia.org/T126756 would be, because it's tagged as "Easy" [21:48:16] musikanimal: you! [21:48:26] I knew you were going to say that haha [21:48:47] musikanimal: if it's changing a thing on extension.json, I can do that [21:48:53] is botpasswords an extension? [21:48:59] I do understand the "various AbuseFilter rights" [21:49:15] MarcoAurelio: not sure, but this affects OAuth too [21:49:34] we need to add a new "grant", or modify an existing one [21:49:43] that's easy [21:49:51] musikanimal: dig in the code and figure out what brad is saying in https://phabricator.wikimedia.org/T126756#2022854 [21:50:02] we need to know on which extension do we have to add it [21:50:45] put up a patch that seems to fix it, add him as reviewer, and then iterate on the code review he gives. Brad is awesome at code review [21:50:47] oh okay, so I guess we want to add it to the AbuseFilter extension itself, which makes sense [21:51:19] alright... I shall try, don't reveal the secret MarcoAurelio ! [21:51:41] musikanimal: on extension.json of AbuseFilter I think [21:51:51] let me fetch a similar patch I did [21:52:12] ok cool [21:52:23] https://phabricator.wikimedia.org/rEGBL69d35960c11ac735a8500f930ff724e3e4766302 [21:54:06] MarcoAurelio: thank you! I'm going to get all this set up on my vagrant then take a stab at it [21:54:52] musikanimal: no problem. I'm however not sure on which group grant this should be. Maybe abusefilter-view on basic, but private filters are probably for sysop grants [21:55:11] correct [21:55:34] a new grant just for abuse filter stuff would be nice, but let's start with just -view [21:56:07] I want to eventually have my bot read private filter details, and getting sysop rights is very unlikely [21:57:31] really the bot task is filling in gaps of functionality the extension should itself have, but one step at a time... [21:58:34] but if your bot does not have permissions to do so, adding a grant will not let your bot do it anyways [21:59:07] there's a global-abusefilter-helper that would be added, since this is also a cross-wiki task [22:10:23] musikanimal: so you want your bot to be added to that globalgroup? in that case the grant would work I think, otherwise not :) [22:11:05] ultimately, yes, but I'd need approval from the community and what not [22:11:26] I'd be sure to encrypt everything it reads/stores, it only cares if something changed, not what changed [22:12:26] so right now the "monitor" task has no idea when someone updates a private filter [22:24:30] okay [22:24:52] if you could add me to the patch as reviewer, so I learn too :) [22:35:21] sure! [22:35:47] done [22:45:48] Meta does allow anons to see abusefilter-log-detail which is not standard, but I think it lgtm [22:55:56] well, OAuth / BotPasswords would be for accounts anyway, right? [22:56:11] enwiki allows anons to view public filters, I believe [22:56:42] yeah