[07:01:37] So "expand all comments" still doens't work? :( https://gerrit.wikimedia.org/r/#/settings/diff-preferences [07:04:04] that probably applies to the diff screen only [07:20:34] Ah no, it auto-expands the comments which contain inline comments, but nothing else. [07:22:02] Which is not too bad since most of the other comments are events (new patchsets, rebase etc.) or jenkins-bot [09:04:34] wth is happening with colours here https://phabricator.wikimedia.org/project/view/1135/ [09:05:43] Nemo_bis: somebody set a board background color [09:06:36] in this case @Hydriz [09:07:23] Whoa. [09:07:23] cute. it has that windows 10 vibe. [09:07:40] Where did the "kome" stuff come from? [09:08:22] Ah, that's also editable nowadays. [09:08:32] Motivator. [09:17:34] Confusing https://phabricator.wikimedia.org/project/manage/137/#24489 [09:18:40] Nemo_bis, see https://phabricator.wikimedia.org/T134103 [09:22:40] It seems our issue tracker is irresistibly attracted towards chaos, nowadays. [09:23:23] But I guess it's ok to be reminded about the laws of thermodynamics. [09:26:54] Nemo_bis: "chaos"? [09:27:59] Nemo_bis: I don't see how renaming a project from an implementation detail ("make an MW extension") to "Technical Tool Request" creates chaos [09:32:19] Not create, just encourage. [09:32:34] How? [09:36:11] ooooh, gerrit emails now specify the branch in the subject. finally i can filter out all the backports from my mail [09:52:37] MatmaRex: i think thats from a breakage that ostriches is planning to fix [09:53:00] although I could be wrong, wasn't paying major attention during the upgrade [14:32:36] I see that editing the commit message is now a two-steps process like inline comments, on gerrit 2.12. Not too tragic. [14:34:46] yeah, that's a little annoying. the update is still a big win [16:02:46] So, new-gerrit, is there a way to get the search box adjusted so it doesn't force the page into being wider than the average laptop screen? (I checked -- it's just the search box doing it.) [16:02:59] lol [16:03:07] It just cuts off for me.. Doesn't add a scroll bar [16:03:09] ostriches: ^^ [16:03:33] Yeah, gerrit is about twice as wide as my browser would allow [16:03:42] It would be nice if the search bar wrapped under the logo [16:03:47] Get a wider screen ;-) [16:03:49] (jk) [16:03:53] (css fixes welcome) [16:04:02] For now, I removed some tabs [16:04:36] In the "My menu" https://gerrit.wikimedia.org/r/#/settings/preferences [16:05:06] https://gerrit.wikimedia.org/r/#/settings/diff-preferences why is it in a big black box? lol [16:05:30] I've yet to figure out why they did that [16:05:30] lol [16:05:41] Probably the first chose the hazel for the buttons and then the best brackground for it [16:05:48] It also doesn't quite line up with the line next to it, which is a different sort of nitpick. :D https://usercontent.irccloud-cdn.com/file/20y2Jm6p/gerrit-search [16:05:50] omg typing [16:06:16] Yeah, ditto [16:06:20] ostriches: We've gotta revert [16:06:23] This is simply unacceptable [16:06:33] * ostriches stabs Reedy [16:06:40] * ostriches stabs a few more times. WITH FEELING [16:06:50] <3! [16:06:53] lol [16:07:00] andre__: With feeling ;-) [16:07:08] It's all about L.U.V, kids! Remember that! [16:07:42] andre__: ostriches love me long time [16:08:03] You know it <3 [16:10:23] the new gerrit, unlike the old gerrit, also uses human-readable class names for things, so you can actually restyle it a bit [16:10:49] Kemayo: personally i just removed "Groups" from the "My" menu :P [16:10:49] ostriches: Well, in a selfish "make it fit onto 1280px browser windows again" sense, `.searchPanel .searchTextBox { max-width: 280px; }` works. [16:11:13] I'm thinking of our first-time contributor experience, naturally. ;) [16:12:22] ostriches: Oh, and changing that same rule's `margin` to `margin: 4px 3px 0 0` makes it be aligned with the divider next to it. [16:13:16] Kemayo: isn't it enough to remove size=70 from [16:13:56] Nemo_bis: Absolutely! But ostriches said CSS fixes, and it wouldn't surprise me if it's much easier to tweak the CSS theme rather than change the HTML output. Maintaining patches, etc. [16:14:03] MatmaRex: the table I'm trying to style right now has the .com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-infoTable class. I *suppose* that's kind of readable [16:14:15] Kemayo: Yeah. We can inject custom CSS easily :) [16:14:23] bd808: They used to be obfuscated. [16:14:27] And change every time you recompile. [16:14:31] bd808: well, it's better than .gerrit-aG7Ftg9JkL [16:14:43] lol yup that [16:15:03] .GJEA35ODNB [16:15:05] lol [16:15:08] close [16:15:24] (Whenever I built it, I had to manually disable the obfuscation. It was super duper lame) [16:15:40] Coincidentally, .GJEA35ODNB a.gwt-InlineHyperlink {} does nothing now :p [16:15:49] (And didn't on our custom 2.8, afaik) [16:36:00] In the meantime, a userscript to just remove the size attribute on the searchbox, in case anyone wants it: https://gist.github.com/kemayo/220f626eaabdc56e519c22cb812607fe#file-gerrit_remove_searchbox_size-user-js [16:37:05] (Which turned out to be more hassle than I had expected, because I wasn't thinking about gerrit's whole entirely-async-loaded nature.) [16:42:33] Kemayo: I'm just using "body .searchPanel .searchTextBox {width:25ch;}" [16:42:54] My way was more fun to write. :D [17:38:20] MaxSem: is your new diff code live on prod now? [17:38:53] kaldari, v [17:38:54] https://phabricator.wikimedia.org/T140443 [17:39:11] thanks [19:23:45] [[Tech]]; 186.190.236.191; [none]; https://meta.wikimedia.org/w/index.php?diff=15792356&oldid=15787764&rcid=8065805 [19:23:59] [[Tech]]; Tegel; Reverted changes by [[Special:Contributions/186.190.236.191|186.190.236.191]] ([[User talk:186.190.236.191|talk]]) to last version by Glaisher; https://meta.wikimedia.org/w/index.php?diff=15792358&oldid=15792356&rcid=8065807