[00:22:12] <Matthew_>	 tgr: (sorry was driving) thank you.
[11:20:06] <snitch>	 [[Tech]]; 109.93.195.73; /* r */ new section; https://meta.wikimedia.org/w/index.php?diff=15716115&oldid=15714851&rcid=7941956
[11:26:14] <snitch>	 [[Tech]]; Syum90; Undo revision 15716115 by [[Special:Contributions/109.93.195.73|109.93.195.73]] ([[User talk:109.93.195.73|talk]]) Test.; https://meta.wikimedia.org/w/index.php?diff=15716121&oldid=15716115&rcid=7941963
[19:59:58] <Wnme_>	 does anybody know how to solve this error?
[20:00:01] <Wnme_>	 Function: DatabaseBase::insert
[20:00:01] <Wnme_>	 Error: 1054 Unknown column 'tmplog_end_devices' in 'field list' (10.64.0.205)
[20:02:39] <Krenair>	 that's not a wikimedia production error is it?
[20:03:10] <Krenair>	 we don't have a DB server with that address and I don't recognise the column name
[20:03:14] <Wnme_>	 it was on test.wikipedia
[20:05:09] <Krenair>	 oh, sorry
[20:05:16] <Krenair>	 I was looking in the wrong place
[20:05:19] <Krenair>	 templates/wmnet:db1075          1H  IN A        10.64.0.205
[20:06:19] <Krenair>	 sigh
[20:06:21] <Krenair>	 CentralNotice.
[20:07:30] <Krenair>	 https://phabricator.wikimedia.org/T134568
[20:09:41] <Krenair>	 what were you doing when you found this error Wnme_?
[20:12:03] <Wnme_>	 Krenair: I tried to create a new banner
[20:13:46] <Krenair>	 yeah okay so this is that tazsk
[20:13:47] <Krenair>	 task*
[20:14:08] <Reedy>	 Schema change not applied?
[20:15:11] <Krenair>	 yeah am looking into it
[20:15:15] <Reedy>	 It is
[20:15:18] <Reedy>	 It's not there on testwiki
[20:15:22] <Reedy>	 There's only a few rows in the db
[20:15:25] <Reedy>	 I'd just apply the patch
[20:15:34] <Reedy>	 ALTER TABLE /*_*/cn_template_log ADD (
[20:15:35] <Reedy>	   `tmplog_begin_devices` varbinary(512) DEFAULT NULL,
[20:15:35] <Reedy>	   `tmplog_end_devices` varbinary(512) DEFAULT NULL
[20:15:35] <Reedy>	 );
[20:15:35] <Reedy>	 UPDATE /*_*/cn_template_log
[20:15:35] <Reedy>	   SET
[20:15:37] <Reedy>	     tmplog_begin_devices = '["desktop"]',
[20:15:40] <Reedy>	     tmplog_end_devices = '["desktop"]';
[20:16:31] <Krenair>	 yeah it's not a new patch either
[20:16:46] <Krenair>	 I wonder what else is missing
[20:17:27] <Reedy>	 wmf_deploy branch?
[20:17:34] <Reedy>	 Maybe they updated it to nearer master recently
[20:17:47] <Krenair>	 commit 3c4eec934f366438f8189c9853ed6c6de80196dd
[20:17:47] <Krenair>	 Author: Matt Walker <mwalker@wikimedia.org>
[20:17:47] <Krenair>	 Date:   Thu May 2 23:30:36 2013 -0700
[20:17:56] <Reedy>	 lol
[20:18:09] <Reedy>	 or testwiki has just been neglected
[20:18:20] <Reedy>	 metawiki has it
[20:18:31] <Reedy>	 I'll apply the patch if you want
[20:18:53] * Reedy jfdi
[20:19:11] <Krenair>	 I just wonder where the code is that's trying to use this column
[20:19:20] <Reedy>	 mysql:wikiadmin@db1075 [testwiki]> ALTER TABLE  cn_template_log ADD (   `tmplog_begin_devices` varbinary(512) DEFAULT NULL,   `tmplog_end_devices` varbinary(512) DEFAULT NULL );
[20:19:20] <Reedy>	 Query OK, 0 rows affected (0.09 sec)
[20:19:20] <Reedy>	 Records: 0  Duplicates: 0  Warnings: 0
[20:20:28] <Reedy>	 Wnme_: Fancy trying again? :)
[20:21:16] <Reedy>	 			$row->tmplog_end_devices
[20:21:22] <Krenair>	 Reedy, only other DB on the cluster which has this column is metawiki
[20:21:24] <Reedy>	 entralNoticeBannerLogPager.php
[20:21:33] <Krenair>	 yeah that's not inserting
[20:21:56] <Reedy>	 I wonder if it's a non greppable usage
[20:22:12] <Krenair>	 wouldn't surprise me
[20:22:25] <Reedy>	 I suspect testwiki is an outlier
[20:22:25] <Wnme_>	 great, it works :)
[20:22:31] <Reedy>	 Other wikis use metas CN db?
[20:22:59] <Reedy>	 yeah
[20:23:00] <Reedy>	 	$wgCentralDBname = 'metawiki';
[20:23:00] <Reedy>	 	if ( $wmfRealm == 'production' && $wgDBname == 'testwiki' ) {
[20:23:00] <Reedy>	 		# test.wikipedia.org has its own central database:
[20:23:00] <Reedy>	 		$wgCentralDBname = 'testwiki';
[20:23:02] <Reedy>	 	}
[20:23:09] <Reedy>	 RESOLVED WFM
[20:27:22] <Krenair>	 there's still some differences Reedy 
[20:27:42] <Reedy>	 Probably
[20:27:48] <Krenair>	 testwiki has tmplog_comment in a different order to metawiki
[20:27:58] <Reedy>	 That doesn't matter
[20:28:04] <Krenair>	 I know
[20:28:31] <Krenair>	 and tmplog_begin_category and tmplog_end_category are varbinary(255) on metawiki but tinyint(4) on testwiki
[20:28:32] <Reedy>	 The patch could've had a clause to put it in the right place
[20:29:28] <Reedy>	 Can't obviously see a patch for that one
[20:29:49] <Krenair>	 I think when it was written there was no comment column
[20:29:49] <Reedy>	 it'd be kinda useful to be able to run update.php sometimes
[20:29:53] <Krenair>	 commit baa15db00aaea21af3a1d5f2dee4f5914ae83f70
[20:29:53] <Krenair>	 Author: Andrew Green <andrew.green.df@gmail.com>
[20:29:53] <Krenair>	 Date:   Wed Aug 6 13:27:09 2014 -0400
[20:29:53] <Krenair>	     Schema change for comments on changes for logs
[20:30:53] <Krenair>	 so patches/patch-template-logging-comments.sql did get applied to testwiki but patches/patch-template-device-logging.sql did not until just now