[03:49:32] Hi, anyone know what's wrong with the OAuth service? I got "Invalid response from token request" for some hours now. https://tools.wmflabs.org/oauth-hello-world/index.php?action=authorize [04:05:42] kenrick95: I was able to login to quarry.wmflabs.org which uses OAuth [04:05:48] so I'm not sure. [04:08:42] legoktm: I'm confused by your https://gerrit.wikimedia.org/r/#/c/249073/2 . a) if I run `composer validate --no-check-publish` still warns about name, description, license, it just doesn't return an error code. Is there any harm in adding those fields to skins/Blueprint/composer.json? [04:11:10] Hmm weird, I'm also able to login to quarry, but not to the OAuth-Hello-World [04:13:57] kenrick95: fails for me too, I dunno. You could try asking in #wikimedia-labs, otherwise file a phab ticket [04:15:51] okay, thanks [10:20:01] If I edit some code in the core repository then how to test whether it worked or not? I am new here please help :) [17:36:34] Hello, could I ask about something? At cswiki we are currently testing new design of the edit window (source) *buttons*. We are trying to make them look like the ones at a login page (classes .mw-ui-progressive etc.). But there is an issue. We cannot figure out, how to make checkboxes (add to watchlist/minor edit) show up in that style like at a login page. It looks like they are somehow maintained by some JS and we don't kn [17:37:36] Could somebody help us with that? [17:38:16] the last sentence got cut [17:38:29] (might be a question for #mediawiki-dev too) [17:38:32] "It looks like they are somehow maintained by some JS and we don't kn" [17:38:36] err #wikimedia-dev [17:39:08] ...we don't know, where to find more information about [17:39:55] @andre__ I'll ask devs too, thank you for your link [17:40:08] so you intend to edit https://cs.wikipedia.org/wiki/MediaWiki:Common.css ? Just to clarify [17:41:06] you put the input inside a .mw-ui-checkbox [17:41:24] Yes... [17:41:46] Unfortunatelly this class doesn't work :/ [17:42:00] We had already tried before [17:42:24] is the mediawiki.ui.checkbox module loaded? [17:43:22] At the moment we provide beta version as a gadget, but the checkboxes are the last thing not changed [17:43:33] I'll check [17:53:08] Loaded module at cswiki is oojs/oojs-ui v0.13.0 [17:55:26] Dvorapa, what is the name of the gadget? [17:56:14] https://cs.wikipedia.org/wiki/MediaWiki:Gadget-fancyButtons.css [17:57:59] We have tried to use CSS from .mw-ui-checkbox, we have even tried to find any information about JS, but nothing worked... [17:58:34] Current look: https://commons.wikimedia.org/wiki/File:Submit_edits_form_proposal.png [17:58:58] you're reimplementing the MW classes in your CSS? [18:01:15] Yeah, because appending classes using JS would cause CSS of buttons load later, so they blinked [18:02:45] After some testing as a gadget we also want to propose it to wikimedia devs officially, but we want checkboxes to be in that style too and we want to test it before... [18:03:11] MatmaRex, ^ [18:04:12] hi [18:05:47] hmm [18:09:12] I asked also in #wikimedia-dev and I got only one advice: documentation here: https://doc.wikimedia.org/oojs-ui/master/js/ [18:10:05] Dvorapa: hmmmm. give me a minute. :) [18:10:19] It looks like checkboxes are called using JQuery and I can't find any chance to just append their styles to existing one [18:12:59] Dvorapa: so first things first, there are two "implementations" of the new forms style, one called simply "MediaWiki UI" and second which is the MediaWiki theme for "OOjs UI". the second is the newer and nicer one, and we're trying to get rid of the first. [18:13:01] i think you have them mixed up (no wonder, this is confusing and messed up). [18:13:28] MediaWiki UI is used in the login and createaccount forms, and on Special:Search, and i think that's all [18:13:54] OOjs UI is used on a number of special pages, but mostly obscure ones. e.g. https://cs.wikipedia.org/wiki/Speciální:ResetTokens is a simple one (has a checkbox and a button) [18:14:04] Maybe, but once more: We are trying to make buttons/inputs/checkboxes under edit window (for source) in style of login page [18:14:11] yeah, i'm getting to it :) [18:14:33] MatmaRex: Maybe we should Just Merge It™? [18:15:09] Yeah, exactly that checkbox at this special page is what we want to achieve for minor edit button. But we just can not figure out how [18:15:16] Dvorapa: OOjs UI has a second theme too, which is used in the MonoBook skin: https://cs.wikipedia.org/wiki/Speciální:ResetTokens?useskin=monobook (MediaWiki UI doesn't) [18:15:26] (MediaWiki UI also has way bigger, huge checkboxes) [18:15:48] checkboxes are notoriously difficult to style, and i don't think it's possible to replicate either the OOUI or the MWUI style using only CSS [18:15:59] (they both use some additional HTML) [18:16:19] so i'm afraid that part of your redesign is impossible without adding the HTML with JavaScript. but! [18:16:45] there's somebody actually working on the same thing you want to implement in MediaWiki. patch https://gerrit.wikimedia.org/r/#/c/231600/ looks like it would do a very similar thing [18:17:19] I understand. Is there some example of MWUI checkbox? (just for me to be sure I understand the diff between MWUI and OOUI) [18:17:31] (somebody = FlorianSW|away) [18:18:04] Dvorapa: Special:UserLogin uses MWUI: https://cs.wikipedia.org/wiki/Speciální:Přihlásit / Special:ResetTokens uses OOUI: https://cs.wikipedia.org/wiki/Speciální:ResetTokens [18:19:03] Now I understand (even if the difference is not so big) [18:19:09] Thank you [18:19:25] https://cs.wikipedia.org/wiki/Speciální:Změna_emailu here's another OOUI form, the text input fields are also a bit different [18:19:38] (and yeah, it's a subtle difference) [18:21:27] Thank you once more. I'll take a look at FlorianSW|away patch and I'll try to rewrite our gadget (CSS was taken from login page > MWUI > old one if I understand you correctly). [18:21:48] ...in the OOUI style [18:24:42] Dvorapa: there's a standalone OOUI demo at https://doc.wikimedia.org/oojs-ui/master/demos/ , by the way. (we mostly use it for testing the code, but it's also a pretty good overview of what's available) [18:26:06] Dvorapa: one thing i'd recommend for the gadget is to use only one fully colored button ("primary" in OOUI terminology), four large color blobs like this look a big overwhelming [18:26:42] (i think Florian's patch also does that, let me see if i can get a screenshot of what it looks like) [18:27:48] Thank you, I'll take a look. Could I ask one more thing? Until now we just tried to reproduce MWUI style under the edit window (for source - not VE) using only CSS. I understand checkboxes need some JS (which adds some HTML). Could we somehow change minor edit button into that OOUI style with some JS? Or JS lib for that button is built just for creating new instance? [18:28:50] (I think you wrote it is not possible, just better to ask once more for sure) [18:29:29] Hello. [18:30:38] Thank you for the demo link. I'll use it for additional changes [18:31:02] Dvorapa: if you're willing to do it with JS, then yeah, it's possible. the downside is that: [18:31:09] a) you need to load the OOUI library, which is pretty large at the moment (we're working to split it into smaller parts) [18:31:18] I am wondering about getting some Speed skating property-databases but i am not sure what is needed to create a new property [18:31:47] b) you can only do it with JS after the page has loaded, so at first the "plain" checkbox will appear, and then it will be replaced by the "pretty" one. this can be distracting/annoying for users [18:34:43] Yeah, that's the blinking we are trying to avoid [18:34:58] ...using just CSS [18:35:32] Dvorapa: Florian's patch makes it look like this, currently: http://i.imgur.com/aXfNUSC.png (it looks too spaced out to me, hmm) [18:35:50] * robla waits for an appropriate time to change topics to http://article.gmane.org/gmane.org.wikimedia.multimedia/1134 [18:36:08] but if there is no chance (as a web coder I know there is a chance to achieve only CSS, but OOUI-like looking button, but it is way harder than just append some HTML using JS) [18:36:56] ...so if there is no chance, I'll try to make them using JS and load them with additional delay [18:37:23] as far as i know it's impossible with the current HTML and only CSS changes [18:38:18] Yes, I understand, it would require really major HTML and CSS changes to make them fully styled by CSS [18:38:44] Dvorapa: i think VisualEditor actually also converts the plain checkboxes it loads from MediaWiki to OOUI ones, you could probably adapt the code easily [18:39:37] I don't understand (maybe because I don't use VE). [18:39:57] https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js#L256 [18:40:24] http://i.imgur.com/sNy2pa9.png [18:41:19] meh, i think you could do this simpler [18:41:25] i'll write a snippet :) [18:42:53] Now I understand. It could be easy just to copy some small piece of code from VE source into common.js... [18:44:43] Or into gadget's JS... [18:46:12] Your preview (http://i.imgur.com/aXfNUSC.png) maybe really looks better than our gadget. On the other side the red/green/blue ones could be better for beginners. [18:47:10] *Florian's preview [18:51:13] Dvorapa: here's a quick and dirty snippet: http://pastebin.com/eqdxEKSJ [18:54:46] Cool and working, many thanks. I'll rewrite the gadget's CSS into OOUI, add your JS snippet and we'll test it locally before asking devs to make these changes globally. [18:54:57] Neat. [18:57:27] Dvorapa: and we should probably figure out what's up with https://gerrit.wikimedia.org/r/#/c/231600/ and see if it can be tweaked and merged. [18:58:04] we should probably really make it perfect first, since this is basically the most visible form anywhere, and it would suck if we botched this and people started hating the new style because of it [18:59:04] so i can't really give any timeline, especially since nobody is working full-time on updating the forms styling [18:59:08] but… hopefully soon? :) [19:01:28] qgil: brion: greg-g : is there an appropriate WikiDev '16 proposal for a discussion of exif metadata? See Jane at CC's thread a while ago? [19:03:26] I did a quick skim through the board, and I didn't see a match Very rudimentary search attempt though [19:03:37] robla: i don't see any proposals that match [19:03:48] Sure, you are right. It was just an idea from cswiki and I understand there is still too many work to be done. I'll share with czech community what I learned and got to know here and we could discuss more details here or anywhere (my global nickname at wikiprojects is the same - "Dvorapa"). I could also help with anything I am able to if needed. [19:03:51] good to get it on the work agenda, perhaps :D [19:04:29] robla: brion yeah, I don't know of anything at wikidev16 [19:04:37] if it doesn't get broad interest, it'd be nice if multimedia/editing could prio it with some partner feedback though [19:04:42] *interst for the summit [19:04:54] brion: yeah, I understand from Jane that CC is still working on this, so it might be a good opportunity to make sure a proposal happens [19:05:02] dunno where in the goal-settings stages things are [19:05:08] * robla nudges qgil [19:06:03] @MatmaRex: I have to leave, later today I'll go back (and improve cswiki gadgets) [19:06:04] brion: yeah, I think they just need to be coaxed out of private point-to-point emails [19:06:42] Dvorapa: :) [19:19:50] hi robla [19:22:54] robla, exif + summit No results found for this query. [19:24:18] robla, also, have you seen https://phabricator.wikimedia.org/T116024#1799005 ? It would be great to have indications from ArchCom about proposals that we should promote, and proposals we could drop [19:24:32] in order to start organizing the schedule [19:28:24] qgil: fair enough. I'll worry about dealing with the mail from Jane later. [19:29:53] robla, thank you! really appreciated. [19:36:44] good evening [22:04:29] https://phabricator.wikimedia.org/E89 is happening in #wikimedia-office now [22:06:52] there seems to be momentum over there to make MediaWiki English-only, since i18n is too hard :-P [22:08:23] Nikerabbit appears to be on board [22:16:58] * legoktm quips [22:17:09] haha [22:32:30] * robla resolves to improve his trolling skills