[01:33:36] TimStarling: ori: (+others): fyi: https://www.mediawiki.org/wiki/User:RobLa-WMF/Blog#2015_FYQ2_goals_.28draft.29 [01:34:24] I'm just about to bail from SF office for the evening, but I'm dropping that here since it's still a normal hour for Tim [01:35:14] robla: `Focus` looks great; `Strengthen` is a bit vague (how do you know when the comm "understands the urgency and importance of its work "?); `Experiment` is a bit underwhelming [01:35:56] ori: feel free to drop something on my talk page :-) [01:36:06] * robla says as he shuts down [03:40:51] comments left [15:56:11] hi, i got some trouble with SyntaxHighlight & wiki composer.json missing component (kzykhys/pygments), could i ask about it there ? thanks [16:01:49] Frogg: I'm probably not the person to help you, but this is a reasonable place to ask for help. what's the problem? [16:03:45] each time i update my wiki, from last git repo i get an error with SyntaxHighlight, cause kzykhys/pygments is missing in composer.json, so each time i have to add it to composer, is there something to by pass this trouble ? [16:12:22] missing from which composer file? [16:17:01] composer.json in wiki main folder [16:18:22] ihave to add in require section [16:18:24] "kzykhys/pygments": ">=1.0" [16:18:42] else i got error when Syntaxhighlight is called [16:22:47] What are you doing with your vendor repo? [16:22:52] /checkout/whatever [16:29:39] sorry seems i got dc :P [16:30:26] i am using git pull to get last wiki, then i use php composer.phar install & update [16:31:07] so i should get vendor from composer.json list [16:31:24] if i am not wrong :P [16:32:47] Well, core composer.json won't depend include the dependency for an extnesion [16:32:49] https://github.com/wikimedia/mediawiki/blob/master/composer.json [16:33:06] I don't know if it's supposed to work from the extension composer.jsons too [16:33:13] even if the extension is bundled ? [16:33:30] Yeah [16:33:44] All the ones in that file above are what core explicitly needs [16:33:52] https://github.com/wikimedia/mediawiki-vendor is the bundle that WMF uses [16:34:39] ok, i see [16:34:59] i should run composer in the extension to get required component [16:35:04] thanks :P [16:38:19] Or that :) [17:01:46] Frogg: did you read the README for SyntaxHighlight? [17:02:36] https://phabricator.wikimedia.org/diffusion/ESHG/browse/master/README [17:02:50] Nemo_bis, Krenair: I'm looking into the Babel stuff now [17:21:51] Krenair: I'm re-reading the merge strategy code, where we have $GLOBALS[$key] = $val + $GLOBALS[$key];. Shouldn't that be the other way around? $GLOBALS[$key] += $val; ? [17:25:50] We want the keys from $val to overwrite, right legoktm? [17:26:05] I don't think so [17:26:14] $GLOBALS[$key] is the LocalSettings configuration [17:26:17] and $val is the defaults [17:26:19] ah [17:26:24] then yes, it needs to be swapped [17:27:38] wow, I even wrote a broken test case for this [17:27:40] >.< [17:31:05] gj legoktm [17:34:16] legoktm, you deploying or shall I? [17:34:23] I am [17:34:31] ok [17:39:38] Krenair: $wgVisualEditorAvailableNamespaces was also using 'array_plus' [17:41:34] legoktm, but you just deployed this right? the resulting config on enwiki looks fine [17:42:52] yes [17:43:05] but it's been broken for a while...