[03:27:17] <Base>	 https://gerrit.wikimedia.org/r/#/c/192246/ anyone besides h.o.o and o.d.d.e.r ? with +2 in operations/mediawiki-config perfectly :)
[03:55:53] <Krenair>	 Base, +2 in operations/mediawiki-config is basically deployment rights on the servers
[03:56:08] <Krenair>	 the two groups of people are supposed to be basically identical
[03:57:30] <Base>	 Krenair: well as long as someone merges i don't care what group he is in :3
[03:57:51] <Krenair>	 you want it to be merged *and deployed*, trust me. just merging is useless :)
[03:58:59] <Krenair>	 Base, anyway check the deployment calendar, it was already added there for monday afternoon
[03:59:23] <Base>	 could you give the link please?
[03:59:50] <Base>	 that patch is my second I think so I'm not very good at knowing where to look :)
[03:59:58] <Krenair>	 you probably shouldn't be asking for configuration change approvals without knowing about https://wikitech.wikimedia.org/wiki/Deployments#Monday.2C.C2.A0March.C2.A002
[04:02:17] <Krenair>	 tonythomas, hey
[04:02:50] <tonythomas>	 Krenair: hey ! 
[04:02:53] <Krenair>	 how are you?
[04:03:02] <tonythomas>	 fine, I guess :) 
[04:03:21] <tonythomas>	 that config change - was to me ?
[04:03:35] <tonythomas>	 I hope I too have something set for the same day :) 
[04:03:40] <Krenair>	 you do
[04:03:43] <Krenair>	 which is what I was going to ask about
[04:04:10] <tonythomas>	 great. Thats how you deploy to group1, right ?
[04:04:12] <Krenair>	 have you spoken to greg-g (or another wmf engineering manager, I guess) about this?
[04:04:16] <Krenair>	 I don't think so.
[04:04:36] <Krenair>	 I think it's 'wikipedia' => false,
[04:04:42] <tonythomas>	 its greg-g who told we should be doing that one week of march2 
[04:04:48] <Glaisher>	 it won't work
[04:04:55] <Glaisher>	 wiki is not a defined tag
[04:05:38] <Krenair>	 tonythomas, private email or somewhere I can read?
[04:05:56] <tonythomas>	 Krenair: I was copying https://gerrit.wikimedia.org/r/#/c/181130/5/wmf-config/InitialiseSettings.php,unified 
[04:06:30] <tonythomas>	 bd808: tells me thats the way they did to group1 
[04:07:23] * tonythomas and greg already commented the same over here : https://phabricator.wikimedia.org/T48640#1055566
[04:07:43] <Glaisher>	 huh
[04:07:47] <Krenair>	 hmm...
[04:07:50] * greg-g nods
[04:09:52] <Krenair>	 alright... well... if it works
[04:10:11] <greg-g>	 I didn't look at the patch, just ok'ing the idea :)
[04:10:34] * greg-g should get off the computer, is still recovering from a migraine
[04:10:40] <tonythomas>	  I personally dont know whether it would work - but we should have something like 'group1' 
[04:11:45] <Krenair>	 (if it did fail to disable on wikipedias, it may have been silent about it)
[04:13:03] <Krenair>	 whoever does the deployment can probably check it by running `mwscript eval.php aawiki` with `var_dump( $wmgUseBounceHandler );` - it should return false
[04:14:03] <tonythomas>	 right. but that would be after the deployment - no way to check if 'wiki' is defined before that ?
[04:14:23] <Glaisher>	 8 instances of "'wiki' => " in InitialiseSettings.php
[04:14:30] <Glaisher>	 I suppose it would work
[04:14:58] <Krenair>	 it would be before sync-file, which is the command that matters.
[04:16:03] <tonythomas>	 yay ! fine in that case
[04:17:14] <Krenair>	 tonythomas, Glaisher: actually...
[04:17:34] <Krenair>	 do you see how wmgMFAppPackageId is set up for 'wiki' => 'org.wikipedia', otherwise false?
[04:18:02] <Krenair>	 krenair@tin:~$ mwscript eval.php mediawikiwiki
[04:18:02] <Krenair>	 > var_dump( $wmgMFAppPackageId );
[04:18:02] <Krenair>	 string(13) "org.wikipedia"
[04:18:18] <Krenair>	 'wiki' applies to a lot more than just 'wikipedia'
[04:19:19] <Krenair>	 It's also like that on aawiki, but false on aawikibooks
[04:20:06] <Krenair>	 Another issue with the wikipedia-centric 'wiki' db name suffix :(
[04:21:38] <tonythomas>	 hmm. It would be perfect if we can have just 'group1' defined 
[04:21:39] <Krenair>	 I wonder what else has unexpected behaviour due to this config.
[04:24:52] <Krenair>	 view-source:https://m.mediawiki.org/wiki/MediaWiki -> <link rel="alternate" href="android-app://org.wikipedia/http/m.mediawiki.org/wiki/MediaWiki" />
[04:24:52] <Krenair>	 that's broken.
[04:25:39] <Glaisher>	 ha
[04:26:22] <Krenair>	 (The Wikipedia app refuses to serve MW sites that aren't Wikipedia, much to my annoyance. It's mostly a MediaWiki client.)
[04:28:37] <tonythomas>	 Krenair: if things are going to break, I will change to 'wikipedia' => false
[04:29:14] <Krenair>	 I'm not sure that works either
[04:30:02] <tonythomas>	 hmm. I still thinks we should have a group1 list defined 
[04:31:06] <Krenair>	 perhaps.
[04:31:15] <Krenair>	 I think we should file a ticket or two
[04:32:15] <tonythomas>	 true 
[04:33:03] * tonythomas stopped reporting tickets after https://phabricator.wikimedia.org/T90520 :\
[04:33:22] <Krenair>	 tonythomas, haha, don't worry about that ticket
[04:33:34] <Krenair>	 you have something constructive to say, go for it
[04:34:07] <tonythomas>	 haha :) It even spammed mailing lists :\
[04:34:13] <tonythomas>	 true. I will 
[04:34:52] <tonythomas>	 gotta go.
[04:35:08] * Krenair waves
[04:39:02] <Base>	 is alex monk here?
[04:39:22] <Glaisher>	 that is Krenair :P
[04:39:24] <Base>	 oh it's you Krenair 
[04:39:29] <Base>	 yep see now
[04:39:41] <Base>	 what do you mean "Not intended properly"?
[04:40:34] <Base>	 (about your comm at https://gerrit.wikimedia.org/r/#/c/192246/3/wmf-config/abusefilter.php)
[04:40:47] <Krenair>	 indented
[04:41:04] <Base>	 ah
[04:41:08] <Krenair>	 the space before $wgAbuseFilterAvailableActions[] = 'block'; // T89379
[04:41:12] <Krenair>	 is not like the others
[04:42:34] <Base>	 hm
[11:05:40] <Nemo_bis>	 Heh, that's a long personal toolbar. :) https://sh.wikipedia.org
[11:12:29] <Steinsplitter>	 hi, somone familar with the new search engine? The regex search seems broken
[11:20:08] <Nemo_bis>	 Steinsplitter: link
[11:21:47] <Steinsplitter>	 https://commons.wikimedia.org/w/index.php?title=Special%3ASearch&profile=default&search=insource%3A%22*%3C!--+*categories+*--%3E+*\n%22&fulltext=Search
[11:23:41] <Nemo_bis>	 That's not a regex search
[11:24:18] <Steinsplitter>	 or try insource:"<!-- categories -->"  (plain search) no results
[11:24:40] <Nemo_bis>	 Steinsplitter: is this what you were trying to do? https://commons.wikimedia.org/w/index.php?title=Special%3ASearch&profile=default&search=insource%3A%22%2F%3C!--.*categories.*--%3E.*\\n%2F%22&fulltext=Search
[11:24:46] <Nemo_bis>	 (144 results here)
[11:27:18] <Steinsplitter>	 Nemo_bis: but not <!-- categories -->   . it schould search only <!-- categories -->
[11:30:45] <Nemo_bis>	 Steinsplitter: I don't understand the difference
[11:33:04] <Steinsplitter>	 it isn matching the <!--
[11:44:04] <Nemo_bis>	 Steinsplitter: I'm not sure what you mean. I see a <!-- in https://commons.wikimedia.org/w/index.php?title=File:Eglise_Saint-Nicolas-des-Champs_-_Fa%C3%A7ade_ouest_-_Paris_03_-_M%C3%A9diath%C3%A8que_de_l%27architecture_et_du_patrimoine_-_APMH00004571.jpg&action=edit before "categories", so the regex was applied correctly
[11:44:50] <Nemo_bis>	 Do you only want spaces between "<!--" and "categories"? Can you just link an example of page you'd like to match? :)
[11:45:18] <Steinsplitter>	 i want only a fetach if it matches the exact string, only if <!-- categories -->  and not <!-- blabla categories -->
[11:45:36] <Nemo_bis>	 Ah, that's easy. You had included a wildcard so I thought the opposite :
[11:49:59] <Steinsplitter>	 oh, sorry :-D
[11:50:24] <Nemo_bis>	 Steinsplitter: do these pages include what you're looking for? https://commons.wikimedia.org/w/index.php?title=Special%3ASearch&profile=default&search=insource%3A%2F--+categories+--%2F&fulltext=Search
[11:51:10] <Nemo_bis>	 Or these https://commons.wikimedia.org/w/index.php?title=Special%3ASearch&profile=default&search=insource%3A%2F--+*%5BCc%5Dategories+*--%2F&fulltext=Search
[11:53:05] <Steinsplitter>	 thanks Nemo_bis :)
[12:05:44] <Nemo_bis>	 Can someone do a mwgrep search on ns8 occurrences of "facebook.com" and "twitter.com"? The result would be useful pasted in the talk pages of https://meta.wikimedia.org/wiki/Microblogging_handles and https://meta.wikimedia.org/wiki/Facebook_pages
[13:11:35] <Betacommand>	 Nemo_bis: why not just use linksearch?
[13:15:42] <Krenair>	 Betacommand, across all wikis...?
[13:16:15] <Krenair>	 Nemo_bis, https://phabricator.wikimedia.org/P343
[13:16:19] <Betacommand>	 Krenair: faster than parsing a dump
[13:16:41] <Betacommand>	 wait whats mwgrep?
[13:16:51] <Krenair>	 mwgrep is so much faster it's ridiculous.
[13:17:30] <Krenair>	 Betacommand, asks the search backend to search for a given string across all wikis, User/MediaWiki/Module namespaces
[13:25:29] <Nemo_bis>	 Thanks Krenair 
[13:26:08] <Nemo_bis>	 Krenair: hm, but that's only js pages? I would have needed all of them (mainly to catch sitenotice and sidebar)
[13:26:41] <Krenair>	 probably, that's what the script was designed for
[13:27:18] <Nemo_bis>	 Ouch, I had added a link to the source but Krinkle removed it :) https://wikitech.wikimedia.org/wiki/Wikimedia_binaries#mwgrep
[13:27:27] <Krenair>	 one sec
[13:29:38] <Nemo_bis>	 Right https://git.wikimedia.org/blob/operations%2Fpuppet/5b7895dcd5b49b385f97e99438acf837f6a1a1d8/files%2Fmisc%2Fscripts%2Fmwgrep#L72
[13:30:42] <Krenair>	 Nemo_bis, I pulled out the two lines which restrict it to JS/CSS: https://phabricator.wikimedia.org/P343#1671
[13:32:26] <Krenair>	 (that link shows an older copy of the script, the relevant code is different there)
[13:32:41] <Krenair>	 current version is https://git.wikimedia.org/blob/operations%2Fpuppet/47a6a8d940b4abe87d8bc6d9248b764c4e01aa6a/modules%2Fscap%2Ffiles%2Fmwgrep#L94
[18:29:02] <Andyrom75>	 hi, question, why during an existence check (e.g. #ifexist), the page is categorized as requested? Is it possible to avoid it?
[18:30:21] <marktraceur>	 Hm.
[18:30:42] <marktraceur>	 Andyrom75: My guess is that an #ifexist counts as a link, and links to nonexistent pages are always categorized that way.
[18:31:44] <Andyrom75>	 marktraceur: but my point is: why? Can this behaviour be changed? It ruins the statistic of the "real" most requested pages.
[18:31:57] <marktraceur>	 Hm.
[18:32:10] <Andyrom75>	 there a functional (not technical) reason behind it?
[18:32:12] <marktraceur>	 You could probably add a config variable for that
[18:32:23] <marktraceur>	 I doubt it, but I could be wrong
[18:32:28] <marktraceur>	 I imagine that, if you changed it, you would find out
[18:32:30] <Andyrom75>	 this could be great, do you know which one?
[18:32:50] <marktraceur>	 No, I mean, I think you would need to edit the code to put a config variable in that would make the behaviour change.
[18:33:53] <Andyrom75>	 oh yes, that's reasonable, but I'm not enough skilled to change the code, I could just open a ticket for it, but I would know in advance the name of the configuration variable (to be sure that exists)
[18:37:30] <marktraceur>	 Sure
[18:37:43] <marktraceur>	 Andyrom75: https://phabricator.wikimedia.org is our issue tracker
[18:37:50] <marktraceur>	 You can name the variable yourself in the ticket :)
[18:40:16] <Andyrom75>	 marktraceur: I'm not sure to have understood. Are you talking of an existing variable that can be configured or about a new variable that must be created and inserted in the code by a developer?
[18:40:35] <marktraceur>	 Andyrom75: The latter.
[18:41:06] <Andyrom75>	 oh... in this case I think is a dead-end road :-D
[18:58:55] <legoktm>	 we register a link in the pagelinks table so that if the page is created or deleted, we can properly invalidate the cache of any page checking whether it exists or not.
[22:41:19] <Nemo_bis>	 Ouch http://www.webperformancetoday.com/2015/02/25/google-new-slow-label-web-performance/
[22:48:33] <cgt>	 Interesting that they mark their own sites as slow in the pictured results
[22:49:55] <cgt>	 Also, does Visual Editor force editors to write a summary? Vandals used to not write summaries, but now they write often deliberately misleading summaries when using Visual Editor. 
[22:55:14] <Nemo_bis>	 cgt: check if there is a tag associated to the edit
[22:55:36] <Nemo_bis>	 It's more likely to be a mobile edit, that's where edit summaries are most pushed
[22:56:05] <cgt>	 There's not necessarily a mobile edit tag, but there's almost always a Visual Editor tag on those kinds of edits. And vandals didn't used to care about summaries.
[22:56:31] <Nemo_bis>	 Vandals have been using false edit summaries for a while
[22:57:08] <cgt>	 Not this much, at least not on dawiki. I think it started about when Visual Editor was rolled out.
[22:58:42] <toblerone>	 Hi all, is this an appropriate channel to ask about the mediawiki api?
[22:59:02] <cgt>	 I'd suggest #mediawiki, but people here might know about it too
[22:59:11] <cgt>	 Not that I blame VE. It's easy to spot the vandals anyway, they seem to write a very particular style of edit summary.
[22:59:22] <toblerone>	 i was on that channel, but it was empty : O
[22:59:35] <cgt>	 no it isn't
[22:59:39] <toblerone>	 ?
[22:59:41] <cgt>	 there are 288 people in there right now
[22:59:43] <toblerone>	 maybe i had a typo
[23:00:27] <cgt>	 Looks like you're in there