[06:37:45] Some bugs to file https://commons.wikimedia.org/wiki/Commons:Administrators%27_noticeboard#Deprecated_toolserver.org_URLs_in_MediaWiki_namespace [21:35:56] any code update in the last four hours ? all attempt to edit wikisource in Page: namespace fail du to a js exception [21:36:09] Uncaught HierarchyRequestError: Failed to execute 'appendChild' on 'Node': The new child element contains the parent. [21:36:25] phe: Do you have an example you can link to [21:36:26] example: https://la.wikisource.org/w/index.php?title=Pagina:Foliot_Canticum.pdf/87&action=edit&debug=1 [21:36:30] maybe I can have a very quick look [21:36:31] ok [21:36:33] looking [21:36:46] wikisource updated to MW1.24 wmf16 [21:37:33] the edit form don't show because the form is tweaked by Proofreadpage extension js, which don't run [21:37:57] it occur only with the "ehanced" toolbatr in preference [21:38:07] I can reproduce [21:38:22] me too Google Chrome on Windows [21:39:01] it's our main namespace where all the work is done, it'll nice to have it the edit form :) [21:48:22] phe, hoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=69327 [21:49:39] I guess it can go out in SWAT; does anyone know when the class was removed? [21:50:06] wait, what [21:50:15] that's a deployed extension and it's full of self review :S [21:50:33] because no one review them... [21:50:52] hoo: Who's going to review Wikisource changes at the Wikipedia Foundation? :P [21:51:40] hoo: oO i think you're right :/ [21:52:46] I reviewed this identical patch https://gerrit.wikimedia.org/r/#/c/152029/ [21:53:09] phe, that doesn't mean it's okay to have stuff on WMF-deployed extensions self-reviewed [21:53:32] yep [21:53:57] marktraceur: I don't know, what content model proofreadpages has, but i think it's the onliest change in WikiEditor for wmf16: https://gerrit.wikimedia.org/r/#/c/141296/2 [21:54:02] Sure [21:54:13] to load WIkiEditor only on wikitext content model pages [21:54:13] onliest :D [21:54:27] lol :P [21:54:45] Hm, where's tpt, I wonder if they'll do the submodule update too [21:54:52] Wait is FlorianSW === tpt? [21:55:07] sure, not ;) [21:55:09] wgPageContentModel [21:55:09] "proofread-page" [21:55:24] I think it uses wikitext behind the scenes [21:55:31] probably it extends it [21:55:32] and the change (https://gerrit.wikimedia.org/r/#/c/153027/1) to fix this, isn't merged for now [21:55:37] (server side) [21:55:58] FlorianSW: It's merged on master, but this needs a backport + deploy [21:56:13] and that needs to be scheduled (we can't just deploy whenever we want) [21:56:34] guess there's a SWAT tonight [21:56:47] ah, damn, not looked at the branch (it's the only change in the bug report). Yes, that needs a swat i think [21:57:48] jap, 23 UTC : https://wikitech.wikimedia.org/wiki/Deployments [21:58:46] hoo, uh, isn't editing broken across the main part of wikisource at the moment? [21:58:46] I can "partner" for that change, if you want/ need [21:58:51] wait what? [21:59:06] or am I misunderstanding the chat log? [21:59:46] Krenair: I think you're right... [21:59:52] well stuff is broken [21:59:58] but not sure what you mean as main part [22:00:02] at least the Page namespace [22:00:06] it's our main namespace where all the work is done, it'll nice to have it the edit form :) [22:00:08] if you mean main part == wikitext then probably not [22:00:43] If greg-g is ok, I can also push it now, or marktraceur can [22:00:55] but that's only one hour [22:01:15] I'm not in a rush [22:03:04] I can't really judge how important that is [22:03:50] wikisource is broken? [22:03:57] if we have a fix, go ahead and fix [22:04:04] it's a blocker for most work, most edit go to that namespace [22:04:10] yeah, ok [22:04:45] beside that disabling the enhanced toolbar allow to edit, so if you don't want to rush... [22:05:08] if it's on per default that's not bearable [22:05:16] +1 hoo [22:08:09] ok, on that now [22:33:50] phe still waiting? :D [22:34:04] Just reload the page you want to edit and edit in Wikisource :) [22:39:53] FlorianSW, we can edit, ty all [22:40:08] thanks to hoo :) [22:40:22] You're welcome [22:41:16] we get always the enhanced tool bar whatsover we want the old in pref, but that'll wait another bug fix for wmf17 prolly [22:42:20] mh... is that new? Create a bug for it, if there isn't one [22:48:40] phe: for the case you don't know how: https://www.mediawiki.org/wiki/How_to_report_a_bug