[00:26:22] * legoktm pokes hoo 
[00:26:39] <hoo>	 uh hi legoktm :)
[00:26:53] <hoo>	 Guess what I'll do tonight ;)
[00:26:58] <legoktm>	 https://ar.wikipedia.org/wiki/%D9%85%D9%8A%D8%AF%D9%8A%D8%A7%D9%88%D9%8A%D9%83%D9%8A:Common.css <-- want to remove the external resources they're loading? 
[00:27:04] <legoktm>	 :D
[00:27:18] <hoo>	 they do what
[00:27:28] <legoktm>	 they have a @import url(//fonts.googleapis.com/earlyaccess/amiri.css);
[00:27:53] <hoo>	 I wish we had git blame for that :P
[00:28:02] <Betacommand>	 hoo: we do
[00:28:06] <legoktm>	 it's been around for 3 months
[00:28:10] <legoktm>	 ashley found it earlier
[00:28:16] <hoo>	 uh?
[00:28:56] <Betacommand>	 hoo: one sec
[00:30:57] <Betacommand>	 hoo: http://wikipedia.ramselehof.de/wikiblame.php?user_lang=en&lang=ar&project=wikipedia&article=%D9%85%D9%8A%D8%AF%D9%8A%D8%A7%D9%88%D9%8A%D9%83%D9%8A%3ACommon.css&needle=nts.googleapis.com%2Fear&skipversions=0&ignorefirst=0&limit=500&offmon=6&offtag=23&offjahr=2014&searchmethod=int&order=desc&force_wikitags=on&user=
[00:31:17] <Betacommand>	 hoo: https://ar.wikipedia.org/w/index.php?title=%D9%85%D9%8A%D8%AF%D9%8A%D8%A7%D9%88%D9%8A%D9%83%D9%8A:Common.css&diff=prev&oldid=12671493
[00:31:31] <hoo>	 awesome...
[00:31:34] * hoo sets a bookmar
[00:31:35] <hoo>	 k
[00:32:26] <Betacommand>	 hoo: just a pain in the RTL wikis
[00:32:47] <Betacommand>	 I couldnt copy/paste the page title
[00:33:24] <Betacommand>	 hoo: make sure you set it to search for wikitext in most cases
[00:33:35] <legoktm>	 I'm nearly done with a phantomjs tool that'll find any other loading of external resources
[00:34:16] <hoo>	 legoktm: Chris did something similar before, but can't really remember what
[00:34:21] <Betacommand>	 legoktm: ??
[00:34:23] <hoo>	 Betacommand: Nice :)
[00:34:37] <Betacommand>	 hoo: I have tools for just about everything.
[00:34:41] <legoktm>	 Betacommand: yes?
[00:34:50] <legoktm>	 hoo: yeah, I think he had one for checking loading of HTTP over HTTPS
[00:34:52] <Betacommand>	 hoo: my toolbox is very large
[00:35:01] <Jasper_Deng>	 legoktm/hoo/Betacommand: is there something bad about importing external CSS? I guess it's a security hazard.
[00:35:04] <Betacommand>	 legoktm: whats the phantomjs
[00:35:23] <hoo>	 Jasper_Deng: Privacy policy violation ;)
[00:35:29] <legoktm>	 Betacommand: http://phantomjs.org/
[00:35:31] <Betacommand>	 Jasper_Deng: its not only  a security but privacy also
[00:35:36] <legoktm>	 it's headless webkit
[00:36:58] <hoo>	 legoktm: I hope this guy speaks English... no babel, but looks like it
[00:38:12] <Jasper_Deng>	 btw hoo, your xwiki link doesn't work
[00:38:20] <Jasper_Deng>	 https://ar.wikipedia.org/w/index.php?title=Foundationwiki:Privacy_policy&action=edit&redlink=1
[00:38:21] <hoo>	 on Toolserver?
[00:38:24] <hoo>	 Oh that, yes
[00:38:33] <hoo>	 I wanted to write more, but pressed enter in mistake
[00:38:43] <hoo>	 and I'm not going to change that
[00:38:51] <Jasper_Deng>	 well, you /can't/ change it xD
[00:39:00] <hoo>	 Jasper_Deng: From the DB I could :P
[00:40:40] <Krenair>	 Actually hoo could.
[00:40:53] <Jasper_Deng>	 db doesn't count
[00:41:01] <Krenair>	 Although... hoo, what are the rules with doing stuff like that?
[00:41:40] <hoo>	 Krenair: There aren't any: Use common sense... and my common sense says this is a clear no-no ;)
[00:42:05] <Krenair>	 :)
[00:50:13] <hoo>	 legoktm: https://ar.wikipedia.org/wiki/%D9%86%D9%82%D8%A7%D8%B4_%D8%A7%D9%84%D9%85%D8%B3%D8%AA%D8%AE%D8%AF%D9%85:%D8%B2%D9%83%D8%B1%D9%8A%D8%A7#.D9.85.D9.8A.D8.AF.D9.8A.D8.A7.D9.88.D9.8A.D9.83.D9.8A:Common.css
[00:50:33] <hoo>	 did you yet drop an email to legal/ Chris?
[00:50:40] <legoktm>	 no, should I?
[00:50:47] <legoktm>	 and thanks
[00:50:57] <hoo>	 I can do that... not very important here, but I usually do that to have them informed
[00:51:50] <hoo>	 this is by far not as bad as the case where someone included google analytics
[00:51:54] <legoktm>	 ok
[00:54:07] <Krenair>	 Hmm... Do we not have any tool to scan wikis for the inclusion of these sorts of things yet?
[00:54:13] <legoktm>	 I'm nearly done writing one!
[00:54:25] <Krenair>	 Oh, okay.
[00:54:54] <legoktm>	 there are a lot of wikis that are throwing JS syntax errors just on the main page
[00:55:43] <hoo>	 Oh yes :/
[00:57:26] <Krenair>	 Yeah...
[00:57:45] <Jasper_Deng>	 isn't it b/c JS doesn't do draconian error handling like XML?
[00:58:07] <Jasper_Deng>	 in the future a global abuse filter could be setup to detect attempts at this
[00:58:23] <hoo>	 Jasper_Deng: Attempts at what?
[00:58:45] <Krenair>	 Things would be so much better if all Wikimedia common/skin JS had to go through code review by a MediaWiki developer (at least with the default outcome being approval)
[00:58:51] <Jasper_Deng>	 adding external JS/CSS to MediaWiki:Common.js or MediaWiki:Common.css respectively
[00:59:17] <hoo>	 Jasper_Deng: We could make a tracking filter for the small wikis
[00:59:26] <Jasper_Deng>	 yeah that's exactly what I meant
[00:59:39] * Jasper_Deng said "detect" not "hinder"
[01:06:45] <legoktm>	 http://tools.wmflabs.org/legobot/js.txt <-- still running
[01:07:47] <legoktm>	 it.wikivoyage.org is loading stuff from toolserver and wmflabs
[01:07:53] <hoo>	 both ok
[01:08:08] <hoo>	 toolserver roots have NDAs with the foundation, because of that it's ok
[01:08:16] <hoo>	 or something along these lines, but it's ok
[01:08:30] <legoktm>	 ok, I'll whitelist  both of those for the next run
[01:09:04] <hoo>	 I still have a list with JS from 200[89] which I want to remove... so many ideas, so few time
[01:14:40] <legoktm>	 heh, officewiki logged out is throwing syntax errors
[01:16:07] <Krenair>	 It tries to include a private gadget...
[01:16:26] <Krenair>	 But I don't get syntax errors...
[01:17:37] <legoktm>	 try it logged out
[01:18:11] <Krenair>	 I tried it both logged in and logged out
[01:18:37] <legoktm>	 I get the syntax error in FF30 logged out
[01:21:30] <Krenair>	 legoktm, so do I, but not in chrome interestingly...
[01:24:50] <Krenair>	 legoktm, hmm... is including things directly from tools.wmflabs.org okay?
[01:24:53] <Krenair>	 What about other labs projects?
[01:25:03] <legoktm>	 hoo said it's fine
[01:25:29] <legoktm>	 from a privacy aspect at least, I remember there was an issue with it.wp DDoS'ing tools when they directly included JS from it on every page view
[01:25:47] <legoktm>	 I don't think other labs projects are ok, since they don't require NDA and you can get the user's IP
[01:26:00] <legoktm>	 so I whitelisted tools.wmflabs.org, not *.wmflabs.org
[01:26:11] <Krenair>	 Although, it would enable the tool to reveal the user's cookies with some JS
[01:26:43] <Krenair>	 But admins can already do that so...
[01:27:52] <hoo>	 labs is awry here... I guess it's not ok (IMO), but tool labs should be bearable (and so is TS, although that wont be an issue soon)
[01:32:59] <legoktm>	 https://github.com/legoktm/foo-js/blob/master/foo.js <-- source code
[02:03:13] <Mono>	 en.wikipedia throwing a database connection error
[02:04:37] <jamesofur>	 Mono: when editing? or on load?
[02:05:36] <Mono>	 on load jamesofur 
[02:05:49] <hoo>	 had that reported as well
[02:05:50] <Mono>	 it's working about 90 seconds later on reload
[02:05:51] <hoo>	 can't see anything
[02:06:03] <Mono>	 white background page
[02:06:09] <jamesofur>	 yeah, I haven't been able to replicate either hoo when did you get report?
[02:06:23] <hoo>	 at :02
[02:23:49] <harej>	 Out of curiosity, how difficult is it to get a WMF Labs account?
[02:24:11] <hoo>	 you just have to sign up
[02:24:27] <harej>	 Sweet!
[02:24:31] <hoo>	 https://wikitech.wikimedia.org/w/index.php?title=Special:UserLogin&returnto=Main+Page&type=signup
[02:24:31] <harej>	 Where can I sign up?
[02:24:36] <harej>	 Thank you hoo
[02:24:39] <hoo>	 see above
[02:24:42] <comets>	 psychic O_O
[02:24:59] <comets>	 my lucky numbers today hoo? :D
[02:25:52] <hoo>	 4 and 9 maybe? :D
[02:27:16] * comets off to the lottery!
[02:59:06] <Josve05a>	 Help!
[02:59:18] <Josve05a>	 I can't login to meta or commons!
[02:59:35] <hoo>	 what's the error?
[02:59:41] <Josve05a>	 When I press Log in, I get redirected within a second to the previous page
[02:59:59] <Josve05a>	 I get to the log in screen, then....poof
[03:00:12] <Josve05a>	 back at the previous article/picture/page
[03:00:42] <hoo>	 Josve05a: Try pressing F5 maybe CentralAuth logged you in in the background ;)
[03:01:08] <Josve05a>	 nope
[03:01:40] <Josve05a>	 I tried pressing Esc (stop) while the page was loading the log in screen, and typed in my things and pressed Log in, and all it did was take me to the prev page...
[03:02:03] <hoo>	 works fine for me
[03:02:13] <hoo>	 are you logged in globally alreadY?
[03:02:23] <Josve05a>	 yes
[03:02:24] <Josve05a>	  things and pressed Log in, and
[03:02:26] <Josve05a>	 oops
[03:02:35] <Josve05a>	 I am logged in on wikipedia
[03:02:44] <Josve05a>	 and wikidata
[03:02:53] <Josve05a>	 but not commons or meta
[03:03:20] <hoo>	 that shouldn't happen
[03:03:38] <hoo>	 usually just a click on log in should log you in, no need to put your data
[03:03:41] <Josve05a>	 https://meta.wikimedia.org/wiki/Special:Contributions/81.236.232.15 <<< I edited with my IP. That's when I noticed I wasn't logged in
[03:04:05] <Josve05a>	 started on 17 June or so...
[03:04:39] <hoo>	 open a bug, I'd say
[03:05:36] <Josve05a>	 (right now when I press Log in at the right top, it takes me to the log in screen, but within a second it takes me to the prev. screen (like it does when it log me in automaticly, but this time without logging me in....)
[03:06:12] <Josve05a>	 I don't really open bugs...only regarding Huggle...how should I do it?
[03:06:57] <hoo>	 Josve05a: https://bugzilla.wikimedia.org/enter_bug.cgi?product=MediaWiki%20extensions select CentralAuth under component and describe the bug as good as possible
[03:08:35] <Josve05a>	 I'll try, but I don't know if it will make much sense...
[03:10:01] <hoo>	 Can't help you offhand now, mostly because it's 5am :/
[03:10:58] <Josve05a>	 I know, I should be sleeping...
[03:11:04] <Josve05a>	 oh...he left...
[10:39:36] <Kolega2357>	 Who can active recent changes patrol on https://sh.wiktionary.org/wiki/Glavna_strana ?
[10:42:44] <andre__>	 Kolega2357: please link to a bug report which links to community consensus, as described on https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes
[10:43:54] <Kolega2357>	 andre__ Community is low.
[10:44:11] <andre__>	 Rules are rules.
[10:44:19] <andre__>	 You can discuss that in the bug report. I guess.
[10:47:24] <Kolega2357>	 andre__ https://sh.wiktionary.org/wiki/Wiktionary:Pijaca-%D0%9F%D0%B8%D1%98%D0%B0%D1%86%D0%B0#Patroliranje_izmena_2 see here
[10:47:35] <andre__>	 please link to a bug report which links to community consensus, as described on https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes
[10:47:47] <andre__>	 not sure how many more times I should write this. I've written it once in private, and twice here now.
[10:47:56] <andre__>	 Is there something you don't understand with that sentence?
[10:48:10] <andre__>	 Create a bug report if there is none yet, and follow the guidelines on meta.
[10:48:31] <Kolega2357>	 Yes I dont understand you. Community is a low. I am only vote for recent changes patrol :)
[10:50:44] <Kolega2357>	 andre__
[10:51:05] <andre__>	 Okay. Please find somebody who can translate https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes for you.
[10:51:08] <andre__>	 Kolega2357, ^
[10:51:38] <Kolega2357>	 andre__ You are a funny Please find somebody who can translate :)
[10:51:46] <andre__>	 No I'm serious.
[10:51:56] <andre__>	 You might know somebody who speaks English.
[10:52:02] <andre__>	 and your language.
[10:52:11] <andre__>	 Anyway, I've explained how things work, so I'm out now. :)
[10:52:14] <andre__>	 good luck
[10:55:54] <andre__>	 Kolega2357, and no, insulting me via private messages does not help either.
[12:03:02] <DanielK_WMDE>	 if you insult andre__, bug files you...
[12:03:18] <andre__>	 :)
[13:35:40] <Josve05a>	 Can someone here download Firefox Nightly to confirm if this bug is just for me or if it is a problem with the browser it self? https://bugzilla.wikimedia.org/show_bug.cgi?id=66964
[13:40:13] <Jurgen>	 Josve05a: no problems here
[13:41:44] <Josve05a>	 hm... then it is me...
[13:46:26] <Jurgen>	 Josve05a: https://www.youtube.com/watch?v=p85xwZ_OLX0
[13:46:51] <Josve05a>	 yes...
[13:47:39] <comets>	 u have ABP add-on?
[13:47:55] <comets>	 its apparently very buggy with FF30
[13:48:29] <Jurgen>	 ABP?
[13:48:41] <comets>	 adblock plus
[13:48:45] <Jurgen>	 Ah
[13:48:53] <Josve05a>	 I have Firefox 33.0 a1
[13:48:59] <Josve05a>	 I got it to work!!!
[13:49:45] <Josve05a>	 It worked! I had to clear all my cookies, and change to "Remember history" instead of "Use custom settings for history"...
[13:50:56] <comets>	 not sure what history has to do with cookies..
[13:52:00] <Josve05a>	 Cookies was under the History-settings, I changed it at the sam time, then it worked...I don't want to chang back. It might not have to do with it, but at least it works, so I am happpy!
[21:13:01] <NativeForeigner>	 did anyone here do work on CheckUser?
[21:14:47] <Nemo_bis>	 as in using special:checkuser or as in authoring its code
[21:15:02] <NativeForeigner>	 authoring the code
[21:15:26] <NativeForeigner>	 trying to find and ameliorate a small issue with it, but I can't figure out where in the code this specific operation occurs
[21:15:38] <NativeForeigner>	 CheckUserLog actually
[21:16:01] <Krenair>	 https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/CheckUser+-owner:L10n-bot,n,z
[21:17:12] <NativeForeigner>	 thanks, I'm just getting started on working with wikimedia dev, I don't know my way around that well
[21:17:12] <NativeForeigner>	 appreciated
[23:36:24] <Carmela>	 NativeForeigner: Hi.
[23:36:34] <Carmela>	 You should just ask your question.
[23:36:45] <Carmela>	 Rather than trying to find someone who once worked on the code and hoping they'll be able to help you.
[23:36:58] <Carmela>	 Just describe the small issue and someone will point you in the correct direction, in theory.
[23:39:32] <NativeForeigner>	 ok, will do
[23:39:49] <NativeForeigner>	 I'm trying to find where the code processes the input, on Special:CheckUserLog
[23:40:04] <NativeForeigner>	 right now if you pad the end of the input with spaces it comes back as invalid, and there is no reason for it to do that
[23:40:18] <NativeForeigner>	 I can see the api calls and such but I can't figure out where the input is coming from
[23:48:32] <Carmela>	 NativeForeigner: Invalid with what error message?
[23:48:48] <Carmela>	 https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCheckUser.git/69e0cd0aaa751a133a5e50f5d889e75f210ea128/specials%2FSpecialCheckUserLog.php#L74
[23:49:17] <Carmela>	 Maybe around there?
[23:49:25] <Carmela>	 I don't have CU installed anywhere to poke at it.
[23:49:35] <NativeForeigner>	 ah ok
[23:49:37] <NativeForeigner>	 let me check
[23:50:22] <Carmela>	 Sometimes you can trace back through the code by matching error messages with the PHP.
[23:50:38] <Carmela>	 So if you're seeing https://www.mediawiki.org/wiki/MediaWiki:Checkuser-user-nonexistent
[23:50:41] <^demon|away>	 Trailing whitespace should be easy to handle.
[23:50:45] <Carmela>	 You can grep for that message key.
[23:50:47] <^demon|away>	 Just a matter of throwing a trim() in there somewhere.
[23:50:54] <Carmela>	 Yes.
[23:50:55] <NativeForeigner>	 yeah, should be, I can literally just run $target through trim
[23:51:12] <Carmela>	 You'd think newFromUser or whatever would be smarter, though.
[23:51:28] <Carmela>	 Like at some level we're aggressively normalizing...
[23:51:30] <NativeForeigner>	 newFromName?
[23:51:35] <Carmela>	 Yeah.
[23:51:41] <Reedy>	 SemanticUser
[23:51:46] <^demon|away>	 I thought WebRequest mostly stripped trailing w/s.
[23:52:02] <NativeForeigner>	 for whatever reason, although trailing w/s is stripped in CheckUser, it isn't for CheckUserLog
[23:52:03] <^demon|away>	 But this is twice in <1 week I've found that to not be the case.
[23:53:20] <Carmela>	 http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCheckUser.git/69e0cd0aaa751a133a5e50f5d889e75f210ea128/specials%2FSpecialCheckUser.php#L18
[23:53:43] <Carmela>	 Looks like someone threw some trim()s on SpecialCheckUser.php, but not SpecialCheckUserLog.php.
[23:53:46] <Carmela>	 Easily remedied.
[23:53:59] <^demon|away>	 lemme open the file.
[23:54:02] <^demon|away>	 and make a patch
[23:54:04] <NativeForeigner>	 if you don't mind
[23:54:07] <NativeForeigner>	 can I go through that process
[23:54:12] <NativeForeigner>	 I haven't before, would like to figure it out
[23:54:31] <^demon|away>	 Knock yourself out :)
[23:54:43] <NativeForeigner>	 I'll go ahead and normalize the checkuser one as well
[23:54:51] <NativeForeigner>	 althoughgh it does look like you're best off stripping $user...
[23:57:54] <NativeForeigner>	 hopefully I'll learn enough going through some easy bugs I'll have enough werewithall to do some touchup on checkuser