[10:00:53] @seen lianagent [10:00:53] twkozlowski: I have never seen lianagent [10:01:02] True. [10:01:05] @seen liangent [10:01:05] twkozlowski: Last time I saw liangent they were talking in the channel, they are still in the channel #mediawiki-visualeditor at 5/6/2014 6:40:36 PM (1d15h20m28s ago) [11:44:31] Hi [14:42:48] bugzilla admin online? [17:09:04] chrismcmahon: ping [17:09:23] was hoping you'd know who's the best person to chat to about getting the gettingstarted extension running the extension phpunit testsuite? [17:12:21] in jenkins? [17:12:31] I believe so [17:12:34] phuedx ^ [17:13:08] You should be able to make a changeset to do this ;) [17:13:18] Then poke Hashar or possibly Krinkle [17:14:12] hoom [17:14:15] i shall have a looksie [17:14:23] Reedy: jenkins-job-builder-config? [17:14:29] StevenW: yep, hashar right off for unit tests in Jenkins [17:14:41] That sounds about right [17:14:46] Let me check what's in the repo [17:15:47] StevenW: at some point I'd like to talk about cross-browser functional tests for GettingStarted, if a few of those would be valuable [17:16:14] Looks right [17:31:03] chrismcmahon: now that the UI is stable, it's not a bad idea [21:18:05] chrismcmahon: another question [21:18:16] sure StevenW [21:18:43] If we have a feature flag (a boolean setting) to enable/disable an experiment in GettingStarted [21:18:59] can we turn that on via settings in en beta labs, but not production enwiki [21:19:00] ? [21:19:34] Or should we use another test wiki for that? [21:19:43] The commits in question are merged to master. [21:20:08] StevenW: sure. if it's in the master branch, we can make it work in beta labs [21:20:59] StevenW: mediawiki-config for beta labs is based on prod, but a few settings can be overridden by a local beta config if necessary [21:21:10] Cool [21:22:02] StevenW: so we can either make it live globally in beta labs but not prod, or we can enable per-user, per-page, whatever [21:22:18] globally on beta labs should be fine [21:23:04] This is wmgGettingStartedRunTest in InitialiseSettings, IIRC [21:25:24] StevenW: OK. if you don't want to make the change to InitialiseSettings, probably easiest is to make a Bugzilla ticket for hashar and/or me with the details. I can make the change, but I don't have +2 in that repo. [21:26:21] what is the wiki name to use in InitialiseSettings if you don't mind me asking? [21:27:35] StevenW: one sec... [21:29:39] StevenW: existing settings: https://git.wikimedia.org/blob/operations%2Fmediawiki-config/09e8798dcc75fb2218d7dc9c9e0965d544e393cb/wmf-config%2FInitialiseSettings-labs.php [21:30:05] Ah cool. [21:30:07] Thanks [21:37:53] chrismcmahon, StevenW: 'default' or 'wikipedia' to enable for en.wikipedia.beta.wmflabs.org [21:38:03] ? [21:38:20] I think we can just set it to true without a wiki identifier [21:38:29] since InitialiseSettings-labs.php only applies to Labs [21:39:00] that will override for beta labs without impacting prod [21:39:26] StevenW: Ok, sounds good to me. [21:40:53] StevenW: Globally i believe means 'default' if you look at all the entries they have a wiki key .. so i'm just going to go for it and hope [21:41:14] I think that's okay for Labs [21:41:32] if you add phuedx, superm401 and hashar as reviewers they will likely confirm or deny :) [21:41:52] Ok [22:25:51] so... we could have some JS or bot or something to detect/warn on syntax error? I'm thinking one place to start is unmatched parens/braces or malformed calls [22:26:10] https://en.wikipedia.org/w/index.php?title=Execution_of_Clayton_Lockett&diff=prev&oldid=607465561 has had a broken {{quote}} call for ~34 hours [22:26:20] (still not fixed) [22:27:03] wtf, did someone read my mind? [22:27:21] compare timestamp for channel with history for the page i linked :) [22:27:57] oh, nvm the bot only fixed other broken stuff on the same page [22:28:18] so i guess that bot could cover this extra case maybe