[00:53:20] Gloria: Just got back from dinner, saw your message, filed bug 63927. [00:54:05] Holy crap, that became a link. How'd that? WHAT MAGIC?! [00:56:15] 'bug 63927' was linked? probably a client extension [00:59:56] Krenair: I have chatzilla [01:00:20] oh, the link is to Mozilla Bugzilla [01:00:24] err [01:05:06] Sven_Manguard: Chatzilla->Preferences [01:05:36] Go to Appearance tab and change BugZilla URL to https://bugzilla.wikimedia.org/show_bug.cgi?id=%s [02:31:58] Can I close my own bug tickets? [02:35:41] Withoutaname: of course [04:48:38] sorry for the mass kick, user had too many clones in here - i.e. had to fix connection [05:13:27] Jasper_Deng. monster kick? :p [05:13:40] yes it's the biggest I've ever done [05:13:41] (Needs UT announcer) [05:14:08] its 22 of them so it is over 21 [05:14:11] you loose! [05:17:32] Hence I have blackjack Jasper_Deng [05:19:35] Jasper_Deng: kapsi.fi has thousands users, please only block tm_travolt@kapsi.fi [05:20:06] c^ [05:21:01] oops need to make it a forward ban >.< [05:21:32] thanks for the heads up nemo [06:31:47] Tm_T/Tm_K: once you've fixed your client, PM me or another op [06:49:54] Jasper_Deng I doubt he got the msg [06:50:15] pm? [06:50:26] I mean memo [06:51:48] I did PM him [06:51:52] most people will archive PMs [11:50:31] http://weblogs.lib.uh.edu/speccol/files/2013/09/cmac002_horizontal.jpg is there any software for mediawiki which lets people collaborate on articles with such inline comments? ('read' more is ok, 'draft' more with comments, like article page + talk page = draft mode) [12:37:30] gry: https://www.mediawiki.org/wiki/Feature_map#Collaboration:_Features_that_support_the_process_of_working_together https://www.mediawiki.org/wiki/Extension:Reflect https://www.mediawiki.org/wiki/Extension:Annotator [17:56:36] thedj, regarding your comment on https://gerrit.wikimedia.org/r/#/c/120396/ that pages are expecting the output page by reference -- can you give me an example? (also thanks for testing it!) [17:56:53] *er; that hook consumers are expecting the output page byref [18:01:54] scribunto and wikieditor hooks were two that failed for [18:02:12] mwalker: after that i stopped actively looking [18:02:37] kk /me goes and looks to see what they're doing with the reference [18:02:56] mwalker: probably nothing, other than adding it to their function signature [18:03:27] but if you remove it core first, we get erors on non matching function signatures. [18:04:23] so you need to remove extension first, and then break backwards compatibilty in all those extensions if you are out of luck. (not sure if we can workaround it inside php, then it might be less invasive) [18:05:43] also, not i only looked at editpage, not at $out [18:05:51] note [18:07:11] Reedy: didn't we have a maintenance script to purge all pages using math ? [18:09:15] mwalker: so wikieditor actually has: editPageShowEditFormInitial( &$toolbar ) [18:09:40] mwalker: ant that needs to be editPageShowEditFormInitial( $editor, $out ) for instance [18:10:19] aka, someone never bothered cleaning up the paramaters, after renaming the hook implementation from toolbar hook to editforminitial hook [18:11:53] Exception from line 222 of /Users/hartman/Development/wikimedia-git/mediawiki-core/includes/Hooks.php: Detected bug in an extension! Hook WikiEditorHooks::editPageShowEditFormInitial has invalid call signature; Parameter 1 to WikiEditorHooks::editPageShowEditFormInitial() expected to be a reference, value given [18:12:02] hmmmm [18:12:33] so i guess we could make a whitelist of hook calls that will not throw this error, because it is in transition [18:12:43] add those to hooks.php [18:13:23] that also sounds terrible [18:13:58] this is probably why no one has bothered to clean it up [18:14:03] probably :D [19:55:14] quiddity: do you know where that "expand view" button comes from? https://wikimania2014.wikimedia.org/wiki/File:Library_of_Congress_in_front_of_Minerva.JPG [19:56:31] class="mw-mmv-view-expanded" so I assume the Multimediaviewer? marktraceur ping^ [19:56:43] Wuh oh [19:56:48] Oh, yeah, it's MMV [19:56:55] That....may be a bug. Sec. [19:57:08] ...huh [19:57:44] So...we apparently deployed to Commons! [19:57:47] Where are the banners [19:59:54] marktraceur: is it expected behaviour to duplicate the link to original? [20:00:21] Nemo_bis: No, it should open the viewer [20:00:32] We're investigating [20:00:36] at any rate this should be documented at https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer#Link_to_Media_Viewer_on_Commons [20:00:41] It should [20:00:48] I didn't even understand that this was decided [20:00:51] This was slightly unintentional, slipped through the cracks [20:00:57] But I think we're fine with this being the case [20:01:25] yes but it's pointless to ask comments if you don't even reply to them with your decision on the matter [20:02:43] Nemo_bis: I've got Fabrice on it [20:03:28] Nemo_bis: In general we've had a hard time responding to community feedback, sorry about that [20:08:03] thanks [20:08:11] oh, I didn't know 555 was NotAnEmo [20:08:37] not a nemo? [20:09:22] :) [20:10:10] fyi: Pleas remove the "expand view" . thanks :) [20:12:24] uhoh. in progress :) [20:15:50] Steinsplitter: Not really something that can just be dumped as an "FYI", mate [20:15:56] Let's have a discussion about it and see where it goes. [20:16:17] well... if i understand correctly this button will be removed... :D [20:16:39] I don't think so - I think Fabrice (our product manager) has decided that the button is a good thing to have on file pages [20:16:44] Steinsplitter: you'd better comment on that talk https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer#Link_to_Media_Viewer_on_Commons [20:16:59] okay, fyi: i go to revert this now via global css [20:17:12] ... [20:17:17] Steinsplitter: That's super productive, thanks. [20:17:50] Steinsplitter: How about instead you engage with your friends in this channel and we have a discussion instead of you unilaterally deciding that nobody gets to use the new feature? [20:18:14] Why you don't ask the communety? Every time the same... huch [20:18:33] Steinsplitter: That's what https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer#Link_to_Media_Viewer_on_Commons was about. [20:20:09] Steinsplitter: Can you talk about what issues you see with the feature? [20:20:13] marktraceur, should the link show if media viewer is turned off? [20:20:19] without media viewer it seems redundant [20:20:27] Eloquence: Yeah, I think that's a separate issue [20:20:29] right now I'm getting it even as a logged out user [20:20:35] 22.00 < marktraceur> Nemo_bis: No, it should open the viewer [20:20:42] k [20:20:53] Nemo_bis: I think we actually backtracked on that [20:21:01] Nemo_bis: I'm thinking of that link as a hash change but it's not [20:21:17] Eloquence: technically, MediaViewer is not turned off, ever [20:21:26] https://commons.wikimedia.org/wiki/File:Feuchtwangen,_Stadtmauer,_Ringstra%C3%9Fe_59,_001.jpg#mediaviewer/File:Feuchtwangen,%20Stadtmauer,%20Ringstra%C3%9Fe%2059,%20001.jpg should work for anyone [20:21:27] it just does not react on thumbnail clicks [20:21:37] Or "expand view" clicks [20:21:44] tgr, "enabled by the user", how's that :) [20:21:56] In BetaFeatures or by default on pilot wikis [20:22:29] Eloquence: moin, Ist das euer enst dass der Knopf dort bleiben soll? o_O Leute beschwersen sich schon onwiki? [20:22:46] oder verstehe ich was falsch :/ [20:22:48] Eloquence: the point is, there are ways to open it even if you disabled it [20:23:06] tgr, understood. but right now the "Expand view" opens the full JPG view if media viewer is not user-enabled. [20:23:06] since MediaViewer has its own URLs [20:23:28] if that is what happens, that is a bug [20:23:31] Eloquence: kannst du bitte was dazu sagen? [20:23:38] I used #mediaviewer URLs in the first iteration, but stopped in a later patchset [20:23:39] it should open the viewer [20:23:42] Steinsplitter, jetzt mach mal halblang :) [20:24:09] k :) [20:24:53] * marktraceur eyes the opaque German in the channel [20:25:19] tgr: For everyone? [20:25:33] for everyone, sure [20:26:37] Yeah, Fabrice agrees [20:26:43] (back-channelling in real life) [20:26:45] Steinsplitter, the idea is explained in the link people shared with you: https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer#Link_to_Media_Viewer_on_Commons - the expand view would open a larger lightbox view from the File: page. That lightbox view is also intended to become the new default when clicking thumbnails anywhere. [20:28:01] We'll make sure it correctly opens the viewer at least [20:28:16] Right now it looks like "Expand view" doesn't work right if you don't in fact have "Media Viewer" enabled in https://commons.wikimedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures [20:28:35] Yeah [20:28:46] Because it decides that you don't deserve to have your clicks hijacked [20:29:42] Steinsplitter, File: pages are a horrible mess and deserve to die a slow fiery death in the long run. It's a long road, and media viewer is one small step on it. [20:31:11] Eloquence: ok :) [20:31:42] (+1) [20:34:02] (Eloquence: ich und andere dachte jetzt wirklich das ding zeit wie vorhin das reine vollbild an. so schon besser... sorry für wirbel ;) man weis ja nie was ihr einbaut ;)) [20:35:00] Steinsplitter, we aim to keep things interesting :P [20:35:12] good :)