[00:03:20] [[Tech]]; MZMcBride; /* Thanking on Login Wiki */ +reply; https://meta.wikimedia.org/w/index.php?diff=6964278&oldid=6926318&rcid=4802309 [00:05:57] arwiki has some shitty-ass javascript gadgets [00:06:39] throws an error on the main page, nice [00:07:07] ori: who cares? [00:07:15] most wikis do [00:07:18] arwiki users should [00:07:19] they'll probably be angry if you fix that, because they;re used to it not working [00:07:30] (whatever "that" is) [00:07:31] Heh. [00:07:42] I'm reminded of that penis desktop background. [00:07:51] haha [00:07:58] http://thewebsiteisdown.com/ [00:08:35] i would really like to see communities elect to version their javascript in git and to put it through code review [00:09:06] You sound like Jon Robson. [00:09:50] well, jon cares about having a consistent user interface across sites; i don't, really [00:09:57] I doubt mediawiki.org would be perfect, forget the rest [00:10:22] so i'm fine with communities retaining the ability to customize js in whatever way they want, but jesus, get someone to look at it before you slap it on every single page [00:12:00] there are wikis whose sitenotice takes half of my screen [00:12:20] I'd consider that a more urgent problem :P but we still can't /don't want to do anything about it [00:12:38] not to mention gadgets being loaded with proper caching headers & client side caching, via RL [00:13:04] I realize the rationale behind the gadgets feature, but I still hate it [00:13:07] paravoid: i'll settle for "don't throw an exception" [00:15:01] I forget how wonderful this video is. [00:15:35] "Just the letter A." [00:18:59] ori, paravoid: Gadget centralization would help. :-) [00:19:05] But nobody is interested. [00:21:34] i have read all the books and the flesh is still sad [00:21:56] MatmaRex: re: https://gerrit.wikimedia.org/r/#/c/89380/ (Rename Watchlist request parameters for consistency with RC's ones), do you have a deprecation plan for the old parameter names? [00:22:13] I thought someone asked that already. [00:22:14] I don't think we should retain them forever [00:22:14] ori: yes, i plan to keep them forever [00:22:20] oh well [00:22:20] why? [00:22:36] because people are bound to have them bookmarked, and it's cheap to support [00:22:57] ori: https://gerrit.wikimedia.org/r/#/c/89380/11/includes/specials/SpecialWatchlist.php,unified [00:23:00] It's discussed there. [00:23:29] ori: (also thanks for looking at this) [00:24:09] i might mail wikitech about the rewrite [00:24:41] the rewriting of parameter names, or the rewriting of SpecialWatchlist ? [00:25:07] uhm, both i guess, about the rewrite in general and the few things it changes [00:25:21] i'll just cook up a few more patches first, to remove a few more of the todos i inserted [00:28:28] do you intend to write to wikitech-l because there are still things you are not sure about, or because you want to have the patches reviewed and merged? [00:32:34] ori: mostly the latter, i guess [00:32:55] this might be actually useful for some people, too, so maybe someone will appreciate knowing i did this [00:37:17] i want us to have accelerated code review expectations for patches targeting poorly-maintained code for removal of cruft and refactoring [00:38:43] i think we exaggerate the impact of minor breakage and miss entirely how rare it is for someone to come along with the requisite skill and interest [00:43:52] +3 [00:44:00] * Gloria has jokes. [00:45:30] ori: heh [00:46:59] getting javascript errors on wiktionary: Uncaught ReferenceError: sajax_init_object is not defined [00:49:36] nadando: Yeah, we're looking into it. :-) [00:50:23] (sorry, i just froze my computer for a while) [00:50:45] ori: breakage is unpleasant, even if minor, and we should damn well avoid it if only possible [00:53:01] minor breakage provides an occasion for people to participate in the maintenance of the code and develop an understanding of the overall architecture's frailties [00:53:37] it also provides occasion for other people to get mad, if it makes it past beta deployment :P [00:53:45] having reams and reams of poorly-maintained code that no one remembers is a worse fate [00:53:57] If _I_ were dictator... [00:54:13] You're feisty today. I like it. [10:21:20] argh. pagecounts still down? [12:03:57] any problems with parsoid? there are some disk space warnings? [12:04:08] gwicke_away: RoanKattouw_away [12:49:13] addshore: ping [12:49:23] pong [13:25:36] Reedy: Heya. Can I make you add a todo item to deploy restoring some ml namespaces in https://bugzilla.wikimedia.org/show_bug.cgi?id=58074 ? [13:26:18] how? [13:31:29] lawl. [13:34:46] "fix a bug" [13:34:50] "bug fixed" [13:35:09] [[Tech]]; Billinghurst; /* Why can't the abuse filter log be viewed.... */ xwiki vandalism; https://meta.wikimedia.org/w/index.php?diff=6971081&oldid=6964278&rcid=4804758 [13:36:28] Reedy: https://bugzilla.wikimedia.org/show_bug.cgi?id=58074#c17 asks for a cache update (again) [13:36:37] I guess you do that and the bug can be closed :-P [13:40:44] How's that help? [13:40:48] What cache? [13:44:55] We could purge all the pages from text caches... [14:05:37] client/revert-troll.php [15:02:56] aude: Might aswell use in here as it's quieter ;) [15:03:09] ij [15:03:12] grrr [15:03:14] ok [15:03:57] rebuilding l10n cache on tin with that config change in place [15:04:08] ok [15:07:14] reedy@tin:/a/common$ grep Wikibase wmf-config/ExtensionMessages-1.23wmf9.php [15:07:14] reedy@tin:/a/common$ [15:07:19] aude: There's the problem [15:07:20] * aude looks [15:07:45] no wikibase! [15:07:58] So that explains why no magic words [15:07:58] :D [15:08:02] obviously [15:10:06] So currently mergeMessageFileList.php is to blame [15:10:11] ok [15:10:24] maybe including the list of entry points this way doesn't work [15:10:32] does it have to be an array? [15:10:42] * aude see if i can test [15:10:47] It's supposed to work like that [15:10:57] on local dev wiki [15:11:13] we can just var_dump and die to confirm [15:11:20] ok [15:12:02] reedy@tin:/a/common$ /usr/local/bin/mw-update-l10n [15:12:03] Updating ExtensionMessages-1.23wmf8.php...array(0) { [15:12:03] } [15:12:37] oh, hashar had to add $wmfConfigDIr [15:12:40] Dir [15:13:13] $wmgUseWikibaseRepo, $wmgUseWikibaseClient [15:13:18] Both are false [15:13:24] wtf! [15:13:25] So the Wikibase entry point isn't loaded [15:14:30] Oh [15:14:41] ? [15:15:05] is localisation update run on a specific wiki [15:15:08] e.g. aawiki [15:15:09] reedy@tin:/a/common$ mwversionsinuse --extended --withdb [15:15:09] 1.23wmf8=aawikibooks 1.23wmf9=mediawikiwiki [15:15:11] Yup [15:15:18] "specific" [15:15:22] First with that version IIRC [15:15:31] oh [15:15:43] so we need to include entry points outside of use wikibase [15:16:26] We can be pretty lazy about this actually [15:16:45] how? [15:16:56] if ( $wmfRealm === 'production' ) { [15:16:56] $wgExtensionEntryPointListFiles[] = 'extension-list-wikidata'; [15:16:57] } else { [15:16:57] $wgExtensionEntryPointListFiles[] = 'extension-list-wikidata-labs'; [15:16:57] } [15:17:00] yeah [15:17:02] Put that in CommonSettings.php [15:17:03] what i was thinking [15:17:05] yep [15:17:07] It's not going to change anything else [15:17:20] * aude amending and it also needs the config dir [15:17:32] Ah, yeah [15:18:03] Might help ;) [15:21:23] submitting [15:21:28] new patch [15:24:45] great [15:25:31] * Reedy cleans up his live hacks [15:25:58] ok [15:26:08] Running /usr/local/bin/mw-update-l10n again [15:26:13] ok [15:31:16] I was about to say no dice [15:31:22] But remembered sync-common on tin first [15:31:30] looks much better [15:31:55] Updating ExtensionMessages-1.23wmf9.php...array(1) { [15:31:56] [0]=> [15:31:56] string(60) "/a/common/php-1.23wmf9/../wmf-config/extension-list-wikidata" [15:31:56] } [15:31:56] yaay [15:32:13] 'wikibaseclient' => "$IP/extensions/Wikibase/client/WikibaseClient.i18n.php", [15:32:17] Lowercase? heh [15:32:17] :) [15:32:19] yes [15:32:21] apparently [15:32:51] good [15:32:59] let me sync-common onto testwiki to confirm [15:34:15] yay [15:35:11] Reedy: i could be confused but see 0 Jan 6 15:31 ExtensionMessages-1.23wmf9.php [15:35:14] size = 0 [15:39:48] I think I might have upset it [15:39:53] Run it again and it's got a size [15:39:58] ok [15:40:15] looks good [15:40:24] running sync-common on mw1017 again [15:40:27] ok [15:41:06] "The Wikipedia Test Wiki is for developers to test their code without breaking all of Wikimedia and blowing the world up." [15:41:08] * Reedy grins [15:41:14] :) [15:41:33] should be fine and looks good [15:42:59] done [15:43:05] quick poke around on testwiki then [15:43:14] yay [15:43:20] really looks good [15:43:29] It's always something simple [15:43:45] * aude always thought localisation cache ran as aawiki [15:43:56] It might've at somepoint [15:44:00] oh [15:44:06] makes sense now [15:44:54] next thing might be to have the extension list thing for wikibase maintained in our wikidata git repo [15:45:29] not exactly sure how best to do [15:45:48] "$IP/extensions/Wikibase/extension-list-wikidata" [15:46:06] yeah [15:46:16] should work and each deployment branch would use the right thing [15:46:21] or master / beta [15:46:28] yup [15:46:34] cool [15:46:37] one step at a time ;D [15:46:39] yes [15:46:59] next is to get this enabled on beta [16:09:12] Gloria: on? [16:13:05] Reedy: have you seen the svgs gone missing bug? https://bugzilla.wikimedia.org/show_bug.cgi?id=59234 I'm trying to determine what is fixed where and I can't reproduce Gloria's screenshot of recent changes, assuming it is because of rights he has that I don't. THis one: https://bugzilla.wikimedia.org/show_bug.cgi?id=59234#c16 [16:13:51] SNR ;) [16:14:17] ? [16:14:23] signal to noise ratio? :) [16:14:24] Signal to noise ratio [16:14:48] People (*cough* Gloria *cough*) add me to a lot of bugs and changesets [16:14:53] * greg-g nods [16:15:04] Easily fixed/deployed though [16:15:17] yah, just trying to figure out if it'll actually fix what they say it'll fix [16:15:41] because the Beta Cluster, which has the change already (its in master) is still broken when looking at "Templates used in this page" part [16:40:41] Reedy: so, andre and I just commented again on that bug, seems we're not fully fixed yet. Could you take a look at it? [16:40:41] 59234, that is [16:42:24] Reedy, see last two comments on that ticket [16:48:54] oh, I submitted a patch which enabled UploadWizard on Romanian Wikipedia! \o/ [16:49:14] ... with English categories being automatically added to every single picture. [16:49:19] wonderful. [16:50:49] omg [16:51:07] what is need of upload wizard in wikipedia [16:51:20] bug + consensus, I expect. [16:51:39] uploading way must be very complicated and awful in wikipedias [16:52:01] to prevent people from uploading files locally [16:52:23] as 90% of them need to be deleted then [16:53:02] unfree stuff beyond licensing policy or free to be moved to commons... [16:57:39] greg-g: andre__ Might aswell deploy the revision... It's not going to make it worse [16:57:47] uh? UploadWizard is generally considered unsuitable for any wiki other than Commons [16:58:06] Nemo_bis: see, it works nice on rowiki. [16:58:42] https://ro.wikipedia.org/wiki/Categorie:Uploaded_with_UploadWizard [16:59:15] oh, scratch that, the file is from ages ago. [17:01:15] Reedy: yeah, just need to figure out how to really fix it, otherwise, we need to revert/not deploy tomorrow [17:01:49] There's another proposed fix [17:01:52] oh, that [17:01:52] But.. [17:02:15] twkozlowski: Yeah, I think there are still some dumb commons-specific things in UW that we should probably deal with [17:02:19] (just fyi, nik/chad are starting their search updates right now) [17:02:29] yay [17:02:48] marktraceur: there are. The manual, even if translated into Romanian, says 'Wikimedia Commons' [17:03:05] the explanatory page you get when you visit https://ro.wikipedia.org/wiki/Special:UploadWizard [17:03:17] Exactly [17:03:31] Also the {{information}} template is hardcoded, which is annoying [17:03:44] And I bet you had to do a lot of hacks to get licensing right for rowiki. [17:04:11] I doubt there's support for e.g. fair use, you probably had to write that into the config file [17:04:20] greg-g: andre__ That fixed mw.o for me [17:04:26] Why does everything need to be written in a config file :-( [17:04:45] Because UW doesn't support things in a sane way, because there's not currently any way for it to do so [17:05:19] Wait, it works OK if I choose all the defaults :-) [17:05:41] * twkozlowski testing with https://test.wikipedia.org/wiki/File:Puppy_in_grass.jpg [17:08:04] marktraceur: the interface is almost fully translated [17:08:04] Reedy: thanks man, I think that did fix it all. [17:08:45] marktraceur: and they specifically wanted to have it enabled to set up some UploadCampaigns, so they'll live with it :-P [17:08:48] twkozlowski: I believe that, there's been plenty of time to translate [17:08:50] Ahhh. [17:09:04] twkozlowski: This is why YUVIPANDA should have BLOODY made it its own extension [17:09:11] * marktraceur goes to find him and berate him [17:09:56] marktraceur: but hey, with JSON it's nice and dandy [17:10:18] you even have a page history for campaigns! \o/ [17:12:11] twkozlowski: So, one notable thing is, Yuvi and I were already talking about doing a split of campaign code and UW code [17:12:30] AFAIK there's no reason to have them tied so closely [17:12:51] Damn it. You broke the website. :( [17:12:54] So I suspect that would be a better option for you [17:13:06] “PHP fatal error in /usr/local/apache/common-local/php-1.23wmf8/extensions/CirrusSearch/includes/Hooks.php line 59: [17:13:06] Class 'CirrusSearch\BetaFeatures' not found” [17:13:20] I might try to cordon off some time for that; our long-term plan has "campaign infrastructure" in it anyway [17:13:23] something's broken, you aware? getting the same as sjoerddebruin. [17:13:53] that's what wiki? [17:14:02] I’m getting it on the nlwiki [17:14:03] dewiktionary in my case [17:14:08] ^d: ^ [17:14:12] so [17:14:13] <^d> We're on it. [17:14:14] 404s? [17:14:15] k [17:14:18] ick [17:14:25] the search team is on it, by the way, everyone :) [17:14:36] k thnx [17:14:38] hey [17:14:48] do you know there's an error thrown when I visit a wiki? [17:14:52] -,-'' :-P [17:14:56] <^d> Sorry about that folks. Worked locally and on test2wiki. [17:15:07] what do you mean [17:15:10] was it from a deploy [17:15:25] <^d> Yes, we were updating the CirrusSearch code [17:15:34] oh [17:15:35] Withoutaname: there's an update to the search software today https://wikitech.wikimedia.org/wiki/Deployments [17:15:36] that's three minutes of error throwing and you're complaining like babies. [17:15:47] twkozlowski: Welcome to -tech [17:16:07] awesome [17:16:21] maybe you could fix the search in monobook that keeps throwing me forward [17:16:33] <^d> twkozlowski: It's part of our testing system. "Wait for twkozlowski, then fix the errors" :) [17:16:44] omg my life is gone [17:16:51] ^d: Wrong. I didn't complain this time! :-) [17:17:42] <^d> Withoutaname: That's frontend for search. I try not to touch the frontend :) [17:17:52] <^d> But, is there a bug filed? [17:18:03] idk [17:18:12] ill search through village pump's archives [17:18:22] once the servers are back online [17:18:32] someone probably already reported though [17:18:46] marktraceur: but while on it, maybe you can help since git.wm.org is killing my browser [17:19:03] you're keeping translations of stuff on TWN? [17:19:09] for UW [17:19:09] fixed [17:19:11] <^d> Ok, things should be back up now. [17:19:24] mmhmm [17:19:30] twkozlowski: Yes, but they're also in UploadWizard.i18n.php, like most extensions do [17:19:44] Confirmed on fr.wikt, thanks :P [17:19:48] Yeah, that's the culprit, changing browsers... [17:22:08] Looks like they didn't translate all of the messages; Mwe-upwiz-license-none for instance [17:23:05] marktraceur: http://translatewiki.net/w/i.php?title=Special:LanguageStats&x=D&language=ro&suppresscomplete=1 is not on that list [17:23:17] UW is not on that list* [17:25:15] It isn't? [17:25:48] why doesn't that "automatically enable all new beta features" do anything ? [17:26:05] twkozlowski: "expand all" [17:26:10] i have that checked, but i still needed to check the cirrussearch beta on commons seperately [17:26:18] thedj: It enables ones that you haven't seen that are just being released [17:26:27] IIRC there's a bug saying it's confusing [17:26:37] Basically it means "turn on new features for me when they come out" [17:26:54] marktraceur: LOL, that's so complicated [17:26:56] so when they go from beta to production ? [17:27:04] I, fool, clicked on 'MediaWiki extensions' [17:27:10] head desk... [17:27:24] thedj: They'll be enabled by default anyway, AFAIK [17:27:32] We haven't had a test case for that yet [17:27:48] perhaps we should just display:none it then for now ? :D [18:17:24] ^d, greg-g, are the issues from Cirrus fixed? [18:17:46] <^d> Fatals all gone. But we're getting some weird configuration behavior. [18:20:20] :) [18:21:04] Why am I getting edit conflicts with myself? [18:21:18] Nemo_bis: You told me once there was a bug about it? [18:22:03] bz? [18:22:15] bz sucks at "conflict" resolution [18:24:02] no, mw [18:24:11] yes there's a bug, self conflicts [18:25:24] !b 33423 apparently [18:25:25] https://bugzilla.wikimedia.org/33423 [18:25:38] woops, !b 34423 [18:27:08] Nobody - You can work on this! [18:27:12] wee andre__ \o/ [18:29:42] do you have edit conflicts on the bug about edit conflicts? make a tracking bug! [18:30:51] :-) [18:31:33] Yo dawg [18:32:37] wait, we have a bug report about edit conflicts? [18:32:59] ah. in MediaWiki :) [18:34:57] andre__: 10:30 < Nemo_bis> yes there's a bug, self conflicts [18:34:58] i think they mean BZ [18:38:54] mutante: no, I meant self edit conflicts in MediaWiki [18:39:04] sorry for not being precise enough :-) [18:39:20] twkozlowski: oooh, ok, i thought you mean the Bugzilla Mid-Air collision:) [18:39:23] nvm [19:22:17] Oh, data was purged? https://gdash.wikimedia.org/dashboards/jobq/ [19:23:48] hi [19:24:14] Does anyone know exactly how irc.wikimedia.org feeds can be parsed in any language? [19:24:40] by parsing some old system messages [19:25:18] Is the code for generating rc-pmtpa messages available? [19:25:25] Yes [19:25:46] They're very much of a format [19:25:57] I'm sure there's already regexes listed on how to split it up [19:26:43] Reedy: can you explain why the feeds use localized messages instead of an easier-to-parse format? [19:26:53] Is it just for backwards compatibility? [19:27:55] Noting the whole thing is a hack [19:28:44] https://github.com/wikimedia/mediawiki-core/blob/master/includes/rcfeed/IRCColourfulRCFeedFormatter.php [19:28:55] $titleString\0034 $flag\00310\00302$url\003 \0035*\003 \00303$user\003 \0035*\003 $szdiff \00310$comment\003\n [19:28:58] That's your format [19:29:04] https://github.com/wikimedia/mediawiki-core/blob/master/includes/rcfeed/IRCColourfulRCFeedFormatter.php [19:29:31] Thanks [19:31:21] if you look for the bug about the last time they were severely broken (by the new logger in 1.18 or so) you'll find an etherpad with some "specs" if one can call them so [19:31:39] [19:27:52] Noting the whole thing is a hack [19:32:03] worse than that I'd say :) [19:34:07] Have you considered just using the default messages for all logs? [19:34:29] it would make parsing it so much easier [19:35:43] greg-g: I'd like to conditionally put myself in the LD time today; I just fixed a bug in MMV that I'd like to put out, and there's another bug (purportedly) that I'll fix once aarcos tells me what it is [19:36:06] If I can't do both I might wait 'til another LD...wait, are there no others this week? [19:36:37] (put out = backport to wmf9) [19:36:52] "put out" [19:37:24] huh: see the bug I mentioned [19:37:25] Reedy: I don't mean to put you out, but.... [19:38:24] nobody's handled the beta cluster admin requests since 2012. is there anyone who can look at those? [19:38:30] o_0 [19:40:22] hashar: you're a steward on beta, right? [19:40:28] jackmcbarn: link? [19:40:36] http://deployment.wikimedia.beta.wmflabs.org/wiki/Global_requests#Permissions [19:41:29] ah permissions, can't do anything about that [19:46:04] marktraceur: cool, add and I'll review after this meeting [19:46:24] 'kay [19:47:45] hah, uh, lost the LDs, my bad, they're there, just in stealth mode [19:48:09] Fun times [20:11:39] manybubbles, ^d - great blog post [20:11:54] thanks! ^d wrote most of it [20:12:02] <^d> Thanks [20:12:32] this makes me wonder whether it's time for a metrics mtg update .. or maybe next month when it's fully settled? [20:19:17] <^d> We could do that :) [20:25:04] ^d - cool - wanna steal a 5 minute spot on https://meta.wikimedia.org/wiki/Metrics_and_activities_meetings/2014-01-09 before they're all gone? :) [20:26:34] hmm, getting Unexpected non-MediaWiki exception encountered, of type "Exception" on commons? [20:27:16] <^d> Eloquence: Done. [20:27:24] akoopal, that sounds like the issue from last week, does a shift+reload do anything? [20:27:28] correction, only on Commons:Photo_challenge it seems [20:27:48] Eloquence: nope [20:27:55] ^d, awesome, thanks :) [20:28:07] yeah, can repro on that page [20:28:28] https://commons.wikimedia.org/wiki/Commons:Photo_challenge?action=edit works - looks like it's using Translate [20:30:32] looks like something in the tag is breaking things [20:32:36] The source is broken. [20:34:43] Sounds like a dupe [20:39:51] https://commons.wikimedia.org/w/index.php?title=Commons:Photo_challenge&oldid=111901298 [20:39:56] can't even revert this thing. [20:43:24] sob inclusion of pages including other pages [20:47:12] Yeah, it's broken much. [20:49:32] akoopal: at least you can see the page now :-P [20:50:18] twkozlowski: yep :-) [20:54:38] marktraceur: still wanting to do that LD? don't see it, let me know/ping me with a gerrit change or such [20:55:55] greg-g: I think we're still reviewing, so my answer is yes but may change to a no if we can't get it in [20:59:27] marktraceur: k, my answer is still "I'll let you know when I see it" :) [21:00:09] Woot [21:09:33] I have an error on http://commons.wikimedia.org/wiki/Commons:Picture_of_the_Year/2013/Control_Panel [21:09:42] Unexpected non-MediaWiki exception encountered, of type "Exception" [21:09:55] We know. [21:10:38] Hmm, what's up? [21:10:46] We don't know. [21:10:50] :-) [21:10:53] Ah :) [21:12:09] * Reedy kicks twkozlowski [21:12:21] hmmm, that's not good [21:12:42] Translate related likely [21:12:50] when they're all asleep, too [21:12:54] siebrand: ^^ [21:12:58] Reedy: Nikke's saying digging out the exception would be nice [21:13:09] I suspected [21:13:12] Hence why I was doing it [21:13:15] :) [21:13:28] and why are you kicking me :-( [21:13:51] Nikerabbit: hola [21:15:45] twkozlowski: I'm afraid you will need someone who knows how to debug on the cluster [21:15:53]