[03:31:56] Hey guys! Any server issues tonight/recently that may have caused some edits to not be saved in the WT namespace on enwp? [07:57:56] valhallasw: ping [08:14:15] dMaggot: yo! I'm at the tables near the coffee machien [08:14:41] valhallasw: hey there, had a chance to check the updated patch? [08:14:51] dMaggot: not yet [08:15:17] valhallasw: the other question I had was about [08:15:33] It's now on my to-do list :-) I need some more coffee before reviewing stuff [08:15:54] valhallasw: mwparserfromhell and textlib, there was a thread about that, what do you think about it? [08:16:06] dMaggot: using mwparserfromhell +1 [08:17:12] valhallasw: good, what will the approach to the migration be? if there's anything I can move forward during the hackathon I'd be glad to help [08:17:29] valhallasw: I would suggest starting a new branch and doing the replace there, then testing and merging back but [08:17:46] dMaggot: I think we should just add mwpfh and then implement new features using that [08:17:48] valhallasw: the git situation around the corner indicates we better not mess with branches [08:17:57] right [08:19:16] valhallasw: one thing that just crossed my mind is that we can actually work only on the git migration and have mwpfh as a git submodule at externals [08:19:39] so that people can simply git init submodules if they do not have mwpfh installed already [08:30:45] dMaggot: ugh submodules [08:31:03] dMaggot: github also does svn, so we can also import it as svn:external ;-) [08:32:38] valhallasw: but then we move to gerrit and change that [08:39:52] dMaggot: yeah, I know :-) [08:43:39] valhallasw: also, wasn't the request in the ML about replacing textlib instead of just adding mwpfh? [08:43:53] valhallasw: that would require, e.g., rewriting old features in terms of mwfph and blow the textlib folder [08:52:15] dMaggot: don't break old things unless required :-) [08:55:16] valhallasw: that's called upgrading, not breaking (but the policy may also be not upgrading unless required) [09:01:44] dMaggot: sure, but there is no direct benefit to /rewriting/ existing code. [09:03:57] valhallasw: that's debatable, of course [09:04:44] valhallasw: anyhow, it would be good to reply to that thread with whatever is the plan to put mwpfh there [10:29:38] dMaggot: https://integration.wikimedia.org/cover/mediawiki-core/master/php/ [12:19:53] hi, we have some newuser log-entry doubleed: https://de.wikipedia.org/wiki/Spezial:Logbuch/newusers [12:20:09] Reedy: is the above related to https://wikitech.wikimedia.org/w/index.php?title=Server_Admin_Log&diff=71801&oldid=71800 ? [12:21:08] i think so because of: https://gerrit.wikimedia.org/r/#/c/65123/ / https://bugzilla.wikimedia.org/show_bug.cgi?id=42434 [12:22:00] Just some? [12:22:05] hoo ^ [12:22:12] It was definitely broken for other usages [12:22:29] * hoo looks [12:22:31] Reedy: in fact all since 12:07 aut-created [12:22:36] Right [12:22:41] Looks like only those from CA [12:22:56] MediaWiki's fault... [12:23:03] really :P [12:23:04] https://login.wikimedia.org/wiki/Special:Log [12:23:07] Hmm [12:23:12] Looks like it was already fixed at somepoint :| [12:23:50] Weird... it seems like MediaWiki is doing log entries in some cases and in some not [12:23:58] and we can't really know that from CA [12:25:33] Reedy: Well... I was wrong... MediaWiki doesn't log anything (although it's aware of autocreations and the loggin logic is in there) [12:25:52] Do we have a bug yet? [12:25:59] * hoo got a patch [12:26:57] I've not pened one [12:27:03] Well... who cares then [12:27:16] open the old one? https://bugzilla.wikimedia.org/show_bug.cgi?id=42434 [12:27:55] se4598: I don't need a bug to solve a problem [12:28:12] fix it [12:28:14] FIX IT [12:28:18] Reedy: https://gerrit.wikimedia.org/r/65437 [12:28:19] FIXITFIXITFIXITFIXITFIXITFIXIT [12:28:22] DONNEEE [12:30:42] hoo: congrats for rcid [12:31:01] are you going to add it to the 1.22 wiki page? [12:31:07] it would be nice to backport it for 1.21.1 [12:31:21] Wassat? [12:32:47] Nemo_bis: Feel free to backport it... but I'm not sure you find someone to CodeReview [12:32:58] Is it a feature? [12:33:17] Reedy: Yeah... but it solves a minor security flaw as well :P [12:33:32] More of a feature, though,.... which we took about 6 months to merge [12:36:19] Reedy: https://gerrit.wikimedia.org/r/65438 (that doesn't need to be deployed urgently... unless you people plan to flood us with local accounts :D) [12:36:39] afk for some minutes [12:36:46] deploying is a bit of PITA atm [12:50:13] hoo|away: LGTM [12:50:54] hoo|away: yes but it's such a pity to lose it from 1.21 when it's merged the same day of its release :/ [12:51:10] I agree that backport won't happen [12:52:22] Nemo_bis: But 1.22 has been branched of a while ago [12:52:51] 1.21 you mean [12:55:01] Nemo_bis: Oh, sure :P [12:55:04] hoo|away: what's the status of group patrolling then [12:55:25] Nemo_bis: Next years' Hackathon :P [12:55:48] hehe [12:56:03] I don't even see an open patch, did you abandon it? [12:56:04] No... not on my roadmap right now as there are open questions... as others are already working on RecentChanges stuff right now, maybe we've got a better base in a few month [12:56:05] s [12:56:25] Nemo_bis: Well, I had smth. in gerrit once, I think... but it's not open, no [12:56:27] you mean MatmaRex's refactoring? [12:56:49] MatmaRe.x? What did he refactor? [12:57:41] dunno [12:57:47] who's working on RC then? [13:11:20] huh? [13:11:22] jzerebecki: ping [13:11:31] what'cha guys breaking? [13:11:35] Nemo_bis : hoo|away [13:11:53] i'm been doing some RC cleanup recently [13:11:56] i've been* [13:12:07] and i've been trying to redesign the huge ugly form at the top of it [13:12:11] hoo|away: ^ [13:12:16] I was moreover thinking about aude's patrol log patch thing [13:12:35] MatmaRex: I'm more interested in the data structures [13:12:39] jzerebecki: nvm [13:12:52] jzerebecki: added you to a review in gerrit btw, just a file rename [13:12:56] hoo|away: ah, cool, then. :) [13:17:52] dMaggot: is there a reason not to use list=allcategories to find out whether the cat is hidden or not? [13:20:18] slthough that module is somewhat misbehaving... [13:36:06] dMaggot: hiddencat is set in page_props, but the api doesn't return it... [14:03:38] valhallasw: I see, using acprop=hidden and such [14:06:10] valhallasw: are the categories guaranteed to be returned in lexicographical order? [14:12:50] dMaggot: http://en.wikipedia.org/w/api.php?action=query&generator=allcategories&gacfrom=1911%20Britannica%20articles%20needing%20updates%20from%20April%202010&gacto=1911%20Britannica%20articles%20needing%20updates%20from%20April%202010&prop=info&gacprop=hidden|size [14:12:56] was what I used [14:12:56] but it doesn't actually work [14:14:09] valhallasw: I used [14:14:51] valhallasw: just ?action=queyr&list=allcategories&acprefix=&acprop=hidden [14:15:15] valhallasw: if it returns with a property hidden="" it is hidden, otherwise it won't have the property [14:15:25] ooooh [14:15:29] list instead of generator [14:15:54] http://en.wikipedia.org/w/api.php?action=query&list=allcategories&acfrom=1911%20Britannica%20articles%20needing%20updates%20from%20April%202010&acto=1911%20Britannica%20articles%20needing%20updates%20from%20April%202010&prop=info&acprop=hidden|size < better! [14:16:02] (I'm using acfrom, acto instead) [14:16:10] valhallasw: the thing is, since acprefix is just the prefix, you may get a whole bunch (meh, not that many) of categories but you should be good if the very first one is always the one you want [14:23:07] gwicke: i saw you brought your bike! [15:09:12] Reedy: Why is deploying a PITA right now? [15:09:22] Can't update extension on tin [15:09:25] need to do it elsewhere [15:09:30] copy to tin [15:09:31] then deploy [15:09:36] Hmmmmmmm. Gay. [15:09:45] and update the extensions/FOOBAR/.git file [15:09:57] Is git submodule broken on tin or something? [15:10:17] It gets 403s trying to update most extensions [15:10:26] Well, I hope you filed a bug! [15:11:11] I did on tuesday [15:11:11] https://bugzilla.wikimedia.org/show_bug.cgi?id=48674 [15:20:37] Reedy: Thx. [15:20:38] <3 [15:33:02] how often may I poll a category? is once per minute OK? [15:33:52] poll a category for what? [15:34:09] for pages [15:34:15] "Have you now or ever been a member of the Communist Party?" [15:34:19] category members? [15:34:26] why do you need once per minute? [15:34:28] How big is the category? [15:34:45] Most category membership is really cheap. [15:34:53] Category:Candidates_for_speedy_deletion_as_nonsense_pages [15:35:01] Poll as often as you'd like. [15:35:07] That category is small. :-) [15:35:09] polls are evil [15:35:10] Reedy: I'm running a submodule update --init in tin:/home/catrope right now and it seems to be pulling them in just fine [15:35:16] Be sure to use the MediaWiki API. [15:35:28] let's see [15:35:36] ugh [15:35:43] I'm starting to get tired of ssh dieing [15:35:54] screen [15:36:00] Or set a higher timeout. [15:36:47] dying * [15:37:35] Hmm [15:37:57] Moving extensions to extensions2 and doing it gain.. [15:38:01] Everything bar [15:38:01] Submodule 'content/easyRdf' (https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Wikibase.git) registered for path 'contrib/easyRdf' [15:38:01] fatal: Could not switch to '/home/wikipedia/common/php-1.22wmf4/extensions/Wikibase/contrib': No such file or directory [15:38:01] Unable to fetch in submodule path 'contrib/easyRdf' [15:39:18] What command are you running? [15:39:29] Isn't there a --recursive flag or something for git submodule? [15:39:31] git submodule update --init --recursive [15:39:35] Yes [15:39:35] Heh. [15:39:52] God hates you. resolved/fixed [15:40:09] reedy@tin:/a/common/php-1.22wmf4$ git pull [15:40:09] Merge made by the 'recursive' strategy. [15:40:09] extensions/CentralAuth | 2 +- [15:40:09] 1 file changed, 1 insertion(+), 1 deletion(-) [15:40:10] reedy@tin:/a/common/php-1.22wmf4$ git submodule update extensions/CentralAuth/ [15:40:12] error: The requested URL returned error: 403 while accessing https://gerrit.wikimedia.org/r/p/mediawiki/extensions/CentralAuth.git/info/refs [15:40:15] fatal: HTTP request failed [15:40:17] Unable to fetch in submodule path 'extensions/CentralAuth' [15:40:19] Just comes back again [15:42:16] Uhh [15:42:23] RoanKattouw: I can't do it in my /home either [15:42:27] reedy@tin:~$ git clone https://gerrit.wikimedia.org/r/p/mediawiki/core.git [15:42:27] Cloning into 'core'... [15:42:27] error: The requested URL returned error: 403 while accessing https://gerrit.wikimedia.org/r/p/mediawiki/core.git/info/refs [15:42:27] fatal: HTTP request failed [15:42:48] fine via SSH [15:43:05] Chad did suggest just changing all extensions to using SSH [15:43:08] WFM [15:43:16] See /home/catrope/core [15:43:43] I wonder why it fails as you but not as me [15:44:19] Other people had issues earlier this week too [15:44:22] So it's not me specific [15:45:57] http://p.defau.lt/?KAhkoPZcZGkAuKI4TauvZQ [15:47:38] So that worked for me [15:47:57] and .gitmodules shows it was fetched over https [15:51:04] Can grab https://gerrit.wikimedia.org/r/static/wikimedia-codereview-logo.png via wget [16:07:10] Reedy: I'm sure you follow my talk page closely and already saw this... [16:07:51] https://en.wikipedia.org/w/index.php?title=User_talk:MZMcBride&diff=556681216&oldid=556680509&diffonly=1 [16:08:06] I think we'll end up with a second generation script. [16:08:06] With a cron job. [16:08:24] Or maybe the same generation script with a flag. [16:08:25] We'll see! [16:10:37] I really don't think it's necessary [16:52:48] I agree it's not [16:56:21] what is not? :) [17:07:56] Base-w: https://meta.wikimedia.org/wiki/Talk:XFF_project#Process_and_speed_of_updates [20:32:32] Reedy: Surely a page on Meta-Wiki is more efficient.