[00:00:40] Reedy: has anything been changed overnight that would have an impact on English Wikisource? I am seeing my old toolbar set lose its ability to have additional buttons [00:01:41] Not that I know of [00:01:41] JS errors? [00:01:43] okay, thx [00:02:19] going to look, but I have changed nothig but wake from hibernation [00:06:42] Reedy: no errors, though string of warnings from ttps://bits.wikimedia.org/en.wikisource.org/load.php [00:09:49] "lots of anonymous function does not always return a value" [00:12:13] so so so many warning for trying to load one page [00:12:39] gn8 folks [00:14:34] * sDrewth sighs and walks away from it [02:45:21] ori-l or kaldari, can you merge https://gerrit.wikimedia.org/r/#/c/61534/ when you have a chance? [02:45:40] looking [02:45:41] It's an EventLogging config change to GettingStarted that should go out with the deploy tomorrow. [02:46:27] merged [02:47:11] kaldari, thanks [08:19:42] MatmaRex: on bug 39996 , can you please also copy the question to talk page? it's easier to see what's pending [08:23:56] good point, doing that [08:25:30] done https://meta.wikimedia.org/wiki/Talk:Single_User_Login_finalisation_announcement#Buggy_unattached_accounts_.28bug_39996.29 [08:33:06] thanks [08:54:15] huh, why is there still default content on https://pl.wikipedia.org/wiki/MediaWiki:Nostalgia.css ? [08:56:34] MatmaRex: maybe the message Nostalgia.css is defined by the nostalgia skin? [08:57:36] but there is no nostalgia skin anymore [08:57:40] MatmaRex: there is indeed a message in the language files [08:57:46] at least with wmf/1.22wmf2 branch :-] [08:57:48] and afaik the extension one is not enabled on pl.wiki [08:57:53] I guess the skin removal has not been deployed yet [08:58:03] it is deployed perfectly well [08:58:07] all other messages are blank [08:58:11] like https://pl.wikipedia.org/wiki/MediaWiki:Simple.css [08:58:25] so that's either something silly, or a caching issue [08:58:32] and i'd like to know which [09:00:05] hmmm. [09:02:48] hashar: where is that message? i can't seemto find it [09:03:17] it's not in MessagesPl nor in MessagesEn [09:06:22] MatmaRex: in the wmf branch? [09:06:50] hashar: 64251f27731389ac2d083e13f7345fa012764c31 ? [09:07:35] MatmaRex: look at Special:Version to get the wmf branch [09:07:58] then check it out git checkout gerrit/wmf/1.22wmf2 [09:08:01] and git grep :-] [09:08:08] ah, there's a commit hash there, too [09:08:29] 1.22wmf2 (197a13c) [09:08:54] but gerrit/wmf/1.22wmf2 is 64251f2 [09:09:15] most probably because we have some live hacks deployed [09:09:17] explain. D: [09:09:21] let me check [09:10:19] yeah we have two live hacks [09:10:47] but apart from that we are running dae018b "Cherry-picked maintenance script for Translate" [09:12:53] and there is no mention of 'nostalgia.css' in the MessagesPl file. [09:13:39] MatmaRex: yeah my wmf branch was not up to date [09:13:46] seems the change has been merged / deployed recently [09:14:52] huh, it's showing in English now. so that's an improvement, i guess [09:15:09] but there is no nostalgia.css in MessagesEn, either. [09:15:26] (same for .js) [09:19:17] MatmaRex: I guess the message cache still has the message [09:19:21] might not have been regenerated [09:19:26] or it is stalled somehow [09:19:58] hm. [09:37:56] what has changed that my own editbuttons abovve the edit fields on several wiki's are largely missing [09:39:13] ? [09:39:25] edit fields? [09:42:01] when you press edit on a page you get a white area where you can type texts [09:44:01] I notice this on several projects [09:49:19] Romaine: so what are the editbuttons, the buttons of the toolbar? [09:49:36] yes [09:49:50] not the beta ones, but the older ones [09:49:59] might be related to the fix for blank pages bug, i guess. [09:50:04] ah, the old-old ones? [09:50:12] the 2006 ones? [09:50:22] yesterday they still worked, example: [09:50:22] mwCustomEditButtons[mwCustomEditButtons.length] = { [09:50:23] "imageId": "mw-xyxA", [09:50:23] "imageFile": "http://upload.wikimedia.org/wikipedia/commons/e/e9/Button_headline2.png", [09:50:23] "speedTip": "Tussenkopje (tweede niveau)", [09:50:23] "tagOpen": "=== ", [09:50:23] "tagClose": " ===", [09:50:23] "sampleText": "Kop van de tweede niveau"} [09:50:28] are there old not-old-old ones? [09:50:38] the new ones are already old :/ [09:51:13] https://bugzilla.wikimedia.org/show_bug.cgi?id=47457 [09:51:13] are there newer ones? [09:51:19] none i know of, no [09:51:24] there is VisualEditor ;) [09:51:27] indeed, my custom toolbar is broken [09:51:38] ah, yes, the thing which overlaps all my monobook skin [09:51:52] (VisualEditor is still worse) [09:52:12] I use vector, there are is the edit toolbar broken [09:52:30] Romaine: let me try this and tets out some things [09:52:35] what code should I use instead of the example I used above? [09:53:22] I don't think it changed [09:55:11] Romaine: which wiki, for example? can you link to your user JS? [09:55:34] nl-wiki, nl-wiktionary [09:55:39] https://nl.wikipedia.org/wiki/Gebruiker:Romaine/vector.js [09:55:45] same on it.quote, meta [09:56:06] nl-voyage, other voyages [09:56:15] wow, that's a lot of buttons. [09:56:26] https://meta.wikimedia.org/wiki/User:Nemo_bis/monobook.js [09:56:31] :) [09:56:40] Romaine: for the record, the slightly newer way to add buttons is to use the mw.toolbar.addButton() function [09:56:51] but i'm investigating why would the old one stop working [09:57:19] I use them a lot [09:58:48] first button for wikieditor in https://it.wikiquote.org/wiki/Utente:Nemo_bis/monobook.js is broken as well [09:59:06] but I gave up with wikieditor years ago, so I don't know if it's a recent thing [09:59:11] it seems every mwCustomEditButtons is broken [09:59:33] Romaine: can you try something for me? replace those with mw.toolbar.addButton() calls [09:59:37] e.g.: [10:00:21] replace every: [10:00:22] mwCustomEditButtons[mwCustomEditButtons.length] = { ... } [10:00:24] with: [10:00:49] mw.toolbar.addButton({ ... }) [10:01:00] (note, parentheses *and* braces) [10:01:05] dubble brackets? [10:01:07] or just replace a few and tell me if it fixes it [10:01:08] double [10:01:17] yes, ({ and }) [10:02:41] that seems to work [10:03:29] should I see this as a permanent fix or a temporary? [10:03:51] alright. my guess right now is that the fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=47457 caused your code defining those buttons to be loaded after the code that adds them loads... [10:04:08] well, this is the right way to od it now, but the old should keep working [10:04:24] that probably depends on how many people have this issue [10:04:39] many many users [10:05:05] if it's just a few around the world, killing off that legacy compatibility would be nice, and the user js fix is simple [10:05:41] dammit, why can;t things just work :P [10:06:34] shouldn't we have a tool/system function/etc that changes these kind of things automatically? [10:07:44] i think Krinkle was working on one some time ago [10:07:49] not sure what came out of it [10:08:12] but there are also third-party users and it would be nice not to break things for them anyway [10:08:18] if it's avoidable [10:10:29] I am technical ambassador for the Dutch wikis, and there are two things that people find very annoying: broken things that are't solved automatically and too less explanation about what new developments there are [10:10:43] the second I take care of, the first one I can't of course... [10:11:08] well, i'm basically the ambassador for Polish wikis ;) i just happen to code some things myself as well [10:12:02] Romaine: loading things in the correct order, while also loading them reasonably fast, is a hard problem, because javascript and web development in general sucks [10:12:08] that's the sad state of things :/ [10:17:05] I think I say something about it on the tech ambassador list [10:21:07] Romaine: i reopened the bug [10:21:09] https://bugzilla.wikimedia.org/show_bug.cgi?id=47457 [10:21:25] Romaine: it seems that there is a reasonably simple solution [10:21:30] which would be kind of weird [10:22:42] but let's have hope [10:23:52] I think I write an announcement for the Dutch wikis [10:25:07] Romaine: let's wait for Krinkle and anomie to show up [10:25:23] Romaine: this was caused by a fix for a comparatively more severe bug [10:25:33] (where pages would just go blank insteda of loading) [10:27:12] ok [10:33:05] MatmaRex: I found another way of edit buttons, don't work either, what would you advice? [10:33:10] https://nl.wiktionary.org/wiki/Gebruiker:Romaine/sjabloonbeta.js [10:34:45] seems working again [10:36:17] Romaine: kCustomMainInsertButton is not a built-in function [10:36:44] it has to be defined on nlwikt [10:40:54] ok [10:57:12] * Romaine is using the unique opportunity of the abdication in the Netherlands to search for new / unknown words and I use for that prupose the edittoolbar [12:36:55] Hello everyone, can anyone help me about a syntax problem ? [12:37:43] I was looking at http://en.wikipedia.org/wiki/Help:Table#Conditional_table_row and tried to apply this to change conditionnally the background color of a certain cell of my table. [12:38:09] So I tried to escape the pipe as follows : [12:38:09] {{#if:{{{1|}}}|{{!}} align="center" style="background:#999999"{{!}}{{{1}}}|}} [12:39:04] (my template is specified like this : {{mymodel|value}} and I want the cell to be grey if the value is specified) [12:39:21] Obviously it doesn't work... does anyone have an idea ? [12:44:05] anyone ? [12:44:11] yeah you might be better off asking in #mediawiki [12:44:28] kk thanks [13:11:46] Romaine: https://bugzilla.wikimedia.org/show_bug.cgi?id=47872 has been opened about that particular issue [13:11:59] Romaine: turns out that as i expected this apparnetly isn't so easy, eh [13:12:53] my question remains, was it a permanent or temporarily fix? [13:13:04] Romaine: it would be best for everyone to migrate to mw.toolbar.addButton(), the old interface has been deprecated for years already [13:13:09] Romaine: i don't know [13:13:37] Romaine: you can just use the search to find people using that [13:13:51] https://nl.wikipedia.org/w/index.php?title=Speciaal:Zoeken&search=mwCustomEditButtons&fulltext=Zoeken&profile=all&redirs=1 [13:13:55] 34 results, not that bad [14:19:47] Romaine: MatmaRex: kCustomMainInsertButton is something I created, it is a gadget of mine. [14:20:05] if you don't have that gadget loaded in your user script it doesn't work. [14:20:14] this has always been that way [14:20:33] Romaine: MatmaRex: I no longer maintain my user gadget 'kCustomMainInsertButton'. [14:20:55] Romaine: Is that for WikiEditor or for the classic toolbar? [14:21:05] (the thing you're working on) [14:21:18] I think everything works now again [14:21:26] Romaine: ? nothing changed [14:21:26] heh, nice backlog Krinkle. :) [14:21:51] Romaine: the issue is timing-dependent, unfortunately, it's going to work and fail randomly [14:21:58] (unless i'm missing something again) [14:22:06] Romaine: I agree with MatmaRex, migrate to mw.toolbar.addButton if you're adding buttons to the old Monobook toolbar. That API is relatively new and will be maintained/supported. [14:22:10] Romaine: or unless you fixed your user JS, which woukd be good to do anyway [14:22:33] MatmaRex: I think Romaine might be using WikiEditor, so mw.toolbar.addButton isn't relevant in that case [14:22:47] I created kCustomMainInsertButton because WikiEditor's API was a monster [14:22:55] kCustomMainInsertButton is an abstraction that makes it more like the legacy API [14:23:08] nah, i'm not talking about kCustomMainInsertButton, just aobut the regular stuff [14:23:13] sure [14:23:32] (btw, we have two or three different wrappers over adding buttons to both toolbars on pl.wiki...) [14:23:51] Romaine: (dutch) Bovenaan https://nl.wiktionary.org/wiki/Gebruiker:Romaine/sjabloonbeta.js zie ik een code die is uitgeschakeld. [14:23:53] "importScript('User:Romaine/insertVectorButtons.js');" [14:23:58] zonder dat werkt het natuurlijk niet [14:24:07] Of laadt je dat ergens anders? [15:16:10] AaronSchulz: Hi, could you comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=46934 please when you have some time? [15:20:22] AaronSchulz: specifically, if there's an upgrade path (ie: disable all jobs or something pre-upgrade so they aren't lost). cc andre__ ;) [15:20:44] how do I query gerrit to see what changes it has made in past 15-36 hours to see how it changed old toolbars at English Wikisource [15:20:47] ? [15:21:50] changes that have gone taken effect in that period [15:22:19] looking at https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap , the last regular wikisource update was 13 days ago [15:22:44] andre__: something changed in last 15-36 hours [15:22:59] when I went to bed my old toolbar was able to be customised [15:23:04] when i got up, NADA [15:23:23] and it is not only me [15:23:52] sDrewth: is there a village pump/etc thread on this? [15:24:23] sDrewth: There's only one person that synced any code in the period where you see problems [15:24:25] I did start one, but more seeing if others had issues [15:24:29] sDrewth, might be https://bugzilla.wikimedia.org/show_bug.cgi?id=47457#c64 ? [15:24:30] He's not here now [15:24:44] looking [15:24:49] Looks very plausible [15:24:56] I hope that https://bugzilla.wikimedia.org/show_bug.cgi?id=47872 would fix that [15:25:19] (somebody correct me if I'm wrong) [15:27:27] yep, that will be it [15:27:29] fffff cxn [15:28:33] sDrewthedoff, yeah, regression (but due to fixing a severe issue), hope to get that solved by 47872 [15:28:58] time frame? [15:29:25] m? h? d? w? [15:29:28] "asap". :) Honestly, I don't know yet. But hopefully in the next days. [15:29:49] okay, I will let community know [15:30:08] thx for the guidance [15:30:19] np [15:30:30] and thanks for trying to find out here, and forwarding the info :) [15:31:28] causing big problems I save for csteipp; and being annoying shit is saved for Philippe :-) [15:32:10] heh [15:42:37] Reedy, test2wiki not responding? [17:03:03] greg-g: howdy [17:03:39] kaldari: uh, hi, was that a shout or something? :) [17:04:27] greg-g: we're going to have a fairly long and complicated deployment today - 4 extensions, lots of config changes, a maintenance script... [17:04:33] weee [17:05:13] greg-g: just hoping you can keep an eye on things and make sure no one else is thinking it's a good time to sneak in a little config-change or something [17:05:19] kaldari: worried about running into mobile's window? [17:05:22] ah, right, will do [17:05:26] possibly [17:05:51] kaldari: if it's looking like you'll go long, let me know when you know, so I can let them know. We all want to know. Knowing is half the battle [17:05:52] but if everything goes according to plan we should be able to finish in the window [17:06:04] :) [17:06:11] cool, let's plan for the things going to plan option ;) [18:16:59] kaldari: looking good! [18:17:09] sweet jesus [18:17:26] correct getting started email and notif, though the flyout is fucked and there are some style issues with the all view [18:17:36] I assume that's because of testwiki badness [18:21:06] StevenW: where'd u go? [18:24:07] Yeah looks good now with JS on kaldari [18:24:16] yeehaw! [18:24:29] Alright, go go go go go [18:50:59] about to scap [18:51:07] hi kaldari [18:51:12] howdy [18:51:24] Echo deployment to en.wiki in 1 hour [18:52:38] hi Reedy [19:09:48] Good afternoon. Is there anyone here who can help me further customize my vector.js file? [19:10:37] Dragonfly6-7: the #mediawiki channel will probably be superior at that [19:11:59] Dragonfly6-7: [[Tech]] is silent? [19:16:48] Nemo_bis - I posted on Tech a few days ago and got no answer [19:17:39] * Nemo_bis threatens Susan  [19:18:00] * sumanah prefers a threat-free environment [19:18:39] sumanah: but Susan doesn't [19:19:07] Nemo_bis: Then please threaten them privately. :) [19:20:19] is Susan indeterminately gendered? :P [19:21:20] Yes, actually. [19:23:03] {{GENDER:Susan|no|no|yes}} hmm [19:44:27] greg-g: Looks like we're going to go a bit over 1:00pm. Still waiting on a scap to finish. After that we still have to do a few config changes. [20:05:05] It is now just a few hours till the Wikimania talk submission deadline just FYI [20:07:43] greg-g: we're done with our deployment [20:07:55] MatmaRex_: ^^ [20:09:10] greg-g, you mean MaxSem? ;) [20:09:17] erm, indeed ;) [20:09:23] MatmaRex_: my bad :) [20:46:39] MatmaRex_: do you have a link to the CSS that moves the section links back to the right? [20:46:49] i cant find it on mw.o [20:47:03] legoktm: it's on the meta page [20:47:22] ah, thanks [20:58:11] can we do anything about wikimapia not opening on the coordinates fed into geohack, like all the other maps? It opens instead at the reader's location. [20:59:09] mareklug: Wikimapia is no Wikimedia project and isn't included anywhere directly (at least it shouldn't) [20:59:48] for example, I expect to be be here, at wikimapia: http://wikimapia.org/#lang=en&lat=34.960281&lon=69.276953&z=16&m=b after I click on: http://www.wikimapia.org/#lat=34.960278&lon=69.276944&z=14&m=b [21:00:09] mareklug: wikimedia doesn't run wikimapia - so we can't do anything about that [21:00:20] hoo take a look at the choices offered whenever you click on any coordinates in mainspace [21:00:57] so basically, we generate the correct URL? are you sure? [21:01:04] ewww, that's a toolserver thing [21:01:10] cuz if we don't, it would default to where the reader is [21:01:12] so that is also not run by the wikimedia foundation [21:01:54] sooner or later you will be running it per Labs. :) Should I wait with this until you do? [21:02:10] the indefinite wait [21:02:21] :) [21:02:42] or is anyone remotely interested in debugging this to help the mainspace user, you know, the "customer" [21:06:14] mareklug: who runs geohack? [21:07:44] mareklug: I don't think I'm seeing the issue. when I click on the "map" wikimapia link on the geohack site it shows me what I expect it to show me (ie: the location of something in the world, not where I am) [21:08:23] mareklug: I'm also running a recent browser (Fx 20.0) which means it would ask me if it wanted my coordinates, but it didn't [21:08:55] mareklug: do you have a test case that repdroduces with a clean browser profile/etc? [21:11:50] greg-g go to this url http://toolserver.org/~geohack/geohack.php?pagename=National_Airlines_Flight_102¶ms=34_57_37_N_069_16_37_E_type:airport_region:AF [21:12:03] choose wikimapia and click the sattleite link, please. [21:13:24] mareklug: I see what I see in Bing aerial view [21:13:38] which is? [21:13:38] and google maps [21:13:53] it might be a Safari issue then [21:13:54] the end of the runway [21:14:16] let me do this in Chrome [21:14:46] go ahead, if you can reliably do it in some browser, please report a bug [21:14:53] I'm going to get back to my tasklist for now ;) [21:15:02] yup. chrome delivers me to the crash site. Safari does not. [21:15:57] greg-g thank you greg-g [21:16:21] stupid safari ;) [21:16:35] but such a lovely touch interface :) [21:16:50] :P [21:17:29] it's probably syntax of the search that needs tweaking a la IE [21:17:38] i mean, of the url [21:30:30] greg-g: Any extra deployment time available for today (for some small Echo follow-up fixes)? [21:30:54] kaldari: 3-4 is open [21:31:06] I'll take it if it's available [21:31:08] I assume MaxSem is done [21:31:24] greg-g, whoa! [21:31:50] howdy Max, what's your frequency? [21:31:54] ? that I pinged the right person this time? [21:33:10] kaldari, frequency? [21:36:33] sorry, I lapse into trucker mode sometimes [21:37:05] are you guys done with Mobile deployment window? [21:37:19] no hurry :0 [21:38:24] kaldari++ #truckermode [21:40:00] kaldari, I see a lot of Fatal error: Call to a member function format() on a non-object in /usr/local/apache/common-local/php-1.22wmf2/languages/Language.php on line 1307 [21:40:16] looking [21:40:20] was it introduced with your scap? [21:40:25] Reedy, ^^^ [21:40:35] (I haven't touched wmf2 yet [21:41:04] I scapped a couple hours ago [21:41:23] was there anything suspicious in fatalmonitor before? [21:42:05] doesn't look like anything related to the Echo deployment [21:45:20] although Echo does call Language::getHumanTimestamp a whole lot and that function is relatively new [21:45:36] and not widely used otherwise [21:58:59] siebrand: ^ (in case it is of interest to you) [22:01:18] kaldari, I'm done [22:01:36] thanks [22:04:42] gn8 folks [22:16:01] Hi [22:25:16] Request: POST http://www.mediawiki.org/w/index.php?title=Special:Nuke&action=delete, from 208.80.154.133 via cp1002.eqiad.wmnet (squid/2.7.STABLE9) to 10.64.0.130 (10.64.0.130) [22:25:16] Error: ERR_READ_TIMEOUT, errno [No Error] at Tue, 30 Apr 2013 22:24:26 GMT [22:28:35] legoktm: That can happen... nothing to worry about [22:28:46] Yeah, I just did it again [22:37:54] greg-g & kaldari, I need to push some MF fixes [22:38:11] go ahead, I'll wait [22:38:36] ok, just fyi, pgehres has a Lightning deploy planned [22:39:25] my stuff will be quick [22:48:50] my fixes aren't materializing yet:( [22:50:13] I just need to merge and sync InitialiseSettings [22:51:36] pgehres, go ahead [22:51:44] MaxSem: k [22:52:55] pgehres: you might see my config changes as well, since I already merged them [22:53:08] kaldari: are they okay to go out? [22:53:09] feel free to push them out with yours [22:53:13] k [22:53:27] yeah, just sync initializesettings first [22:53:45] that's all i am doing [22:54:23] and CommonSettings if you feel like it [22:55:19] otherwise, I'll take care of the rest [22:55:43] and when you're done, I'll revert my stuff [22:56:50] kaldari: MaxSem: I'm done. All yours [22:57:03] All I did was Initialise [22:57:11] MaxSem: You need to do anything else? [22:57:20] Nemo_bis: Dragonfly6-7 is looking for someone to write him a skin. [22:57:27] Nemo_bis: And he's already received plenty of help. [22:57:33] MaxSem: ah, yeah, go ahead and revert [22:57:52] thanks [22:57:54] Nemo_bis: Plus he can of course do it himself. We know this because he's able to edit the wiki. [22:57:59] :D [22:58:09] CSS requires a lot of guess and check. [22:58:10] Or used to. [22:58:13] Now you can inspect elements. [22:58:16] So it's trivial. [22:58:25] Dragonfly6-7: Watch a video about the browser concept "Inspect element". [22:58:31] I'm sure there's a YouTube video for this. [22:58:38] You can futz with this shit all day. [22:58:48] It's amazing. [23:00:56] FYI: Most of the existing skins are based on the Monobook SkinTemplate (even Vector), but you can define your own SkinTemplate and actually change the underlying HTML DOM for your particular skin (if you want to do something more radical than changing the CSS). [23:02:54] can't deploy, Gerrit is down [23:04:15] MaxSem: Gerrit is up for me [23:04:29] showed me an exception [23:04:36] now pretends to live [23:22:01] MaxSem: lemme know whenever you're done. [23:22:10] kaldari, I'm done [23:22:14] thnaks :) [23:25:30] Hello. [23:25:36] https://gerrit.wikimedia.org/r/#/c/61168/ isn't loading for me. [23:25:49] > Working ... [23:25:54] gerrit seems to be having some problems [23:26:00] Fucking Gerrit. [23:26:06] I think it's in +zombie mode [23:26:07] All right. [23:26:22] I guess I'll leave Gerrit e-mail for later. [23:26:23] Susan: wfm, try refresh [23:26:37] It loads everything for you? [23:26:46] Oh, there it goes. [23:27:05] It's painfully slow. [23:48:20] why does the feedback link on https://en.wikipedia.org/wiki/Special:Notifications go to surveymonkey? [23:50:46] https://gerrit.wikimedia.org/r/#/c/58444/ [23:50:50] kaldari, ^ [23:52:22] thanks for finding that Krenair