[00:19:11] <Betacommand>	 does anyone know if Ryan Vesey is on IRC ?
[00:19:26] <Jasper_Deng_busy>	 not that I know of
[00:19:34] <Betacommand>	 thanks
[00:39:10] <logmsgbot>	 !log asher synchronized wmf-config/db-eqiad.php  'adding db1051 at a low warmup weight'
[00:39:22] <morebots>	 Logged the message, Master
[01:37:32] <DaBPunkt>	 gn8 folks
[02:21:09] <logmsgbot>	 !log LocalisationUpdate completed (1.21wmf12) at Tue Mar 26 02:21:08 UTC 2013
[02:21:21] <morebots>	 Logged the message, Master
[02:45:52] <logmsgbot>	 !log LocalisationUpdate completed (1.21wmf11) at Tue Mar 26 02:45:52 UTC 2013
[02:46:04] <morebots>	 Logged the message, Master
[04:16:11] <logmsgbot>	 !log tstarling synchronized wmf-config/CommonSettings.php 
[04:16:23] <morebots>	 Logged the message, Master
[08:45:57] <logmsgbot>	 !log nikerabbit synchronized php-1.21wmf12/extensions/UniversalLanguageSelector 
[08:46:09] <morebots>	 Logged the message, Master
[08:47:12] <logmsgbot>	 !log nikerabbit synchronized php-1.21wmf12/extensions/Translate 
[08:47:24] <morebots>	 Logged the message, Master
[10:23:29] <logmsgbot>	 !log nikerabbit synchronized php-1.21wmf12/extensions/UniversalLanguageSelector/UniversalLanguageSelector.php  'Testing fix for wikidata'
[10:23:41] <morebots>	 Logged the message, Master
[11:00:11] <Nemo_bis>	 Does someone know if there's the way to change, in gerrit, the "tab" selected by default?
[11:01:07] <Nemo_bis>	 "My" gives this endless line "Changes Drafts Draft Comments Watched Changes Starred Changes" that pushes the search bar outside the screen
[11:17:12] <hashar>	 Nemo_bis: that does not play well on a small screen indeed
[11:18:09] <hashar>	 Nemo_bis: it was even worse before https://bugzilla.wikimedia.org/show_bug.cgi?id=44902#c0  :-D
[11:20:02] <Nemo_bis>	 hashar: yes, I remember that
[11:20:45] <Nemo_bis>	 hashar: another option would be hiding the logo and its container (AdBlock leaves a blank space), would greasemonkey help with this?
[11:21:00] <Nemo_bis>	 hashar: and thanks for bug 44902, I appreciated it :)
[11:21:08] <hashar>	 Nemo_bis: we could use responsive CSS to hide the logo whenever the screen width is below some value
[11:26:03] <Nemo_bis>	 hashar: yes but I'd like a solution for my problem in the near future
[11:26:20] <Nemo_bis>	 or preferably today if I have time to waste on greasemonkey or whatever
[11:26:39] <hashar>	 that is the workaround :-D
[11:27:11] <hashar>	 the CSS file is in operations/puppet.git :::    files/gerrit/skin/GerritSite.css
[11:27:47] <Nemo_bis>	 hmm maybe https://addons.mozilla.org/en-us/firefox/addon/editcss/ then
[11:27:53] <hashar>	 then you do something like:
[11:28:06] <hashar>	 @media screen and (max-width: 480px) {   .logo { display:none; }    }
[11:28:29] <hashar>	 try it out, submit the patch. done :-]
[11:28:34] <hashar>	 then others will benefit from it
[11:28:53] <hashar>	 you can test it out by saving a copy of the gerrit page to your local disk and  tweak the css
[11:28:58] <hashar>	 once happy copy paste :-]
[11:37:29] <Nemo_bis>	 hmpf, that extension doesn't seem to work... learning CSS patches is not in the plans for today, maybe another day
[12:15:28] <Hammond17>	 Hello
[12:15:56] <Hammond17>	 Somebody who can speak german, who could i asked?
[12:17:08] <Cyberpower678>	 I speak German
[12:18:24] <Hammond17>	 Sehr gut
[12:18:28] <Hammond17>	 �hm
[12:18:35] <Hammond17>	 folgendes Problem:
[12:18:51] <Hammond17>	 wie kann geht, das, das was ich in anderen wikis gesehen habe, dass man links in die WP setzt mit dem Schema [[de:WP-Artikel-Name]]?
[12:19:55] <Cyberpower678>	 Verstehe ich nicht.
[12:20:08] <Cyberpower678>	 wie kann geht?
[12:21:09] <Hammond17>	 In einem Wiki wo ich bin geht dass dass wenn ich [[de:Hilfe]] als bsp mache in der Wikipedia bei der Seite Hilfe raus komme. das m�chte ich in einem anderen wiki auch haben
[12:22:26] <Hammond17>	 http://de.wikipedia.org/wiki/Hilfe:Interwiki-Links
[12:22:32] <Hammond17>	 das meine ich
[12:24:04] <Cyberpower678>	 Also du willlst das es nicht in der Seitenleiste auftaucht sondern als link?
[12:24:38] <Hammond17>	 warte mal
[12:25:08] <Cyberpower678>	 Hammond17, https://en.wikipedia.org/w/index.php?title=User%3ACyberpower678%2Fsandbox&action=view&diff=547056439
[12:26:00] <Cyberpower678>	 das ist was [[de:Hilfe]] produziert.  Einen Interwiki link unter sprachen.
[12:26:14] <Hammond17>	 aha
[12:26:18] <Hammond17>	 aber warte mal
[12:28:13] <Hammond17>	 ah
[12:28:17] <Hammond17>	 fehler gefunden
[13:43:18] <guillom>	 I'm getting slow page loads on mediawiki.org & en.wikipedia
[13:44:29] <guillom>	 It seems to come from bits
[13:58:21] <apergos>	 not seeing that here as logged in user
[14:34:10] <logmsgbot>	 !log hashar synchronized multiversion  '{{gerrit|47564}} wikiversions.cdb now vary by realm'
[14:34:24] <morebots>	 Logged the message, Master
[15:02:51] <guillom>	 MediaWiki templates in log messages = win.
[15:03:59] <hashar>	 totally
[16:30:54] <Alchimista>	 addshore: about your bot on pt.wiki, is your bot running the same code of lego?
[16:31:02] <addshore>	 no :P
[16:31:32] <Alchimista>	 ah, ok. so would it be a case of botofobia? XD
[16:31:35] <addshore>	 bnut it runs the same code as my bot does on every other languages :P
[16:32:09] <Alchimista>	 do you have any log errro? Abuse filter? captcha?
[16:34:31] <Alchimista>	 addshore: can you try again? I though it already had autoconfirmed status, but seems not. I've just gave him autoconfirmed status now
[17:11:29] <MatmaRex>	 hello
[17:11:38] <MatmaRex>	 where can i get a hold on the fundraising guys and shout at them>
[17:11:39] <MatmaRex>	 ?
[17:11:57] <MatmaRex>	 https://pl.wikipedia.org/wiki/Loren_Acton is displaying three banners, all the same, one under another
[17:11:59] <MatmaRex>	 (when logged out)
[17:12:43] <MatmaRex>	 if this isn't fixed, like, immediately, i'm going to hide the banners in site CSS.
[17:12:52] <MatmaRex>	 (as in, mediawiki:common.css)
[17:23:48] <MatmaRex>	 [if anyone cares, crisis averted, on #-operations]
[17:39:25] <MatmaRex>	 mwalker: okay, so
[17:39:32] <MatmaRex>	 mwalker: loadBanner() is called twice
[17:39:52] <MatmaRex>	 mwalker: on the initial loading (straight from mw.loader.using), and on $.ready
[17:39:56] <mwalker>	 right; so about all I've got is that mw.centralNotice.initialize() is called twice
[17:40:08] <mwalker>	 oh
[17:40:13] <mwalker>	 that's interesting
[17:40:28] <mwalker>	 wonder why that behaviour changed
[17:40:48] <MatmaRex>	 technically, it's $(function() { mw.centralNotice.initialize(); });
[17:41:06] <MatmaRex>	 (save for the spacing, i guess, i'm wrking on autoformatted minimized JS)
[17:44:03] <MatmaRex>	 mw.loader.using( 'ext.centralNotice.bannerController', function() { mw.centralNotice.initialize(); } );
[17:44:05] <mwalker>	 MatmaRex: where's the $.ready() call?
[17:44:33] <mwalker>	 oh
[17:44:35] <MatmaRex>	 mwalker: it's $(function() { mw.centralNotice.initialize(); });
[17:44:40] <MatmaRex>	 so, these two calls
[17:44:43] <mwalker>	 ya -- I see what you're getting at
[17:44:46] <mwalker>	 fun :)
[17:44:58] <MatmaRex>	 there's no .ready to grep for :P
[17:46:01] <MatmaRex>	 mwalker: that $ calls is inside mw.loader.implement("ext.centralNotice.bannerController", function() {
[17:46:09] <MatmaRex>	 (in the RL-generated minified JS)
[17:46:29] <MatmaRex>	 at the very end of it
[17:47:00] <mwalker>	 yeppers -- I'm trying to find where RL get's told where the init function is
[17:47:49] <mwalker>	 (whilst dealing with four other fires *facepalm*)
[17:47:58] <MatmaRex>	 mwalker: which gerrit repo this is? extensions\CentralNotice?
[17:48:23] <mwalker>	 yes
[17:49:14] <MatmaRex>	 mwalker: okay, lol
[17:49:16] <MatmaRex>	 just grep the repo
[17:49:20] <MatmaRex>	 for "mw.loader.using( 'ext.centralNotice.bannerController', function() { mw.centralNotice.initialize(); } );"
[17:49:35] <MatmaRex>	 that code is in an inline <script/>
[17:50:27] <mwalker>	 oh frack
[17:50:34] <mwalker>	 that came out of a skin hook call didn't it?
[17:50:35] <MatmaRex>	 but i have no idea where does the $ call come from
[17:50:38] <MatmaRex>	 it doesn't grep :/
[17:51:08] <MatmaRex>	 modules/ext.centralNotice.bannerController/bannerController.js ends on the line before that call
[17:51:22] <MatmaRex>	 on master, that it
[17:51:23] <mwalker>	 update your repo to master :)
[17:51:33] <MatmaRex>	 ah, sorry
[17:51:43] <mwalker>	 no worries -- that's where this is coming from
[17:51:49] <mwalker>	 we have old skin code out there with new JS
[17:52:10] <MatmaRex>	 uh
[17:52:10] <MatmaRex>	 yeah
[17:52:15] <MatmaRex>	 i see it now
[17:52:18] <mwalker>	 so; solution is to; as you said; make sure initialize only runs once
[17:52:25] * mwalker  writes patch now

[17:52:39] <MatmaRex>	 will it be quicker if i patch it and you merge? :P
[17:53:00] <mwalker>	 probably -- but we still need a deploy window
[17:53:02] <mwalker>	 I'll find one
[17:53:20] <K4-713>	 Did I just get nominated again? 
[17:53:30] <mwalker>	 yep
[17:53:47] * K4-713  nods stoically

[17:53:51] <K4-713>	 Okay then. 
[17:54:38] <mwalker>	 greg-g: can fundraising snag what looks to be the first open deploy window between 1300 and 1400?
[17:55:38] <greg-g>	 mwalker: yes. But, check with matthiasmullie before you start, just in case they are running over, I don't think they've started their deploy yet.
[17:56:02] <greg-g>	 actually, matthiasmullie: please be done by 1300 Pacific so mwalker can do a fundraising deploy at that time
[17:56:05] * pgehres  is glad he trained K4-713 yesterday

[17:56:23] <K4-713>	 I *might* remember all of it. 
[17:56:27] <greg-g>	 :)
[17:56:33] <K4-713>	 This is why it's nice to do these things in IRC. 
[17:56:37] <K4-713>	 No IRL logs. 
[17:56:51] <pgehres>	 How to deploy code is fairly authoritative
[17:57:11] <matthiasmullie>	 greg-g: that should work
[17:57:24] <MatmaRex>	 mwalker: i'm pushing a patch for review right now
[17:57:25] <greg-g>	 matthiasmullie: great, thanks.
[17:58:20] <MatmaRex>	 mwalker: https://gerrit.wikimedia.org/r/55911
[17:58:22] <MatmaRex>	 (untested)
[18:03:56] <mwalker>	 MatmaRex: thanks for the patch -- it looks like it'll work; but it also looks like master is currently broken somehow
[18:04:04] <mwalker>	 so; I'm going to track that down
[18:04:12] <mwalker>	 and all this'll get deployed in ~2 hours
[18:04:21] <MatmaRex>	 track what down? who broke it? you ;) Idbc96ed4c5eceefedddafc05b335f0aa5f9b4acc
[18:04:24] <K4-713>	 mwalker: Did we get a window? 
[18:04:32] <mwalker>	 yes; 1300
[18:04:43] <K4-713>	 Roger that. I'll be ready. 
[18:06:58] <mwalker>	 I'm sure I did :)
[18:07:05] <mwalker>	 I just don't know why!
[18:07:17] <mwalker>	 oh no no no
[18:07:22] <mwalker>	 I know why loading broke
[18:07:28] <mwalker>	 I don't know why allocations seems to have broken
[18:07:55] <K4-713>	 What was it? 
[18:08:06] <mwalker>	 skin change for mobile that I forgot about
[18:09:23] <K4-713>	 Ah. That makes some amount of sense, I suppose. 
[18:09:45] <mwalker>	 it makes more sense when you know that the skin change moved where we initialized centralnotice
[18:09:55] <mwalker>	 so; on pages that were still cached initialize was getting called twice
[18:10:05] <K4-713>	 Aha! Yes.
[18:12:37] <mwalker>	 MatmaRex: ah; there is a problem with your patch -- but it did expose something else that I didn't know was going on -- so yay!
[18:13:15] <MatmaRex>	 mwalker: argh. sorry
[18:13:21] <MatmaRex>	 i shouldn't trust code autocomplete
[18:13:36] <logmsgbot>	 !log krinkle synchronized php-1.21wmf12/resources/mediawiki/mediawiki.js  'I80af730daa815 fixing bug 46575'
[18:13:39] <mwalker>	 what autocompleter do you use?
[18:13:47] <mwalker>	 the one in PhpStorm seems to do the job
[18:13:48] <morebots>	 Logged the message, Master
[18:13:54] <mwalker>	 I've had issues with the one in vim though
[18:15:37] <MatmaRex>	 mwalker: sublime text
[18:15:55] <MatmaRex>	 2
[18:16:16] <mwalker>	 considering how much one has to pay for that editor... tsk tsk! to the bug report!
[18:16:50] <MatmaRex>	 i didn't pay for it ;) (yet, i suppose)
[18:17:20] <MatmaRex>	 mwalker: i just typed 'centr' or something, and in that code, there's CentralNotice, centralnotice, centralNotice and centralnotice_
[18:17:42] <mwalker>	 ah yes... the terrible code in the controller
[18:18:02] <mwalker>	 I shall refrain from bashing sublime when I have that dark cloud hovering over my shoulder
[18:18:09] <MatmaRex>	 well anyway. too much haste. thanks for noticing this
[18:18:56] <MatmaRex>	 i use sublime for three reasons: goto anything, command paletter and perfectly executed multiple cursor editing
[18:19:02] <mwalker>	 hey; without you this would have taken much longer to figure out -- so thanks for the help :)
[18:19:17] <mwalker>	 I want my multiline editing back!
[18:19:36] <MatmaRex>	 i mean, other editors do multi-cursor editing as well
[18:19:42] <MatmaRex>	 notepad++, notably, it's great as well
[18:19:50] <MatmaRex>	 but sublime does it Right.
[18:20:11] <mwalker>	 notepad++ has other strange issues though -- like it used to not be able to insert tabs in multiline mode
[18:20:25] <MatmaRex>	 yeah, that's what i mean, there are quirks
[18:20:39] <MatmaRex>	 IIRC copy&paste in multiline mode behaves weird as well
[18:20:59] <mwalker>	 ya; it expects the buffer to be already allocated and then it overwrites whatever is in it
[18:21:08] <mwalker>	 which is sometimes what I want; but mostly not
[18:24:52] <logmsgbot>	 !log mlitn synchronized wmf-config/InitialiseSettings.php  'Turning Thanks extension on on MediaWiki wiki'
[18:25:04] <morebots>	 Logged the message, Master
[18:41:32] <logmsgbot>	 !log kaldari synchronized php-1.21wmf11/extensions/Echo/modules/icons  'syncing Echo icons dir'
[18:41:45] <morebots>	 Logged the message, Master
[18:41:56] <Alchimista>	 StevenW: any idea of when Guided Tour will be lunched globally?
[18:43:10] <logmsgbot>	 !log reedy synchronized php-1.21wmf12/extensions/MobileFrontend/includes/specials/SpecialMobileWatchlist.php 
[18:43:21] <morebots>	 Logged the message, Master
[18:43:34] <addshore>	 Alchimista: ill try again now
[18:43:44] <addshore>	 It may make a few more than 50 edits though
[18:43:44] <Alchimista>	 addshore: ok.
[18:44:24] <Reedy>	 Alchimista: Lunched?
[18:44:30] <Reedy>	 That'll be espensive
[18:44:30] <Alchimista>	 it doesn't need to be exactly 50 edits, as long as you dont make 300 :P
[18:44:41] <Alchimista>	 Reedy: :P deployed
[18:44:48] <addshore>	 should be somewhere between 0 and 100 :)
[18:45:13] <Alchimista>	 sometmes, i like to eat bits.
[18:46:06] <addshore>	 Alchimista: it works ;p http://pt.wikipedia.org/wiki/Especial:Contribui%C3%A7%C3%B5es/Addbot
[18:46:36] <Alchimista>	 hehe, so provably the problem was the captcha
[18:47:55] <Alchimista>	 addshore: the edit summary isn't localized, isn't he using this page -> http://meta.wikimedia.org/wiki/User:Addbot/WDS
[18:48:59] <addshore>	 just spotted a missing "break;" on the line for the pt summary, should be fixed as of next run :)
[18:49:25] <Alchimista>	 ok then :d
[18:54:03] <addshore>	 Alchimista: turns out the first run only actualy made 2 edits ;p started a second with the fixed summary http://pt.wikipedia.org/wiki/Especial:Contribui%C3%A7%C3%B5es/Addbot
[18:55:26] <addshore>	 ahh Alchimista http://pt.wikipedia.org/w/index.php?title=Especial:Registro_de_abusos&wpSearchUser=Addbot
[18:56:38] <addshore>	 that filter will probably need to be altered
[18:58:03] <Alchimista>	 addshore: done.
[18:58:30] <Alchimista>	 people use !(autoconfirmed) and forget the cases where bots got the confirmed status by sysops
[18:59:30] <StevenW>	 Alchimista: you mean default = true?
[18:59:38] <StevenW>	 Or where it is localized?
[18:59:55] <StevenW>	 For the latter, we've already launched in German, French, Dutch, and a few other Wikipedias.
[19:00:05] <Alchimista>	 StevenW: what about pt.wikipedia?
[19:00:15] * StevenW  goes to check translatewiki

[19:00:40] <StevenW>	 Yeah it's not localized https://translatewiki.net/w/i.php?title=Special%3AMessageGroupStats&x=D&group=ext-guidedtour&suppressempty=1&language=#sortable:3=desc
[19:00:54] <Alchimista>	 so when it gets localized, it's launched?
[19:00:59] <StevenW>	 As soon as that happens, we can easily add it during one of our weekly deployment windows. 
[19:01:15] <StevenW>	 If you want to keep bugging me and superm401 (the lead dev) file a bug request :)
[19:01:50] <Alchimista>	 ah, so i'll poke some people to translate it quickly
[19:02:39] <StevenW>	 Muito obrigado
[19:15:14] <addshore>	 Alchimista: see what you think :) done a fair few edits :)
[19:15:54] <Alchimista>	 addshore: ok, just give me a few minutes
[19:17:37] <kaldari>	 just did an extension deployment 15 minutes ago that included some css updates. The new css has been picked up by palladium, but not any of the other bits servers. Is there any way to flush it on the others? Would a scap do that?
[19:20:48] <Alchimista>	 addshore: flag granted! the bot can now run freely
[19:21:08] * addshore  goes to release it from its cage :)

[19:21:42] <addshore>	 600*24
[19:21:45] <addshore>	 opps
[19:22:13] <kaldari>	 hmm, touch and re-sync didn't fix it
[19:30:28] <matthiasmullie>	 greg-g: I'm done for now - whoever (fundraising?) needed to deploy can start already
[19:31:02] <greg-g>	 matthiasmullie: thanks mwalker ^^
[19:31:14] <mwalker>	 K4-713: ready?
[19:31:26] <K4-713>	 nope.
[19:34:57] <Alchimista>	 StevenW-food: done: https://translatewiki.net/w/i.php?title=Special%3ATranslate&taction=translate&group=ext-guidedtour&language=pt&limit=100&task=untranslated
[19:35:05] <K4-713>	 mwalker: Okay, now I'm ready. 
[19:35:07] <Alchimista>	 when is the next deployment window? :P
[19:35:28] <K4-713>	 greg-g: I'm starting the fundraising deploy. 
[19:35:49] <K4-713>	 Thanks!
[19:37:00] <greg-g>	 K4-713: thank you, go forth and deploy :)
[19:54:24] <K4-713>	 greg-g: Deploy done, and verified. We should be good now. Thanks!
[19:54:53] <mwalker>	 MatmaRex: ok; we're deployed -- seems to working so redeploying banners
[19:54:59] <greg-g>	 K4-713: awesome, thank you much
[19:55:41] <MatmaRex>	 mwalker: yay. thanks
[19:55:58] <MatmaRex>	 i think it's the fastest i've seen any wmf team react to an issue ;)
[19:56:43] <mwalker>	 you caught us when we were awake!
[19:56:45] * Reedy  beats MatmaRex

[19:57:00] <MatmaRex>	 mwalker: ;)
[19:57:04] <greg-g>	 MatmaRex: hey!
[19:57:06] <MatmaRex>	 Reedy: you're awesome, too
[19:57:07] <MatmaRex>	 :D
[19:59:33] <MatmaRex>	 greg-g: hi
[19:59:50] <K4-713>	 Whew! Go team. :)
[20:00:04] <K4-713>	 MatmaRex: Please do let us know if you see anything else going... funny. 
[20:00:26] <MatmaRex>	 K4-713: surely will. but it seems alright now :)
[20:00:50] <greg-g>	 MatmaRex: sorry, was just being interjectionist to your "fastest i've seen any wmf team react" comment ;)
[20:02:05] <MatmaRex>	 greg-g: ah. ;)
[20:02:10] <kaldari>	 K4-713: can I have the rest of your deployment window?
[20:02:28] <K4-713>	 kaldari: Take it! 
[20:02:31] <kaldari>	 merci
[20:07:12] <ori-l>	 are we trying to / hoping to eliminate call-time pass-by-reference from core? what's the policy on that?
[20:09:02] <^demon>	 ori-l: Don't use it in new code? :)
[20:09:15] <ori-l>	 ^demon: yeah, that's what I thought. thanks.
[20:36:47] <Nemo_bis>	 hm, mediawiki.org unavailable for a moment
[20:37:37] <Alchimista>	 Nemo_bis: are you sure? it's working fine for me
[20:38:11] <Reedy>	 he said a moment ;)
[20:38:59] <Alchimista>	 Ah, for "a" moment :P
[20:39:05] <Alchimista>	 i really need a coffe
[20:43:42] * Nemo_bis  is preparing one

[22:04:10] <csteipp>	 Hey Aaron|home, could I get a review of https://gerrit.wikimedia.org/r/#/c/33971 too?
[22:05:39] <csteipp>	 I made most of the changes you suggested except limiting the number of IPs checked, since most users won't have a log of XFF ips. But it could be done recursively now, so if you think it would be better, it's easy to add.
[22:22:21] <greg-g>	 kaldari: what's the priority on getting that fix for bug 46059 out?
[22:22:29] <greg-g>	 !b 46059
[22:22:29] <wm-bot>	 https://bugzilla.wikimedia.org/46059
[22:22:58] * greg-g  wonders if the smart setting works

[22:23:05] <kaldari>	 I'd like it merged before Monday
[22:23:15] <greg-g>	 I wonder if I can just reference a !bug 1253 in a sentence normally
[22:23:18] <greg-g>	 nope
[22:23:29] <greg-g>	 nope to my question to myself, not your response, kaldari :)
[22:23:42] <Susan>	 kaldari: Hello.
[22:23:53] <greg-g>	 kaldari: ok, there's a lightning deploy today, if this is not intrusive, but it looks like it hasn't been reviewed yet
[22:24:07] <Susan>	 I say it's fine.
[22:24:13] <Susan>	 I commented on the changeset.
[22:24:18] <kaldari>	 Susan: thanks
[22:24:39] <kaldari>	 I also fixed the text-alignment in monobook
[22:25:00] <kaldari>	 in a different change that's already merged
[22:27:38] <greg-g>	 why are all those other people on the review list? I can't tell if their auto-added because of where the change is in the codebase or because you added them/they added themselves
[22:27:42] <greg-g>	 kaldari: ^
[22:28:04] <kaldari>	 I added all of them. Scattershot approach :)
[22:28:19] <greg-g>	 :)
[22:28:31] <greg-g>	 good policy
[22:28:36] <kaldari>	 Waldir was autoadded due to the bug though
[22:29:00] <kaldari>	 don't know where Daniel came from, he might have added himself
[22:29:42] <kaldari>	 I added Krinkle, Trevor, and Rob because their all CSS people
[22:29:51] <kaldari>	 their = they're
[22:30:20] <greg-g>	 your welcome, you're change is nice #sorry
[22:30:55] <kaldari>	 I wonder how many developers it takes to review a 1 character core change? :)
[22:36:59] <valhallasw>	 kaldari, greg-g, Waldir and Daniel were added by the reviewer bot
[22:37:37] <kaldari>	 that's a helpful bot
[22:38:17] <valhallasw>	 (it currently adds because of a file mask, but integrating with bugzilla is an interesting possibility)
[22:38:18] <greg-g>	 valhallasw: how do you see/know that?
[22:38:24] <valhallasw>	 greg-g: from the log :-)
[22:38:50] <valhallasw>	 (I'm running the bot - the logs are not public atm, although that would be nice)
[22:38:57] <greg-g>	 well then
[22:38:58] <greg-g>	 ;)
[22:44:16] <greg-g>	 well, kaldari, to be explicit, if you can get another review on that dang one char patch, the lightning deploy in 15 minutes should be good to go for you
[22:44:52] <greg-g>	 I mean, it looks good to me (what's the harm in adding 3 to that value? ;-) ), but that's not my call
[22:54:58] <siebrand>	 K4-713 / mwalker / greg-g / marktraceur : Just a ping about moving discussion about https://bugzilla.wikimedia.org/46579 here.
[22:55:15] <siebrand>	 Just had a look at en.wp with nl UI. English pops in left and right, indeed.
[22:55:17] <greg-g>	 hah
[22:55:47] <mwalker>	 siebrand: sure -- so enwiki has lots of customization
[22:55:54] * marktraceur  is going to take leave of this unless there's some reason to pull him in :)

[22:56:04] <siebrand>	 If you want to see for yourself, set your UI to russian or something. There all Latin strings will pop out clearly (Russian has complete localisation)
[22:56:27] <mwalker>	 I can actually code this such that the stock translation will take precedence -- but there was an argument for "if they've changed it, they must think it's REALLY important"
[22:56:28] <siebrand>	 marktraceur: No need to stay involved, I guess. Thanks for yelling on #wikimedia-staff :)
[22:56:57] * marktraceur  loves helping people when it only means pointing at others :P

[22:57:08] <siebrand>	 that's the best, I know :)
[22:57:17] <mwalker>	 I know where you sit marktraceur -- and I have heavy weaponry up here!
[22:59:01] <mwalker>	 so -- siebrand; we can obviously revert -- but I would actually like to push for keeping it
[22:59:36] <mwalker>	 mostly because I guess I don't understand why the community would override a translation
[22:59:59] <mwalker>	 I can only think they do it because they think it's important -- and so this gives them control to do that to all languages
[23:01:40] <marktraceur>	 mwalker: The pain, bring it
[23:03:07] <marktraceur>	 I mean, fix wikipedia first.
[23:03:42] <greg-g>	 siebrand: you're the one I trust in this discussion re internationalization and motives of people overriding, what say you?:
[23:04:13] <siebrand>	 I say it's midnight and I shouldn't rush into this at this time.
[23:05:10] <greg-g>	 siebrand: good thinking
[23:05:38] <siebrand>	 mwalker: well, one reason to override a lot of messages: MediaWiki uses the concept of (content) page as default. Wikipedias usually use 'article' for content page. That means customising 50-100 messages across core and the 120 or so extensions that Wikimedia deploys.
[23:05:55] <siebrand>	 mwalker: Other reasons to override: Wikimedians love verbosity.
[23:06:11] <Reedy>	 "It seemed a good idea at the time..."
[23:06:34] <mwalker>	 sure -- here's what I'll do; I'll write up my thoughts in the bug and we can continue the discussion tomorrow when your well rested
[23:06:55] <mwalker>	 unless you want to pull the patch now
[23:07:05] <siebrand>	 mwalker: yep. By that time Niklas will hopefully say something nice and technical about it. Much better than I can.
[23:07:18] <mwalker>	 cool
[23:07:46] <greg-g>	 great, thanks
[23:07:49] <greg-g>	 all
[23:08:55] <siebrand>	 mwalker: It's a confirmed issue now. It's a bit weird, but all basic uses cases still work, although the may be a little awkward at some points. I don't think it's a critical issue, but it's a high priority issue we have to resolve one way or the other before the weekend, is what I'd say.
[23:09:13] <mwalker>	 *thumbs up*
[23:20:03] <awight>	 !log payments cluster updated from fa2e240b to 4862fb8
[23:20:09] <morebots>	 Logged the message, Master
[23:33:15] <awight>	 !log payment cluster rollback, from 4862fb8 to fa2e240b
[23:33:22] <morebots>	 Logged the message, Master
[23:53:12] <awight>	 !log payments cluster updated from fa2e240b6e9 to e758102
[23:53:19] <morebots>	 Logged the message, Master
[23:54:17] <awight>	 !log payments cluster rolled back from e758102 to fa2e240b6e9
[23:54:23] <morebots>	 Logged the message, Master