[00:24:41] for some reason i am unable to merge https://gerrit.wikimedia.org/r/#/c/53689/ - anyone know why/what's going on? i feel like there may have been a gerrit workflow change i missed a note about... [00:25:31] awjr, merge conflict [00:25:37] needs rebase [00:25:46] gn8 folks [00:25:58] there's a comment and 'Can merge: No' [00:26:01] @_@ [00:26:29] ah now i see the comment, thanks krenari [00:26:37] Krenair, rather [03:11:33] !log started incremental updater on searchidx1001 and searchidx2, apparently has not been running since March 13 [03:11:53] Logged the message, Master [03:45:46] I added MediaWiki to . [08:20:26] hello -_- [09:27:07] omg Echo emails are horrible [09:27:26] $ echo [09:29:43] Nemo_bis huh? [09:42:40] Nemo_bis: proof? Send us a screenshot :-] [09:46:47] petan, hashar, legoktm, https://bugzilla.wikimedia.org/show_bug.cgi?id=46316 https://bugzilla.wikimedia.org/show_bug.cgi?id=46315 [09:46:56] hi [09:48:28] ah [09:48:31] thanks [09:48:49] Nemo_bis: great :-] [09:50:33] I was already filing it :p [10:40:44] legoktm: have you understood when the JS to add interwikis where there's none is being deployed, the 20th or the 27th? [10:40:54] there was big confusion about this yesterday [10:41:06] not sure [10:41:15] Lydia_WMDE would probably know [10:48:57] oh well, I told it.wiki it will be on some wednesday but nobody knows which [10:49:10] whatever the day, it will be a pleasant surprise [11:02:00] Nemo_bis: heh the next client update is on 27th [11:02:12] i am not sure what the status of that particular patch is though atm [11:02:35] as far as i know it is good but.. [12:52:16] When using the API to upload files in chunks, and setting all the necessary parameters to do it and then having the API spit back "Internal Error" with info being "Invalid file title supplied" is it talking about the path to the file being uploaded or the name of the File page or what? [12:54:41] !log on professor: restarted collector [12:54:49] Logged the message, Master [13:19:13] Can somebody help me? [13:39:47] hi Cyberpower678 [13:40:06] Cyberpower678: what's your question? [13:41:45] sumanah, I'm testing a new bot feature, uploading chunked files, and when I feed the API the first chunk, it returns "internal-error" along with "Invalid file title supplied". What could that be? [13:43:30] if I had to guess, it would be your first answer Cyberpower678 - "path to the file being uploaded" [13:43:36] can you give a sample file? [13:43:41] have you tried a different filename? [13:44:38] Yes. [13:46:48] I think you misunderstood me. I meant, can you tell us a sample filename. [13:47:07] sumanah, oops [13:47:20] sumanah, Wildlife.wmv [13:47:35] So I want to upload to Wildlife.wmv [13:47:39] ok. So, does the wiki you're trying to upload to accept .wmv files? [13:47:44] File:Wildlife.wmf [13:47:53] have you tried something like a .txt or .ogg instead? [13:48:48] I don't know. [13:48:54] I'm using test.wikipedia.org [13:49:22] I think that test.wikipedia.org almost certainly does not accept .wmv files [13:49:50] Also, please skim http://wikitech.wikimedia.org/view/Test.wikipedia.org and http://wikitech.wikimedia.org/view/Test2.wikipedia.org -- you probably want to target test2 instead. [13:52:19] I see. [13:52:51] That would certainly explain the action=createaccount issue. [13:53:08] Since it's still being tinkered around with, [13:54:03] wmv isn't a open file format, no where in the cluster will accept it afaik [13:57:52] Then I'll try chunk uploading an image then. .jpeg images are accepted, though? [13:59:39] sumanah, p858snake|l, ^ [14:00:12] yes [14:00:21] .png would be even better! [14:00:44] depending on the type of image :) [14:00:50] I'm going to delete the files I upload anyways. [14:01:33] p858snake|l, it's a 4MB picture of a pizza I pulled from the internet. [14:02:44] you could just grab something from Commons like https://commons.wikimedia.org/wiki/File:Strlen_in_Scribunto.png and then it'd be sure to be fine. :) [14:05:30] Just make a large, entirely blue image. [14:05:45] Or make a small one and upload it in chunks of 10 bytes. [14:06:55] anomie: so, make a progress bar :-) ? [14:07:47] sumanah, thanks for that. It was a file type issue. Now to resolve the bug of the file not committing. [14:08:06] Glad to help! [14:38:05] andre__: just to remember me, is wikibugs a bugzilla account or not? https://bugzilla.wikimedia.org/show_bug.cgi?id=28402#c12 [14:38:20] if it is I suppose one could change its preferences on bugmail? [14:38:56] Nemo_bis, wikibugs-l at lists.wikimedia.org must be a Bugzilla account because you can assign bugs to it. :) [14:39:11] but it is also the Bugzilla account that is on the globalwatcher list in the Bugzilla preferences. [14:40:02] so yeah, you should be right. But I have no idea about the implications with this specific construction, because a globalwatcher account is expected to provide... *all* bugmail. Hmm. Interesting. [14:41:40] andre__: provide whom? nobody wants those [14:41:58] I want those. [14:42:03] andre__: ah no, you can assign bugs to the watcher in other bz installs as well [14:42:42] andre__: can't you make yourself global watcher or whatever? [14:42:44] I know. :) I just wonder how defining an account as globalwatcher works with restrictive settings for that account in its Bugzilla email preferences [14:42:53] ah :) [14:43:00] Nemo_bis, hmm. Now that's an interesting workaround. :) [14:43:12] worth trying, it takes only a minute or so to change its prefs [14:43:19] or just set yourself as a default cc to everything... [14:43:30] like we threaten to do with hex >.> [14:43:33] but still, where does this solve the original problem? [14:44:15] wikibugs-l@ isn't assignee or default CC for all tickets. so it must remain globalwatcher anyway. [14:44:33] and if you want to reapply that hack, any other globalwatcher (like my personal email address) would face the same limitations. [14:44:59] on the other hand, it's all broken anyway - https://bugzilla.wikimedia.org/show_bug.cgi?id=44929 [14:45:30] right now I don't get all bugmail either, for reasons I don't know. Though I'd like too. [15:05:18] "BUG DAY about open LiquidThreads bug reports" – right now on #wikimedia-dev [20:09:23] Krinkle, you there? Re gerrit 54713 I appreciate the feedback. We want to get feedback and testing on these opt-in versions of the login and create account forms _during_ development (regular login is unchanged). [20:13:04] ^ ignore that, Matmarex submitted it. I assume scathing reviews come from Krinkle LOL. [20:13:23] !g 54713 [20:13:23] https://gerrit.wikimedia.org/r/#q,54713,n,z [20:13:31] MatmaRex, want to talk about it? [20:14:14] <^demon> That needs to come out of master unless someone's fixing all those problems like right now. [20:14:40] spagewmf: What feedback? I don't see my name on 54713 (the revert) nor on the original (30637). [20:14:47] spagewmf: i want it reverted for now. i definitely want it fixed then, and i dont mind oit getting merged once it works [20:21:43] <^demon> Can we go ahead and merge the revert for now? This just isn't quite ready for prime time :) [20:22:02] sorry Krinkle. MatmaRex, again we (E3 team) want to get feedback and testing on an opt-in basis early. "It works" for that. [20:22:49] ^demon sure revert away. How about I come up with a new patch that has the new mw-ui styles and the optional opt-in login, which are 95% there? [20:23:08] spagewmf: you were already testing it for a few months, no? [20:23:08] <^demon> You guys can do whatever you want. I just want master clean :) [20:23:22] spagewmf: i understand that it want's in core, but i don't really see the dfifference [20:23:30] it wasn't* [20:23:56] It's the createaccount that's more problematic, thanks to the fancycaptcha. [20:24:03] spagewmf: you mean those sass-generated styles? :/ [20:24:27] even off by default, that code is simply not acceptable [20:24:35] the hardcoded link is just to much [20:24:36] Can\'t see the image? We can create an account for you! [20:25:10] and i won't mention the helvetica in CSS munaf has been arguing for a few weeks ago and that was reverted [20:25:36] and i won't mention the excessive todos and comments from a dev to another dev [20:26:06] even the js captcha munging i could survive with, if it was the only issue [20:26:34] but together, this breaks most of the basic coding craft rules i know of [20:27:00] i was really expecting more from wmf guys :/ [20:27:36] <^demon> Well, there's no need to assign blame. Sometimes bad patches go through. This is why we use version control :) [20:28:04] <^demon> But yes, the point of pre-commit review is to catch these sorts of things and make sure code's up to standards. I trust any future patches will take the various criticisms into consideration. [20:28:10] MatmaRex Re: the Helvetica font stack, it's part of the Agora redesign, controversial. [20:28:28] spagewmf: it's certainly quite controversial, yes [20:28:35] so it shouldn't be snuck in via back doors [20:28:43] i'm going to go and have a tea now. [20:29:33] MatmaRex your other (completely valid!) points are all in the create account form. [20:30:42] MatmaRex but the whole point of getting this out early in core is so we can tell people "Try the new look forms"! It's the opposite of "back door". [20:31:34] The new look has been on enwiki for months, but since Wikipedians don't create accounts it has indeed been under the radar. [20:33:04] Let [20:33:06] Let [20:33:07] gah [20:33:33] I was also surprised to see that into core [20:33:35] Let's not argue about it. Let's just look over MatmaRex's comments and take the feedback in to account [20:33:41] spagewmf: that's what code review is for? :/ [20:33:51] for trying out and letting people know? [20:33:58] and yes, it is back door, don't be silly [20:34:02] it wasn't mentioned anywhere [20:34:03] at all [20:34:07] not a word [20:34:09] so yes [20:34:12] it is via a back door [20:35:36] * Platonides looks with displeasure the hardcoded English + urls at resources/mediawiki.special/mediawiki.special.createaccount.agora.js [20:41:35] gah, should have put "Opt-in " in commit title, makes it less incendiary. Platonides, agree 110% createaccount not ready for primetime. [20:43:27] spagewmf: even off by default, this code is not good enough :/ [20:43:28] <^demon> Just because something's opt-in doesn't mean the code doesn't have to be up to standards :) [20:43:37] <^demon> Sure, you can cut some corners, but conventions are important :) [20:43:57] developing a mockup-like extension that works in one language on one wikis is OCMPLETELY UNLIKE developoing in core of a huge open-soruce projects used on thousnads of sites in some 200 langauges [20:44:08] <^demon> (Plus, if you start out lazy, you just build yourself technical debt to fix later on. FIXMEs have a habit of sticking around longer than you'd like ;-)) [20:44:29] even if that one language is english, and that one wiki is the english wikipedia [20:44:37] the e3 approach justdoesn't scale [20:44:46] and it just saddens me [20:46:20] James_F: https://en.wikipedia.org/wiki/Wikipedia_talk:VisualEditor#Timeline [20:47:23] ^demon and MatmaRex completely reasonable points. We wanted to overlap engineering and getting early design and translation feedback, if that's not how it's done for core then I won't do it that way. [20:50:23] spagewmf, if you wanted early translation feedback you should have asked siebrand or Niklas [20:51:07] Siebrand was added to the reviewer list from the getgo, FYI. [20:51:10] they would have pointed out those «this isn't translated this way» problems [20:51:30] I think the revert is just fine. If people have comments then they have comments, but let's not pretend no one under the sun saw the patch. [20:51:39] he probably didn't review it [20:51:46] StevenW: yeah, but you replied to first comment, then rewrote most of the patch, then merged it after a few hours. no wonder he didn't have time to rpely. [20:51:57] to his first comment* [20:52:10] you = e3 team, not you personally :) [20:52:52] anyway, let's just agree it's not ready to be merged yet. and you can look for a follow up review request. [20:52:54] Platonides, the feedback I seek is more the customization of signupstart/signupend/fancycaptcha etc. fields by wikis; the new forms get rid of them in the service of a more compact design. And again, don't blame the whole thing for the createaccount FIXMEs. [20:55:21] (also loginstart/loginend messages) [20:55:28] spage, I'm not sure what you mean [20:55:51] I was surprised when I saw it merged [20:56:03] but it was kind-of ok [20:56:38] after all, it was configuration-protected [20:57:44] I started disliking it more after seeing it with more detail based in the revert commit msg :) [20:59:08] Platonides, I mean http://en.wikipedia.org/w/index.php?title=Special:UserLogin&uselang=qqx , the new form removes loginstart and loginend. That's not translation feedback, but it is a change. [21:01:08] Platonides, wiki admins can use the new userlogin-helplink to provide similar information to those fields, but it's a change and work. [21:04:25] I'm seeing the checkbox without separation with the "Remember me" text in monobook [21:05:04] hmm... vertical separation is also smaller [21:48:11] Platonides: can you send screengrab etc? I know it's not perfect in Monobook yet, especially if you view account creation while logged in already. [21:48:39] In Vector there should be better separation, monobook probably has more bugs. [21:55:06] StevenW, what do i do with the image? [21:56:49] heh, Susan. ori-l see the mess @ http://lists.wikimedia.org/pipermail/wikitech-l/2013-March/067742.html [21:56:53] :-) [21:56:58] I just visited Special:userlogin with ?useAgora=1&useskin=monobook [21:57:24] a bug works, or you can just email it to me (swalling@wikimedia.org) [21:57:27] Did it get deployed? [21:58:20] ^demon: You still around? [21:58:54] Susan, I visited http://wiki.wikimedia.org.es/wiki/Especial:Entrar?useAgora=1&useskin=monobook [21:58:59] which runs on nearly-master [21:59:12] it now updated to the revert change [22:00:55] <^demon> Susan: Sup? [22:01:06] ^demon: https://bugzilla.wikimedia.org/show_bug.cgi?id=44628#c24 [22:01:09] I was going to point you to that. [22:01:58] <^demon> All I did was merge the revert, because the code was inappropriate for core as-written. [22:02:04] Right. [22:02:17] <^demon> I don't have any opinions on the feature or anything else about it. [22:02:17] K. [22:04:24] StevenW, https://bugzilla.wikimedia.org/show_bug.cgi?id=46338 [22:04:31] Muchas gracias [22:05:23] :) [22:05:28] HI! [22:05:39] hi domas [23:47:40] gn8 folks [23:52:11] !log synchronized payments cluster to fe4fb96bea1378e [23:52:17] Logged the message, Master