[07:59:56] <Nikerabbit>	 hello
[08:00:28] <domas>	 hi
[09:23:10] <logmsgbot>	 !log nikerabbit synchronized php-1.20wmf10/extensions/wikihiero/  'RTL fix'
[09:23:20] <morebots>	 Logged the message, Master
[10:02:15] <logmsgbot>	 !log nikerabbit synchronized php-1.20wmf10/extensions/Translate/  'Picking up Solarium'
[10:02:25] <morebots>	 Logged the message, Master
[10:08:21] <Nikerabbit>	 hmph
[13:11:45] <logmsgbot>	 !log demon synchronized .gitignore  'Syncing .gitignore'
[13:11:54] <morebots>	 Logged the message, Master
[13:13:15] <logmsgbot>	 !log demon synchronized wmf-config/InitialiseSettings.php  'Syncing f58063db'
[13:13:25] <morebots>	 Logged the message, Master
[13:14:56] <logmsgbot>	 !log demon synchronized wmf-config/CommonSettings.php  'Syncing 95c87a0b for AFT (mlitn said its ok)'
[13:15:08] <morebots>	 Logged the message, Master
[14:02:18] <logmsgbot>	 !log nikerabbit synchronized wmf-config/InitialiseSettings.php  'ttmserver part 1'
[14:02:27] <morebots>	 Logged the message, Master
[14:03:10] <logmsgbot>	 !log nikerabbit synchronized wmf-config/CommonSettings.php  'ttmserver part 2'
[14:03:19] <morebots>	 Logged the message, Master
[17:22:18] <robla>	 csteipp: does using addClass in jQuery obviate the need for escaping what you pass in (assuming it's user input), or does it need to be escaped?
[17:24:10] <csteipp>	 robla: I'm pretty sure it escapes, but I'm looking it up
[17:24:38] <robla>	 thanks...it wasn't obvious from the little bit of experimenting that I'm doing, or the docs I was able to find
[17:26:59] <robla>	 csteipp: if you don't know off the top of your head, that's ok.  I'm just replying to your mail, and I'll just be unsure in that mail  :)
[18:30:26] <bsitu>	 Hello, I am submitting a submodule for review, but jenkins-bot failed it: Build step 'Trigger/call builds on other projects' marked build as failure.  Does anyone know what may cause this?
[18:35:14] <RoanKattouw>	 bsitu: Link?
[18:35:40] <bsitu>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/21760/
[18:37:08] <RoanKattouw>	 RevisionStorageTest::testRevText Use of Revision::revText was deprecated in MediaWiki 1.17. [Called from RevisionStorageTest::testRevText in /var/lib/jenkins/jobs/MediaWiki-GIT-Fetching/workspace/tests/phpunit/includes/RevisionStorageTest.php at line 219]
[18:37:12] <RoanKattouw>	 WTF
[18:37:49] <AaronSchulz>	 things still use revText?
[18:38:03] <RoanKattouw>	 That looks like a test failure in core though
[18:38:09] <RoanKattouw>	 Maybe the tests don't pass in wmf10 right now?
[18:38:17] <RoanKattouw>	 Shouldn't hold up deployment of that commit anyway
[18:38:20] * RoanKattouw  marks it as verified

[18:39:13] <RoanKattouw>	 bsitu: OK I manually overrode Jenkins for that commit
[18:39:30] <bsitu>	 RoanKattouw: thx
[18:49:56] <RoanKattouw>	 AaronSchulz: bsitu just pointed out to me that enwiki is on wmf9 according to /h/w/c/wikiversions.dat , but on wmf10 according to https://en.wikipedia.org/wiki/Special:Version , any idea what's going on there?
[18:57:56] <hashar>	 RoanKattouw: that #21760 was marking as failure because the tests hits some deprecated method
[18:58:26] <hashar>	 need to post on wikitech-l about it
[18:59:14] <RoanKattouw>	 hashar: So I guess that failure somehow made it into the wmf10 branch?
[18:59:31] <hashar>	 yup
[18:59:41] <hashar>	 the output is at https://integration.mediawiki.org/ci/job/MediaWiki-Tests-Misc/4458/console
[18:59:51] <hashar>	 that spurt stuff like: 18:19:53       [exec] Use of Revision::revText was deprecated in MediaWiki 1.17. [Called from RevisionStorageTest::testRevText in /var/lib/jenkins/jobs/MediaWiki-GIT-Fetching/workspace/tests/phpunit/includes/RevisionStorageTest.php at line 219]
[19:00:06] <hashar>	 well that is the only error actually
[19:01:04] <RoanKattouw>	 Yeah
[19:01:16] <RoanKattouw>	 What I'm wondering is how did that failure make its way into core
[19:01:25] <RoanKattouw>	 Shouldn't Jenkins have stopped the broken commit from getting merged?
[19:03:36] <hashar>	 RoanKattouw: it should have marked it as -2 or something
[19:04:07] <hashar>	 I have posted on wikitech / BCCed your gmail email
[19:04:20] <RoanKattouw>	 Thansk
[19:04:28] <hashar>	 I guess you removed Jenkins from the reviewer list
[19:04:36] <RoanKattouw>	 For the  broken commits yes
[19:04:52] <RoanKattouw>	 Otherwise it won't let them merge I think
[19:05:06] <hashar>	 yup cause of the "do not submit" flag :)
[19:05:29] <RoanKattouw>	 I got your bcc but not your wikitech-l post
[19:06:01] <RoanKattouw>	 But... can we turn this behavior back off for now? It means that Gerrit admin intervention is now required to merge anything into the wmf10, because Jenkins needs to be overridden each time
[19:06:15] <hashar>	 will fix wmf10
[19:06:24] <RoanKattouw>	 Or that
[19:06:28] <hashar>	 and rebase the changes
[19:07:42] <hashar>	 I am not sure though why it happens in wmf10 and not in master
[19:10:18] <AaronSchulz>	 RoanKattouw: maybe it wasn't pushed to git and someone reset it?
[19:10:40] <hashar>	 apparently fixed in master with https://gerrit.wikimedia.org/r/#/c/21732/
[19:11:07] <hashar>	 which also replace doEdit( $text, $summary )   with   +               $page->doEditContent( ContentHandler::makeContent( $text, $title ), '', EDIT_NEW );
[19:11:08] <hashar>	 oh noo
[19:11:25] <AaronSchulz>	 meh, pushed now
[19:14:56] <hashar>	 I am not going to merge https://gerrit.wikimedia.org/r/#/c/21732/ in wmf10
[19:15:07] <hashar>	 I have send a mail to DanielK_away about it
[19:15:15] <hashar>	 I am wondering why he replaced doEdit by doEditContent
[19:19:23] <Krenair>	 It was fixed in master in https://gerrit.wikimedia.org/r/#/c/20926/
[19:20:34] <Krenair>	 Which isn't in 1.20wmf10 yet, so all the tests there fail
[19:24:29] <Krenair>	 I did try to cherry-pick that into 1.20wmf10 for review but did it wrong and the dependency was backwards, so I gave up and abandoned
[19:28:30] <RoanKattouw>	 Krenair: I'll cherry-pick that then
[19:30:08] <RoanKattouw>	 Krenair: Whoa, wait, it's already there v
[19:30:09] <RoanKattouw>	 https://gerrit.wikimedia.org/r/#/c/21736
[19:30:25] <RoanKattouw>	 It passed Jenkins but you abandoned it?
[19:30:55] <RoanKattouw>	 Oh, it was dependent on something else
[19:31:14] <Krenair>	 Yes
[19:31:28] <RoanKattouw>	 I reopened the change and submitted a new patchset
[19:31:33] <RoanKattouw>	 Hopefully that one will pass the tests
[19:31:35] <Krenair>	 Okay
[19:40:15] <Krenair>	 RoanKattouw, looks like it worked
[19:47:08] <RoanKattouw>	 Krenair, hashar: Looks like it's fixed now https://gerrit.wikimedia.org/r/#/c/21808/
[19:47:56] <hashar>	 congrats!!
[19:53:35] <logmsgbot>	 !log catrope synchronized php-1.20wmf10/tests/phpunit/includes/RevisionStorageTest.php  'Deploy e1cfe5ada99f3ed4594c5cfc33906538f4e02bdf'
[19:53:45] <morebots>	 Logged the message, Master
[19:55:16] <logmsgbot>	 !log catrope synchronized php-1.20wmf10/extensions/ProofreadPage  'Deploy 65fcb5984fd7d52ecd1887b248fda608b9dc4987'
[19:55:26] <morebots>	 Logged the message, Master
[20:16:33] <logmsgbot>	 !log mlitn Started syncing Wikimedia installation... : Updating ArticleFeedbackv5
[20:16:43] <morebots>	 Logged the message, Master
[20:43:59] <thedj>	 Error deleting file: The file "mwstore://local-multiwrite/local-public/6/60/Miley_Cyrus_interpreta_Miley_Stewart.jpg" is in an inconsistent state within the internal storage backends
[20:44:16] <hoo>	 not again -.-
[20:44:19] <hoo>	 RoanKattouw: ^
[20:44:56] * RoanKattouw  passes the buck to AaronSchulz

[20:46:17] <Krenair>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=39221
[20:48:22] <apergos>	 nice pass, very smooth
[20:48:49] <apergos>	 I'd like to hear what that turns out to be and how it's tracked down
[20:52:29] <logmsgbot>	 !log mlitn Finished syncing Wikimedia installation... : Updating ArticleFeedbackv5
[20:52:39] <morebots>	 Logged the message, Master
[20:58:58] <logmsgbot>	 !log dzahn synchronized ./wmf-config/InitialiseSettings.php 
[20:59:09] <morebots>	 Logged the message, Master
[21:06:45] <K4-713>	 !log updated the payments cluster to 9bcd8961fecb5
[21:06:54] <morebots>	 Logged the message, Master
[21:28:56] <RoanKattouw>	 AaronSchulz: OK I reviewed most of your changes, but I stayed away from the RDBStore and JobQueue stuff because they're huge and it seems others are already involved with reviewing those. Also ignored the SwiftCloudFiles change because you self-minus-two-ed it.
[21:36:17] <jeremyb>	 AaronSchulz: what is http://flaggedrevssandbox.wikimedia.org/ 
[21:36:20] <jeremyb>	 ?
[21:36:27] <jeremyb>	 can we kill that domain?
[21:36:38] <jeremyb>	 see OTRS 2012082810011103
[21:41:14] <jeremyb>	 that domain is pointing at a linode
[21:42:02] <jeremyb>	 please hilight me if you deal with it, bbl
[21:42:12] <jeremyb>	 (i've locked that ticket to me)
[21:44:49] <logmsgbot>	 !log bsitu synchronized php-1.20wmf10/extensions/PageTriage/tools/cleanupPageTriagePageTags.php  'Fix the cleanup cron'
[21:44:59] <morebots>	 Logged the message, Master
[21:47:28] <jeremyb>	 actually, making an RT for that
[21:50:45] <jeremyb>	 ok, RT made. on second thought, best guess is it was a relevant record at one point and then the IP was returned to their pool and someone else got the IP
[21:54:52] <LeslieCarr>	 jeremyb: getting that
[21:56:23] <jeremyb>	 LeslieCarr: danke!
[22:02:21] <LeslieCarr>	 jeremyb: all gone
[22:13:01] <jeremyb>	 LeslieCarr: yay! replied to him
[23:12:27] <plugwash_>	 anyone else seeing problems accessing wikimedia sites over IPv6?
[23:13:35] <LeslieCarr>	 plugwash_: ironically the office doesn't have ipv6 enabled -- can you pm me your source ip and a traceroute ?
[23:17:31] <paravoid>	 I'm still here and have native IPv6
[23:17:43] <paravoid>	 works for me
[23:43:33] <LeslieCarr>	 fyi there are some network issues with one of our ipv6 carriers, so as soon as those are fixed, we shouldn't see any issues with european ipv6 connectivity
[23:44:00] <paravoid>	 LeslieCarr: maybe !log?
[23:44:47] <LeslieCarr>	 good idea paravoid
[23:49:31] <RoanKattouw>	 LeslieCarr: FYI !log works here too
[23:49:43] <LeslieCarr>	 yeah but i just by default use it in -operations
[23:49:52] <LeslieCarr>	 because.. um… i do
[23:50:03] <AaronSchulz>	 RoanKattouw: I didn't expect you to review the DB stuff, lol
[23:50:18] <AaronSchulz>	 anyway I made comments on two of those patches
[23:51:13] <RoanKattouw>	 OK
[23:59:53] <RoanKattouw>	 AaronSchulz: Yeah sorry if my review comments weren't clearer