[00:06:06] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10TechCom, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Legoktm) I haven't fully reviewed the technical implications of `@`, but as the original creator of at-ease, I fully support replacing it with a PHP lan... [00:11:21] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10Developer Productivity: ASCI escape codes shown literally in Jenkins build output - https://phabricator.wikimedia.org/T254408 (10Jdforrester-WMF) We're currently running 0.6.3; if 0.7.1 with the fix gets released soon, upgrading isn't hard. [00:11:42] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Developer Productivity, 10Jenkins: ASCI escape codes shown literally in Jenkins build output - https://phabricator.wikimedia.org/T254408 (10Jdforrester-WMF) [00:21:55] Yippee, build fixed! [00:21:56] Project beta-update-databases-eqiad build #42619: 09FIXED in 1 min 54 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/42619/ [00:36:42] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.35 deployment blockers - https://phabricator.wikimedia.org/T253023 (10Reedy) [02:16:03] Project mediawiki-core-doxygen-docker build #16353: 04FAILURE in 11 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16353/ [03:15:17] Yippee, build fixed! [03:15:17] Project mediawiki-core-doxygen-docker build #16354: 09FIXED in 10 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16354/ [03:53:36] PROBLEM - Free space - all mounts on deployment-logstash2 is CRITICAL: CRITICAL: deployment-prep.deployment-logstash2.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-logstash2.diskspace._var_lib_elasticsearch.byte_percentfree (No valid datapoints found)deployment-prep.deployment-logstash2.diskspace.root.byte_percentfree (<100.00%) [06:42:46] Project beta-scap-eqiad build #303120: 04FAILURE in 7 min 53 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/303120/ [06:49:56] Project beta-scap-eqiad build #303121: 04STILL FAILING in 5 min 25 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/303121/ [06:59:56] Yippee, build fixed! [06:59:57] Project beta-scap-eqiad build #303122: 09FIXED in 5 min 27 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/303122/ [07:11:02] good morning [07:12:04] o/ [07:40:51] 10Phabricator: Limit mass-adding subscribers on Phabricator - https://phabricator.wikimedia.org/T254409 (10Aklapper) 05Open→03Stalled @Yair_rand: This lacks a clear rationale... What is [the actual problem](https://meta.stackexchange.com/questions/66377/what-is-the-xy-problem#answer-66378) to solve? Where ex... [08:03:58] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Developer Productivity, 10Jenkins: ASCI escape codes shown literally in Jenkins build output - https://phabricator.wikimedia.org/T254408 (10hashar) I had the plugin updated on May 6th from 0.6.2 t... [08:22:04] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Developer Productivity, 10Jenkins: ASCI escape codes shown literally in Jenkins build output - https://phabricator.wikimedia.org/T254408 (10hashar) From stylelint 7.6.0 changelog: > Fixed: the `st... [08:22:35] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, 10Jenkins: ASCI escape codes shown literally in Jenkins build output - https://phabricator.wikimedia.org/T254408 (10hashar) p:... [08:22:45] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, 10Jenkins: ASCI escape codes shown literally in Jenkins build output - https://phabricator.wikimedia.org/T254408 (10hashar) a:... [08:35:08] 10Phabricator: Determine policy for Phabricator multi-factor authentication reset requests - https://phabricator.wikimedia.org/T85706 (10Mvolz) >>! In T85706#5003286, @Aklapper wrote: >>>! In T85706#1805699, @Aklapper wrote: >> Reopning as the current policy at https://www.mediawiki.org/wiki/Phabricator/Help/Two... [08:50:47] RhinosF1: still around? ;) [08:50:55] I am looking at ZppixBot [08:53:14] ah thx [08:53:19] I'm here [08:53:28] * RhinosF1 is goofing around with a new logo [08:54:29] so in short [08:54:36] we can start adding 'stylelint' to lint the css file [08:54:44] and I can make CI to run 'npm test' on the repo ;) [08:54:51] ok [08:55:44] is there any basic html check? [08:56:59] RhinosF1: http://validator.w3.org/ [08:57:12] mutante: that CI can run [08:57:48] https://validator.w3.org/docs/install.html [08:58:20] that could work [08:58:32] and surprisingly it passes on the new index page [08:58:41] ;) [08:58:49] RhinosF1: https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602292 Add stylelint to lint the css file [08:58:58] I am configuring CI now and we can have it run against that change [08:59:28] hashar: great! [08:59:47] * RhinosF1 hopes it passes on the open change as that is the new website [09:03:28] RhinosF1: so my change above just sets the basics and fix a few errors [09:03:42] ok, what next? [09:03:42] https://gerrit.wikimedia.org/r/#/c/integration/config/+/602296 is the magic CI config [09:03:50] just going to merge that and deploy the CI config [09:04:03] then we can trigger CI on the https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602292 [09:04:07] ty [09:07:06] deployed [09:07:29] the bots are dead bah [09:08:14] huh? [09:08:35] RhinosF1: https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602292/ it works ;] [09:08:51] yey! [09:09:21] hashar: is there any check for the html as well? I'm happy to C+2 that though and we revoke submit from non-CI [09:09:25] I have just followed their tutorial: https://github.com/stylelint/stylelint/blob/HEAD/docs/user-guide/get-started.md [09:09:28] for HTML well [09:09:31] I don't know ;] [09:09:45] mutante mentioned https://validator.w3.org/docs/install.html [09:15:06] hashar: am I good to +2 your change? [09:16:02] hashar: you mean wikibugs' down? [09:16:12] I can restart it if needed [09:19:56] hauskatze: yeah wikibugs looks dead indeed :/ [09:20:11] RhinosF1: probably yes ;) stylelint looks fine [09:21:01] hashar: +2'd, once jenkins submits fine, we can revoke submit from non-CI [09:21:35] 10Release-Engineering-Team, 10Operations, 10SRE-tools, 10Patch-For-Review: Support running puppet Beaker on CI - https://phabricator.wikimedia.org/T253635 (10Dzahn) p:05Triage→03Medium [09:21:47] yeah, that worked [09:23:01] RhinosF1: and for htmllint https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602300 [09:23:16] the npm package is https://www.npmjs.com/package/htmllint [09:23:28] unforutnately the cli utility is a bit out of date ( https://github.com/htmllint/htmllint-cli ) [09:23:51] local .htmllintrc file not found (you can create one using "htmllint init") [09:24:11] ah [09:24:14] forgot to add it haha [09:24:45] it has a ton of settings though [09:25:12] ok [09:28:23] RhinosF1: https://integration.wikimedia.org/ci/job/labs-tools-ZppixBot-node10-docker/5/console ;) [09:28:40] some should probably be fixed [09:28:53] * RhinosF1 facepalms [09:28:57] and some others rules you might want to ignore them [09:29:04] by changing the setting in .htmllintrc [09:29:19] hashar: what happens on https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602138/ [09:29:23] for example "tag is not closed" probably needs a fix ;) [09:29:58] RhinosF1: for https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602138/ , just comment in Gerrit "recheck" [09:30:01] and that will trigger CI [09:30:04] (well should) [09:30:34] * RhinosF1 wonders why gerrit won't rebase it [09:30:47] it needs a ignore conflicts option [09:31:25] we'll see what happens but it'll need rebasing [09:32:07] "Please rebase" [09:35:28] hauskatze: has the wikibugs restart happened? [09:35:44] I am on it [09:35:49] thank you! [09:36:12] I use a different pc with unix for this kind of stuff [09:41:45] hashar: can you rebase https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602138/ for me? [09:41:53] yeah [09:42:00] * RhinosF1 thinks if that passes he might just add html checks after that [09:42:18] oh [09:42:35] RhinosF1: try the rebase button in Gerrit maybe? [09:42:45] hashar: conflicts [09:43:17] ^ it's me restarting [09:43:42] RhinosF1: ah yeah fixing [09:44:18] ty [09:45:17] RhinosF1: I have rebased https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602303 [09:45:24] there are a bunch of css issues being reported [09:46:44] mutante / hashar : bot restarted [09:46:44] hashar: I'll get someone to fix them! [09:47:02] hashar: could we get the html checks to run on that too? [09:47:30] * RhinosF1 wants to just fix them as part of the big re-design [09:49:57] hauskatze: thank you! [09:50:47] RhinosF1: the patch to run the html checks is still open for review [09:50:54] once it is merged, it will be run for any future changes [09:51:26] hashar: could you please approve https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/chameleon/+/602305/ ? [09:51:28] hauskatze: thanks :) [09:51:43] they set the wrong perms on creation [09:51:47] hashar: I might just submit that failing and then fix them separately in the redesign [09:51:58] yes, that seems less time consuming [09:53:25] {{done}} [09:54:09] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, and 2 others: Update Doxygen to 1.8.18 - https://phabricator.wikimedia.org/T253793 (10Dzahn) a:03Dzahn [09:54:24] 10Continuous-Integration-Config, 10Tool-Zppixbot, 10Patch-For-Review: Add CI tests for labs/tools/zppixbot - https://phabricator.wikimedia.org/T254393 (10RhinosF1) [09:55:15] hashar: is that running fine on https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602303/ now then? [09:55:20] * RhinosF1 merged your patch [09:56:12] 10Continuous-Integration-Config, 10Tool-Zppixbot, 10Patch-For-Review: Add CI tests for labs/tools/zppixbot - https://phabricator.wikimedia.org/T254393 (10RhinosF1) a:03hashar html+css checks deployed and unsurprisingly failing - merged so we can fix in the re-design. [09:56:35] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, and 2 others: Update Doxygen to 1.8.18 - https://phabricator.wikimedia.org/T253793 (10Dzahn) package was built on deneb (docs = joe's bash_hi... [09:58:33] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10TechCom, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Ladsgroup) My two cents: - Has any sort of profiling done on `@` and AtEase, one might be quite faster. We should check. - I'm always supportive of re... [10:03:00] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10TechCom, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Tgr) >>! In T253461#6191082, @Legoktm wrote: > Having tried to do this in the past with some documentation rules, having PHPCS rules that people are sup... [10:09:16] hashar: if you're happy with, https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602303/ is running properly. We can pull submit access from non-ci. [10:11:49] https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602316/ [10:17:21] 10Continuous-Integration-Config, 10Tool-Zppixbot, 10Patch-For-Review, 10User-RhinosF1: Add CI tests for labs/tools/zppixbot - https://phabricator.wikimedia.org/T254393 (10RhinosF1) [10:19:32] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, 10Doxygen: Update Doxygen to 1.8.18 - https://phabricator.wikimedia.org/T253793 (10Dzahn) `Cannot find file './doxygen-latex_1.8.18-1~exp1~... [10:21:41] 10Continuous-Integration-Config, 10Tool-Zppixbot, 10Patch-For-Review, 10User-RhinosF1: Add CI tests for labs/tools/zppixbot - https://phabricator.wikimedia.org/T254393 (10RhinosF1) [10:25:24] hashar, mutante: wikibugs still refuses to report gerrit events to IRC. I've filed a task [10:25:34] :-\ [10:25:58] I'll see if I can contact with Mr. van Deen [10:26:20] * RhinosF1 thinks https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602322/2/.stylelintrc.json should fix most of the CI stuff [10:26:22] hashar: ^ [10:26:46] nope [10:26:55] hauskatze: I am not even in the wikibugs group :/ [10:27:37] hashar: I apparently don't understand Json according to https://integration.wikimedia.org/ci/job/labs-tools-ZppixBot-node10-docker/13/console [10:29:01] hehe [10:29:32] 10Continuous-Integration-Config, 10Tool-Zppixbot, 10Patch-For-Review, 10User-RhinosF1: Add CI tests for labs/tools/zppixbot - https://phabricator.wikimedia.org/T254393 (10RhinosF1) I've done https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602322/2/.stylelintrc.json to stop it running on the upstre... [10:29:58] RhinosF1: that stylelintrc change should be made in the change that adds Font-Awesome https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602303/ [10:30:08] the json is invalid cause it is missing a comma [10:30:15] ah [10:30:16] and well hmm [10:30:23] you did: [10:30:39] { ... } { "ignoreFiles": ... } [10:30:42] which are two blocks [10:31:42] hashar: https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602303/2/.stylelintrc.jso [10:32:13] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, 10Doxygen: Update Doxygen to 1.8.18 - https://phabricator.wikimedia.org/T253793 (10Dzahn) ` [apt1001:~] $ sudo -i reprepro ls doxygen doxyg... [10:33:02] hashar: I still broke it, https://integration.wikimedia.org/ci/job/labs-tools-ZppixBot-node10-docker/14/console [10:36:27] * RhinosF1 tries PS3 [10:38:54] hashar: based on https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602303/3..4, I didn't do it right [10:39:22] https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602303/2..4 even [10:42:06] * RhinosF1 lunch [10:47:35] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, 10Doxygen: Update Doxygen to 1.8.18 - https://phabricator.wikimedia.org/T253793 (10Dzahn) a:05Dzahn→03None ` [apt1001:~] $ sudo -E repr... [10:48:05] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, 10Doxygen: Update Doxygen to 1.8.18 - https://phabricator.wikimedia.org/T253793 (10Dzahn) a:03Dzahn [10:48:55] (03PS1) 10Jcrespo: Add transferpy new repo to tox-based automated CI [integration/config] - 10https://gerrit.wikimedia.org/r/602333 (https://phabricator.wikimedia.org/T248256) [10:49:48] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, 10Doxygen: Update Doxygen to 1.8.18 - https://phabricator.wikimedia.org/T253793 (10Dzahn) 05Open→03Resolved [10:49:51] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, and 2 others: mwext-doxygen-publish fails: corrupted size vs. prev_size - https://phabricator.wikimedia.org/T253723 (10Dzahn) [10:51:02] (03CR) 10Jcrespo: "https://gerrit.wikimedia.org/r/c/integration/config/+/598492 will have to be moved to transfer.py, but I would like to see CI working for " [integration/config] - 10https://gerrit.wikimedia.org/r/602333 (https://phabricator.wikimedia.org/T248256) (owner: 10Jcrespo) [11:00:13] PROBLEM - English Wikipedia Mobile Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [11:00:52] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [11:02:44] hashar: /me will look after lunch [11:03:56] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-07 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [11:04:47] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, 10Doxygen: Update Doxygen to 1.8.18 - https://phabricator.wikimedia.org/T253793 (10hashar) 05Resolved→03Open [11:04:51] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, and 2 others: mwext-doxygen-publish fails: corrupted size vs. prev_size - https://phabricator.wikimedia.org/T253723 (10hashar) [11:05:05] RECOVERY - English Wikipedia Mobile Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 60922 bytes in 1.051 second response time [11:05:44] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 96288 bytes in 1.121 second response time [11:07:35] (03PS1) 10Hashar: dockerfiles: rebuild for Doxygen 1.8.18 [integration/config] - 10https://gerrit.wikimedia.org/r/602337 (https://phabricator.wikimedia.org/T253793) [11:08:49] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-07 is OK: HTTP OK: HTTP/1.1 200 OK - 95991 bytes in 1.198 second response time [11:09:40] (03PS1) 10Hashar: jjb: update to Doxygen 1.8.18 [integration/config] - 10https://gerrit.wikimedia.org/r/602338 (https://phabricator.wikimedia.org/T253723) [11:10:22] hauskatze: looks like it is back thanks ;) [11:10:41] hashar: thanks to legoktm [11:10:50] (03CR) 10Hashar: [C: 03+2] dockerfiles: rebuild for Doxygen 1.8.18 [integration/config] - 10https://gerrit.wikimedia.org/r/602337 (https://phabricator.wikimedia.org/T253793) (owner: 10Hashar) [11:11:16] hashar: by the way, it looks there's no deployer for SWAT... Wondering if you'd be available? [11:11:34] yeah [11:11:48] There's just one patch and very simple [11:11:50] (03Merged) 10jenkins-bot: dockerfiles: rebuild for Doxygen 1.8.18 [integration/config] - 10https://gerrit.wikimedia.org/r/602337 (https://phabricator.wikimedia.org/T253793) (owner: 10Hashar) [11:17:53] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Make test pipline vote Verified+1 instead of +2 to avoid unintentional submit - https://phabricator.wikimedia.org/T226123 (10hashar) To retain the quick blue CR+2, w... [11:21:33] !log Built docker-registry.discovery.wmnet/releng/doxygen:0.8.0 # T253793 [11:21:36] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [11:21:36] T253793: Update Doxygen to 1.8.18 - https://phabricator.wikimedia.org/T253793 [11:23:05] (03CR) 10Hashar: [C: 03+2] "INFO:jenkins_jobs.builder:Reconfiguring jenkins job mediawiki-core-doxygen-docker" [integration/config] - 10https://gerrit.wikimedia.org/r/602338 (https://phabricator.wikimedia.org/T253723) (owner: 10Hashar) [11:24:14] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, and 2 others: mwext-doxygen-publish fails: corrupted size vs. prev_size - https://phabricator.wikimedia.org/T253723 (10hashar) [11:24:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, and 2 others: Update Doxygen to 1.8.18 - https://phabricator.wikimedia.org/T253793 (10hashar) 05Open→03Resolved a:05Dzahn→03hashar Co... [11:24:15] hashar: https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602303/4..5 [11:24:18] (03Merged) 10jenkins-bot: jjb: update to Doxygen 1.8.18 [integration/config] - 10https://gerrit.wikimedia.org/r/602338 (https://phabricator.wikimedia.org/T253723) (owner: 10Hashar) [11:24:31] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, and 2 others: mwext-doxygen-publish fails: corrupted size vs. prev_size - https://phabricator.wikimedia.org/T253723 (10hashar) I have switched the Jenki... [11:25:19] RhinosF1: yeah so I tried and .stylelintignore makes it WAY faster [11:26:13] hashar: does that patch work though? 12:24:44 public_html/Font-Awesome/css/all.css from the jenkins log shows no [11:26:21] it's not ignoring [11:28:39] * RhinosF1 looks and tries PS6 [11:29:20] yeah wrong dir name [11:29:52] RhinosF1: public_html/Fonts-Awesome/ [11:29:58] but you can try th ecommand locally with: [11:30:05] git submodule update [11:30:08] git submodule update --init [11:30:10] npm install [11:30:11] npm test [11:30:13] ;) [11:30:28] hashar: oooooh, I didn't know that - PS7 uploaded [11:31:29] that is the idea [11:31:37] the CI jobs usually just invoke stuff that is the repo [11:31:47] hashar: that's worked! I don't see the html checks though run. [11:31:52] so that developers can more or less run them "easily" on their machines [11:31:54] https://integration.wikimedia.org/ci/job/labs-tools-ZppixBot-node10-docker/19/console [11:31:54] heheh [11:32:06] gotta then fix all the reported issues [11:32:19] or slightly change the rules that are provided :) [11:32:34] such as stylelint complaining about #eeeeeee which should be #eee [11:32:43] i guess it is up to you to enforce it or not [11:32:45] hashar: We'll work on that. Are they html-lint checks running? [11:32:51] s/they/the [11:33:38] it looks in the logs like it stops and doesn't run because stylelint fails, correct? [11:35:11] yeah [11:35:24] great! I can't try and make it pass now! [11:35:29] Thanks for the help [11:35:32] npm run stylelint && npm run htmllint [11:35:38] which means run "stylelint" [11:35:55] && is a boolean AND operator [11:36:06] i see [11:36:09] so if stylelint is false we now that false && will always be false [11:36:18] and the second part to run htlmlint is not executed [11:36:32] cause whatever the result of htmllint is, stylelint failed already ;) [11:36:50] got ya [11:36:51] so in human language: run stylelint, and if it passed, run htmllint [11:36:53] ;) [11:37:32] :) [11:38:01] hashar: and I assume I got https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602316/ correct? [11:41:12] as in that on merge will mean only CI can actually merge the change [11:43:17] 10Continuous-Integration-Config, 10Tool-Zppixbot, 10Patch-For-Review, 10User-RhinosF1: Add CI tests for labs/tools/zppixbot - https://phabricator.wikimedia.org/T254393 (10RhinosF1) >>! In T254393#6192145, @RhinosF1 wrote: > I've done https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602303/ to stop... [11:44:48] (03CR) 10Hashar: Switch to CI-Only push access (031 comment) [labs/tools/ZppixBot] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/602316 (https://phabricator.wikimedia.org/T254393) (owner: 10RhinosF1) [11:45:31] RhinosF1: jenkinsbot does not git push anything ;) It just submit the change in gerrit ( example: https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602301/ ) [11:46:04] (03PS3) 10RhinosF1: Switch to CI-Only push access [labs/tools/ZppixBot] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/602316 (https://phabricator.wikimedia.org/T254393) [11:46:16] hashar: so https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602316/3/project.config [11:54:46] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, and 2 others: Update Doxygen to 1.8.18 - https://phabricator.wikimedia.org/T253793 (10Pablo-WMDE) FYI a 1.8.18 build just failed for us witho... [11:55:39] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, 10Regression: mwext-doxygen-publish Doxygen 1.8.18 fails for Wikibase.git - https://phabricator.wikimedia.org/T254465 (10hashar) [11:56:39] (03PS1) 10Hashar: jjb: rollback mwext-doxygen-publish to Doxygen 1.8.16 [integration/config] - 10https://gerrit.wikimedia.org/r/602345 (https://phabricator.wikimedia.org/T254465) [11:57:01] (03CR) 10Hashar: [C: 03+2] jjb: rollback mwext-doxygen-publish to Doxygen 1.8.16 [integration/config] - 10https://gerrit.wikimedia.org/r/602345 (https://phabricator.wikimedia.org/T254465) (owner: 10Hashar) [11:57:40] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, and 2 others: mwext-doxygen-publish fails: corrupted size vs. prev_size - https://phabricator.wikimedia.org/T253723 (10hashar) And it failed again. I ha... [11:58:05] (03Merged) 10jenkins-bot: jjb: rollback mwext-doxygen-publish to Doxygen 1.8.16 [integration/config] - 10https://gerrit.wikimedia.org/r/602345 (https://phabricator.wikimedia.org/T254465) (owner: 10Hashar) [12:01:14] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, and 2 others: mwext-doxygen-publish Doxygen 1.8.18 fails for Wikibase.git - https://phabricator.wikimedia.org/T254465 (10Lucas_Werkmeister_WMDE) [12:02:33] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, and 2 others: mwext-doxygen-publish Doxygen 1.8.18 fails for Wikibase.git - https://phabricator.wikimedia.org/T254465 (10hashar) [12:14:32] hashar: is https://gerrit.wikimedia.org/r/#/c/602316/ good to merge? [12:14:54] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, 10Regression: mwext-doxygen-publish Doxygen 1.8.18 fails for Wikibase.git - https://phabricator.wikimedia.org/T254465 (10hashar) One that fails on `Pa... [12:23:51] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, 10Regression: mwext-doxygen-publish Doxygen 1.8.18 fails for Wikibase.git - https://phabricator.wikimedia.org/T254465 (10hashar) Another example choki... [12:29:43] (03CR) 10Hashar: [V: 03+2 C: 03+2] Switch to CI-Only push access [labs/tools/ZppixBot] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/602316 (https://phabricator.wikimedia.org/T254393) (owner: 10RhinosF1) [12:29:52] RhinosF1: yeah ;) [12:30:39] 10Continuous-Integration-Config, 10Tool-Zppixbot, 10Patch-For-Review, 10User-RhinosF1: Add CI tests for labs/tools/zppixbot - https://phabricator.wikimedia.org/T254393 (10RhinosF1) 05Open→03Resolved [12:41:14] RhinosF1: you are welcome [12:41:27] :) [12:43:34] (03CR) 10Hashar: [C: 03+2] Add transferpy new repo to tox-based automated CI [integration/config] - 10https://gerrit.wikimedia.org/r/602333 (https://phabricator.wikimedia.org/T248256) (owner: 10Jcrespo) [12:44:01] (03CR) 10Jcrespo: "yay!!!!" [integration/config] - 10https://gerrit.wikimedia.org/r/602333 (https://phabricator.wikimedia.org/T248256) (owner: 10Jcrespo) [12:44:40] (03Merged) 10jenkins-bot: Add transferpy new repo to tox-based automated CI [integration/config] - 10https://gerrit.wikimedia.org/r/602333 (https://phabricator.wikimedia.org/T248256) (owner: 10Jcrespo) [13:13:03] hashar: a very bad puppet thing has happened. Prod patch absented the labs/private repo everywhere. It was reverted, but that made a clean clone. So all local patches in labs/private on every puppetmaster are gone. Not sure how much that will effect deployment-prep. [13:13:48] oh god [13:14:16] bd808: our only hope is if puppet magically file bucketted it ;D [13:14:24] hashar: first hope is to disable puppet in a project and then look for diff logs from runs [13:14:28] yeah [13:14:40] which is probably unlikely cause it is a git::clone [13:15:18] hashar: not likely to have the for the repo, but possible for the files that are changed when the secrets switched to the defaults [13:16:06] so integration puppetmaster looks still fine [13:16:10] moaybe puppet did not run there [13:16:42] bd808: and deployment-prep puppet master still has a bunch of cherry picks in private.git ;) [13:17:14] bd808: the patch has been reverted hasn't it ? [13:17:23] hashar: yes reverted [13:18:07] !log Disabled puppet on integration-puppetmaster-02 and deployment-puppetmaster04 [13:18:24] !log Backing up labs/private.git integration-puppetmaster-02 and deployment-puppetmaster04 [13:18:29] bah sal bot disappeared [13:18:40] (03PS1) 10Bartosz Dziewoński: Make DiscussionTools depend on Linter [integration/config] - 10https://gerrit.wikimedia.org/r/602365 [13:21:15] (03CR) 10Bartosz Dziewoński: "Related to T253799" [integration/config] - 10https://gerrit.wikimedia.org/r/602365 (owner: 10Bartosz Dziewoński) [13:21:48] and both puppet masters are out of sync bah [13:21:51] bd808: thank you ;) [13:25:01] bd808: luckily both of our puppetmaster are stall / need rebase [13:30:59] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Prevents labs/private to disappear from integration and deployment-prep puppet mas... - https://phabricator.wikimedia.org/T254473 [13:31:54] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Prevents labs/private to disappear from integration and deployment-prep puppet mas... - https://phabricator.wikimedia.org/T254473 [13:44:02] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Prevents labs/private to disappear from integration and deployment-prep puppet mas... - https://phabricator.wikimedia.org/T254473 [13:52:55] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Prevents labs/private to disappear from integration and deployment-prep puppet mas... - https://phabricator.wikimedia.org/T254473 [13:54:27] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Prevents labs/private to disappear from integration and deployment-prep puppet mas... - https://phabricator.wikimedia.org/T254473 [13:56:42] been super lucky [13:56:45] I am out for an hair cut [14:15:21] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10Patch-For-Review, and 4 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10WDoranWMF) [14:15:23] 10Beta-Cluster-Infrastructure, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Green), 10Patch-For-Review, and 2 others: Create new wiki on the beta cluster to test API Portal - https://phabricator.wikimedia.org/T254185 (10WDoranWMF) 05Open→03Resolved a:03WDoranWMF [14:24:18] 10Beta-Cluster-Infrastructure, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Green), 10Patch-For-Review, and 2 others: Create new wiki on the beta cluster to test API Portal - https://phabricator.wikimedia.org/T254185 (10Reedy) 05Resolved→03Open a:05WDoranWMF→03None Please don't... [14:24:23] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10Patch-For-Review, and 4 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10Reedy) [14:37:24] (03CR) 10Hashar: [C: 03+2] Add User:Sohom_data GSoC student [integration/config] - 10https://gerrit.wikimedia.org/r/602275 (https://phabricator.wikimedia.org/T247157) (owner: 10Samwilson) [14:37:52] (03CR) 10Hashar: [C: 03+2] Make DiscussionTools depend on Linter [integration/config] - 10https://gerrit.wikimedia.org/r/602365 (owner: 10Bartosz Dziewoński) [14:38:25] (03Merged) 10jenkins-bot: Add User:Sohom_data GSoC student [integration/config] - 10https://gerrit.wikimedia.org/r/602275 (https://phabricator.wikimedia.org/T247157) (owner: 10Samwilson) [14:39:04] (03Merged) 10jenkins-bot: Make DiscussionTools depend on Linter [integration/config] - 10https://gerrit.wikimedia.org/r/602365 (owner: 10Bartosz Dziewoński) [14:43:40] (03CR) 10Hashar: "The repository description states it is read only and development is on github. So I guess we should just archive it?" [skins/chameleon] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/602305 (owner: 10MarcoAurelio) [14:46:20] (03CR) 10Hashar: [C: 03+2] "Deployed!" [integration/config] - 10https://gerrit.wikimedia.org/r/602365 (owner: 10Bartosz Dziewoński) [15:18:25] Project mediawiki-core-doxygen-docker build #16366: 04FAILURE in 13 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16366/ [15:21:54] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Prevents labs/private to disappear from integration and deployment-prep puppet mas... - https://phabricator.wikimedia.org/T254473 [15:44:53] (03PS1) 10Hashar: Revert "Wipe repo with non-git commands" [integration/quibble] - 10https://gerrit.wikimedia.org/r/602402 (https://phabricator.wikimedia.org/T211702) [15:44:55] (03PS1) 10Hashar: Revert "Clone only the target project at first" [integration/quibble] - 10https://gerrit.wikimedia.org/r/602403 (https://phabricator.wikimedia.org/T211702) [15:44:57] (03PS1) 10Hashar: Revert "Drop --dry-run parameter" [integration/quibble] - 10https://gerrit.wikimedia.org/r/602404 [15:44:59] (03PS1) 10Hashar: Do not create log directory when building the plan [integration/quibble] - 10https://gerrit.wikimedia.org/r/602405 [15:45:59] (03CR) 10jerkins-bot: [V: 04-1] Do not create log directory when building the plan [integration/quibble] - 10https://gerrit.wikimedia.org/r/602405 (owner: 10Hashar) [15:47:09] (03CR) 10Hashar: Do not create log directory when building the plan (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/602405 (owner: 10Hashar) [15:50:50] (03PS2) 10Hashar: Do not create log directory when building the plan [integration/quibble] - 10https://gerrit.wikimedia.org/r/602405 [16:00:47] (03CR) 10Bartosz Dziewoński: "Thanks :o" [integration/config] - 10https://gerrit.wikimedia.org/r/602365 (owner: 10Bartosz Dziewoński) [16:01:42] (03CR) 10Hashar: "I really dislike reverting changes. The use of rm / rmdir is a bit too fragile, git clean just restore things." [integration/quibble] - 10https://gerrit.wikimedia.org/r/602402 (https://phabricator.wikimedia.org/T211702) (owner: 10Hashar) [16:06:48] (03CR) 10Hashar: "I am ashamed to have to revert this change given the feature speed up the execution. Then it causes a few issues and is a bit funky. The" [integration/quibble] - 10https://gerrit.wikimedia.org/r/602403 (https://phabricator.wikimedia.org/T211702) (owner: 10Hashar) [16:06:59] 10Beta-Cluster-Infrastructure, 10Analytics, 10Analytics-EventLogging, 10Wikimedia-production-error: [beta] EventLogging trying to fetch wrong Schema title - https://phabricator.wikimedia.org/T254058 (10Milimetric) p:05Triage→03Low [16:07:19] 10Beta-Cluster-Infrastructure, 10Analytics, 10Analytics-EventLogging, 10Analytics-Kanban, 10Wikimedia-production-error: [beta] EventLogging trying to fetch wrong Schema title - https://phabricator.wikimedia.org/T254058 (10Milimetric) [16:07:24] 10Project-Admins: Create project CatTalk - https://phabricator.wikimedia.org/T254497 (10Naypta) [16:08:21] (03CR) 10Hashar: "The reason for removing the feature was:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/602404 (owner: 10Hashar) [16:08:50] (03CR) 10Jforrester: [C: 03+2] "I proposed this at I53d6af53 of course. Sad that this seems needed." [integration/quibble] - 10https://gerrit.wikimedia.org/r/602402 (https://phabricator.wikimedia.org/T211702) (owner: 10Hashar) [16:09:32] (03CR) 10Jforrester: [C: 03+2] Revert "Clone only the target project at first" [integration/quibble] - 10https://gerrit.wikimedia.org/r/602403 (https://phabricator.wikimedia.org/T211702) (owner: 10Hashar) [16:09:49] (03CR) 10Jforrester: [C: 03+2] Revert "Drop --dry-run parameter" [integration/quibble] - 10https://gerrit.wikimedia.org/r/602404 (owner: 10Hashar) [16:10:40] (03CR) 10Jforrester: [C: 03+2] Do not create log directory when building the plan [integration/quibble] - 10https://gerrit.wikimedia.org/r/602405 (owner: 10Hashar) [16:10:44] (03Merged) 10jenkins-bot: Revert "Wipe repo with non-git commands" [integration/quibble] - 10https://gerrit.wikimedia.org/r/602402 (https://phabricator.wikimedia.org/T211702) (owner: 10Hashar) [16:10:48] (03CR) 10Hashar: "This change is not strictly needed, I just find it odd to invoke mkdir when generating the list of commands to execute. The intent is th" [integration/quibble] - 10https://gerrit.wikimedia.org/r/602405 (owner: 10Hashar) [16:11:14] (03Merged) 10jenkins-bot: Revert "Clone only the target project at first" [integration/quibble] - 10https://gerrit.wikimedia.org/r/602403 (https://phabricator.wikimedia.org/T211702) (owner: 10Hashar) [16:11:36] (03Merged) 10jenkins-bot: Revert "Drop --dry-run parameter" [integration/quibble] - 10https://gerrit.wikimedia.org/r/602404 (owner: 10Hashar) [16:11:44] James_F: hard call :^\ I hate reverting things [16:11:57] Yippee, build fixed! [16:11:57] Project mediawiki-core-doxygen-docker build #16367: 09FIXED in 7 min 7 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16367/ [16:12:10] hashar: Yeah, I do too. :-( [16:12:13] I have looked at a few other pending patches and eventually I dediced the end result was too much monkey patching and we should revisit the implementaion of the feature [16:12:52] I wanna add a bunch of tests for the build plan generation [16:13:09] so that the tests more or less define what we intend [16:13:41] (03Merged) 10jenkins-bot: Do not create log directory when building the plan [integration/quibble] - 10https://gerrit.wikimedia.org/r/602405 (owner: 10Hashar) [16:15:41] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Puppet, 10User-brennen: logspam-watch: Add interactive sorting / filtering - https://phabricator.wikimedia.org/T242882 (10brennen) 05Open→03Resolved Tested and generally available on mwlog1001. [16:18:15] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quibble, 10Patch-For-Review: Quibble initialize step should only clone the target repository - https://phabricator.wikimedia.org/T211702 (10hashar) @awight I have reviewed the changes as well as... [16:18:35] James_F: and i havent looked whether there are any open changes worth merging now for the next release [16:18:55] There probably aren't. Shall we just cut the release to get back to known-good anyway? [16:24:24] Project mediawiki-core-doxygen-docker build #16368: 04FAILURE in 12 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16368/ [16:31:23] hashar: Time for weekly triage? [16:32:06] +1 on cutting a new release as is [16:32:11] though I haven't updated the changelog [16:32:33] I can do that. [16:36:34] (03PS1) 10Reedy: Add basic CI for Expressions extension [integration/config] - 10https://gerrit.wikimedia.org/r/602424 [16:36:36] (03PS1) 10Reedy: Whitelist Xxmarijnw for CI [integration/config] - 10https://gerrit.wikimedia.org/r/602425 [16:36:41] Am I ok to deploy both of those? [16:40:51] 10Continuous-Integration-Infrastructure, 10Operations, 10serviceops: replace backends for releases.wikimedia.org with buster VMs - https://phabricator.wikimedia.org/T247652 (10Jdforrester-WMF) [16:44:29] (03CR) 10Reedy: [C: 03+2] Add basic CI for Expressions extension [integration/config] - 10https://gerrit.wikimedia.org/r/602424 (owner: 10Reedy) [16:44:33] (03CR) 10Reedy: [C: 03+2] Whitelist Xxmarijnw for CI [integration/config] - 10https://gerrit.wikimedia.org/r/602425 (owner: 10Reedy) [16:45:41] (03Merged) 10jenkins-bot: Add basic CI for Expressions extension [integration/config] - 10https://gerrit.wikimedia.org/r/602424 (owner: 10Reedy) [16:45:48] (03Merged) 10jenkins-bot: Whitelist Xxmarijnw for CI [integration/config] - 10https://gerrit.wikimedia.org/r/602425 (owner: 10Reedy) [16:46:57] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/602424 https://gerrit.wikimedia.org/r/602425 [16:46:59] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:16:20] Project mediawiki-core-doxygen-docker build #16369: 04STILL FAILING in 11 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16369/ [17:18:40] 10Project-Admins: Create project CatTalk - https://phabricator.wikimedia.org/T254497 (10Aklapper) Hi @Naypta, is there any further information existing somewhere that you could link to, or code? [17:22:45] 10Project-Admins: Create project CatTalk - https://phabricator.wikimedia.org/T254497 (10Naypta) Hi, of course! I've created an extension page over here: https://www.mediawiki.org/wiki/Extension:CatTalk As to code, I'm waiting on a Gerrit repo being created - once that's done, it'll be linked too :) C... [17:45:51] (03PS1) 10Reedy: Whitelist another email for Xxmarijnw [integration/config] - 10https://gerrit.wikimedia.org/r/602435 [17:46:06] (03CR) 10Reedy: [C: 03+2] Whitelist another email for Xxmarijnw [integration/config] - 10https://gerrit.wikimedia.org/r/602435 (owner: 10Reedy) [17:47:11] (03Merged) 10jenkins-bot: Whitelist another email for Xxmarijnw [integration/config] - 10https://gerrit.wikimedia.org/r/602435 (owner: 10Reedy) [17:47:58] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/602435 [17:47:59] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:15:59] Yippee, build fixed! [18:15:59] Project mediawiki-core-doxygen-docker build #16370: 09FIXED in 11 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16370/ [19:09:08] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.35 deployment blockers - https://phabricator.wikimedia.org/T253023 (10Jdforrester-WMF) 05Open→03Resolved Fully deployed. [19:14:59] (03CR) 10MarcoAurelio: "The repo seems to be ahead of https://github.com/ProfessionalWiki/chameleon/commits/master by 7 commits. The description says that they're" [skins/chameleon] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/602305 (owner: 10MarcoAurelio) [19:17:39] (03CR) 10MarcoAurelio: "Looks like the inheritance was removed at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/chameleon/+/47f4d30dacffff4d40e6c" [skins/chameleon] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/602305 (owner: 10MarcoAurelio) [19:23:09] (03Abandoned) 10MarcoAurelio: Inherit permissions from mediawiki/skins [skins/chameleon] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/602305 (owner: 10MarcoAurelio) [19:57:09] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) [20:07:19] 10Gerrit, 10DBA: Get a writable reviewdb clone to test Gerrit upgrade with - https://phabricator.wikimedia.org/T254516 (10hashar) [20:07:57] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) >>! In T254158#6184685, @Dzahn wrote: > Shouldn't we be using (renaming) T200739 instead so we don't lose history? (see all the linked tasks there) Those tasks for the gerrit-2.16 upgrade are the reason, that I started a fresh t... [20:11:25] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) >>! In T254158#6190824, @Jdforrester-WMF wrote: > I thought we were doing T200739 and then this one. Is that not the case any more? If we update to 2.16, then 3.0, then 3.1, then 3.2 (with maybe waiting a week between updates so... [20:14:23] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Jdforrester-WMF) Right, that makes sense. In that case, we should mark T200739 as Declined. [20:15:09] 10Gerrit: "Server error: line 1:33 no viable alternative at character '['" when visiting particular patch - https://phabricator.wikimedia.org/T223278 (10Jdforrester-WMF) [20:15:11] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Jdforrester-WMF) 05Open→03Declined We're upgrading to 3.x in {T254158}... [20:15:13] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Developer Productivity, 10User-zeljkofilipin: PolyGerrit 2.15 UI does not support custom dashboards (supported from in 2.16+) - https://phabricator.wikimedia.org/T220801 (10Jdforrester-WMF) [20:15:15] 10Gerrit: Create a plugin that add's recheck as a button to PolyGerrit's ui - https://phabricator.wikimedia.org/T214631 (10Jdforrester-WMF) [20:15:17] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops: Deploy multi-site plugin to gerrit1001 and gerrit2001 - https://phabricator.wikimedia.org/T217174 (10Jdforrester-WMF) [20:15:20] 10Gerrit: context links in diff don't use pointer cursor - https://phabricator.wikimedia.org/T210515 (10Jdforrester-WMF) [20:15:24] 10Gerrit: Make a PolyGerrit plugin to welcome new users - https://phabricator.wikimedia.org/T201246 (10Jdforrester-WMF) [20:15:25] 10Gerrit: Big empty space under patch description - https://phabricator.wikimedia.org/T206453 (10Jdforrester-WMF) [20:15:27] 10Gerrit, 10Upstream: New Gerrit UI does not contain copyable Change-Id or parent commit id - https://phabricator.wikimedia.org/T195280 (10Jdforrester-WMF) [20:15:32] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, and 2 others: Display Zuul status of jobs for a change on Gerrit UI - https://phabricator.wikimedia.org/T214068 (10Jdforrester-WMF) [20:15:33] 10Gerrit, 10User-Addshore: "Included groups" do not appear in New gerrit UI - https://phabricator.wikimedia.org/T200310 (10Jdforrester-WMF) [20:18:02] 10Gerrit, 10Upstream: Polygerrit Outgoing reviews, Incoming reviews and Recently closed headings should be more different from commits - https://phabricator.wikimedia.org/T186406 (10Paladox) [20:18:04] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Paladox) [20:18:10] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:18:43] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Developer Productivity, 10User-zeljkofilipin: PolyGerrit 2.15 UI does not support custom dashboards (supported from in 2.16+) - https://phabricator.wikimedia.org/T220801 (10Paladox) [20:18:45] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Paladox) [20:18:50] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:19:29] 10Gerrit: Big empty space under patch description - https://phabricator.wikimedia.org/T206453 (10Paladox) [20:19:31] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Paladox) [20:19:36] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:20:31] 10Gerrit, 10Operations, 10serviceops, 10Patch-For-Review: Convert Gerrit to use H2 as the database - https://phabricator.wikimedia.org/T211139 (10Paladox) 05Stalled→03Declined Declining as we're going straight to 3.1 so we won't be needing a db from that release. [20:20:50] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Paladox) [20:20:57] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:22:31] 10Gerrit: context links in diff don't use pointer cursor - https://phabricator.wikimedia.org/T210515 (10Paladox) [20:22:33] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Paladox) [20:22:37] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:23:12] (03PS5) 10Jforrester: layout: Drop the seccheck job from all repos with phan [integration/config] - 10https://gerrit.wikimedia.org/r/601500 (https://phabricator.wikimedia.org/T248630) [20:23:14] (03PS1) 10Jforrester: layout: [mediawiki] Drop seccheck experimental, done in phan proper [integration/config] - 10https://gerrit.wikimedia.org/r/602480 [20:23:16] (03PS1) 10Jforrester: jjb: Drop mediawiki-core-php72-phan-seccheck-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602481 [20:23:18] (03PS1) 10Jforrester: layout: Replace extension-seccheck with extension-phan where used [integration/config] - 10https://gerrit.wikimedia.org/r/602482 [20:23:20] (03PS1) 10Jforrester: jjb: Drop mw*php72-phan-seccheck-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602483 [20:23:23] (03PS1) 10Jforrester: dockerfiles: [mediawiki-phan-seccheck] Drop, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602484 [20:23:25] (03PS1) 10Jforrester: dockerfiles: [mediawiki-phan] Make jobs fail if repo is unconfigured [integration/config] - 10https://gerrit.wikimedia.org/r/602485 [20:25:00] 10Gerrit: "Server error: line 1:33 no viable alternative at character '['" when visiting particular patch - https://phabricator.wikimedia.org/T223278 (10Paladox) [20:25:03] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Paladox) [20:25:09] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:27:27] 10Gerrit, 10Upstream: Allow searching for 'state:active', 'state:read_only', 'state:hidden' via web interface - https://phabricator.wikimedia.org/T180297 (10Paladox) [20:27:29] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Paladox) [20:27:35] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:28:21] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Paladox) [20:28:30] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:28:51] 10Gerrit, 10User-Addshore: "Included groups" do not appear in New gerrit UI - https://phabricator.wikimedia.org/T200310 (10Paladox) [20:28:56] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:29:15] 10Gerrit: Gerrit upload-pack send ALL references causing massive network I/O on common operations - https://phabricator.wikimedia.org/T103990 (10Paladox) [20:29:17] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Paladox) [20:29:20] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:29:30] (03CR) 10Jforrester: [C: 03+2] layout: [mediawiki] Drop seccheck experimental, done in phan proper [integration/config] - 10https://gerrit.wikimedia.org/r/602480 (owner: 10Jforrester) [20:29:42] (03CR) 10Jforrester: [C: 03+2] jjb: Drop mediawiki-core-php72-phan-seccheck-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602481 (owner: 10Jforrester) [20:29:54] 10Gerrit, 10Upstream: New Gerrit UI does not contain copyable Change-Id or parent commit id - https://phabricator.wikimedia.org/T195280 (10Paladox) [20:29:56] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Paladox) [20:30:00] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:30:10] 10Gerrit: Make a PolyGerrit plugin to welcome new users - https://phabricator.wikimedia.org/T201246 (10Paladox) [20:30:16] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:30:18] 10Gerrit: Make a PolyGerrit plugin to welcome new users - https://phabricator.wikimedia.org/T201246 (10Paladox) p:05Triage→03Low [20:30:29] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops: Deploy multi-site plugin to gerrit1001 and gerrit2001 - https://phabricator.wikimedia.org/T217174 (10Paladox) [20:30:34] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:30:39] (03Merged) 10jenkins-bot: layout: [mediawiki] Drop seccheck experimental, done in phan proper [integration/config] - 10https://gerrit.wikimedia.org/r/602480 (owner: 10Jforrester) [20:30:40] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops: Deploy multi-site plugin to gerrit1001 and gerrit2001 - https://phabricator.wikimedia.org/T217174 (10Paladox) p:05Medium→03Low [20:30:54] (03Merged) 10jenkins-bot: jjb: Drop mediawiki-core-php72-phan-seccheck-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602481 (owner: 10Jforrester) [20:31:11] 10Release-Engineering-Team-TODO, 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), 10MW-1.35-release, and 3 others: PHP 7.2 garbage collector segfault - https://phabricator.wikimedia.org/T228346 (10cscott) > @cscott @ssastry maybe you can get a follow up task to remember to cleanup the wo... [20:31:52] !log Zuul: [mediawiki] Drop seccheck experimental, done in phan proper [20:31:54] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:32:35] 10Gerrit, 10Release-Engineering-Team-TODO, 10Documentation: Update Gerrit documentation on mediawiki.org before upgrading to Gerrit 2.16.x / PolyGerrit UI - https://phabricator.wikimedia.org/T227562 (10Paladox) [20:32:48] 10LibUp, 10phan-taint-check-plugin, 10MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), 10Patch-For-Review, and 2 others: phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10Umherirrender) 05Open→03Resolved extensions and skins are done, some libs are stalled because seccheck is failing, bu... [20:33:30] 10Gerrit, 10Release-Engineering-Team-TODO, 10Documentation: Update Gerrit Document on the User Interface (for 3.1) - https://phabricator.wikimedia.org/T227562 (10Paladox) [20:34:29] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, and 2 others: Display Zuul status of jobs for a change on Gerrit UI - https://phabricator.wikimedia.org/T214068 (10Paladox) [20:34:33] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:34:48] 10Gerrit, 10Operations, 10serviceops, 10Patch-For-Review: Convert Gerrit to use H2 as the database - https://phabricator.wikimedia.org/T211139 (10Paladox) [20:34:50] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:35:38] (03CR) 10Jforrester: [C: 03+2] "Everything that's running phan is using 0.10.x now." [integration/config] - 10https://gerrit.wikimedia.org/r/601500 (https://phabricator.wikimedia.org/T248630) (owner: 10Jforrester) [20:35:40] 10Continuous-Integration-Config, 10LibUp, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan, and 3 others: Upgrade phan to 0.10.2 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 (10Umherirrender) Some extensions only using seccheck are still open: http://libra... [20:35:46] (03CR) 10Jforrester: [C: 04-2] layout: Replace extension-seccheck with extension-phan where used [integration/config] - 10https://gerrit.wikimedia.org/r/602482 (owner: 10Jforrester) [20:36:36] 10Gerrit, 10Release-Engineering-Team-TODO, 10Documentation: Update Gerrit Document on the User Interface (for 3.1) - https://phabricator.wikimedia.org/T227562 (10Paladox) [20:36:43] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Paladox) [20:36:46] (03Merged) 10jenkins-bot: layout: Drop the seccheck job from all repos with phan [integration/config] - 10https://gerrit.wikimedia.org/r/601500 (https://phabricator.wikimedia.org/T248630) (owner: 10Jforrester) [20:37:33] !loh Zuul: Drop the seccheck job from all repos with phan T248630 [20:37:34] T248630: Upgrade phan to 0.10.2 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 [20:38:09] (03PS2) 10Thcipriani: Blubber: move expansion before verification [blubber] - 10https://gerrit.wikimedia.org/r/593315 (https://phabricator.wikimedia.org/T248927) (owner: 10DC Slagel) [20:40:32] 10Continuous-Integration-Config, 10LibUp, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan, and 3 others: Upgrade phan to 0.10.2 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 (10Jdforrester-WMF) 05Open→03Resolved Declaring this Resolved. Will continue w... [20:40:36] 10LibUp, 10phan-taint-check-plugin, 10MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), 10Patch-For-Review, and 2 others: phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10Jdforrester-WMF) [20:41:50] (03PS4) 10Jforrester: jjb: Drop mwskin-php72-phan-seccheck-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/601501 [20:42:37] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/601501 (owner: 10Jforrester) [20:43:46] (03Merged) 10jenkins-bot: jjb: Drop mwskin-php72-phan-seccheck-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/601501 (owner: 10Jforrester) [20:48:15] (03PS2) 10Jforrester: layout: Replace extension-seccheck with extension-phan where used [integration/config] - 10https://gerrit.wikimedia.org/r/602482 [20:48:17] (03PS2) 10Jforrester: jjb: Drop mwextphp72-phan-seccheck-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602483 [20:48:19] (03PS2) 10Jforrester: dockerfiles: [mediawiki-phan-seccheck] Drop, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602484 [20:48:21] (03PS2) 10Jforrester: dockerfiles: [mediawiki-phan] Make jobs fail if repo is unconfigured [integration/config] - 10https://gerrit.wikimedia.org/r/602485 [20:50:30] (03CR) 10Thcipriani: "couple of nits, deeper review incoming" (032 comments) [blubber] - 10https://gerrit.wikimedia.org/r/593315 (https://phabricator.wikimedia.org/T248927) (owner: 10DC Slagel) [20:59:55] 10phan-taint-check-plugin: ERROR: Error: Undefined constant 'ast\AST_LIST' - https://phabricator.wikimedia.org/T251346 (10cscott) This seems to be crashing Parsoid CI now? @Arlolra has details. [21:02:05] 10LibUp: libraryupgrader missed WikibaseQualityConstraints to update phan-taint-check-plugin - https://phabricator.wikimedia.org/T203331 (10Umherirrender) 05Open→03Resolved LibUp now working on that repo - last commit is https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseQualityConstraints/+/601... [21:10:22] 10phan-taint-check-plugin: ERROR: Error: Undefined constant 'ast\AST_LIST' - https://phabricator.wikimedia.org/T251346 (10Arlolra) >>! In T251346#6194362, @cscott wrote: > This seems to be crashing Parsoid CI now? @Arlolra has details. It was locally and sounds like a release is coming soon. [21:16:45] Project mediawiki-core-doxygen-docker build #16373: 04FAILURE in 12 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16373/ [21:25:54] 10Project-Admins: Create project CatTalk - https://phabricator.wikimedia.org/T254497 (10MarcoAurelio) Gerrit repository created (I'm handling the Diffusion and GitHub mirrors) [21:26:37] 10Continuous-Integration-Config, 10Tool-Zppixbot, 10User-RhinosF1: Add CI tests for labs/tools/zppixbot - https://phabricator.wikimedia.org/T254393 (10hashar) Well done @RhinosF1 ;) [21:28:02] 10Continuous-Integration-Config, 10Tool-Zppixbot, 10User-RhinosF1: Add CI tests for labs/tools/zppixbot - https://phabricator.wikimedia.org/T254393 (10RhinosF1) >>! In T254393#6194426, @hashar wrote: > Well done @RhinosF1 ;) You did the hard work, and @MacFan4000 managed to get them passing on the new site! [21:29:33] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Operations: Reimage gerrit1001 and gerrit2001 as buster - https://phabricator.wikimedia.org/T176774 (10Cmjohnson) [21:29:36] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Operations, and 2 others: Gerrit Hardware Upgrade (+ upgrade from jessie to stretch or buster) - https://phabricator.wikimedia.org/T222391 (10Cmjohnson) [21:30:17] 10Continuous-Integration-Config, 10Tool-Zppixbot, 10User-RhinosF1: Add CI tests for labs/tools/zppixbot - https://phabricator.wikimedia.org/T254393 (10hashar) Perfect! So from now on, you just have to Code-Review +2 and CI will take care of running the defined tests and ultimately get the change merged if ev... [21:32:43] 10Continuous-Integration-Config, 10Tool-Zppixbot, 10User-RhinosF1: Add CI tests for labs/tools/zppixbot - https://phabricator.wikimedia.org/T254393 (10RhinosF1) >>! In T254393#6194453, @hashar wrote: > Perfect! So from now on, you just have to Code-Review +2 and CI will take care of running the defined tests... [21:48:48] (03PS1) 10MarcoAurelio: layout: Add extension-CatTalk to zuul [integration/config] - 10https://gerrit.wikimedia.org/r/602505 [21:49:34] hashar: now I just got teach our new devs the wonders of gerrit [21:49:42] * RhinosF1 can't wait for gerrit 3.x [21:49:54] yeah that is going to improve a lot of things ;] [21:50:17] * RhinosF1 wants 2 of its feautres [21:50:20] image uploads [21:50:28] and editing patchsets from new ui [21:50:38] https://www.mediawiki.org/wiki/Gerrit has a few sections for gerrit [21:51:21] our main struggle is pushing to the right patchset [21:51:25] from cli [21:51:30] I found out pairing is very effective to pass knowledge though [21:52:13] when you send a change for review with for example: git push origin HEAD:refs/for/master [21:52:28] it's that that's been the struggle [21:52:37] gerrit look at at the target repo + the branch (from refs/for/master) + the Change-Id meta header [21:52:59] (03PS2) 10MarcoAurelio: layout: Add extension-CatTalk to zuul [integration/config] - 10https://gerrit.wikimedia.org/r/602505 [21:53:08] if some existing change has the same (repo, branch, ChangeId) it just creates a new patchset to the exisdting change [21:53:14] else it creates a new change [21:53:22] now we got them not pushing to master accidentally, it's creating a new change rather than keeping the old one [21:53:44] strange [21:53:49] well you need to have the same change-id [21:53:56] and to push to the same branch [21:53:59] if the Change-Id is the same that should create a new patchset [21:54:37] also folks have to learn to amend and send again [21:54:41] it was https://gerrit.wikimedia.org/r/602504 compared to https://gerrit.wikimedia.org/r/602303 that failed [21:54:52] instead of github which lets you pil up commits on top of each others [21:54:54] 602303 is the one we want it to go to [21:55:02] github is simple [21:55:21] well [21:55:22] heh [21:55:41] you pushed without a change id [21:55:41] oh fun [21:55:45] https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602303/1 does not have c hange id [21:55:48] * hashar blames self [21:55:54] you need to create a change id [21:56:02] hashar, that was yours! [21:56:08] so later when the change got amended, it got a change-id [21:56:23] Git review normally tells me it's adding one [21:56:26] which resulted in a different set of (repo, branch, changeid) and caused gerrit to create https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602504/ [21:56:39] yeah [21:57:05] https://gerrit.wikimedia.org/r/#/admin/projects/labs/tools/ZppixBot [21:57:12] Require Change-Id in commit message:: FALSE [21:57:28] should be inherit true [21:57:48] {{done}} [21:57:59] ;) [21:58:00] git-review normally adds a change-id though [21:58:10] hashar i think newer gerrit releases enforce it now [21:58:30] ;) [21:58:32] It's normally somewhere in the middle of the about 10 times I have to give my ssh password on cli [21:59:07] ssh-agent could hold the password for you ;D [21:59:22] but that is a different story. I am off to bed now! take care [21:59:33] Take care! [22:00:34] hmm, hashar there's https://gerrit.wikimedia.org/r/Documentation/project-configuration.html#require-change-id so i'm wrong (must have mis-remembered wrongly) [22:00:39] oh [22:00:46] i was reading the old docs [22:00:54] heh i thought that was gerrit-review... [22:01:10] paladox: how do you add a change id now? [22:01:26] you can generate one locally by pulling the commit [22:01:30] and amending [22:01:37] then edit the commit message using the web ui [22:01:41] git review -d [22:01:46] git commit --amend [22:02:07] although git review does the whole magic for you [22:03:14] https://opendev.org/opendev/gerrit/commit/ec79eb968296c5900b483c87439901a3ce8862df [22:03:17] there we go :P [22:04:52] hauskatze: I've done git commit --amend now [22:05:05] how do I ensure it will stay on the same patchset [22:05:26] RhinosF1: git review will take care of that [22:05:34] if the change-id is the same [22:05:45] now you can git review -R and see magic happen [22:05:50] hauskatze: this was supposed to add the missing commit-id [22:05:56] change-id even [22:06:32] RhinosF1 did you add the hook? [22:06:36] (03PS1) 10Jforrester: Release Quibble 0.0.44 [integration/quibble] - 10https://gerrit.wikimedia.org/r/602508 [22:06:36] into .git/hooks [22:06:38] (03PS1) 10Jforrester: changelog: Begin new 0.0.45 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/602509 [22:06:46] paladox: that means nothing to me [22:06:51] I pulled the change [22:06:51] (03CR) 10Jforrester: [C: 03+2] Release Quibble 0.0.44 [integration/quibble] - 10https://gerrit.wikimedia.org/r/602508 (owner: 10Jforrester) [22:06:57] ran git review -d [22:07:03] you have to add commit-msg to .git/hooks for a change id to be generated [22:07:04] then git commit --amend [22:07:45] (03Merged) 10jenkins-bot: Release Quibble 0.0.44 [integration/quibble] - 10https://gerrit.wikimedia.org/r/602508 (owner: 10Jforrester) [22:07:48] RhinosF1 https://gerrit.wikimedia.org/r/tools/hooks/commit-msg [22:07:50] * RhinosF1 is lost [22:07:52] copy that into .git/hooks [22:07:56] and chmod a+x it [22:07:59] RhinosF1: now git review -R [22:08:01] then re do the steps [22:08:21] hauskatze: what about what paladox is saying? [22:08:29] I never did such thing :) [22:09:10] (03CR) 10Jforrester: [C: 03+2] changelog: Begin new 0.0.45 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/602509 (owner: 10Jforrester) [22:09:45] hauskatze: didn't work [22:10:02] (03Merged) 10jenkins-bot: changelog: Begin new 0.0.45 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/602509 (owner: 10Jforrester) [22:10:13] RhinosF1: then I suggest git review -s [22:10:30] hauskatze: no output? [22:10:47] now pull the change you're trying to amend again [22:10:53] git review -d ... [22:11:00] git commit --amend [22:11:04] save commit message [22:11:09] git review [22:12:06] hauskatze: that's worse, A new changeset is much easier [22:12:27] which commit are you trying to amend by the way? [22:13:02] https://gerrit.wikimedia.org/r/602303 [22:13:39] Well, the patch is abandoned, it won't be modified [22:14:07] macfan! [22:14:19] i'm just doing the new changeset [22:16:42] k, gonna watch a tv series then [22:16:43] * RhinosF1 is off to sleep [22:17:47] Project mediawiki-core-doxygen-docker build #16374: 04STILL FAILING in 13 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16374/ [22:18:39] (03PS3) 10Jeena Huneidi: Blubber: move expansion before verification [blubber] - 10https://gerrit.wikimedia.org/r/593315 (https://phabricator.wikimedia.org/T248927) (owner: 10DC Slagel) [22:18:41] (03PS1) 10Jeena Huneidi: Use ExpandIncludesAndCopies in tests [blubber] - 10https://gerrit.wikimedia.org/r/602517 [22:22:06] (03CR) 10Jeena Huneidi: "Hi DC," (036 comments) [blubber] - 10https://gerrit.wikimedia.org/r/593315 (https://phabricator.wikimedia.org/T248927) (owner: 10DC Slagel) [22:23:31] 10Beta-Cluster-Infrastructure, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Green), 10Patch-For-Review, and 2 others: Create new wiki on the beta cluster to test API Portal - https://phabricator.wikimedia.org/T254185 (10Reedy) 05Open→03Resolved a:03Reedy >>! In T254185#6187328, @... [22:23:36] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10Patch-For-Review, and 4 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10Reedy) [22:24:03] (03CR) 10Jeena Huneidi: "Forgot to add a link to the related patchset: https://gerrit.wikimedia.org/r/c/blubber/+/602517" [blubber] - 10https://gerrit.wikimedia.org/r/593315 (https://phabricator.wikimedia.org/T248927) (owner: 10DC Slagel) [22:51:26] (03PS1) 10Jforrester: dockerfiles: [quibble*] Install quibble 0.0.44 and cascade. [integration/config] - 10https://gerrit.wikimedia.org/r/602525 [22:52:08] (03CR) 10Jforrester: [C: 03+2] dockerfiles: [quibble*] Install quibble 0.0.44 and cascade. [integration/config] - 10https://gerrit.wikimedia.org/r/602525 (owner: 10Jforrester) [22:53:12] (03Merged) 10jenkins-bot: dockerfiles: [quibble*] Install quibble 0.0.44 and cascade. [integration/config] - 10https://gerrit.wikimedia.org/r/602525 (owner: 10Jforrester) [22:53:40] !log Docker: Publishing Quibble 44 images [22:53:41] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:16:32] Project mediawiki-core-doxygen-docker build #16375: 04STILL FAILING in 12 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16375/ [23:24:12] (03PS3) 10Jforrester: jjb: Switch quibble jobs to 0.0.44 images [integration/config] - 10https://gerrit.wikimedia.org/r/594522 [23:39:56] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Documentation: Document how to deploy a new Quibble version to CI - https://phabricator.wikimedia.org/T231251 (10Jdforrester-WMF) 05Open→03Resolved h...