[14:52:21] Krinkle: hey, I found a bottleneck in wikibase api calls that flamegraph says it takes 9% of its cpu time (sum over all of API calls to wikidata.org), that'd 33M requests per day. Is there a way to properly measure the impact? [14:52:30] the patch hopefully will be merged soon [14:54:15] Amir1: hm.. well, we have api request graphs: https://grafana.wikimedia.org/?query=api&search=open&orgId=1 [14:54:47] and the appserver cluster for api requests could also be an indicator of cpu/throughput [14:54:52] https://grafana.wikimedia.org/d/RIA1lzDZk/application-servers-red-dashboard?var-cluster=api_appserver [14:55:06] if it becomes signignicant enough to e.g. shift a % of reqs to a lower latency bucket [14:55:39] and the flame grphs themselves could be compared as well, but that might take longer e.g. 2-3 hours for there to be multiple hourly graphs to compare, or a daily graph [14:56:06] hmm, that's pretty good already [14:56:13] fingers crossed [14:56:16] Thanks. [14:56:27] now I go convince addshore to review my patch [15:07:39] oh checking this would be really nice https://grafana.wikimedia.org/d/000000559/api-requests-breakdown?orgId=1&refresh=5m&var-metric=p50&var-module=wbgetentities [17:48:26] See them all at once with wb* ;) https://grafana.wikimedia.org/d/000000559/api-requests-breakdown?orgId=1&refresh=5m&var-metric=p50&var-module=wb* [19:21:49] Amir1: https://github.com/wikimedia/jquery-client "used by @wikimedia/data-values-value-view" [19:21:51] interesting! [19:22:08] https://github.com/wikimedia/data-values-value-view/blob/7344b75d3d82a77ba3e8c068dde12bc9e1e8561b/lib/jquery.event/jquery.event.special.eachchange.js#L90 [19:23:17] if that's all, can probably drop it as dependency