[23:09:48] Krinkle: is there a phan workaround for https://gerrit.wikimedia.org/r/c/mediawiki/core/+/524663 ? [23:12:12] AaronSchulz: there's a hundred or so warnings on that phan job [23:12:19] what issue specifically? [23:13:22] Krinkle: enable_class_alias_support is explicitly turned off in phan config [23:13:25] It's either re-enable it, or use [23:13:27] class BagOStuff extends Wikimedia\LightweightObjectStore\BagOStuff {} [23:16:09] * AaronSchulz isn't fond of non-obvious phan-only workarounds, but gives it a go [23:16:37] https://github.com/wikimedia/mediawiki/commit/f74400487fdb4c48833f566524d4079bce098250 [23:16:43] Or just re-enable it [23:16:57] It looks like it was explicitly disabled because it "wasn't needed" [23:16:58] maybe there's a way to tell phan about it through @ instructions like @property and such [23:17:03] not for perf reasons [23:17:12] or not explicitly [23:17:16] I think when using the extend workaround, the "old" one has to be the real one and the new one the subclass [23:18:58] AaronSchulz: Revert my suggestion to split the class_alias into another file, and flip the phan config [23:19:00] see what happens