[16:31:56] <addshore>	 Anyone any ideas about how to fix https://phabricator.wikimedia.org/T235554 ? It feels like quite a big regression in 1.35 :/
[17:06:23] <Krinkle>	 not aware of a 1.35 connection
[17:26:32] <addshore>	 Krinkle: I believe it all comes down the the commit I link to in https://phabricator.wikimedia.org/T235554#6620757 
[20:45:51] <AaronSchulz>	 Krinkle: what's the status of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/640868 ?
[20:46:48] <Krinkle>	 AaronSchulz: nothing blocking, but I think we can do slightly stricter on the test. I really don't want us to have to deal with this again :)
[20:47:16] <Krinkle>	 I can merge it now if you'd like to do that later, so that we're not blocking the next branch cut
[20:47:19] * AaronSchulz still doesn't see where the EditPage flame graphs went
[20:47:31] <Krinkle>	 AaronSchulz: they're there, the link you used is for log files not graphs
[20:47:35] <AaronSchulz>	 Krinkle: ah, I missed the one inline comment
[20:47:37] <Krinkle>	 we use the same log file for both
[20:49:00] <AaronSchulz>	 I thought I clicked the svg one
[20:49:11] <AaronSchulz>	 Krinkle: yes, index.all, I wrote that bit ;)
[20:49:33] <Krinkle>	 https://performance.wikimedia.org/arclamp/svgs/daily/
[20:49:37] <Krinkle>	 fn-EditAction
[20:49:52] <Krinkle>	 Is it not there for you?
[21:29:05] <AaronSchulz>	 Krinkle: oh, I found it, I was just sure I clicked the right link
[21:29:15] <AaronSchulz>	 Krinkle: anyway, any reason why "Direct link rendered image" doesn't work in grafana ?
[21:29:24] <AaronSchulz>	 the images always say "do data"
[21:42:25] <Krinkle>	 that probably requires a service or package that we haven't installed, afaik that never worked. in Grafana what that would basically do is spin up headless firefox and take a screen grab and serve that up as PNG
[21:42:44] <Krinkle>	 the other permalinks do work, but I usually take a partial screenshot directly with OS tooling
[21:43:09] <Krinkle>	 e.g. https://grafana.wikimedia.org/dashboard/snapshot/aub7twxi6nuhdR9sGZTzDBExkq2VSav4
[21:43:22] <Krinkle>	 is an immutable snapshot of 1 panel with 1 timerange of data
[21:56:28] <AaronSchulz>	 ugh, some weirdness in wfArrayDiff2() at https://performance.wikimedia.org/arclamp/svgs/daily/2020-11-04.excimer.all.fn-EditAction.svgz ; must be the strcmp() on a Message or something triggering __toString()
[21:56:46] * AaronSchulz stares at EditPage::getEditPermissionErrors
[21:58:42] <Krinkle>	 what led you there? a particular regression?
[22:00:45] <AaronSchulz>	 just more time spent there (by comparison of two graphs)
[22:00:53] * AaronSchulz goes afk
[22:01:44] <Krinkle>	 ah week over week?
[22:01:46] <Krinkle>	 nice
[22:53:41] <mszabo>	 one of the grafana 7.x releases removed the phantomjs binary it was using for the screenshots
[22:53:47] * mszabo tries to find the notes
[22:54:23] <mszabo>	 https://community.grafana.com/t/release-notes-v7-0-x/29381
[22:54:31] <mszabo>	 yeah, looks like there's a plugin now instead
[23:38:42] <Krinkle>	 they should probably make it not show the link if that's not installed.
[23:38:53] <Krinkle>	 or maybe we have the plugin installed but its broken?
[23:39:03] <Krinkle>	 given that it does get back a PNG with grafana's panel UI rendered
[23:39:10] <Krinkle>	 it just syas "no data" where the line graph would be
[23:55:16] <mszabo>	 huh, strange