[03:23:21] Krinkle: I was probably thinking of $wgForeignFileRepos having several repos on a foreign domain with different names or something [03:24:26] * AaronSchulz should make sure the docs are at least clear on what 'name' is for [03:50:05] anyway, all the subclasses using shared keys are DB* ones that use the DB domain for file metadata (e.g. not files-only) [04:04:57] Yeah [04:05:29] Even so it might be worth looking unto if repo name is neeeded in the key but seems unrelated to t he commit and been that way for years without presumably [04:07:09] So that could be an exploratory task for a later time if were interested in supporting that kind of config [04:07:50] Was it intentional? I assumed it was a file class copy mistake where getName means something else and happened to work [06:01:09] Krinkle: I just made a patch removing the name bit. It's not a case we need to add support for. [06:18:30] the name is only useful for local-only keys (e.g. for foriegn api repos or something) [06:30:34] Krinkle: is there a vendor/ patch for https://gerrit.wikimedia.org/r/c/mediawiki/core/+/573342 ? [06:31:50] AaronSchulz: landed already [06:31:51] yes [06:32:08] https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/573341 [06:32:28] back when we all still ran around naked and naive. [06:32:42] (covid) [06:32:44] good night [06:34:55] aye [16:06:01] Tentative ping: https://gerrit.wikimedia.org/r/c/performance/arc-lamp/+/633858 [16:48:14] mszabo: he, oops. That's what we get for copy pasting instead of actually using. Our copy is in wmf-config still [16:48:19] Thx [16:51:17] you're welcome :D [23:54:54] dpifke: I don't see the custom entry point graphs at https://performance.wikimedia.org/arclamp/logs/daily/