[19:53:59] Krinkle: I amended the comments in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/634116/4 and did the phan change in another patch [22:08:49] Krinkle: is phpunit.xml.dist missing stuff? [22:14:54] I don't know, is it :) [22:14:55] ? [22:15:58] if it is, that's most likely due to some tests not yet having been ported to the unit/ and integration/ division, and by extent to be compatible without the legacy phpunit.php runner [22:32:16] it hardly runs anything [22:34:38] https://phabricator.wikimedia.org/T258089 [22:34:40] * AaronSchulz sighs [22:42:57] It runs in CI [22:42:58] https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php72-docker/33573/consoleFull#console-section-8 [22:43:07] 6752 within the "unit" group [22:43:18] the "integration" group doesn't run in CI currently since its slower and already runs in the legacy endpoint [23:12:15] Krinkle: I also run into https://phabricator.wikimedia.org/T263911 with 'composer phpunit' [23:12:35] if the exclusion of most tests is intentional, then I'll keep focusing on the xml file [23:13:21] https://phabricator.wikimedia.org/T258089 I should say [23:13:59] https://phabricator.wikimedia.org/T230781 looks like a duplicate [23:14:43] yeah, that's still a WIP, just ignore for now [23:14:54] it's not used by anything [23:15:03] only the "unit" group is actively used and enforced by CI [23:17:31] https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Running_the_tests could be clearer