[01:41:27] Coren: ping [01:42:30] sumanah: Pong. [09:05:00] greg-g let me fix it [09:17:36] hi petan [09:19:14] could you please investigate usage of non-open-source code at http://bots.wmflabs.org/~dgideas/ideasbot/source/wmf_conn/ [09:20:18] it was once at http://bots.wmflabs.org/~dgideas/ideasbot/source/wmf_s1/ , with a line at footer (c) 20xx all rights reserved. after I told that user, he moved the page around and removed that footer, but is still using it.... [09:20:40] errr [09:20:48] why is someone running a proxy... [09:20:50] aha [09:22:53] disabled [09:22:58] I will try to contact him [09:23:12] @seenrx gideas [09:23:12] petan: I have never seen gideas [09:23:34] @seenrx [Gg]ideas [09:23:34] petan: Last time I saw DGideas they were quitting the network with reason: Quit: Page closed at 3/30/2013 6:00:01 AM (7.03:23:32.8624630 ago) [09:23:47] @notify DGideas [09:23:47] I will notify you, when I see DGideas around here [09:25:08] !log bots petrb: disabled /data/project/public_html/dgideas/ideasbot/source because of problems with proprietary code [09:25:10] Logged the message, Master [09:28:40] what does seenrx mean? [09:29:56] it's @seen with regex [09:30:00] @seen liangent [09:30:00] legoktm: I have never seen liangent [09:30:06] ... [09:30:25] wtf [09:30:28] @seen liangent [09:30:28] petan: liangent is in here, right now [09:30:41] heh [09:30:49] funny bug [09:30:59] "liangent " != "liangent" [09:31:29] lol [09:31:32] @seen liangent [09:31:32] legoktm: liangent is in here, right now [09:31:32] @seen ​petan [09:31:33] liangent: I have never seen ​petan [09:32:11] go someone fix it prove you are master of c# :D [09:32:14] Type @commands for list of commands. This bot is running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 1.10.6.8 source code licensed under GPL and located at https://github.com/benapetr/wikimedia-bot [09:32:17] sources ^ [09:32:26] isnt it just [09:32:26] hint: it's in modules/seen [09:32:28] .strip() [09:32:31] no [09:32:37] no? [09:32:55] I would myself use either Substring or Trim or something like that [09:33:34] like while(string.EndsWith(" ")) { string = string.Substring(0, string.Length -1); } [09:33:37] er [09:33:41] right [09:33:45] its called trim in java [09:33:59] doesn't c# have similar function? [09:34:04] yes probably [09:34:12] I would need to check [09:34:28] but for some reason I think substring is faster but maybe not [09:34:46] I guess trim is removing the characters as it reads the string [09:34:51] which could be faster IMHO [09:35:16] but Trim probably checks the beginning and end while we are only interested in end [09:35:24] so this might be few instructions faster [09:35:50] unless there are several spaces, in that case it is slower [09:35:52] I'm don't know about c#'s implementation, but will while(string.EndsWith(" ")) { string = string.Substring(0, string.Length -1); } create some unused string objects? [09:36:12] like what may happen in java, if it hasn't been automatically optimized [09:36:14] yes, it doesn't hurt performace though [09:36:27] string is immutable [09:36:40] so everytime you change it you create new object [09:37:37] so if you're trimming "petan " to "petan", some strings like "petan " "petan " "petan " are created then GCed soon [09:37:58] I believe they are GCED as soon as you exit the block which is immediately [09:38:24] but not sure... [09:38:28] (this is not true in java) [09:38:43] for some reason all my tests with huge loops allocating and disposing large objects didn't eat any memory [09:38:51] so GC collected these object immediately [09:38:55] otherwise it wouldn't work [09:39:17] it is possible that IL code contains even delete [09:39:21] I don't know [09:39:30] maybe compiler is so smart [09:39:35] ah there's no delete in java AFAIK [09:39:43] there is no delete in c# either [09:39:55] but on level of .net assembly there is [09:40:04] and that's up to implemetation ... some runtime deletes objects as soon as it loses all references to it [09:40:06] so binary code might contain it [09:40:41] in this case the object is allocated and disposed on level of block, so compiler might be smart enough to automatically delete it [09:41:21] if it was just up to GC to remove these things if you had a very fast while that allocates a lot of memory and immediately remove the reference [09:41:36] your application would eat lot of ram, then it would be disposed after GC.Collect() ran [09:41:53] which would make it randomly allocate lot of memory and then dispose it in loop [09:42:04] that doesn't happen though so there must be some magic :D [09:42:10] or something [09:43:18] like i=99999999; while ( i > 1) {string blah="fdkgofdsgs"; i--;} [09:43:35] that creates a string and immediately lose the reference [09:44:15] I should ask on stack.. [09:44:17] so .. this shouldn't eat even a little more memory [09:44:27] "fdkgofdsgs" should leave in the string pool [09:44:56] and blah always points to the same object, without creating and deleting [09:45:22] s/leave/live [09:45:40] see http://stackoverflow.com/questions/2486191/java-string-pool [09:51:16] let me try... [09:52:46] I'm not sure whether c# is doing the same thing or not [09:53:07] but m$ was copying java for c# initially [09:58:38] http://stackoverflow.com/questions/15849383/how-does-c-sharp-remove-the-memory-allocated-in-loop [09:58:55] not detailed answer so far :/ [10:39:08] Change on 12mediawiki a page Wikimedia Labs/Tool Labs/Needed Toolserver features was modified, changed by Silke WMDE link https://www.mediawiki.org/w/index.php?diff=669401 edit summary: [+624] /* OSM */ added more details to OSM section [11:06:46] Change on 12mediawiki a page Wikimedia Labs/Tool Labs/Needed Toolserver features was modified, changed by Silke WMDE link https://www.mediawiki.org/w/index.php?diff=669403 edit summary: [+196] /* To be discussed */ added item [14:05:03] * Coren waves. [14:06:57] hi [14:08:25] Coren: Do you have the time to help me now? [14:09:00] If you don't mind waiting 5m for me to fetch coffee, I'd be glad to. :-) [14:09:54] Darkdadaah what do you need a help with? [14:10:33] petan: My webpages (php) don't work: http://tools.wmflabs.org/anagrimes/wiktio/anagrimes_web/index.php [14:11:43] did you look in error log? [14:12:13] php_error.log? [14:12:25] /var/log/apache2/error.log [14:12:38] No, I did not. [14:12:50] you should see an error there [14:13:39] There is no /var/log/apache2 directory (I'm on the "tools" project by the way). [14:13:53] aha sec [14:14:03] @labs-project-instances tools [14:14:04] Following instances are in this project: tools-login, tools-puppet-test, tools-webproxy, tools-exec-01, tools-webserver-01, tools-master, tools-db, tools-exec-02, tools-shadow, [14:14:17] you need to be on tools-webserver-01 [14:15:33] Permission denied :-) [14:15:56] ok this need to be fixed... [14:16:49] SoftException in Application.cpp:299: Script "/data/project/anagrimes/public_html/wiktio/anagrimes_web/index.php" resolving to "/data/project/anagrimes/public_html/wiktio/anagrimes_web/index.php" not within configured docroot [14:16:50] [Sat Apr 06 14:16:25 2013] [error] [client 10.4.1.89] Premature end of script headers: index.php [14:18:05] Coren we need to change config of php somehow, or change the permissions on these logs [14:22:05] btw Darkdadaah that is error which is thrown by php on execution of your script [14:23:42] * Coren is back. [14:23:49] petan: I get the same error with a file.php with no script at all inside. [14:24:21] hmm first of all you should be able to read logs [14:24:29] without that ability the server is nearly unusable [14:24:40] petan: I have to package Apache 2.4 so that I have a proper ErrorLogFormat first. Thankfully, I'll be able to backport raring's. [14:24:50] ok [14:31:47] Darkdadaah: Yeah, so the error isn't that helpful at all. Can I switch to your tool to see what's up? [14:32:07] Coren: sure. [14:36:57] Darkdadaah: Try this. [14:37:35] Wasn't a bug of yours, it was a bug of mine. One thing I hadn't considered when moving old-style tool accounts to new-style ones is that the webserver needed restarting. [14:37:45] Coren: It works. [14:39:57] I did not make the connection, but it does seem to have bugged after the conversion (I did not check right away). [14:41:03] Thanks Coren. [14:44:55] No, I'm sorry. That's something I should have tested. [14:51:25] Coren: Another small bug(?): tools.wmflabs.org/anagrimes should redirect to tools.wmflabs.org/anagrimes/ [14:52:03] Doesn't it? That should be easy to fix. Give me a minute. [14:54:11] Ah, it's the "normal" implicit redirection, and that confuses the stylesheet relative paths. Lemme add an explicit 302 [14:55:14] All relative links are confused, yes. [15:04:00] [bz] (NEW - created by: anubhav, priority: Unprioritized - normal) [Bug 46951] Unable to Create a New Developer Account - https://bugzilla.wikimedia.org/show_bug.cgi?id=46951 [15:06:35] Darkdadaah: Fix't [15:06:47] Explicit 302 ftw. [15:07:05] Thanks :) [15:07:32] Ah. Oh? [15:08:39] https url is "uncertified" https://tools.wmflabs.org/anagrimes/ [15:15:55] Darkdadaah: That's because the tools webserver doesn't have the signed certificate yet. I should probably look into doing so now, actually. [15:17:52] Coren: Please do so when you can :-) [17:53:45] [bz] (UNCONFIRMED - created by: anyumousse, priority: Unprioritized - normal) [Bug 46959] Lose new account button when changing language - https://bugzilla.wikimedia.org/show_bug.cgi?id=46959 [18:15:36] [bz] (UNCONFIRMED - created by: testingwithfire, priority: Unprioritized - normal) [Bug 46962] User login on new system with HTTPS everywhere enabled is confusing; HTTPS server apparently down - https://bugzilla.wikimedia.org/show_bug.cgi?id=46962 [18:17:59] [bz] (UNCONFIRMED - created by: anyumousse, priority: Unprioritized - normal) [Bug 46963] Tools: Special Pages: Login/Create account link goes to old login page - https://bugzilla.wikimedia.org/show_bug.cgi?id=46963 [18:32:58] [bz] (ASSIGNED - created by: testingwithfire, priority: Unprioritized - normal) [Bug 46962] HTTPS link is shown on toro new login form but HTTPS is not supported - https://bugzilla.wikimedia.org/show_bug.cgi?id=46962 [18:35:36] * Jasper_Deng really hopes Tool Labs will be more reliable than TS [18:39:16] More stable, yes. [20:55:38] [bz] (NEW - created by: anubhav, priority: Unprioritized - normal) [Bug 46951] Unable to Create a New Developer Account - https://bugzilla.wikimedia.org/show_bug.cgi?id=46951