[15:07:24] Okay, actual request for that review now :) Just rebased. [21:47:29] ugh, rebase error still? [21:48:24] Yeah. Let me try to rebase again. [21:48:45] It's RELEASE-NOTES-1.30... there's such a small window for that file... [21:51:01] twentyafterfour: Patch rebased. [21:52:03] +2 [21:53:08] Thank you. It's reporting a conflict with https://gerrit.wikimedia.org/r/#/c/366872/10 but that doesn't appear to have been merged yet. [22:10:32] twentyafterfour: Appears it failed phpcs, I'm going to do one more patch set if you don't mind. I'm sorry I'm still learning my way around here :/ I'm sorry... [22:10:54] Matthew_: sure no problem [22:13:55] Ok, submitted. Jenkins likes it so far. [22:45:33] +2 again :) [22:48:51] Thank you :) [22:57:24] doh another -1 [22:57:26] wtf [22:58:05] something must be wrong with jenkins? I don't get it. I mean, why can't it auto-rebase a change to the changelog? it's silly [22:58:51] I think gerrit is confused about the parent revision [23:00:44] I don't know... I've rebased twice and the last time RELEASE-NOTES-1.30 was touched was over 7 hours ago... I don't know if I'm doing something wrong or what... [23:01:07] Are you rebasing on the tip of head? I think jenkins is wrong here not you [23:01:23] it's saying your patch is based on a revision that isn't current but that revision is merged [23:02:05] You could try abandoning and submitting a new revision with the change [23:02:19] I have a feeling jenkins is just confused about this one and I don't know why exactly [23:02:41] I mean gerrit [23:02:44] not jenkins [23:02:46] doh [23:03:09] stupid anthropomorphised software [23:03:16] can't keep them straight :_ [23:08:46] Hm... [23:09:23] My steps for rebasing are https://www.entropywins.wtf/blog/2013/07/01/resolving-a-merge-conflict-on-gerrit/ [23:10:12] yeah but I think gerrit got this one wrong because there doesn't seem to be any real conflict [23:12:57] no I'm wrong, there is a conflict in release notes [23:12:59] hmm [23:14:42] I'm sorry I don't know... [23:14:46] updated [23:15:38] ok one more time :) [23:16:08] twentyafterfour hi [23:16:18] hi [23:16:21] i think i know why it's failing for you [23:16:25] it's jenkins side [23:16:39] this has happened before with repo's [23:16:42] oh?? [23:16:50] you need to delete the repo on the contint host [23:16:55] where zuul clones it [23:17:03] hmm [23:17:21] I thought those were supposed to get regenerated every time [23:17:58] Not sure but it has happened before, that's how hashar fixed it :) [23:18:03] * paladox -> in the car [23:18:29] thanks! [23:18:44] your welcome :) [23:19:07] seems like it's mw/core so it should be causing all tests to fail [23:31:22] twentyafterfour: Okay, thank you so much. It appears to have been merged now... [23:31:30] :) [23:31:42] Sorry gerrit is such a pain [23:45:10] It's ok. Thank you for troubleshooting :)