[16:01:09] addshore: hey. got some minutes to review https://gerrit.wikimedia.org/r/#/c/304692 ? [16:01:29] :( I wish I did but I am not going to have any spare time all month :/ [16:02:25] addshore: wow. That sounds scary :P [16:02:29] Good luck, then [16:03:52] :( [16:21:38] * tonythomas just want to ask if anyone else in this list is interested in reviewing our https://gerrit.wikimedia.org/r/#/c/304692 [20:15:57] <|L> meh [20:20:08] (03CR) 10Legoktm: [C: 04-1] Output a better deprecation message for mw.config [core] - 10https://gerrit.wikimedia.org/r/312422 (https://phabricator.wikimedia.org/T98653) (owner: 10Bmansurov) [20:26:53] (03CR) 10Bartosz Dziewoński: [C: 032] Use a more specific rule for setting cursor:pointer on JS links [core] - 10https://gerrit.wikimedia.org/r/317011 (owner: 10Esanders) [20:36:44] (03Merged) 10jenkins-bot: Use a more specific rule for setting cursor:pointer on JS links [core] - 10https://gerrit.wikimedia.org/r/317011 (owner: 10Esanders) [20:40:39] (03CR) 10Gergő Tisza: "What I am aware of so far:" [core] - 10https://gerrit.wikimedia.org/r/284902 (https://phabricator.wikimedia.org/T85853) (owner: 10Bartosz Dziewoński) [20:42:53] (03CR) 10Gergő Tisza: "recheck" [core] - 10https://gerrit.wikimedia.org/r/316301 (owner: 10Gergő Tisza) [20:43:15] (03CR) 10Gergő Tisza: "(CI choked on some git error)" [core] - 10https://gerrit.wikimedia.org/r/316301 (owner: 10Gergő Tisza) [20:53:33] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think this is too likely to break existing special pages that rely on the subpage/parameter being preserved :/" [core] - 10https://gerrit.wikimedia.org/r/316704 (owner: 10Legoktm) [20:53:48] (03CR) 10Krinkle: [C: 04-1] Make updateCategoryCounts() have better lag checks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/316733 (https://phabricator.wikimedia.org/T95501) (owner: 10Aaron Schulz) [20:53:56] (03CR) 10Krinkle: "Otherwise LGTM, and good to go." [core] - 10https://gerrit.wikimedia.org/r/316733 (https://phabricator.wikimedia.org/T95501) (owner: 10Aaron Schulz) [20:54:13] (03PS24) 10Krinkle: Add caching to ResourceLoaderWikiModule::preloadTitleInfo() [core] - 10https://gerrit.wikimedia.org/r/308138 (owner: 10Aaron Schulz) [20:58:27] (03CR) 10Bartosz Dziewoński: [C: 032] FormSpecialPage: Only add redirectparams for POST forms [core] - 10https://gerrit.wikimedia.org/r/316705 (owner: 10Legoktm) [20:58:34] (03PS9) 10Krinkle: [WIP] resourceloader: Re-implement mw.Map atop native Map w/ fallback [core] - 10https://gerrit.wikimedia.org/r/313231 [20:58:43] (03PS6) 10Krinkle: [WIP] qunit: Ensure mw.Map StringMap fallback is tested [core] - 10https://gerrit.wikimedia.org/r/313232 [21:01:26] (03PS7) 10Krinkle: [WIP] qunit: Ensure mw.Map StringMap fallback is tested [core] - 10https://gerrit.wikimedia.org/r/313232 [21:07:35] (03Merged) 10jenkins-bot: FormSpecialPage: Only add redirectparams for POST forms [core] - 10https://gerrit.wikimedia.org/r/316705 (owner: 10Legoktm) [21:09:09] (03CR) 10Gergő Tisza: [C: 032] Relax phpdoc of PermissionError to match actual usage [core] - 10https://gerrit.wikimedia.org/r/316301 (owner: 10Gergő Tisza) [21:11:29] (03CR) 10jenkins-bot: [V: 04-1] [WIP] resourceloader: Re-implement mw.Map atop native Map w/ fallback [core] - 10https://gerrit.wikimedia.org/r/313231 (owner: 10Krinkle) [21:14:16] (03CR) 10jenkins-bot: [V: 04-1] [WIP] qunit: Ensure mw.Map StringMap fallback is tested [core] - 10https://gerrit.wikimedia.org/r/313232 (owner: 10Krinkle) [21:16:33] (03Merged) 10jenkins-bot: Relax phpdoc of PermissionError to match actual usage [core] - 10https://gerrit.wikimedia.org/r/316301 (owner: 10Gergő Tisza) [21:19:29] (03PS2) 10Gergő Tisza: Clarify phpdoc of DatabaseUpdater::addExtensionUpdate [core] - 10https://gerrit.wikimedia.org/r/316513 [21:29:58] (03CR) 10Gergő Tisza: [C: 032] Clarify phpdoc of DatabaseUpdater::addExtensionUpdate [core] - 10https://gerrit.wikimedia.org/r/316513 (owner: 10Gergő Tisza) [21:37:44] (03Merged) 10jenkins-bot: Clarify phpdoc of DatabaseUpdater::addExtensionUpdate [core] - 10https://gerrit.wikimedia.org/r/316513 (owner: 10Gergő Tisza) [21:43:46] (03CR) 10Krinkle: [C: 032] Add caching to ResourceLoaderWikiModule::preloadTitleInfo() [core] - 10https://gerrit.wikimedia.org/r/308138 (owner: 10Aaron Schulz) [21:47:42] (03PS1) 10Aaron Schulz: objectcache: avoid using process cache in nested callbacks [core] - 10https://gerrit.wikimedia.org/r/317051 [21:50:27] (03Merged) 10jenkins-bot: Add caching to ResourceLoaderWikiModule::preloadTitleInfo() [core] - 10https://gerrit.wikimedia.org/r/308138 (owner: 10Aaron Schulz) [21:51:25] (03PS1) 10Krinkle: OutputPage: Reduce getTitleInfo() calls (improve preloading) [core] - 10https://gerrit.wikimedia.org/r/317064 [21:52:11] (03CR) 10Krinkle: "@Aaron: After this patch, in MediaWiki-Vagrant, debug.log shows 0 queries from getTitleInfo() when browsing around. Both logged-in and log" [core] - 10https://gerrit.wikimedia.org/r/317064 (owner: 10Krinkle) [21:58:41] (03CR) 10Krinkle: "Code LGTM and test verifies the change. The commit message doesn't explain to me why this is though. The test imho doesn't demonstrate why" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/317051 (owner: 10Aaron Schulz) [21:59:30] (03PS2) 10Krinkle: OutputPage: Reduce getTitleInfo() calls (improve preloading) [core] - 10https://gerrit.wikimedia.org/r/317064 [22:00:12] (03CR) 10Aaron Schulz: [C: 032] OutputPage: Reduce getTitleInfo() calls (improve preloading) [core] - 10https://gerrit.wikimedia.org/r/317064 (owner: 10Krinkle) [22:00:36] (03PS2) 10Aaron Schulz: objectcache: avoid using process cache in nested callbacks [core] - 10https://gerrit.wikimedia.org/r/317051 [22:09:14] (03PS10) 10Krinkle: [WIP] resourceloader: Re-implement mw.Map atop native Map w/ fallback [core] - 10https://gerrit.wikimedia.org/r/313231 [22:13:36] (03PS3) 10Aaron Schulz: objectcache: avoid using process cache in nested callbacks [core] - 10https://gerrit.wikimedia.org/r/317051 [22:18:40] (03Merged) 10jenkins-bot: OutputPage: Reduce getTitleInfo() calls (improve preloading) [core] - 10https://gerrit.wikimedia.org/r/317064 (owner: 10Krinkle) [22:24:33] (03PS1) 10Legoktm: Show user ID on action=info [core] - 10https://gerrit.wikimedia.org/r/317071 [22:34:35] (03PS3) 10Aaron Schulz: Make updateCategoryCounts() have better lag checks [core] - 10https://gerrit.wikimedia.org/r/316733 (https://phabricator.wikimedia.org/T95501) [22:36:15] (03PS6) 10Aaron Schulz: Use adaptive CDN TTLs for page views [core] - 10https://gerrit.wikimedia.org/r/306140 [22:37:17] (03PS1) 10AndyRussG: MessageCache: Use checkKeys for large messages [core] (wmf/1.28.0-wmf.22) - 10https://gerrit.wikimedia.org/r/317074 (https://phabricator.wikimedia.org/T144952) [22:46:27] (03CR) 10Nikerabbit: "Looking with fresh eyes..." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/241499 (https://phabricator.wikimedia.org/T115217) (owner: 10Amire80) [23:09:29] (03CR) 10Dereckson: [C: 032] "SWAT" [core] (wmf/1.28.0-wmf.22) - 10https://gerrit.wikimedia.org/r/317074 (https://phabricator.wikimedia.org/T144952) (owner: 10AndyRussG) [23:12:13] (03CR) 10Jforrester: "Didn't we intentionally stop showing these to uses on Special:Preferences because we will (eventually) replace them in the Great Leap Towa" [core] - 10https://gerrit.wikimedia.org/r/317071 (owner: 10Legoktm) [23:14:17] (03CR) 10Legoktm: "In the commit message I wrote () I said it was because it wasn't useful for the user to know the" [core] - 10https://gerrit.wikimedia.org/r/317071 (owner: 10Legoktm) [23:18:20] (03Merged) 10jenkins-bot: MessageCache: Use checkKeys for large messages [core] (wmf/1.28.0-wmf.22) - 10https://gerrit.wikimedia.org/r/317074 (https://phabricator.wikimedia.org/T144952) (owner: 10AndyRussG) [23:22:38] (03PS7) 10Aaron Schulz: Use adaptive CDN TTLs for page views [core] - 10https://gerrit.wikimedia.org/r/306140