[12:58:58] hola [13:04:40] https://phabricator.wikimedia.org/E206 is now, right? [13:05:04] Hi. Right. [13:06:33] We didn't publicize a lot this new windows, a bit last minute. [13:06:55] next week better, with CI hopefully [13:07:43] I am looking at your patches since nobody else suggested anything [13:13:09] Would you have a test plan for 289650? [13:14:08] hmmm the T43720 conditions perhaps [13:14:08] T43720: DISPLAYTITLE of a page not applied on the page itself for page title and category headers - https://phabricator.wikimedia.org/T43720 [13:17:50] Dereckson: yeah I didn't actually test it with Translatable pages, but you could just enable a display title and use {{#displaytitle:something}} on the category page [13:18:05] works fine at https://mediawiki.dereckson.be/Category:IPad [13:19:23] https://gerrit.wikimedia.org/r/#/c/268622/ looks good to me, left a question [13:20:41] Answered, I've removed it in 268625 [13:21:06] (the actual extension registration convert) [13:21:09] should I remove it too from 268622? [13:21:47] Dereckson: no that's fine [13:29:55] Dereckson: what's your plan for the backwards incompatible changes in https://gerrit.wikimedia.org/r/#/c/268625/ ? Just have a big announce and forse users to migrate? [13:30:55] Dereckson: I assume https://www.mediawiki.org/wiki/Extension:CategoryTree will be updated after merge [13:31:03] perhaps also good time to get rid of some of those deprecated things? [13:33:44] you mean for users < 1.25? [13:35:16] Dereckson: I mean that if users were using CT_WHATEVER in their LocalSettings.php, we cannot support that as far as I know [13:35:57] unless you leave them at CategoryTree.php and force users change when they switch to wfLoadExtension... which could be little more nice [13:37:13] with a deprecate wfWarn, that would be a niec idea [13:37:43] but we don't have static analysis tools to inspect user configuration [13:37:54] so we can't guess they're using it or no for such warning easily [13:39:08] well, I would guess that some are using it [13:39:34] Yes, I guess CategoryTree is an extension used by 3rd parties. [13:41:27] well, http://wikiapiary.com/wiki/Extension:CategoryTree should tell [13:41:49] Website count: 5310 (22.53%) [13:41:55] it's very popular even [13:43:30] (setenv MW_INSTALL_PATH /home/dereckson/dev/mediawiki/core ; php data/LanguageNameIndexer.php works like a charm) [13:43:38] good [13:46:14] MediaWiki 1.27 is a LTS [13:46:25] isn't? [13:47:23] yes [13:47:38] If so, I offer to add back to CategoryTree.php and mark them deprecated in a comment the defines, advertise the fact in the page extension documentation, but only remove them at the next LTS (.31?) [13:49:15] Dereckson: if you mean only adding the constants back to CategoryTree.php, yes that sounds good. The constants can then go away when CategoryTree.php is completely removed. [13:49:52] and while people migrate to extension.json, they will migrate away fro the constants [13:58:38] So stay the question on how to handle extension.json keys. Numeric key allow to use $wgCategoryTreeMaxDepth = [ CategoryTreeMode::PAGES => 2, CategoryTreeMode::ALL => 1 ]; [13:59:18] I don't understand what you mean [14:00:05] You offer to get rid in in extension.json of the numeric keys like: [14:00:08] » » » "10": 1, [14:00:39] to get rid of -> to use string keys with human understable names [14:01:23] That would mean replace at three place: JS code, CategoryMode class, extension.json, but then we would break compatibility if people use numeric values instead of constants currently. [14:01:57] Not a real issue I guess, constants are meant so we don't need to use numeric values. [14:02:10] Dereckson: yes that would break, but then again don't number values get reordered anyway with extension registration? [14:02:36] at least unsetting is not possible [14:04:47] * Dereckson nods. [14:06:33] We do that in a change between 268624 and 268625, or after 268625? [14:07:56] Dereckson: after sounds okay to me, probably not that many will udpate to ..25 but rather skip to latest version we provide [14:08:34] k [14:25:44] You're right: extension.json is *really* more legible: https://gerrit.wikimedia.org/r/293318 [14:46:27] done for today [14:48:12] hi [14:55:12] hi Luke081515 [14:55:49] hi Dereckson :). I'm going to fix the topic now [14:56:00] so that the other window is mentioned too [15:53:34] Luke081515: thanks [15:54:03] Luke081515: does chanserv need a separate update? it seems to use slightly different message [15:57:43] Nikerabbit: I already updated it ;) [16:00:39] Luke081515: great