[19:49:24] <Luke081515>	 today we have the codereview cluster, where we can test code :), so ask me if you need access ;)
[19:52:23] <MGC_>	 I think I'll come fifteen minutes later
[19:58:35] <twentyafterfour>	 Luke081515: awesome
[19:59:10] <Luke081515>	 the advantage at vagrant is, that you can halt the machine, so no worries about spam ;)
[19:59:56] <Luke081515>	 wow
[20:00:08] <Luke081515>	 come back, we need you :D
[20:01:21] <Luke081515>	 ok, let's start, who is here?
[20:02:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use inNamespace in CategoryPage [core] - 10https://gerrit.wikimedia.org/r/289649 (owner: 10Nikerabbit)
[20:03:20] <jdlrobson>	 \o
[20:03:29] <twentyafterfour>	 o/
[20:03:53] <Luke081515>	 gate-ans-submit is emtpy, so we can start :D
[20:04:29] <Luke081515>	 Guess we can start with: https://phabricator.wikimedia.org/E181#2053
[20:05:09] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/280507/ is waiting for feedback from florian
[20:05:57] <jdlrobson>	 someone needs to rebase https://gerrit.wikimedia.org/r/#/c/283467/5
[20:06:02] <jdlrobson>	 but ill merge when that's done
[20:06:24] <jdlrobson>	 can anyone do that on Alex's behalf?
[20:06:56] <jdlrobson>	 Ceranium's patch also needs a rebase..
[20:07:05] <jdlrobson>	 having a look at code now
[20:07:09] <Luke081515>	 Krenair: FYI^
[20:07:30] <paladox>	 jdlrobson i can rebase https://gerrit.wikimedia.org/r/#/c/283467/5
[20:07:42] <jdlrobson>	 thanks paladox 
[20:08:08] <jdlrobson>	 i'm not too familiar with the logging code. maybe anomie could take a look?
[20:08:15] <paladox>	 Your welcome
[20:08:48] <jdlrobson>	 Luke081515: what else needs reviewing apart from those?
[20:08:53] <jdlrobson>	 i'm not too familiar with that logging code
[20:09:20] <Luke081515>	 at E181 there is nothing, so I guess we dcan choose the oldest patches?
[20:11:11] <paladox>	 jdlrobson: Is wgActionFilteredLogs that supported in extension.json
[20:11:19] <paladox>	 CentralAuth was converted this week.
[20:17:16] <Luke081515>	 Hi Florian
[20:17:31] <FlorianSW>	 Hi Luke081515 :)
[20:17:39] <Luke081515>	 jdlrobson: Guess we can continue with his patch? :)
[20:18:10] <grrrit-wm>	 (03PS3) 10Aaron Schulz: Limit DELETE in purgeExpiredRestrictions() and use primary key [core] - 10https://gerrit.wikimedia.org/r/289170 (https://phabricator.wikimedia.org/T135470) 
[20:20:29] <paladox>	 jdlrobson: Ive rebased https://gerrit.wikimedia.org/r/#/c/283467/ now.
[20:20:45] <Luke081515>	 FlorianSW: So please put you feedback in here ;) https://gerrit.wikimedia.org/r/#/c/280507/
[20:20:49] <jdlrobson>	 FlorianSW: we were hoping to wrap it up :)
[20:20:55] <jdlrobson>	 paladox: on it
[20:21:01] <paladox>	 Thanks
[20:21:35] <FlorianSW>	 jdlrobson Luke081515 I'm currently downloading the change (and resetting my local environment after I messed it up). Then I'll take a look what tests I could produce :)
[20:21:59] <Luke081515>	 since last week we have a online testcluster too :)
[20:23:26] <paladox>	 jdlrobson: Would you be able to review and merge https://gerrit.wikimedia.org/r/#/c/288818/ please. It ads phplint to composer
[20:23:38] <paladox>	 centralauth currently is not linted for by php.
[20:23:42] <paladox>	 That patch adds it
[20:23:57] <jdlrobson>	 paladox: there is no task on it
[20:24:27] <jdlrobson>	 it looks fine but are the maintainers e.g. csteipp okay with that?
[20:24:42] <paladox>	 jdlrobson: Nope, but im going through repos adding missing tests.
[20:24:42] <jdlrobson>	 will they use that?
[20:24:50] <MGC_>	 So, I'm back
[20:24:55] <paladox>	 It would only be used for linting.
[20:25:34] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/283467/6 < paladox your rebase didnt go well
[20:26:03] <paladox>	 Oh
[20:28:02] <paladox>	 jdlrobson: csteipp: says he is ok with it.
[20:29:40] <MGC_>	 https://gerrit.wikimedia.org/r/#/c/283467/7/i18n/en.json < I'm unsure about the localization here
[20:29:59] <paladox>	 jdlrobson i think i fixed the test failure now at https://gerrit.wikimedia.org/r/#/c/283467/
[20:29:59] <MGC_>	 Isn't there log-action-filter-suppress missing? 
[20:30:06] <paladox>	 thanks for telling me about the errors
[20:30:29] <bawolff>	 On paladox's patch, how come jenkins-bot doesn't seem to actually do the lint check (only composer validate)
[20:30:54] <bawolff>	 unless I missed something
[20:31:31] <paladox>	 bawolff we need to add composer-test to centralauth
[20:31:52] <paladox>	 bawolff https://gerrit.wikimedia.org/r/#/c/288819/
[20:32:07] <bawolff>	 cool
[20:33:32] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/177181/2 < twentyafterfour is that something that's ever likely to get merged?
[20:33:34] <jdlrobson>	 given S is gone
[20:34:10] <paladox>	 bawolff we can do check experimental which runs composer-test
[20:34:12] <twentyafterfour>	 jdlrobson: looking
[20:34:21] <bawolff>	 paladox: oh cool
[20:35:28] <grrrit-wm>	 (03CR) 10JanZerebecki: [C: 032] "I personally prefer the verbose variant because of the reason Hashar outlined above. Merging because this seems more popular." [core] - 10https://gerrit.wikimedia.org/r/289629 (owner: 10Ori.livneh)
[20:35:29] <twentyafterfour>	 jdlrobson: looks like it's mostly good, I'll take over that patch
[20:36:06] <grrrit-wm>	 (03PS4) 10Gerrit Patch Uploader: EditPage: Use localized special page links for 'anoneditwarning' [core] - 10https://gerrit.wikimedia.org/r/269059 
[20:36:10] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/269059 (owner: 10Gerrit Patch Uploader)
[20:36:13] <grrrit-wm>	 (03CR) 10Fomafix: EditPage: Use localized special page links for 'anoneditwarning' (033 comments) [core] - 10https://gerrit.wikimedia.org/r/269059 (owner: 10Gerrit Patch Uploader)
[20:36:16] <jdlrobson>	 twentyafterfour: sweet
[20:37:22] <grrrit-wm>	 (03CR) 10Luke081515: "recheck" [core] - 10https://gerrit.wikimedia.org/r/269059 (owner: 10Gerrit Patch Uploader)
[20:39:27] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Needs a rebase. Siebrand is this still relevant?" [core] - 10https://gerrit.wikimedia.org/r/143025 (owner: 10Kunalgrover05)
[20:40:59] <jdlrobson>	 twentyafterfour: what about GitWeb? https://gerrit.wikimedia.org/r/#/c/135910/
[20:41:24] <grrrit-wm>	 (03PS3) 10Jdlrobson: Add oi_sha1, oi_timestamp log_search relations for upload overwrites [core] - 10https://gerrit.wikimedia.org/r/167392 (owner: 10Brian Wolff)
[20:41:37] <jdlrobson>	 bawolff: what's going on with https://gerrit.wikimedia.org/r/#/c/167392/ ? want to reboot that?
[20:41:47] <jdlrobson>	 2 years old :)
[20:42:06] <bawolff>	 Umm good question
[20:43:04] <twentyafterfour>	 jdlrobson: I don't know anything about mediawiki/extensions/GitWeb
[20:43:11] <twentyafterfour>	 is that actively used?
[20:43:30] <bawolff>	 I don't even remember the context about why I wanted that patch
[20:43:36] <jdlrobson>	 twentyafterfour: ah sorry i thought that was git web the repo :)
[20:43:50] <jdlrobson>	 seems Jeroen De Dauw is the owner
[20:43:52] <Luke081515>	 bawolff: and the patch has a dependencie too ;)
[20:44:22] <bawolff>	 Right. Anomie didn't like the idea of exposing log_relations in the api
[20:45:24] <bawolff>	 Oh, and modern day me agrees with his complaint on that patch
[20:45:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: PHPUnit: turn off verbose option [core] - 10https://gerrit.wikimedia.org/r/289629 (owner: 10Ori.livneh)
[20:45:35] <MGC_>	 https://gerrit.wikimedia.org/r/#/c/258413/ < Anything blocking this commit
[20:45:37] <MGC_>	 ?
[20:46:28] <bawolff>	 And I think I semi-normalized the timestamp for image uploads, making that patch less needed anyways
[20:46:30] <grrrit-wm>	 (03PS3) 10Florianschmidtwelzow: Allow to define exceptions for Special:UncategorizedCategories on-wiki [core] - 10https://gerrit.wikimedia.org/r/280507 (https://phabricator.wikimedia.org/T126117) 
[20:46:37] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Parent patch is -1ed. Mega rebase needed." [core] - 10https://gerrit.wikimedia.org/r/137915 (owner: 10Kunalgrover05)
[20:46:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add oi_sha1, oi_timestamp log_search relations for upload overwrites [core] - 10https://gerrit.wikimedia.org/r/167392 (owner: 10Brian Wolff)
[20:46:43] <grrrit-wm>	 (03Abandoned) 10Brian Wolff: Show log_search relations in API log events output. [core] - 10https://gerrit.wikimedia.org/r/167393 (owner: 10Brian Wolff)
[20:46:53] <FlorianSW>	 jdlrobson, Luke081515 I added a test for it :)
[20:47:01] <FlorianSW>	 hope it's fine now :)
[20:47:18] <grrrit-wm>	 (03PS4) 10Florianschmidtwelzow: Allow to define exceptions for Special:UncategorizedCategories on-wiki [core] - 10https://gerrit.wikimedia.org/r/280507 (https://phabricator.wikimedia.org/T126117) 
[20:47:19] <jdlrobson>	 FlorianSW: looking
[20:47:29] <twentyafterfour>	 MGC_: that looks reasonable to me
[20:47:38] * twentyafterfour hasn't looked at the code in depth though
[20:47:46] <bawolff>	 MGC_: Do we actually want to remove log entries from disabled extensions
[20:48:11] <bawolff>	 Ignoring the case with hidden log entries, it strikes me that keeping old log entries around might be something wanted
[20:48:38] <bawolff>	 I don't have strong feelings on that, just unsure
[20:48:41] <MGC_>	 The patrol use case is even left if these entries aren't kept
[20:49:05] <bawolff>	 oh, i see you still have a url parameter
[20:49:13] <MGC_>	 yes
[20:49:46] <FlorianSW>	 is there someone who is freaky enough to take a look at ConfirmEdit patches? :D -> https://gerrit.wikimedia.org/r/#/c/277051/ -> https://gerrit.wikimedia.org/r/#/c/265529/ -> https://gerrit.wikimedia.org/r/#/c/185089/ -> https://gerrit.wikimedia.org/r/#/c/272331/
[20:49:50] <bawolff>	 Umm, does this affect what indexes the query uses?
[20:51:47] <grrrit-wm>	 (03Abandoned) 10Brian Wolff: Add oi_sha1, oi_timestamp log_search relations for upload overwrites [core] - 10https://gerrit.wikimedia.org/r/167392 (owner: 10Brian Wolff)
[20:56:42] <bawolff>	 FlorianSW: for the first one. Is postion => top needed on the css?
[20:56:58] <bawolff>	 I thought we didn't use position => top anymore
[20:57:04] <bawolff>	 but i don't follow RL very closely
[20:57:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Allow to define exceptions for Special:UncategorizedCategories on-wiki [core] - 10https://gerrit.wikimedia.org/r/280507 (https://phabricator.wikimedia.org/T126117) (owner: 10Florianschmidtwelzow)
[20:57:36] <FlorianSW>	 bawolff: me, too :/ I thought it's still needed.
[21:00:35] <bawolff>	 Hmm, Resources.php is still full of position => "top", so maybe you're right
[21:00:52] <jdlrobson>	 FlorianSW: freaky enough haha
[21:01:36] <jdlrobson>	 FlorianSW: does ConfirmEdit have a maintainer/
[21:01:44] <FlorianSW>	 jdlrobson: yes, me :P
[21:01:50] <FlorianSW>	 (and legoktm sometimes)
[21:02:09] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" [core] - 10https://gerrit.wikimedia.org/r/143015 (owner: 10Kunalgrover05)
[21:10:57] <grrrit-wm>	 (03PS1) 10Mattflaschen: RevDel: Fix ChangeTags for archived items [core] - 10https://gerrit.wikimedia.org/r/289756 (https://phabricator.wikimedia.org/T128980) 
[21:16:45] <bawolff>	 FlorianSW: Another cool thing to possibly do, would be to have the start and end of the range as extra columns
[21:24:32] <grrrit-wm>	 (03PS1) 10TheDJ: Revert "Convert Special:WhatLinksHere from XML form to OOUI form" [core] - 10https://gerrit.wikimedia.org/r/289770 (https://phabricator.wikimedia.org/T135773) 
[21:26:05] <grrrit-wm>	 (03PS2) 10TheDJ: Revert "Convert Special:WhatLinksHere from XML form to OOUI form" [core] - 10https://gerrit.wikimedia.org/r/289770 (https://phabricator.wikimedia.org/T135773) 
[21:29:34] <Luke081515>	 seems like the second review hour was a bit less used
[21:29:43] <Luke081515>	 conclusion?
[21:30:44] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Revert "Convert Special:WhatLinksHere from XML form to OOUI form" [core] - 10https://gerrit.wikimedia.org/r/289770 (https://phabricator.wikimedia.org/T135773) (owner: 10TheDJ)
[21:31:58] <bawolff>	 I only even found out it was going on by accident...
[21:32:18] <Luke081515>	 :O
[21:32:35] <Luke081515>	 how we can improve that?
[21:32:46] <grrrit-wm>	 (03PS1) 10TheDJ: Revert "Convert Special:WhatLinksHere from XML form to OOUI form" [core] (wmf/1.28.0-wmf.2) - 10https://gerrit.wikimedia.org/r/289772 (https://phabricator.wikimedia.org/T135773) 
[21:33:44] * bawolff thinks it would be better to have it in #wikimedia-dev. More likely to attract drive by attention
[21:35:17] <bawolff>	 Or at least post something like "Code review office hours starting now in #wikimedia-codereview" in several common channels, right when office hours start
[21:37:54] <Luke081515>	 I think the second one is better, the first one would require a grrrit in tech, if we use the same concept
[21:37:54] <thedj>	 also, for me this heavily conflicted with dealing with the deploy to en.wp fallout :(
[21:38:19] <Luke081515>	 thedj: you mean deployment to group2?
[21:38:30] <thedj>	 yes
[21:40:16] <Luke081515>	 thedj: so a second hour would help?
[21:40:45] <thedj>	 for me it would