[00:03:37] (03Merged) 10jenkins-bot: Upgrade mismatched begin() warnings to exceptions [core] - 10https://gerrit.wikimedia.org/r/260890 (owner: 10Aaron Schulz) [00:12:32] (03PS1) 10Tim Starling: In removeHTMLtags, silently normalize self-closing tags [core] - 10https://gerrit.wikimedia.org/r/287154 [00:13:23] (03CR) 10Tim Starling: "My alternative: https://gerrit.wikimedia.org/r/287154" [core] - 10https://gerrit.wikimedia.org/r/286928 (https://phabricator.wikimedia.org/T134423) (owner: 10Cscott) [01:18:37] (03CR) 10Bartosz Dziewoński: "This is inspired by https://gerrit.wikimedia.org/r/#/c/251797/ ." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/287103 (https://phabricator.wikimedia.org/T118097) (owner: 10Bartosz Dziewoński) [01:19:44] (03PS5) 10Aaron Schulz: Batch links updates performed by refreshLinks jobs [core] - 10https://gerrit.wikimedia.org/r/287007 (https://phabricator.wikimedia.org/T109943) [01:28:12] (03PS6) 10Aaron Schulz: Batch links updates performed by refreshLinks jobs [core] - 10https://gerrit.wikimedia.org/r/287007 (https://phabricator.wikimedia.org/T109943) [03:13:07] (03PS1) 10Tim Starling: Split out doBlockLevels() into its own class [core] - 10https://gerrit.wikimedia.org/r/287162 [03:17:57] (03CR) 10jenkins-bot: [V: 04-1] Split out doBlockLevels() into its own class [core] - 10https://gerrit.wikimedia.org/r/287162 (owner: 10Tim Starling) [03:23:35] (03PS2) 10Tim Starling: Split out doBlockLevels() into its own class [core] - 10https://gerrit.wikimedia.org/r/287162 [04:35:41] (03PS3) 10Tim Starling: Split out doBlockLevels() into its own class [core] - 10https://gerrit.wikimedia.org/r/287162 [04:43:43] (03PS4) 10Tim Starling: Split out doBlockLevels() into its own class [core] - 10https://gerrit.wikimedia.org/r/287162 [04:43:46] (03PS1) 10Tim Starling: BlockLevelPass: minor changes due to initial code review [core] - 10https://gerrit.wikimedia.org/r/287170 [06:28:48] (03PS4) 10Legoktm: Fix deleting pages/files when using Microsoft SQL Server [core] - 10https://gerrit.wikimedia.org/r/287049 (owner: 10Skizzerz) [06:29:07] (03CR) 10Legoktm: [C: 032] Fix deleting pages/files when using Microsoft SQL Server [core] - 10https://gerrit.wikimedia.org/r/287049 (owner: 10Skizzerz) [06:35:43] (03Merged) 10jenkins-bot: Fix deleting pages/files when using Microsoft SQL Server [core] - 10https://gerrit.wikimedia.org/r/287049 (owner: 10Skizzerz) [06:41:33] (03CR) 10Nikerabbit: [C: 032] Add missing 'public' keywords to some more Language methods [core] - 10https://gerrit.wikimedia.org/r/279697 (owner: 10Ricordisamoa) [06:43:59] (03PS1) 10Legoktm: Fix deleting pages/files when using Microsoft SQL Server [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/287172 [06:44:06] (03CR) 10Legoktm: [C: 032] Fix deleting pages/files when using Microsoft SQL Server [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/287172 (owner: 10Legoktm) [06:46:48] (03CR) 10Nikerabbit: "We do not usually remove existing aliases because people might have links using them we do not want to break." [core] - 10https://gerrit.wikimedia.org/r/287116 (owner: 10Urbanecm) [06:51:36] (03Merged) 10jenkins-bot: Add missing 'public' keywords to some more Language methods [core] - 10https://gerrit.wikimedia.org/r/279697 (owner: 10Ricordisamoa) [06:51:42] (03Merged) 10jenkins-bot: Fix deleting pages/files when using Microsoft SQL Server [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/287172 (owner: 10Legoktm) [07:09:38] (03CR) 10Urbanecm: "But "Resetovat heslo" can be translated as Reset password but not as Change password. Correct Czech alias is "Změnit heslo"." [core] - 10https://gerrit.wikimedia.org/r/287116 (owner: 10Urbanecm) [08:19:03] (03PS7) 10WMDE-leszek: Add tests for ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/282918 [08:26:59] (03CR) 10Nikerabbit: "Are you talking ResetPassword in some extension? Only ResetPassword in core as far as I can see is an alias for ChangePassword." [core] - 10https://gerrit.wikimedia.org/r/287116 (owner: 10Urbanecm) [08:47:32] (03PS10) 10Addshore: Make WatchedItemStore use MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/283463 [08:47:39] (03PS8) 10Addshore: Remove WatchedItemStore::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/283683 [08:50:03] (03PS3) 10Addshore: Add tests for MediawikiTestCase::setService stuff [core] - 10https://gerrit.wikimedia.org/r/286432 [09:00:47] (03CR) 10Addshore: [C: 032] "re +2 (daniel already has) to poke CI for gate sumbit.." [core] - 10https://gerrit.wikimedia.org/r/283463 (owner: 10Addshore) [09:01:08] (03CR) 10Addshore: [C: 032] "re +2 (daniel already has) to poke CI for gate sumbit.." [core] - 10https://gerrit.wikimedia.org/r/283683 (owner: 10Addshore) [09:08:13] (03Merged) 10jenkins-bot: Make WatchedItemStore use MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/283463 (owner: 10Addshore) [09:09:23] (03Merged) 10jenkins-bot: Remove WatchedItemStore::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/283683 (owner: 10Addshore) [09:22:49] (03PS5) 10Addshore: add setNotificationTimestampsForUser to WatchedItemStore [core] - 10https://gerrit.wikimedia.org/r/286880 (https://phabricator.wikimedia.org/T134387) [09:24:35] (03PS6) 10Addshore: add setNotificationTimestampsForUser to WatchedItemStore [core] - 10https://gerrit.wikimedia.org/r/286880 (https://phabricator.wikimedia.org/T134387) [09:26:24] (03PS1) 10Addshore: Use WIS::getNotificationTimestampsBatch in ApiSetNotifTimestamp [core] - 10https://gerrit.wikimedia.org/r/287184 (https://phabricator.wikimedia.org/T134387) [09:29:20] (03PS1) 10Addshore: Stoip using watchlist db group in WatchedItemStore [core] - 10https://gerrit.wikimedia.org/r/287185 [09:32:59] (03PS2) 10Addshore: Stop using watchlist db group in WatchedItemStore [core] - 10https://gerrit.wikimedia.org/r/287185 [09:33:08] (03PS3) 10Addshore: Stoip using watchlist db group in WatchedItemStore [core] - 10https://gerrit.wikimedia.org/r/287185 [09:35:34] (03Abandoned) 10Addshore: Add LinkCache to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/286436 (owner: 10Addshore) [09:36:24] (03PS7) 10Addshore: Introduce SpecialPageFatalTest [core] - 10https://gerrit.wikimedia.org/r/279367 [09:37:58] (03CR) 10Addshore: "@Umherirrender" [core] - 10https://gerrit.wikimedia.org/r/279367 (owner: 10Addshore) [09:40:10] (03CR) 10Jcrespo: "For things like getWatchedItemsForUser, it may make a differenece, as the user table will be partitioned." [core] - 10https://gerrit.wikimedia.org/r/287185 (owner: 10Addshore) [09:40:14] (03Abandoned) 10Addshore: Add getPageProps to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/284163 (owner: 10Addshore) [09:41:18] (03CR) 10Addshore: "@Jcrespo okay!" [core] - 10https://gerrit.wikimedia.org/r/287185 (owner: 10Addshore) [09:41:58] (03CR) 10jenkins-bot: [V: 04-1] Introduce SpecialPageFatalTest [core] - 10https://gerrit.wikimedia.org/r/279367 (owner: 10Addshore) [09:42:46] (03CR) 10Urbanecm: "I mean Special:PasswordReset, this page is in core, isn't it?" [core] - 10https://gerrit.wikimedia.org/r/287116 (owner: 10Urbanecm) [09:46:31] (03CR) 10Addshore: [C: 031] Add TTL_PROC_* constants for clarity [core] - 10https://gerrit.wikimedia.org/r/287151 (owner: 10Aaron Schulz) [09:46:59] (03CR) 10Addshore: [C: 032] Do not let DataUpdate exceptions block other deferred updates [core] - 10https://gerrit.wikimedia.org/r/285518 (owner: 10Aaron Schulz) [09:47:40] (03CR) 10Addshore: [C: 032] Tweak RefreshLinksJob cache logic [core] - 10https://gerrit.wikimedia.org/r/286584 (owner: 10Aaron Schulz) [09:54:19] (03CR) 10Jcrespo: "Anything that uses the tables user or logging *may* be affected, specially on larger wikis. Please note that I am not disagreeing with the" [core] - 10https://gerrit.wikimedia.org/r/287185 (owner: 10Addshore) [09:55:31] (03Merged) 10jenkins-bot: Do not let DataUpdate exceptions block other deferred updates [core] - 10https://gerrit.wikimedia.org/r/285518 (owner: 10Aaron Schulz) [09:55:40] (03Merged) 10jenkins-bot: Tweak RefreshLinksJob cache logic [core] - 10https://gerrit.wikimedia.org/r/286584 (owner: 10Aaron Schulz) [10:21:40] (03CR) 10Nikerabbit: "Ok that makes sense. But why not add the new translation for that in this commit directly?" [core] - 10https://gerrit.wikimedia.org/r/287116 (owner: 10Urbanecm) [10:41:24] (03PS6) 10Addshore: Add wfDeprecated calls to WatchedItem [core] - 10https://gerrit.wikimedia.org/r/286895 [10:42:12] (03CR) 10jenkins-bot: [V: 04-1] Add wfDeprecated calls to WatchedItem [core] - 10https://gerrit.wikimedia.org/r/286895 (owner: 10Addshore) [10:43:03] (03PS7) 10Addshore: Add wfDeprecated calls to WatchedItem [core] - 10https://gerrit.wikimedia.org/r/286895 [10:48:04] (03CR) 10jenkins-bot: [V: 04-1] Add wfDeprecated calls to WatchedItem [core] - 10https://gerrit.wikimedia.org/r/286895 (owner: 10Addshore) [10:57:14] (03CR) 10Nikerabbit: "See https://phabricator.wikimedia.org/T102744" [core] - 10https://gerrit.wikimedia.org/r/282426 (owner: 10Umherirrender) [11:14:12] (03CR) 10Ricordisamoa: "Isn't resources/lib pulled from upstream? I'd like to know where is upstream in this case. Thanks in advance." [core] - 10https://gerrit.wikimedia.org/r/260950 (https://phabricator.wikimedia.org/T114007) (owner: 10Jdlrobson) [11:30:06] (03PS2) 10Urbanecm: "Resetovat heslo" is translation of PasswordReset [core] - 10https://gerrit.wikimedia.org/r/287116 [11:31:27] (03CR) 10Urbanecm: "Set an alias for PasswordReset. Is it good?" [core] - 10https://gerrit.wikimedia.org/r/287116 (owner: 10Urbanecm) [11:32:27] (03PS3) 10Urbanecm: Changed translation of ChangePassword and PasswordReset [core] - 10https://gerrit.wikimedia.org/r/287116 [11:59:46] (03CR) 10Florianschmidtwelzow: [C: 04-1] Convert Special:DeletedContributions to use OOUI. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/287134 (https://phabricator.wikimedia.org/T134525) (owner: 10Sethakill) [12:06:27] (03CR) 10Florianschmidtwelzow: "Code looks good, but the form is really big now and you don't see the content of the page (the table with the messages) without scrolling " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/286944 (owner: 10Sethakill) [12:11:08] (03CR) 10Florianschmidtwelzow: [C: 032] "Thanks! :)" [core] - 10https://gerrit.wikimedia.org/r/286881 (owner: 10Ricordisamoa) [12:17:17] (03PS1) 10Florianschmidtwelzow: Fix mode of files (755 -> 644) [core] - 10https://gerrit.wikimedia.org/r/287200 [12:18:06] (03CR) 10Florianschmidtwelzow: "Interesting, I haven't changed it intentionally and there's no need for this file mode. Fixed in I779534561ccb38." [core] - 10https://gerrit.wikimedia.org/r/286241 (https://phabricator.wikimedia.org/T133628) (owner: 10Florianschmidtwelzow) [12:18:19] (03Merged) 10jenkins-bot: Do not show useless form at Special:ChangeContentModel [core] - 10https://gerrit.wikimedia.org/r/286881 (owner: 10Ricordisamoa) [12:18:22] (03PS5) 10Florianschmidtwelzow: Search: Change dataLocation default value and add docs [core] - 10https://gerrit.wikimedia.org/r/284239 [12:28:37] (03CR) 10Florianschmidtwelzow: "> The form should be always displayed at the top." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/236270 (owner: 10Ricordisamoa) [12:34:15] (03PS1) 10Aaron Schulz: Bump PRESUME_FRESH_TTL_SEC to 10 to improve hit rate and avoid link queries [core] - 10https://gerrit.wikimedia.org/r/287201 [12:34:45] (03PS8) 10Umherirrender: Rewrite autopromote code with handlers [core] - 10https://gerrit.wikimedia.org/r/267527 [12:36:07] (03CR) 10Umherirrender: "Patch Set 8: Rebased and moved to 1.28" [core] - 10https://gerrit.wikimedia.org/r/267527 (owner: 10Umherirrender) [12:38:17] (03CR) 10jenkins-bot: [V: 04-1] Rewrite autopromote code with handlers [core] - 10https://gerrit.wikimedia.org/r/267527 (owner: 10Umherirrender) [12:39:50] (03PS4) 10Nikerabbit: Changed translation of ChangePassword and PasswordReset [core] - 10https://gerrit.wikimedia.org/r/287116 (owner: 10Urbanecm) [12:40:33] (03CR) 10Nikerabbit: [C: 032] "Looks good to me. As it is non-primary alias before and after, impact should be minimal." [core] - 10https://gerrit.wikimedia.org/r/287116 (owner: 10Urbanecm) [12:44:29] (03PS2) 10Umherirrender: Allow blocks in sql strict mode by use of numeric boolean [core] - 10https://gerrit.wikimedia.org/r/281711 [12:46:39] (03PS9) 10Umherirrender: Rewrite autopromote code with handlers [core] - 10https://gerrit.wikimedia.org/r/267527 [12:47:29] (03CR) 10jenkins-bot: [V: 04-1] Changed translation of ChangePassword and PasswordReset [core] - 10https://gerrit.wikimedia.org/r/287116 (owner: 10Urbanecm) [12:47:32] (03CR) 10Umherirrender: "Patch Set 9: Fixed json" [core] - 10https://gerrit.wikimedia.org/r/267527 (owner: 10Umherirrender) [13:06:52] (03CR) 10Urbanecm: "Thanks for +2 but what's with jenkins-bot and its -2?" [core] - 10https://gerrit.wikimedia.org/r/287116 (owner: 10Urbanecm) [13:35:02] (03PS8) 10WMDE-leszek: Add tests for ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/282918 [13:38:24] (03CR) 10Nikerabbit: "recheck" [core] - 10https://gerrit.wikimedia.org/r/287116 (owner: 10Urbanecm) [13:38:30] (03PS9) 10WMDE-leszek: Add tests for ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/282918 [13:43:33] (03CR) 10jenkins-bot: [V: 04-1] Add tests for ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/282918 (owner: 10WMDE-leszek) [13:43:48] (03CR) 10Nikerabbit: "Was unrelated temporary failure." [core] - 10https://gerrit.wikimedia.org/r/287116 (owner: 10Urbanecm) [13:50:20] (03CR) 10Urbanecm: "Thanks." [core] - 10https://gerrit.wikimedia.org/r/287116 (owner: 10Urbanecm) [14:10:27] (03CR) 10Daniel Kinzler: [C: 032] Add tests for MediawikiTestCase::setService stuff [core] - 10https://gerrit.wikimedia.org/r/286432 (owner: 10Addshore) [14:16:37] (03CR) 10jenkins-bot: [V: 04-1] Add tests for MediawikiTestCase::setService stuff [core] - 10https://gerrit.wikimedia.org/r/286432 (owner: 10Addshore) [14:17:39] (03PS1) 10Urbanecm: Set aliases for special pages in Czech [core] - 10https://gerrit.wikimedia.org/r/287216 [14:18:06] (03CR) 10Daniel Kinzler: [C: 04-1] "Please add a unit test for the new method to LanguageTest." [core] - 10https://gerrit.wikimedia.org/r/253851 (owner: 10Gerrit Patch Uploader) [14:29:10] (03CR) 10WMDE-leszek: Add tests for ApiQueryWatchlist (031 comment) [core] - 10https://gerrit.wikimedia.org/r/282918 (owner: 10WMDE-leszek) [14:29:17] (03CR) 10Addshore: "recheck" [core] - 10https://gerrit.wikimedia.org/r/286895 (owner: 10Addshore) [14:29:29] (03CR) 10WMDE-leszek: Add tests for ApiQueryWatchlist (035 comments) [core] - 10https://gerrit.wikimedia.org/r/282918 (owner: 10WMDE-leszek) [14:30:48] (03CR) 10WMDE-leszek: "PS9 is a rewrite of tests, including comments posted on PS5" [core] - 10https://gerrit.wikimedia.org/r/282918 (owner: 10WMDE-leszek) [14:31:10] (03PS8) 10Addshore: Add wfDeprecated calls to WatchedItem [core] - 10https://gerrit.wikimedia.org/r/286895 [14:31:22] (03PS9) 10Addshore: Add wfDeprecated calls to WatchedItem [core] - 10https://gerrit.wikimedia.org/r/286895 [14:35:30] (03PS4) 10Addshore: Add tests for MediawikiTestCase::setService stuff [core] - 10https://gerrit.wikimedia.org/r/286432 [14:46:41] (03CR) 10Addshore: [C: 032] "re +2 to poke jenkins (daniel has already +2ed this)" [core] - 10https://gerrit.wikimedia.org/r/286432 (owner: 10Addshore) [14:52:35] (03Merged) 10jenkins-bot: Add tests for MediawikiTestCase::setService stuff [core] - 10https://gerrit.wikimedia.org/r/286432 (owner: 10Addshore) [15:01:56] (03PS1) 10Addshore: Add @since tags for TestUser::getUser/Password [core] - 10https://gerrit.wikimedia.org/r/287225 [15:02:31] (03CR) 10Jforrester: "https://phabricator.wikimedia.org/diffusion/GOJR/" [core] - 10https://gerrit.wikimedia.org/r/260950 (https://phabricator.wikimedia.org/T114007) (owner: 10Jdlrobson) [15:03:19] (03CR) 10Hoo man: [C: 032] Add @since tags for TestUser::getUser/Password [core] - 10https://gerrit.wikimedia.org/r/287225 (owner: 10Addshore) [15:07:01] (03PS1) 10Addshore: Remove uses of deprecated TestUser properties [core] - 10https://gerrit.wikimedia.org/r/287228 [15:10:40] (03CR) 10Matěj Suchánek: [C: 04-1] "Some of these special pages are not in core and should be translated in extensions." [core] - 10https://gerrit.wikimedia.org/r/287216 (owner: 10Urbanecm) [15:10:59] (03Merged) 10jenkins-bot: Add @since tags for TestUser::getUser/Password [core] - 10https://gerrit.wikimedia.org/r/287225 (owner: 10Addshore) [15:11:51] (03PS1) 10Addshore: Make deprecated TestUser properties private [core] - 10https://gerrit.wikimedia.org/r/287230 [15:14:24] (03Abandoned) 10Urbanecm: Set aliases for special pages in Czech [core] - 10https://gerrit.wikimedia.org/r/287216 (owner: 10Urbanecm) [15:16:07] (03CR) 10Urbanecm: "Ok, abandoned. Can you explain (or give me a link) how can I translate special page names in extension? And how can I check if a special p" [core] - 10https://gerrit.wikimedia.org/r/287216 (owner: 10Urbanecm) [15:17:03] (03CR) 10jenkins-bot: [V: 04-1] Make deprecated TestUser properties private [core] - 10https://gerrit.wikimedia.org/r/287230 (owner: 10Addshore) [15:17:58] (03CR) 10Addshore: "Woo, PS6 reduced the test time from 144 seconds to 55 for me! :)" [core] - 10https://gerrit.wikimedia.org/r/282918 (owner: 10WMDE-leszek) [15:19:55] (03CR) 10Matěj Suchánek: "All core special pages are in includes/specials/. If you find any other, it propably comes from an extension which should have an *.alias." [core] - 10https://gerrit.wikimedia.org/r/287216 (owner: 10Urbanecm) [15:20:27] (03PS2) 10Addshore: Make deprecated TestUser properties private [core] - 10https://gerrit.wikimedia.org/r/287230 [15:22:16] (03CR) 10Urbanecm: "Thanks." [core] - 10https://gerrit.wikimedia.org/r/287216 (owner: 10Urbanecm) [15:23:21] (03PS3) 10Sethakill: Convert Special:AllMessages to use OOUI. [core] - 10https://gerrit.wikimedia.org/r/286944 [15:26:47] (03CR) 10jenkins-bot: [V: 04-1] Make deprecated TestUser properties private [core] - 10https://gerrit.wikimedia.org/r/287230 (owner: 10Addshore) [15:31:09] (03PS3) 10Addshore: Make deprecated TestUser properties private [core] - 10https://gerrit.wikimedia.org/r/287230 [15:34:26] (03PS2) 10Matěj Suchánek: Add Czech aliases to most special pages [core] - 10https://gerrit.wikimedia.org/r/284858 [15:34:49] (03CR) 10jenkins-bot: [V: 04-1] Add Czech aliases to most special pages [core] - 10https://gerrit.wikimedia.org/r/284858 (owner: 10Matěj Suchánek) [15:35:53] (03CR) 10Urbanecm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/284858 (owner: 10Matěj Suchánek) [15:36:32] (03CR) 10jenkins-bot: [V: 04-1] Make deprecated TestUser properties private [core] - 10https://gerrit.wikimedia.org/r/287230 (owner: 10Addshore) [15:38:46] (03CR) 10Urbanecm: [C: 04-1] "See comment." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284858 (owner: 10Matěj Suchánek) [15:41:58] (03PS3) 10Urbanecm: Add Czech aliases to most special pages [core] - 10https://gerrit.wikimedia.org/r/284858 (owner: 10Matěj Suchánek) [15:44:37] (03CR) 10Urbanecm: "Why there are no ASCII-only aliases as the others have it?" [core] - 10https://gerrit.wikimedia.org/r/284858 (owner: 10Matěj Suchánek) [15:44:50] (03CR) 10Urbanecm: "PS3: Rebase." [core] - 10https://gerrit.wikimedia.org/r/284858 (owner: 10Matěj Suchánek) [15:49:25] (03CR) 10Matěj Suchánek: "Thanks, you actually helped me quite a lot." [core] - 10https://gerrit.wikimedia.org/r/284858 (owner: 10Matěj Suchánek) [15:50:14] (03PS4) 10Sethakill: Convert Special:AllMessages to use OOUI. [core] - 10https://gerrit.wikimedia.org/r/286944 [15:50:49] (03CR) 10Matěj Suchánek: Add Czech aliases to most special pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284858 (owner: 10Matěj Suchánek) [15:53:02] (03CR) 10Sethakill: "I know it. The filter options should be inline but it doesn't work, so I created task T134424." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/286944 (owner: 10Sethakill) [16:00:43] (03CR) 10WMDE-leszek: [C: 04-1] Add tests for ApiQueryWatchlist (031 comment) [core] - 10https://gerrit.wikimedia.org/r/282918 (owner: 10WMDE-leszek) [16:04:42] (03CR) 10Urbanecm: [C: 031] "You're welcome." [core] - 10https://gerrit.wikimedia.org/r/284858 (owner: 10Matěj Suchánek) [16:05:21] (03CR) 10Urbanecm: Add Czech aliases to most special pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284858 (owner: 10Matěj Suchánek) [16:12:14] (03PS10) 10WMDE-leszek: Add tests for ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/282918 [16:18:54] (03CR) 10WMDE-leszek: "PS10 is only adding (possibly not the most elegant) way to clean up after previous tests potentially touching the watchlist table." [core] - 10https://gerrit.wikimedia.org/r/282918 (owner: 10WMDE-leszek) [16:29:27] (03PS8) 10WMDE-leszek: Refactor database-related code in ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/284169 (https://phabricator.wikimedia.org/T132565) [16:39:11] (03CR) 10WMDE-leszek: "PS8 is a manual rebase" [core] - 10https://gerrit.wikimedia.org/r/284169 (https://phabricator.wikimedia.org/T132565) (owner: 10WMDE-leszek) [17:52:16] (03CR) 10Legoktm: [C: 04-1] "update.php is supposed to be 755 I think, it even has a shebang" [core] - 10https://gerrit.wikimedia.org/r/287200 (owner: 10Florianschmidtwelzow) [17:56:40] (03CR) 10Anomie: [WIP] Refactor upload dialog to make it configurable (033 comments) [core] - 10https://gerrit.wikimedia.org/r/287103 (https://phabricator.wikimedia.org/T118097) (owner: 10Bartosz Dziewoński) [17:57:10] (03PS2) 10Sethakill: Convert Special:DeletedContributions to use OOUI. [core] - 10https://gerrit.wikimedia.org/r/287134 (https://phabricator.wikimedia.org/T134525) [18:12:50] (03PS2) 10Florianschmidtwelzow: Fix mode of files (755 -> 644) [core] - 10https://gerrit.wikimedia.org/r/287200 [18:18:15] (03CR) 10Ricordisamoa: "Do you suggest to abandon it in favor of Ieae79e8ab3fefb1b2af73961785fc63cafb2c9b6?" [core] - 10https://gerrit.wikimedia.org/r/236270 (owner: 10Ricordisamoa) [18:24:49] (03PS8) 10Legoktm: [WIP] Add TitleParser and TitleFormatter to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/285141 [18:26:09] (03PS3) 10Legoktm: registration: Fix mode of files (755 -> 644) [core] - 10https://gerrit.wikimedia.org/r/287200 (owner: 10Florianschmidtwelzow) [18:26:16] (03CR) 10Legoktm: [C: 032] registration: Fix mode of files (755 -> 644) [core] - 10https://gerrit.wikimedia.org/r/287200 (owner: 10Florianschmidtwelzow) [18:32:21] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add TitleParser and TitleFormatter to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/285141 (owner: 10Legoktm) [18:33:16] (03Merged) 10jenkins-bot: registration: Fix mode of files (755 -> 644) [core] - 10https://gerrit.wikimedia.org/r/287200 (owner: 10Florianschmidtwelzow) [18:33:52] (03PS1) 10Legoktm: registration: Fix mode of files (755 -> 644) [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/287255 [18:34:00] (03CR) 10Legoktm: [C: 032] registration: Fix mode of files (755 -> 644) [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/287255 (owner: 10Legoktm) [18:36:10] (03PS1) 10Catrope: MemcachedClient: Always return an array from get_multi(), don't return false [core] - 10https://gerrit.wikimedia.org/r/287256 [18:36:51] (03PS2) 10Catrope: MemcachedClient: Always return an array from get_multi(), don't return false [core] - 10https://gerrit.wikimedia.org/r/287256 [18:38:01] (03PS3) 10BryanDavis: MemcachedClient: Always return an array from get_multi(), don't return false [core] - 10https://gerrit.wikimedia.org/r/287256 (owner: 10Catrope) [18:38:14] (03CR) 10BryanDavis: [C: 032] MemcachedClient: Always return an array from get_multi(), don't return false [core] - 10https://gerrit.wikimedia.org/r/287256 (owner: 10Catrope) [18:41:13] (03Merged) 10jenkins-bot: registration: Fix mode of files (755 -> 644) [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/287255 (owner: 10Legoktm) [18:46:40] (03Merged) 10jenkins-bot: MemcachedClient: Always return an array from get_multi(), don't return false [core] - 10https://gerrit.wikimedia.org/r/287256 (owner: 10Catrope) [19:07:55] (03PS1) 10Sethakill: Convert Special:MIMESearch to use OOUI. [core] - 10https://gerrit.wikimedia.org/r/287267 (https://phabricator.wikimedia.org/T117744) [19:40:03] (03PS1) 10Legoktm: [WIP] Bump mediawiki-codesniffer to 0.7.0 [core] - 10https://gerrit.wikimedia.org/r/287272 [19:44:01] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Bump mediawiki-codesniffer to 0.7.0 [core] - 10https://gerrit.wikimedia.org/r/287272 (owner: 10Legoktm) [19:44:09] (03PS3) 10Legoktm: Stop supporting old versions of composer for ComposerPackageModifier [core] - 10https://gerrit.wikimedia.org/r/285000 (https://phabricator.wikimedia.org/T119590) (owner: 10Ori.livneh) [19:44:18] (03CR) 10Legoktm: [C: 032] Stop supporting old versions of composer for ComposerPackageModifier [core] - 10https://gerrit.wikimedia.org/r/285000 (https://phabricator.wikimedia.org/T119590) (owner: 10Ori.livneh) [19:51:29] (03CR) 10Ori.livneh: "Thanks for seeing this through, legoktm. I won't miss that loud deprecation notice :)" [core] - 10https://gerrit.wikimedia.org/r/285000 (https://phabricator.wikimedia.org/T119590) (owner: 10Ori.livneh) [19:55:44] (03Merged) 10jenkins-bot: Stop supporting old versions of composer for ComposerPackageModifier [core] - 10https://gerrit.wikimedia.org/r/285000 (https://phabricator.wikimedia.org/T119590) (owner: 10Ori.livneh) [20:05:00] (03PS4) 10Addshore: Make deprecated TestUser properties private [core] - 10https://gerrit.wikimedia.org/r/287230 [20:08:32] (03PS1) 10Legoktm: Stop supporting old versions of composer for ComposerPackageModifier [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/287277 (https://phabricator.wikimedia.org/T119590) [20:08:35] (03CR) 10jenkins-bot: [V: 04-1] Make deprecated TestUser properties private [core] - 10https://gerrit.wikimedia.org/r/287230 (owner: 10Addshore) [20:08:40] (03CR) 10Legoktm: [C: 032] Stop supporting old versions of composer for ComposerPackageModifier [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/287277 (https://phabricator.wikimedia.org/T119590) (owner: 10Legoktm) [20:09:01] (03CR) 10Addshore: "recheck" [core] - 10https://gerrit.wikimedia.org/r/287230 (owner: 10Addshore) [20:16:00] (03Merged) 10jenkins-bot: Stop supporting old versions of composer for ComposerPackageModifier [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/287277 (https://phabricator.wikimedia.org/T119590) (owner: 10Legoktm) [20:18:35] (03CR) 10Ricordisamoa: [C: 04-1] Convert Special:MIMESearch to use OOUI. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/287267 (https://phabricator.wikimedia.org/T117744) (owner: 10Sethakill) [20:26:50] (03PS1) 10Paladox: Update mediawiki/mediawiki-codesniffer to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/287280 [20:32:06] (03CR) 10jenkins-bot: [V: 04-1] Update mediawiki/mediawiki-codesniffer to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/287280 (owner: 10Paladox) [20:35:53] (03PS2) 10Paladox: Update mediawiki/mediawiki-codesniffer to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/287280 [20:37:56] (03PS3) 10Paladox: Update mediawiki/mediawiki-codesniffer to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/287280 [20:38:00] (03CR) 10Florianschmidtwelzow: [C: 04-1] "This change also fixes some code style errors, but doesn't mention it in the commit message." [core] - 10https://gerrit.wikimedia.org/r/287280 (owner: 10Paladox) [20:39:13] (03CR) 10Florianschmidtwelzow: [C: 04-1] Update mediawiki/mediawiki-codesniffer to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/287280 (owner: 10Paladox) [20:41:19] (03CR) 10jenkins-bot: [V: 04-1] Update mediawiki/mediawiki-codesniffer to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/287280 (owner: 10Paladox) [20:41:49] (03PS4) 10Paladox: Update mediawiki/mediawiki-codesniffer to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/287280 [20:45:09] (03PS5) 10Paladox: Update mediawiki/mediawiki-codesniffer to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/287280 [20:51:48] (03CR) 10Ricordisamoa: "T121921" [core] - 10https://gerrit.wikimedia.org/r/265303 (owner: 10Florianschmidtwelzow) [20:55:08] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/287280 (owner: 10Paladox) [21:15:35] (03CR) 10Cscott: "I think the argument is that this usage is not widespread on the wikis, and so it's easiest just to identify and fix it. Then wikitext "H" [core] - 10https://gerrit.wikimedia.org/r/286928 (https://phabricator.wikimedia.org/T134423) (owner: 10Cscott) [21:17:41] (03CR) 10Cscott: "Cross-linking https://gerrit.wikimedia.org/r/286928 for completeness." [core] - 10https://gerrit.wikimedia.org/r/287154 (owner: 10Tim Starling) [21:24:55] (03CR) 10Umherirrender: [C: 032] Update mediawiki/mediawiki-codesniffer to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/287280 (owner: 10Paladox) [21:25:14] (03Abandoned) 10Umherirrender: [WIP] Bump mediawiki-codesniffer to 0.7.0 [core] - 10https://gerrit.wikimedia.org/r/287272 (owner: 10Legoktm) [21:52:05] (03PS8) 10Florianschmidtwelzow: Structure test: Add autoload.php order check [core] - 10https://gerrit.wikimedia.org/r/265303 (https://phabricator.wikimedia.org/T121921) [21:52:29] (03CR) 10jenkins-bot: [V: 04-1] Structure test: Add autoload.php order check [core] - 10https://gerrit.wikimedia.org/r/265303 (https://phabricator.wikimedia.org/T121921) (owner: 10Florianschmidtwelzow) [22:05:20] (03CR) 10Paladox: "@Umherirrender could you re c+2 since MySQL was terminated and didn't stop testing." [core] - 10https://gerrit.wikimedia.org/r/287280 (owner: 10Paladox) [22:05:33] (03PS6) 10Paladox: Update mediawiki/mediawiki-codesniffer to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/287280 [22:06:12] (03CR) 10Paladox: "Failed https://integration.wikimedia.org/ci/job/mediawiki-core-qunit/64208/console" [core] - 10https://gerrit.wikimedia.org/r/287280 (owner: 10Paladox) [22:12:34] (03PS9) 10Florianschmidtwelzow: Structure test: Add autoload.php order check [core] - 10https://gerrit.wikimedia.org/r/265303 (https://phabricator.wikimedia.org/T121921) [22:12:58] (03CR) 10jenkins-bot: [V: 04-1] Structure test: Add autoload.php order check [core] - 10https://gerrit.wikimedia.org/r/265303 (https://phabricator.wikimedia.org/T121921) (owner: 10Florianschmidtwelzow) [22:13:28] (03CR) 10Florianschmidtwelzow: "A good point legoktm :) PS9 is another approach, hope that's better for all :)" [core] - 10https://gerrit.wikimedia.org/r/265303 (https://phabricator.wikimedia.org/T121921) (owner: 10Florianschmidtwelzow) [22:17:05] (03PS10) 10Florianschmidtwelzow: Structure test: Add autoload.php order check [core] - 10https://gerrit.wikimedia.org/r/265303 (https://phabricator.wikimedia.org/T121921) [22:19:34] (03CR) 10Florianschmidtwelzow: [C: 032] Update mediawiki/mediawiki-codesniffer to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/287280 (owner: 10Paladox) [22:24:27] (03CR) 10jenkins-bot: [V: 04-1] Structure test: Add autoload.php order check [core] - 10https://gerrit.wikimedia.org/r/265303 (https://phabricator.wikimedia.org/T121921) (owner: 10Florianschmidtwelzow) [22:27:20] (03PS1) 10Aaron Schulz: Add WebRequest::isNullipotent()/markNullipotent() methods [core] - 10https://gerrit.wikimedia.org/r/287292 (https://phabricator.wikimedia.org/T134608) [22:54:28] (03CR) 10Brion VIBBER: "Probably a good thing, but we do rebuild metadata too on purge... Do we need a separate way to ping those updates from client side?" [core] - 10https://gerrit.wikimedia.org/r/286925 (https://phabricator.wikimedia.org/T132921) (owner: 10Aaron Schulz) [23:05:04] (03CR) 10jenkins-bot: [V: 04-1] Update mediawiki/mediawiki-codesniffer to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/287280 (owner: 10Paladox) [23:06:51] (03CR) 10Jforrester: "> Thanks for seeing this through, legoktm. I won't miss that loud deprecation notice :)" [core] - 10https://gerrit.wikimedia.org/r/285000 (https://phabricator.wikimedia.org/T119590) (owner: 10Ori.livneh) [23:42:13] (03PS7) 10Paladox: Update mediawiki/mediawiki-codesniffer to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/287280 [23:42:40] (03CR) 10Paladox: "@Florianschmidtwelzow could you re c+2 please." [core] - 10https://gerrit.wikimedia.org/r/287280 (owner: 10Paladox) [23:45:44] (03PS2) 10Ori.livneh: Add TTL_PROC_* constants for clarity [core] - 10https://gerrit.wikimedia.org/r/287151 (owner: 10Aaron Schulz) [23:45:53] (03CR) 10Ori.livneh: [C: 032] Add TTL_PROC_* constants for clarity [core] - 10https://gerrit.wikimedia.org/r/287151 (owner: 10Aaron Schulz) [23:46:37] (03CR) 10Aaron Schulz: "I don't see a pressing need atm, though if you want an extra URL param for that, a patch could be made for that." [core] - 10https://gerrit.wikimedia.org/r/286925 (https://phabricator.wikimedia.org/T132921) (owner: 10Aaron Schulz) [23:49:54] (03CR) 10Brion VIBBER: "Well this patch won't stop image metadata from being purged and rebuilt will it? It just avoids active update of old metadata format iiuc" [core] - 10https://gerrit.wikimedia.org/r/286925 (https://phabricator.wikimedia.org/T132921) (owner: 10Aaron Schulz) [23:52:45] (03Merged) 10jenkins-bot: Add TTL_PROC_* constants for clarity [core] - 10https://gerrit.wikimedia.org/r/287151 (owner: 10Aaron Schulz) [23:56:39] (03CR) 10Bartosz Dziewoński: "Wait, if it keeps failing, perhaps there's an actual problem?" [core] - 10https://gerrit.wikimedia.org/r/287280 (owner: 10Paladox) [23:57:24] (03CR) 10Aaron Schulz: "maybeUpgradeRow() still gets called on cache miss. I suppose this could call maybeUpgradeRow() post-send to make sure it always gets hit o" [core] - 10https://gerrit.wikimedia.org/r/286925 (https://phabricator.wikimedia.org/T132921) (owner: 10Aaron Schulz)