[04:20:36] (03CR) 10Tim Starling: [C: 031] "I've tested it now, with maxqueue=1 and a fake client holding the slot indefinitely. I changed the revision ID from eval.php with Revision" [core] - 10https://gerrit.wikimedia.org/r/285337 (https://phabricator.wikimedia.org/T133659) (owner: 10Tim Starling) [04:58:19] (03CR) 10Skizzerz: "As an alternative to creating a new dir so that is_writable() returns true, we could simply try creating a new file in the temp dir and su" [core] - 10https://gerrit.wikimedia.org/r/284528 (https://phabricator.wikimedia.org/T44730) (owner: 10Addshore) [05:14:47] (03PS1) 10Gerrit Patch Uploader: Do not double decode HTML entities for IDs [core] - 10https://gerrit.wikimedia.org/r/286385 (https://phabricator.wikimedia.org/T103714) [05:14:51] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/286385 (https://phabricator.wikimedia.org/T103714) (owner: 10Gerrit Patch Uploader) [05:24:26] (03PS12) 10Gerrit Patch Uploader: Do not double decode HTML entities for IDs [core] - 10https://gerrit.wikimedia.org/r/221614 (https://phabricator.wikimedia.org/T103714) [05:24:29] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/221614 (https://phabricator.wikimedia.org/T103714) (owner: 10Gerrit Patch Uploader) [05:26:08] (03CR) 10Fomafix: "rebased and changed spaces to tabs." [core] - 10https://gerrit.wikimedia.org/r/221614 (https://phabricator.wikimedia.org/T103714) (owner: 10Gerrit Patch Uploader) [07:07:43] (03CR) 10Nikerabbit: registration: Add new "UnitTests" option (031 comment) [core] - 10https://gerrit.wikimedia.org/r/286253 (https://phabricator.wikimedia.org/T126093) (owner: 10Florianschmidtwelzow) [07:11:25] (03PS2) 10Skizzerz: Update Microsoft SQL Server schema [core] - 10https://gerrit.wikimedia.org/r/285139 [07:16:01] (03CR) 10jenkins-bot: [V: 04-1] Update Microsoft SQL Server schema [core] - 10https://gerrit.wikimedia.org/r/285139 (owner: 10Skizzerz) [07:18:55] (03PS3) 10Skizzerz: Update Microsoft SQL Server schema [core] - 10https://gerrit.wikimedia.org/r/285139 [07:50:15] (03PS1) 10Sethakill: Convert Special:Activeusers to use OOUI [core] - 10https://gerrit.wikimedia.org/r/286392 (https://phabricator.wikimedia.org/T117733) [08:29:24] (03PS1) 10Whym: EditPage: Style anonymous editor preview warning as a warning box [core] - 10https://gerrit.wikimedia.org/r/286396 (https://phabricator.wikimedia.org/T127403) [08:52:22] (03PS1) 10Gerrit Patch Uploader: API: Avoid duplicate IDs in API documentation [core] - 10https://gerrit.wikimedia.org/r/286398 (https://phabricator.wikimedia.org/T134155) [08:52:25] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/286398 (https://phabricator.wikimedia.org/T134155) (owner: 10Gerrit Patch Uploader) [10:19:09] (03CR) 10Matthias Mullie: Check if user is blocked during upload process (031 comment) [core] - 10https://gerrit.wikimedia.org/r/286161 (https://phabricator.wikimedia.org/T111228) (owner: 10Matthias Mullie) [10:19:35] (03PS2) 10Matthias Mullie: Check if user is blocked during upload process [core] - 10https://gerrit.wikimedia.org/r/286161 (https://phabricator.wikimedia.org/T111228) [10:24:24] (03PS3) 10Matthias Mullie: Check if user is blocked during upload process [core] - 10https://gerrit.wikimedia.org/r/286161 (https://phabricator.wikimedia.org/T111228) [10:26:26] (03CR) 10Addshore: [C: 04-1 V: 031] "Verified this generally works and does not have the issue with MF that the previous patch did." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/286314 (owner: 10Daniel Kinzler) [10:33:04] (03PS5) 10Addshore: Make WatchedItemStore use MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/283463 [10:33:22] (03CR) 10Addshore: "PS5 is a rebase onto the redux patch" [core] - 10https://gerrit.wikimedia.org/r/283463 (owner: 10Addshore) [10:33:37] (03PS5) 10Addshore: Remove WatchedItemStore::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/283683 [10:34:18] (03PS5) 10Addshore: Add tests for ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/282918 (owner: 10WMDE-leszek) [10:34:27] (03PS7) 10Addshore: Refactor database-related code in ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/284169 (https://phabricator.wikimedia.org/T132565) (owner: 10WMDE-leszek) [10:34:47] (03PS17) 10Addshore: Use WatchedItemStore::getWatchedItemsForUser in ApiQueryWatchlistRaw [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T132566) (owner: 10WMDE-leszek) [10:58:52] (03CR) 10Daniel Kinzler: [C: 032] "Looks good to me :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/283463 (owner: 10Addshore) [11:11:09] (03CR) 10Daniel Kinzler: "I would suggest to keep the simple lookups in the store separate from complex queries. The code for complex queries could live in a separa" [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T132566) (owner: 10WMDE-leszek) [11:16:42] (03CR) 10WMDE-Fisch: [C: 031] "Apart from running slow this looks generally good. Maybe some else has hint how to speed up these tests?" [core] - 10https://gerrit.wikimedia.org/r/282918 (owner: 10WMDE-leszek) [11:21:27] (03CR) 10WMDE-leszek: "Thanks for this comment." [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T132566) (owner: 10WMDE-leszek) [12:36:52] (03CR) 10Addshore: Make WatchedItemStore use MediaWikiServices (031 comment) [core] - 10https://gerrit.wikimedia.org/r/283463 (owner: 10Addshore) [12:56:35] (03CR) 10Addshore: Add tests for ApiQueryWatchlist (037 comments) [core] - 10https://gerrit.wikimedia.org/r/282918 (owner: 10WMDE-leszek) [13:08:42] (03CR) 10Addshore: Allow reset of global services (redux). (031 comment) [core] - 10https://gerrit.wikimedia.org/r/286314 (owner: 10Daniel Kinzler) [13:09:33] (03CR) 10Addshore: Allow reset of global services (redux). (031 comment) [core] - 10https://gerrit.wikimedia.org/r/286314 (owner: 10Daniel Kinzler) [13:13:42] (03PS3) 10Addshore: Add getPageProps to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/284163 [13:18:15] (03CR) 10jenkins-bot: [V: 04-1] Add getPageProps to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/284163 (owner: 10Addshore) [13:19:41] (03CR) 10Addshore: "It sounds like that may also run into the same issue in regards to users that was described above." [core] - 10https://gerrit.wikimedia.org/r/284528 (https://phabricator.wikimedia.org/T44730) (owner: 10Addshore) [13:26:52] (03PS5) 10Addshore: wfTempDir try harder to get a tmp dir on Windows [core] - 10https://gerrit.wikimedia.org/r/284528 (https://phabricator.wikimedia.org/T44730) [13:29:27] (03CR) 10Anomie: [C: 04-1] API: Avoid duplicate IDs in API documentation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/286398 (https://phabricator.wikimedia.org/T134155) (owner: 10Gerrit Patch Uploader) [13:44:53] (03PS1) 10Addshore: User LoggerInterface::class in MediaWikiTestCaseTest [core] - 10https://gerrit.wikimedia.org/r/286429 [13:46:36] (03PS1) 10Gerrit Patch Uploader: Minify JS in jquery.makeCollapsible [core] - 10https://gerrit.wikimedia.org/r/286430 [13:46:39] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/286430 (owner: 10Gerrit Patch Uploader) [13:57:10] (03PS1) 10Addshore: Add tests for MediawikiTestCase::setService stuff [core] - 10https://gerrit.wikimedia.org/r/286432 [14:02:04] (03CR) 10Aklapper: [C: 04-1] "Needs rebasing hence temporarily marking as -1." [core] - 10https://gerrit.wikimedia.org/r/149531 (https://bugzilla.wikimedia.org/57138) (owner: 10Gerrit Patch Uploader) [14:02:52] (03PS4) 10Aklapper: [WIP] Start switching to ES6 Promises [core] - 10https://gerrit.wikimedia.org/r/160949 (owner: 10Adrian Heine) [14:03:17] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Start switching to ES6 Promises [core] - 10https://gerrit.wikimedia.org/r/160949 (owner: 10Adrian Heine) [14:09:09] (03PS2) 10Gerrit Patch Uploader: API: Avoid duplicate IDs in API documentation [core] - 10https://gerrit.wikimedia.org/r/286398 (https://phabricator.wikimedia.org/T134155) [14:09:12] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/286398 (https://phabricator.wikimedia.org/T134155) (owner: 10Gerrit Patch Uploader) [14:12:55] (03CR) 10Fomafix: API: Avoid duplicate IDs in API documentation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/286398 (https://phabricator.wikimedia.org/T134155) (owner: 10Gerrit Patch Uploader) [14:13:00] (03PS6) 10Addshore: Make WatchedItemStore use MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/283463 [14:16:14] (03CR) 10Anomie: [C: 04-1] Do not double decode HTML entities for IDs (032 comments) [core] - 10https://gerrit.wikimedia.org/r/286385 (https://phabricator.wikimedia.org/T103714) (owner: 10Gerrit Patch Uploader) [14:20:45] (03CR) 10Luke081515: "recheck" [core] - 10https://gerrit.wikimedia.org/r/286398 (https://phabricator.wikimedia.org/T134155) (owner: 10Gerrit Patch Uploader) [14:23:55] (03PS4) 10Addshore: Add getPageProps to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/284163 [14:24:23] (03CR) 10Addshore: "Not really sure why this one is having some db issues" [core] - 10https://gerrit.wikimedia.org/r/284163 (owner: 10Addshore) [14:24:43] (03Draft1) 10Addshore: Add LinkCache to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/286436 [14:25:28] (03CR) 10Anomie: [C: 031] "I wonder whether the proper solution might be to pass the 'legacy' flag to Sanitizer::escapeId(), instead of omitting the span entirely wh" [core] - 10https://gerrit.wikimedia.org/r/286398 (https://phabricator.wikimedia.org/T134155) (owner: 10Gerrit Patch Uploader) [14:26:01] (03CR) 10Aklapper: "@PGiner: Any vague idea who could review this / decide on this old rotting CSS/LESS patch by a former employee? :-/ Thanks in advance for " [core] - 10https://gerrit.wikimedia.org/r/145302 (owner: 10SG) [14:30:14] (03CR) 10jenkins-bot: [V: 04-1] Add getPageProps to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/284163 (owner: 10Addshore) [14:30:29] (03CR) 10Anomie: [C: 04-1] Make refreshLinksJob explicitly check the cache rev ID (031 comment) [core] - 10https://gerrit.wikimedia.org/r/285449 (https://phabricator.wikimedia.org/T133659) (owner: 10Aaron Schulz) [14:32:05] (03CR) 10Anomie: [C: 032] "Ok, let's do it." [core] - 10https://gerrit.wikimedia.org/r/285337 (https://phabricator.wikimedia.org/T133659) (owner: 10Tim Starling) [14:32:56] (03Abandoned) 10Gergő Tisza: [TEST] Check gerrit behavior for draft commits [core] - 10https://gerrit.wikimedia.org/r/283127 (owner: 10Gergő Tisza) [14:38:09] (03PS5) 10Addshore: Add getPageProps to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/284163 [14:42:33] (03Merged) 10jenkins-bot: In ParserCache, respect $useOutdated [core] - 10https://gerrit.wikimedia.org/r/285337 (https://phabricator.wikimedia.org/T133659) (owner: 10Tim Starling) [14:42:38] (03CR) 10jenkins-bot: [V: 04-1] Add getPageProps to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/284163 (owner: 10Addshore) [14:44:04] (03CR) 10Bartosz Dziewoński: [C: 032] Removing unicode-bidi: -webkit-isolate [core] - 10https://gerrit.wikimedia.org/r/286297 (https://phabricator.wikimedia.org/T134067) (owner: 10Amire80) [14:45:36] (03CR) 10Jforrester: [C: 032] EditPage: Style anonymous editor preview warning as a warning box [core] - 10https://gerrit.wikimedia.org/r/286396 (https://phabricator.wikimedia.org/T127403) (owner: 10Whym) [14:48:39] (03PS2) 10Bartosz Dziewoński: jquery.makeCollapsible: Simplify code [core] - 10https://gerrit.wikimedia.org/r/286430 (owner: 10Gerrit Patch Uploader) [14:50:08] (03CR) 10Bartosz Dziewoński: [C: 032] "Just a small tweak to the commit message (see https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines). Thanks!" [core] - 10https://gerrit.wikimedia.org/r/286430 (owner: 10Gerrit Patch Uploader) [14:50:17] (03Merged) 10jenkins-bot: Removing unicode-bidi: -webkit-isolate [core] - 10https://gerrit.wikimedia.org/r/286297 (https://phabricator.wikimedia.org/T134067) (owner: 10Amire80) [14:52:48] (03Merged) 10jenkins-bot: EditPage: Style anonymous editor preview warning as a warning box [core] - 10https://gerrit.wikimedia.org/r/286396 (https://phabricator.wikimedia.org/T127403) (owner: 10Whym) [14:58:20] (03Merged) 10jenkins-bot: jquery.makeCollapsible: Simplify code [core] - 10https://gerrit.wikimedia.org/r/286430 (owner: 10Gerrit Patch Uploader) [15:04:42] (03CR) 10Anomie: [C: 04-1] Split off permission to delete tags from managechangetags permission (033 comments) [core] - 10https://gerrit.wikimedia.org/r/286282 (https://phabricator.wikimedia.org/T133811) (owner: 10MGChecker) [15:26:58] (03Merged) 10jenkins-bot: Give redirects a sort index in title widget [core] - 10https://gerrit.wikimedia.org/r/286280 (https://phabricator.wikimedia.org/T134020) (owner: 10Esanders) [15:37:15] (03PS2) 10Bartosz Dziewoński: mediawiki.api: Make the result promise of #postWithToken abortable [core] - 10https://gerrit.wikimedia.org/r/285563 [15:42:46] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Welcome to the MediaWiki development and big thanks for your first change!" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/286392 (https://phabricator.wikimedia.org/T117733) (owner: 10Sethakill) [15:49:31] (03CR) 10Anomie: Factor InterwikiLookup out of Interwiki class. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/250150 (owner: 10Daniel Kinzler) [15:59:17] (03CR) 10Anomie: [C: 032] "Ok, although I dislike doing half a job." [core] - 10https://gerrit.wikimedia.org/r/237883 (https://phabricator.wikimedia.org/T112364) (owner: 10Amire80) [16:05:44] (03Merged) 10jenkins-bot: Set explicit direction to ApiHelp headers with module names [core] - 10https://gerrit.wikimedia.org/r/237883 (https://phabricator.wikimedia.org/T112364) (owner: 10Amire80) [16:12:31] (03PS2) 10Gerrit Patch Uploader: Do not double decode HTML entities for IDs [core] - 10https://gerrit.wikimedia.org/r/286385 (https://phabricator.wikimedia.org/T103714) [16:12:34] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/286385 (https://phabricator.wikimedia.org/T103714) (owner: 10Gerrit Patch Uploader) [16:12:37] (03CR) 10Anomie: Unify HTMLForm message handling (034 comments) [core] - 10https://gerrit.wikimedia.org/r/283846 (owner: 10Gergő Tisza) [16:13:03] (03CR) 10Fomafix: Do not double decode HTML entities for IDs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/286385 (https://phabricator.wikimedia.org/T103714) (owner: 10Gerrit Patch Uploader) [16:33:13] (03PS13) 10MGChecker: Split off permission to delete tags from managechangetags permission [core] - 10https://gerrit.wikimedia.org/r/286282 (https://phabricator.wikimedia.org/T133811) [16:37:39] (03PS2) 10Sethakill: Convert Special:Activeusers to use OOUI [core] - 10https://gerrit.wikimedia.org/r/286392 (https://phabricator.wikimedia.org/T117733) [16:38:47] (03CR) 10Luke081515: "recheck" [core] - 10https://gerrit.wikimedia.org/r/286282 (https://phabricator.wikimedia.org/T133811) (owner: 10MGChecker) [16:45:23] (03CR) 10Bartosz Dziewoński: "Eh, I think the API should just provide this parameter for this error message, as it does for many others. Or we could just use the name t" [core] - 10https://gerrit.wikimedia.org/r/285401 (https://phabricator.wikimedia.org/T115946) (owner: 10Matthias Mullie) [16:54:26] (03PS13) 10Gerrit Patch Uploader: Do not double decode HTML entities for IDs [core] - 10https://gerrit.wikimedia.org/r/221614 (https://phabricator.wikimedia.org/T103714) [16:54:29] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/221614 (https://phabricator.wikimedia.org/T103714) (owner: 10Gerrit Patch Uploader) [16:56:00] (03CR) 10Daniel Kinzler: "I have extracted the most important part of this to Ie06782ffb96e675c0aa55dc26fb8f22037e8517d. That change should be less disruptive." [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [16:56:11] (03CR) 10Fomafix: "Removed 'noninitial' changes." [core] - 10https://gerrit.wikimedia.org/r/221614 (https://phabricator.wikimedia.org/T103714) (owner: 10Gerrit Patch Uploader) [16:59:07] (03CR) 10Luke081515: "recheck" [core] - 10https://gerrit.wikimedia.org/r/221614 (https://phabricator.wikimedia.org/T103714) (owner: 10Gerrit Patch Uploader) [17:02:19] (03PS3) 10Daniel Kinzler: Allow reset of global services (redux). [core] - 10https://gerrit.wikimedia.org/r/286314 [17:03:01] (03CR) 10Luke081515: "check zend" [core] - 10https://gerrit.wikimedia.org/r/221614 (https://phabricator.wikimedia.org/T103714) (owner: 10Gerrit Patch Uploader) [17:06:50] (03CR) 10Daniel Kinzler: Allow reset of global services (redux). (037 comments) [core] - 10https://gerrit.wikimedia.org/r/286314 (owner: 10Daniel Kinzler) [17:26:58] (03CR) 10Skizzerz: [C: 04-1] "The change to includes/db/Database.php is unrelated to the rest of this commit, it was meant to go in a separate patch set." [core] - 10https://gerrit.wikimedia.org/r/285139 (owner: 10Skizzerz) [17:31:00] (03CR) 10Matthias Mullie: "I probably missed something obvious then, but what would be an example of a message where the API also responds with the i18n params?" [core] - 10https://gerrit.wikimedia.org/r/285401 (https://phabricator.wikimedia.org/T115946) (owner: 10Matthias Mullie) [17:43:07] (03CR) 10Florianschmidtwelzow: registration: Add new "UnitTests" option (031 comment) [core] - 10https://gerrit.wikimedia.org/r/286253 (https://phabricator.wikimedia.org/T126093) (owner: 10Florianschmidtwelzow) [17:43:54] (03CR) 10Daniel Kinzler: "LinkCache probably can't be reset cleanly before I37b8e8018 and perhaps also Iab2b774 is merged. I think that might be the cause for the " [core] - 10https://gerrit.wikimedia.org/r/286436 (owner: 10Addshore) [17:44:28] (03CR) 10Daniel Kinzler: "Regarding the test failure, see my comment on I55c668a." [core] - 10https://gerrit.wikimedia.org/r/284163 (owner: 10Addshore) [18:02:40] (03PS4) 10Skizzerz: Update Microsoft SQL Server schema [core] - 10https://gerrit.wikimedia.org/r/285139 [18:04:38] (03CR) 10MaxSem: [C: 04-1] Allow unified diffs, as well as side by side (031 comment) [core] - 10https://gerrit.wikimedia.org/r/280904 (https://phabricator.wikimedia.org/T121469) (owner: 10Jdlrobson) [18:06:37] (03PS1) 10Skizzerz: Quote column name aliases [core] - 10https://gerrit.wikimedia.org/r/286489 [18:11:23] (03PS2) 10Skizzerz: Quote column name aliases [core] - 10https://gerrit.wikimedia.org/r/286489 [18:18:37] (03Abandoned) 10Aaron Schulz: [WIP] Added support for CDN-only thumbnail storage [core] - 10https://gerrit.wikimedia.org/r/126210 (owner: 10Aaron Schulz) [18:32:28] (03PS1) 10MaxSem: Allow specifying targets for ResourceLoaderWikiModule [core] - 10https://gerrit.wikimedia.org/r/286493 [18:33:30] (03CR) 10Yurik: [C: 032] Allow specifying targets for ResourceLoaderWikiModule [core] - 10https://gerrit.wikimedia.org/r/286493 (owner: 10MaxSem) [18:35:26] (03CR) 10Addshore: [C: 04-1] "Ahh, I thought those things had already gone in, but I guess not!" [core] - 10https://gerrit.wikimedia.org/r/286436 (owner: 10Addshore) [18:39:01] (03PS1) 10Brian Wolff: [DO NOT MERGE until feedback wikitech-l] Remove support for $wgWellFormedXml=false [core] - 10https://gerrit.wikimedia.org/r/286495 [18:41:06] (03Merged) 10jenkins-bot: Allow specifying targets for ResourceLoaderWikiModule [core] - 10https://gerrit.wikimedia.org/r/286493 (owner: 10MaxSem) [18:49:21] (03CR) 10MaxSem: [C: 032] Log when resyncFiles() fails in FileBackendMultiWrite [core] - 10https://gerrit.wikimedia.org/r/286203 (owner: 10Aaron Schulz) [18:50:01] (03PS1) 10Aaron Schulz: Log when resyncFiles() fails in FileBackendMultiWrite [core] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/286496 [18:55:44] (03Merged) 10jenkins-bot: Log when resyncFiles() fails in FileBackendMultiWrite [core] - 10https://gerrit.wikimedia.org/r/286203 (owner: 10Aaron Schulz) [18:59:09] (03CR) 10Bartosz Dziewoński: "Sorry, that was confusing, I just mean additional data. I was thinking of the 'duplicate' error (although, it seems it's actually a warnin" [core] - 10https://gerrit.wikimedia.org/r/285401 (https://phabricator.wikimedia.org/T115946) (owner: 10Matthias Mullie) [19:05:27] (03CR) 10Aaron Schulz: [C: 032] Log when resyncFiles() fails in FileBackendMultiWrite [core] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/286496 (owner: 10Aaron Schulz) [19:10:50] (03PS3) 10Aaron Schulz: Make refreshLinksJob explicitly check the cache rev ID [core] - 10https://gerrit.wikimedia.org/r/285449 (https://phabricator.wikimedia.org/T133659) [19:11:59] (03Merged) 10jenkins-bot: Log when resyncFiles() fails in FileBackendMultiWrite [core] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/286496 (owner: 10Aaron Schulz) [19:17:42] (03PS3) 10Gergő Tisza: Unify HTMLForm message handling [core] - 10https://gerrit.wikimedia.org/r/283846 [19:24:45] (03PS1) 10Gergő Tisza: Fix HTMLForm noData logic in trySubmit [core] - 10https://gerrit.wikimedia.org/r/286499 [19:26:40] (03CR) 10jenkins-bot: [V: 04-1] Unify HTMLForm message handling [core] - 10https://gerrit.wikimedia.org/r/283846 (owner: 10Gergő Tisza) [19:29:59] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Looks great, just one nitpick: the message texts should end with a full stop." [core] - 10https://gerrit.wikimedia.org/r/286161 (https://phabricator.wikimedia.org/T111228) (owner: 10Matthias Mullie) [19:31:01] (03CR) 10Bartosz Dziewoński: Check if user is blocked during upload process (031 comment) [core] - 10https://gerrit.wikimedia.org/r/286161 (https://phabricator.wikimedia.org/T111228) (owner: 10Matthias Mullie) [19:31:48] (03CR) 10Anomie: "Do we need the same in HTMLFormFieldCloner::cancelSubmit() and HTMLFormFieldCloner::validate()?" [core] - 10https://gerrit.wikimedia.org/r/286499 (owner: 10Gergő Tisza) [19:38:18] (03CR) 10Anomie: Unify HTMLForm message handling (031 comment) [core] - 10https://gerrit.wikimedia.org/r/283846 (owner: 10Gergő Tisza) [19:45:10] (03PS4) 10Gergő Tisza: Unify HTMLForm message handling [core] - 10https://gerrit.wikimedia.org/r/283846 [19:48:42] (03PS5) 10Gergő Tisza: Unify HTMLForm message handling [core] - 10https://gerrit.wikimedia.org/r/283846 [20:39:38] (03CR) 10Martineznovo: "I have to test it, but you may need to wrap the touch() inside wfDisableWarnings()/wfEnableWarnings() to prevent it to generate a warning " [core] - 10https://gerrit.wikimedia.org/r/286375 (https://phabricator.wikimedia.org/T126736) (owner: 10KOKOS250) [20:42:47] (03CR) 10Anomie: [C: 032] Make refreshLinksJob explicitly check the cache rev ID [core] - 10https://gerrit.wikimedia.org/r/285449 (https://phabricator.wikimedia.org/T133659) (owner: 10Aaron Schulz) [20:43:04] (03PS1) 10Anomie: Quick-fail refreshLinksJob if the triggering revision isn't the latest [core] - 10https://gerrit.wikimedia.org/r/286520 [20:43:50] (03CR) 10Anomie: [C: 032] Unify HTMLForm message handling [core] - 10https://gerrit.wikimedia.org/r/283846 (owner: 10Gergő Tisza) [20:47:40] (03CR) 10Aaron Schulz: [C: 032] Quick-fail refreshLinksJob if the triggering revision isn't the latest [core] - 10https://gerrit.wikimedia.org/r/286520 (owner: 10Anomie) [20:48:21] (03PS1) 10MGChecker: Correct error message for missing permission to get patrol information [core] - 10https://gerrit.wikimedia.org/r/286521 [20:48:47] (03CR) 10Daniel Kinzler: [C: 032] "again" [core] - 10https://gerrit.wikimedia.org/r/283463 (owner: 10Addshore) [20:49:09] (03Merged) 10jenkins-bot: Make refreshLinksJob explicitly check the cache rev ID [core] - 10https://gerrit.wikimedia.org/r/285449 (https://phabricator.wikimedia.org/T133659) (owner: 10Aaron Schulz) [20:52:51] (03Merged) 10jenkins-bot: Unify HTMLForm message handling [core] - 10https://gerrit.wikimedia.org/r/283846 (owner: 10Gergő Tisza) [20:52:58] (03CR) 10Luke081515: [C: 04-1] Correct error message for missing permission to get patrol information (031 comment) [core] - 10https://gerrit.wikimedia.org/r/286521 (owner: 10MGChecker) [20:54:52] (03Merged) 10jenkins-bot: Quick-fail refreshLinksJob if the triggering revision isn't the latest [core] - 10https://gerrit.wikimedia.org/r/286520 (owner: 10Anomie) [21:13:22] (03PS2) 10MGChecker: Correct error message for missing permission to get patrol information [core] - 10https://gerrit.wikimedia.org/r/286521 [21:23:01] (03PS3) 10Legoktm: Quote column name aliases [core] - 10https://gerrit.wikimedia.org/r/286489 (https://phabricator.wikimedia.org/T118973) (owner: 10Skizzerz) [21:23:04] (03PS4) 10Legoktm: Quote column name aliases [core] - 10https://gerrit.wikimedia.org/r/286489 (https://phabricator.wikimedia.org/T118973) (owner: 10Skizzerz) [21:24:13] (03CR) 10Bartosz Dziewoński: "I think it would be a lot easier for people customizing this on-wiki if the default templates was also in the localisation message (rather" [core] - 10https://gerrit.wikimedia.org/r/251797 (https://phabricator.wikimedia.org/T118097) (owner: 10Florianschmidtwelzow) [21:25:07] (03CR) 10Legoktm: [C: 032] "Better than nothing, but I think we can probably provide a better error here." [core] - 10https://gerrit.wikimedia.org/r/285140 (owner: 10Skizzerz) [21:26:08] (03CR) 10Legoktm: [C: 032] Update Microsoft SQL Server schema [core] - 10https://gerrit.wikimedia.org/r/285139 (owner: 10Skizzerz) [21:26:13] (03CR) 10Legoktm: [C: 032] Quote column name aliases [core] - 10https://gerrit.wikimedia.org/r/286489 (https://phabricator.wikimedia.org/T118973) (owner: 10Skizzerz) [21:34:11] (03CR) 10Luke081515: [C: 031] Correct error message for missing permission to get patrol information [core] - 10https://gerrit.wikimedia.org/r/286521 (owner: 10MGChecker) [21:34:22] (03Merged) 10jenkins-bot: Pass through errors creating the main page to the installer. [core] - 10https://gerrit.wikimedia.org/r/285140 (owner: 10Skizzerz) [21:34:54] (03Merged) 10jenkins-bot: Update Microsoft SQL Server schema [core] - 10https://gerrit.wikimedia.org/r/285139 (owner: 10Skizzerz) [21:35:04] (03CR) 10Martineznovo: [C: 04-1] "Actually, attempting to write to the temp directory every time this function is called is not good. Instead, this method should be called " [core] - 10https://gerrit.wikimedia.org/r/286375 (https://phabricator.wikimedia.org/T126736) (owner: 10KOKOS250) [21:38:42] (03Merged) 10jenkins-bot: Quote column name aliases [core] - 10https://gerrit.wikimedia.org/r/286489 (https://phabricator.wikimedia.org/T118973) (owner: 10Skizzerz) [21:42:08] (03PS2) 10Addshore: Add tests for MediawikiTestCase::setService stuff [core] - 10https://gerrit.wikimedia.org/r/286432 [21:42:42] (03PS7) 10Addshore: Make WatchedItemStore use MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/283463 [21:42:51] (03PS6) 10Addshore: Remove WatchedItemStore::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/283683 [21:54:33] (03CR) 10KOKOS250: "Thanks for your review. I will change behaviour back and I will add the check into the installer." [core] - 10https://gerrit.wikimedia.org/r/286375 (https://phabricator.wikimedia.org/T126736) (owner: 10KOKOS250) [22:03:49] (03PS3) 10MGChecker: Correct error message for missing permission to get patrol information [core] - 10https://gerrit.wikimedia.org/r/286521 [22:23:47] (03PS2) 10Gergő Tisza: Fix HTMLForm noData logic in trySubmit [core] - 10https://gerrit.wikimedia.org/r/286499 [22:38:25] (03PS1) 10Daniel Kinzler: Manage $wgCOntLang and $wgParser in MediaWikiServices. [core] - 10https://gerrit.wikimedia.org/r/286540 [22:42:58] (03CR) 10jenkins-bot: [V: 04-1] Manage $wgCOntLang and $wgParser in MediaWikiServices. [core] - 10https://gerrit.wikimedia.org/r/286540 (owner: 10Daniel Kinzler) [22:48:50] (03PS2) 10Daniel Kinzler: Manage $wgContLang and $wgParser in MediaWikiServices. [core] - 10https://gerrit.wikimedia.org/r/286540 [22:52:55] (03CR) 10jenkins-bot: [V: 04-1] Manage $wgContLang and $wgParser in MediaWikiServices. [core] - 10https://gerrit.wikimedia.org/r/286540 (owner: 10Daniel Kinzler) [23:17:37] (03PS3) 10Daniel Kinzler: Manage $wgContLang and $wgParser in MediaWikiServices. [core] - 10https://gerrit.wikimedia.org/r/286540 [23:22:01] (03CR) 10Legoktm: [C: 04-1] "Still somehow 1.5k lines of code, but this is better I think :)" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/286314 (owner: 10Daniel Kinzler) [23:53:48] (03PS1) 10Aaron Schulz: Document mInterwikis in LinksUpdate [core] - 10https://gerrit.wikimedia.org/r/286547