[00:31:48] (03CR) 10CSteipp: [C: 031] "Small text comment, but otherwise this looks good. Thanks!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/285438 (owner: 10Anomie) [00:50:25] (03CR) 10CSteipp: API changes for AuthManager (031 comment) [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [00:51:35] (03CR) 10CSteipp: [C: 031] "Wording clarity to clean up, but otherwise I think security of this looks good." [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [01:48:04] (03PS3) 10Aude: Add populateInterwiki maintenance script [core] - 10https://gerrit.wikimedia.org/r/286037 [01:48:14] (03CR) 10Aude: Add populateInterwiki maintenance script (032 comments) [core] - 10https://gerrit.wikimedia.org/r/286037 (owner: 10Aude) [04:07:42] (03PS1) 10Asaenz: Just an example tribute [core] - 10https://gerrit.wikimedia.org/r/286120 [04:12:03] (03PS2) 10Asaenz: Just an example tribute [core] - 10https://gerrit.wikimedia.org/r/286120 [06:04:36] (03PS1) 10Amire80: Bidi-isolate autonumber and free external links [core] - 10https://gerrit.wikimedia.org/r/286128 [07:05:57] (03CR) 10Eranroz: "I'm not sure whether it would work in IE/Opera/Safari." [core] - 10https://gerrit.wikimedia.org/r/286128 (owner: 10Amire80) [07:33:06] (03CR) 10Amire80: "Works in Safari and Opera, broken in IE, including Edge." [core] - 10https://gerrit.wikimedia.org/r/286128 (owner: 10Amire80) [07:34:33] (03PS2) 10Amire80: Bidi-isolate autonumber and free external links [core] - 10https://gerrit.wikimedia.org/r/286128 [07:38:19] (03CR) 10jenkins-bot: [V: 04-1] Bidi-isolate autonumber and free external links [core] - 10https://gerrit.wikimedia.org/r/286128 (owner: 10Amire80) [09:14:18] (03PS3) 10Addshore: Assert jobs called from WIS::resetNotificationTimestamp are correct [core] - 10https://gerrit.wikimedia.org/r/284461 (owner: 10WMDE-leszek) [09:14:54] (03CR) 10Addshore: [C: 032] Assert jobs called from WIS::resetNotificationTimestamp are correct [core] - 10https://gerrit.wikimedia.org/r/284461 (owner: 10WMDE-leszek) [09:21:04] (03Merged) 10jenkins-bot: Assert jobs called from WIS::resetNotificationTimestamp are correct [core] - 10https://gerrit.wikimedia.org/r/284461 (owner: 10WMDE-leszek) [10:26:28] (03CR) 10Hashar: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/285389 (https://phabricator.wikimedia.org/T131556) (owner: 10Hashar) [10:54:48] (03CR) 10Bartosz Dziewoński: "`display: inline-block` will prevent line breaking inside the link. This might not be desirable for free links. :/" [core] - 10https://gerrit.wikimedia.org/r/286128 (owner: 10Amire80) [11:21:50] (03CR) 10Amire80: "Hmmmmmm." [core] - 10https://gerrit.wikimedia.org/r/286128 (owner: 10Amire80) [11:22:03] (03CR) 10Amire80: "recheck" [core] - 10https://gerrit.wikimedia.org/r/286128 (owner: 10Amire80) [12:14:18] (03CR) 10Addshore: [C: 032] Improve diff docs [core] - 10https://gerrit.wikimedia.org/r/285566 (owner: 10MaxSem) [12:15:36] (03CR) 10Addshore: [C: 032] Remove unused stuff [core] - 10https://gerrit.wikimedia.org/r/285547 (owner: 10MaxSem) [13:06:46] (03CR) 10Bartosz Dziewoński: "This broke one of Commons's gadgets, which also used something AMD-like for loading. Fix: https://commons.wikimedia.org/w/index.php?title=" [core] - 10https://gerrit.wikimedia.org/r/265793 (https://phabricator.wikimedia.org/T108655) (owner: 10Jdlrobson) [13:21:35] (03CR) 10Eranroz: "autonumber - I think that for autonumber links this (line break behavior) is the desired behavior, so sticking to inline-block for cross b" [core] - 10https://gerrit.wikimedia.org/r/286128 (owner: 10Amire80) [13:21:42] (03CR) 10Anomie: SessionManager: Add provision for encrypting session data (031 comment) [core] - 10https://gerrit.wikimedia.org/r/285438 (owner: 10Anomie) [13:21:45] (03PS3) 10Anomie: SessionManager: Add provision for encrypting session data [core] - 10https://gerrit.wikimedia.org/r/285438 [13:32:19] (03CR) 10Amire80: "But wouldn't these templates use proper links with [] anyway?" [core] - 10https://gerrit.wikimedia.org/r/286128 (owner: 10Amire80) [13:42:49] (03CR) 10MarkTraceur: [C: 032] "Thanks for answering that, makes sense to me." [core] - 10https://gerrit.wikimedia.org/r/285562 (https://phabricator.wikimedia.org/T132920) (owner: 10Bartosz Dziewoński) [13:49:22] (03Merged) 10jenkins-bot: Add 'api-error-ratelimited' message for UploadWizard [core] - 10https://gerrit.wikimedia.org/r/285562 (https://phabricator.wikimedia.org/T132920) (owner: 10Bartosz Dziewoński) [14:25:20] (03PS1) 10Matthias Mullie: Check if user is blocked during upload process [core] - 10https://gerrit.wikimedia.org/r/286161 (https://phabricator.wikimedia.org/T111228) [14:49:15] (03Abandoned) 10Amire80: WIP: Allow attribute names in some RTL letters [core] - 10https://gerrit.wikimedia.org/r/164223 (https://bugzilla.wikimedia.org/71386) (owner: 10Amire80) [15:07:35] (03PS3) 10Amire80: Set explicit direction to ApiHelp headers with module names [core] - 10https://gerrit.wikimedia.org/r/237883 (https://phabricator.wikimedia.org/T112364) [15:12:35] (03CR) 10Amire80: "How time flies." [core] - 10https://gerrit.wikimedia.org/r/237883 (https://phabricator.wikimedia.org/T112364) (owner: 10Amire80) [15:16:56] (03CR) 10Gergő Tisza: API changes for AuthManager (031 comment) [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [15:22:47] (03PS137) 10Gergő Tisza: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie) [15:23:11] (03PS88) 10Gergő Tisza: Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) [15:23:27] (03PS49) 10Gergő Tisza: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [15:23:42] (03PS26) 10Gergő Tisza: AuthManager release notes [core] - 10https://gerrit.wikimedia.org/r/282202 (owner: 10Anomie) [15:23:57] (03PS31) 10Gergő Tisza: Remove $wgDisableAuthManager [core] - 10https://gerrit.wikimedia.org/r/280945 [15:25:26] (03CR) 10jenkins-bot: [V: 04-1] AuthManager release notes [core] - 10https://gerrit.wikimedia.org/r/282202 (owner: 10Anomie) [15:25:39] (03CR) 10jenkins-bot: [V: 04-1] Remove $wgDisableAuthManager [core] - 10https://gerrit.wikimedia.org/r/280945 (owner: 10Gergő Tisza) [15:47:16] (03CR) 10Bartosz Dziewoński: "Well, in that case I'd just do this for autonumber links only." [core] - 10https://gerrit.wikimedia.org/r/286128 (owner: 10Amire80) [15:59:51] (03PS27) 10Gergő Tisza: AuthManager release notes [core] - 10https://gerrit.wikimedia.org/r/282202 (owner: 10Anomie) [15:59:54] (03PS32) 10Gergő Tisza: Remove $wgDisableAuthManager [core] - 10https://gerrit.wikimedia.org/r/280945 [15:59:57] (03PS89) 10Gergő Tisza: Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) [16:00:00] (03PS4) 10Gergő Tisza: SessionManager: Add provision for encrypting session data [core] - 10https://gerrit.wikimedia.org/r/285438 (owner: 10Anomie) [16:00:03] (03PS138) 10Gergő Tisza: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie) [16:00:06] (03PS50) 10Gergő Tisza: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [16:04:02] (03CR) 10Jforrester: [C: 032] Merge Wikidiff3 into DiffEngine [core] - 10https://gerrit.wikimedia.org/r/285548 (owner: 10MaxSem) [16:05:05] (03CR) 10Jforrester: [C: 032] Refactor diffs [core] - 10https://gerrit.wikimedia.org/r/285443 (owner: 10MaxSem) [16:14:01] (03CR) 10jenkins-bot: [V: 04-1] Refactor diffs [core] - 10https://gerrit.wikimedia.org/r/285443 (owner: 10MaxSem) [16:14:05] (03CR) 10jenkins-bot: [V: 04-1] Remove unused stuff [core] - 10https://gerrit.wikimedia.org/r/285547 (owner: 10MaxSem) [16:14:08] (03CR) 10jenkins-bot: [V: 04-1] Merge Wikidiff3 into DiffEngine [core] - 10https://gerrit.wikimedia.org/r/285548 (owner: 10MaxSem) [16:14:11] (03CR) 10jenkins-bot: [V: 04-1] Improve diff docs [core] - 10https://gerrit.wikimedia.org/r/285566 (owner: 10MaxSem) [16:26:17] (03CR) 10CSteipp: API changes for AuthManager (031 comment) [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [16:28:56] (03CR) 10Anomie: Check if user is blocked during upload process (032 comments) [core] - 10https://gerrit.wikimedia.org/r/286161 (https://phabricator.wikimedia.org/T111228) (owner: 10Matthias Mullie) [17:14:23] (03PS1) 10Chad: Remove vague GPL headers from browser tests with dead links [core] - 10https://gerrit.wikimedia.org/r/286178 [17:14:45] (03PS1) 10Chad: oojs/oojs-ui: Swap to using Phabricator for the links to release notes [core] - 10https://gerrit.wikimedia.org/r/286179 [17:35:03] (03CR) 10Jforrester: [C: 032] oojs/oojs-ui: Swap to using Phabricator for the links to release notes [core] - 10https://gerrit.wikimedia.org/r/286179 (owner: 10Chad) [17:38:44] (03CR) 10Jforrester: [C: 032] Remove vague GPL headers from browser tests with dead links [core] - 10https://gerrit.wikimedia.org/r/286178 (owner: 10Chad) [17:39:49] (03PS1) 10Glaisher: Make sure OtherBlockLogLink's second parameter is a string [core] - 10https://gerrit.wikimedia.org/r/286181 (https://phabricator.wikimedia.org/T132935) [17:42:35] (03CR) 10Jforrester: "Eurgh, MF dependency needs fixing." [core] - 10https://gerrit.wikimedia.org/r/285443 (owner: 10MaxSem) [17:43:52] (03Merged) 10jenkins-bot: oojs/oojs-ui: Swap to using Phabricator for the links to release notes [core] - 10https://gerrit.wikimedia.org/r/286179 (owner: 10Chad) [17:47:10] (03Merged) 10jenkins-bot: Remove vague GPL headers from browser tests with dead links [core] - 10https://gerrit.wikimedia.org/r/286178 (owner: 10Chad) [17:57:06] (03PS1) 10JanZerebecki: Update Wikidata: - Fix fatal error in OutputPageBeforeHTMLHookHandler [core] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/286189 [17:57:27] (03CR) 10JanZerebecki: [C: 032] Update Wikidata: - Fix fatal error in OutputPageBeforeHTMLHookHandler [core] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/286189 (owner: 10JanZerebecki) [18:05:03] (03Merged) 10jenkins-bot: Update Wikidata: - Fix fatal error in OutputPageBeforeHTMLHookHandler [core] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/286189 (owner: 10JanZerebecki) [18:17:32] (03PS1) 10MaxSem: Highlight new requirement [core] - 10https://gerrit.wikimedia.org/r/286192 [18:44:23] (03PS139) 10Anomie: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) [18:44:41] (03CR) 10Anomie: "PS139 redoes the domain handling in AuthPluginPrimaryAuthenticationProvider to bring back "PasswordDomainAuthenticationRequest" that we ha" [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie) [19:04:12] (03PS1) 10Aaron Schulz: Avoid spamming the duplicate key fetch log in BagOStuff::merge() [core] - 10https://gerrit.wikimedia.org/r/286201 [19:04:49] (03CR) 10Daniel Kinzler: [C: 031] "Yes this should be here." [core] - 10https://gerrit.wikimedia.org/r/286037 (owner: 10Aude) [19:16:57] (03PS1) 10Aaron Schulz: Log when resyncFiles() fails in FileBackendMultiWrite [core] - 10https://gerrit.wikimedia.org/r/286203 [19:22:17] (03CR) 10Daniel Kinzler: [C: 032] Avoid master queries in getAutoDeleteReason() [core] - 10https://gerrit.wikimedia.org/r/286038 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [19:24:16] (03PS1) 10Catrope: Update CentralNotice for I13ae9c69646 [core] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/286204 [19:24:21] (03PS1) 10Chad: Point skins/extension READMEs to Phabricator [core] - 10https://gerrit.wikimedia.org/r/286205 [19:26:11] (03PS8) 10Daniel Kinzler: [DNM] Allow reset of global services. [core] - 10https://gerrit.wikimedia.org/r/283462 [19:26:29] (03PS9) 10Daniel Kinzler: [DNM] Allow reset of global services. [core] - 10https://gerrit.wikimedia.org/r/283462 [19:26:33] (03CR) 10jenkins-bot: [V: 04-1] [DNM] Allow reset of global services. [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [19:26:44] (03PS31) 10Daniel Kinzler: Factor InterwikiLookup out of Interwiki class. [core] - 10https://gerrit.wikimedia.org/r/250150 [19:26:50] (03CR) 10jenkins-bot: [V: 04-1] [DNM] Allow reset of global services. [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [19:28:59] (03Merged) 10jenkins-bot: Avoid master queries in getAutoDeleteReason() [core] - 10https://gerrit.wikimedia.org/r/286038 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [19:39:20] (03CR) 10Catrope: [C: 032] Update CentralNotice for I13ae9c69646 [core] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/286204 (owner: 10Catrope) [19:46:14] (03Merged) 10jenkins-bot: Update CentralNotice for I13ae9c69646 [core] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/286204 (owner: 10Catrope) [19:54:21] (03PS32) 10Daniel Kinzler: Factor InterwikiLookup out of Interwiki class. [core] - 10https://gerrit.wikimedia.org/r/250150 [19:55:01] (03PS3) 10Mattflaschen: PrefixSearchTest, SearchEnginePrefixTest: ignore ext. special pages [core] - 10https://gerrit.wikimedia.org/r/274641 [19:56:17] (03CR) 10Mattflaschen: "Manually rebased." [core] - 10https://gerrit.wikimedia.org/r/274641 (owner: 10Mattflaschen) [19:59:32] (03CR) 10jenkins-bot: [V: 04-1] Factor InterwikiLookup out of Interwiki class. [core] - 10https://gerrit.wikimedia.org/r/250150 (owner: 10Daniel Kinzler) [20:00:06] (03CR) 10Anomie: [C: 032] PrefixSearchTest, SearchEnginePrefixTest: ignore ext. special pages [core] - 10https://gerrit.wikimedia.org/r/274641 (owner: 10Mattflaschen) [20:14:34] (03Merged) 10jenkins-bot: PrefixSearchTest, SearchEnginePrefixTest: ignore ext. special pages [core] - 10https://gerrit.wikimedia.org/r/274641 (owner: 10Mattflaschen) [20:18:41] (03PS33) 10Daniel Kinzler: Factor InterwikiLookup out of Interwiki class. [core] - 10https://gerrit.wikimedia.org/r/250150 [20:24:34] (03PS18) 10Florianschmidtwelzow: registration: Allow specifying extension dependencies [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) [20:27:20] (03CR) 10jenkins-bot: [V: 04-1] Factor InterwikiLookup out of Interwiki class. [core] - 10https://gerrit.wikimedia.org/r/250150 (owner: 10Daniel Kinzler) [20:33:56] (03PS6) 10MaxSem: Refactor diffs [core] - 10https://gerrit.wikimedia.org/r/285443 [20:33:59] (03PS4) 10MaxSem: Remove unused stuff [core] - 10https://gerrit.wikimedia.org/r/285547 [20:34:02] (03PS4) 10MaxSem: Merge Wikidiff3 into DiffEngine [core] - 10https://gerrit.wikimedia.org/r/285548 [20:34:05] (03PS3) 10MaxSem: Improve diff docs [core] - 10https://gerrit.wikimedia.org/r/285566 [20:34:08] (03PS3) 10MaxSem: WIP: rethink diff limits [core] - 10https://gerrit.wikimedia.org/r/285567 [20:37:22] (03CR) 10MaxSem: "I undid the namespacing of WordLevelDiff, we will address this later as part of Jon R's work." [core] - 10https://gerrit.wikimedia.org/r/285443 (owner: 10MaxSem) [20:41:52] (03CR) 10jenkins-bot: [V: 04-1] WIP: rethink diff limits [core] - 10https://gerrit.wikimedia.org/r/285567 (owner: 10MaxSem) [20:47:45] (03PS19) 10Florianschmidtwelzow: registration: Allow specifying extension dependencies [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) [20:52:10] (03CR) 10jenkins-bot: [V: 04-1] registration: Allow specifying extension dependencies [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [21:02:02] (03PS20) 10Florianschmidtwelzow: registration: Allow specifying extension dependencies [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) [21:23:33] (03PS1) 10Florianschmidtwelzow: registration: Allow string value for Hooks [core] - 10https://gerrit.wikimedia.org/r/286241 (https://phabricator.wikimedia.org/T133628) [21:24:19] (03CR) 10Florianschmidtwelzow: registration: Allow string value for Hooks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/286241 (https://phabricator.wikimedia.org/T133628) (owner: 10Florianschmidtwelzow) [21:33:30] (03PS1) 10Esanders: Add class to div wrapper around category lists [core] - 10https://gerrit.wikimedia.org/r/286245 [21:34:21] (03PS4) 10Ori.livneh: Avoid lock error exceptions during upgradeRow() contention [core] - 10https://gerrit.wikimedia.org/r/284213 (https://phabricator.wikimedia.org/T132921) (owner: 10Aaron Schulz) [21:34:27] (03CR) 10Ori.livneh: [C: 032] Avoid lock error exceptions during upgradeRow() contention [core] - 10https://gerrit.wikimedia.org/r/284213 (https://phabricator.wikimedia.org/T132921) (owner: 10Aaron Schulz) [21:41:15] (03CR) 10Jforrester: [C: 032] Add class to div wrapper around category lists [core] - 10https://gerrit.wikimedia.org/r/286245 (owner: 10Esanders) [21:45:07] (03Merged) 10jenkins-bot: Avoid lock error exceptions during upgradeRow() contention [core] - 10https://gerrit.wikimedia.org/r/284213 (https://phabricator.wikimedia.org/T132921) (owner: 10Aaron Schulz) [21:48:23] (03Merged) 10jenkins-bot: Add class to div wrapper around category lists [core] - 10https://gerrit.wikimedia.org/r/286245 (owner: 10Esanders) [22:02:39] (03PS34) 10Daniel Kinzler: Factor InterwikiLookup out of Interwiki class. [core] - 10https://gerrit.wikimedia.org/r/250150 [22:03:33] (03CR) 10Daniel Kinzler: [V: 04-1] "Fails with: Fatal error: Class undefined: Cdb\Reader\Hash in /mnt/jenkins-workspace/workspace/mediawiki-phpunit-hhvm/src/includes/interwik" [core] - 10https://gerrit.wikimedia.org/r/250150 (owner: 10Daniel Kinzler) [22:07:59] (03CR) 10jenkins-bot: [V: 04-1] Factor InterwikiLookup out of Interwiki class. [core] - 10https://gerrit.wikimedia.org/r/250150 (owner: 10Daniel Kinzler) [22:48:12] (03PS1) 10Aaron Schulz: Fix executeTiming statsd metrics [core] - 10https://gerrit.wikimedia.org/r/286249 [23:05:47] (03PS1) 10Florianschmidtwelzow: registration: Add new "UnitTests" option [core] - 10https://gerrit.wikimedia.org/r/286253 (https://phabricator.wikimedia.org/T126093)