[02:09:30] (03PS1) 10Skizzerz: Update Microsoft SQL Server schema [core] - 10https://gerrit.wikimedia.org/r/285139 [02:19:19] (03PS1) 10Skizzerz: Pass through errors creating the main page to the installer. [core] - 10https://gerrit.wikimedia.org/r/285140 [03:18:56] (03PS8) 10Skizzerz: Fix escaping for MSSQL LIKE queries. [core] - 10https://gerrit.wikimedia.org/r/162508 (owner: 10Emadelwany) [03:20:08] (03CR) 10Skizzerz: [C: 031] "Updated commit message (made the topic less lengthy and pointed it at the phab task). Can we get this merged in please? :)" [core] - 10https://gerrit.wikimedia.org/r/162508 (owner: 10Emadelwany) [03:27:23] (03CR) 10Skizzerz: [C: 04-1] "T74171 requires schema changes as well, which would be best suited for this patch set. Going to upload a new version with a fix for that t" [core] - 10https://gerrit.wikimedia.org/r/285139 (owner: 10Skizzerz) [04:51:35] (03PS9) 10Legoktm: Fix escaping for MSSQL LIKE queries. [core] - 10https://gerrit.wikimedia.org/r/162508 (https://phabricator.wikimedia.org/T73207) (owner: 10Emadelwany) [04:51:51] (03CR) 10Legoktm: [C: 032] "Sorry about the delay in getting this merged :(" [core] - 10https://gerrit.wikimedia.org/r/162508 (https://phabricator.wikimedia.org/T73207) (owner: 10Emadelwany) [05:01:56] (03Merged) 10jenkins-bot: Fix escaping for MSSQL LIKE queries. [core] - 10https://gerrit.wikimedia.org/r/162508 (https://phabricator.wikimedia.org/T73207) (owner: 10Emadelwany) [05:24:32] (03CR) 10Legoktm: "This code is a little different, it doesn't actually run in the context of MediaWiki or even use the vendor that MediaWiki depends upon - " [core] - 10https://gerrit.wikimedia.org/r/285000 (https://phabricator.wikimedia.org/T119590) (owner: 10Ori.livneh) [05:40:46] (03CR) 10Ori.livneh: "That is an odd state of affairs. The file path suggests the exact opposite. I thought we ditched this whole way of using Composer?" [core] - 10https://gerrit.wikimedia.org/r/285000 (https://phabricator.wikimedia.org/T119590) (owner: 10Ori.livneh) [05:41:52] (03PS1) 10Legoktm: [WIP] Add TitleParser and TitleFormatter to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/285141 [05:42:20] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add TitleParser and TitleFormatter to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/285141 (owner: 10Legoktm) [06:10:53] (03PS5) 10Legoktm: registration: Allow ActionFilteredLogs to be modified by extensions [core] - 10https://gerrit.wikimedia.org/r/284177 (owner: 10Glaisher) [06:18:03] (03CR) 10Glaisher: [C: 031] "Thanks" [core] - 10https://gerrit.wikimedia.org/r/284177 (owner: 10Glaisher) [06:18:28] (03CR) 10Legoktm: [C: 032] registration: Allow ActionFilteredLogs to be modified by extensions [core] - 10https://gerrit.wikimedia.org/r/284177 (owner: 10Glaisher) [06:28:14] (03Merged) 10jenkins-bot: registration: Allow ActionFilteredLogs to be modified by extensions [core] - 10https://gerrit.wikimedia.org/r/284177 (owner: 10Glaisher) [08:11:50] (03CR) 10Jcrespo: "Change buffer is InnoDB only. Nothing against it, but I am not sure it really helps a lot given our low rate of writes. It should follow u" [core] - 10https://gerrit.wikimedia.org/r/282807 (owner: 10Aaron Schulz) [08:14:33] (03CR) 10Jcrespo: "As a negative impact, it could make an eq_ref into a ref, altering the query plans, did you research that, Aaron?" [core] - 10https://gerrit.wikimedia.org/r/282807 (owner: 10Aaron Schulz) [09:40:48] (03PS3) 10TheDJ: Tweak packed-hover gallery mode for better video compat [core] - 10https://gerrit.wikimedia.org/r/248572 (https://phabricator.wikimedia.org/T77988) (owner: 10Brion VIBBER) [10:11:13] (03CR) 10TheDJ: Tweak packed-hover gallery mode for better video compat (032 comments) [core] - 10https://gerrit.wikimedia.org/r/248572 (https://phabricator.wikimedia.org/T77988) (owner: 10Brion VIBBER) [12:09:52] (03CR) 10Addshore: [C: 032] Parser: Don't use deprecated Title::setFragment() [core] - 10https://gerrit.wikimedia.org/r/285056 (owner: 10Legoktm) [12:18:59] (03PS1) 10Addshore: Add @since docs to SpecialPage::getTitleFor [core] - 10https://gerrit.wikimedia.org/r/285172 [12:19:25] (03Merged) 10jenkins-bot: Parser: Don't use deprecated Title::setFragment() [core] - 10https://gerrit.wikimedia.org/r/285056 (owner: 10Legoktm) [12:24:47] (03CR) 10Addshore: Have Linker::normaliseSpecialPage() accept LinkTarget objects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284422 (owner: 10Legoktm) [12:58:00] (03PS3) 10Addshore: Make WatchedItemStore use MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/283463 [12:58:43] (03PS3) 10Addshore: Remove WatchedItemStore::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/283683 [12:59:20] (03CR) 10Addshore: "You should be able to rebase this one now :)" [core] - 10https://gerrit.wikimedia.org/r/282918 (owner: 10WMDE-leszek) [12:59:23] (03CR) 10jenkins-bot: [V: 04-1] Make WatchedItemStore use MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/283463 (owner: 10Addshore) [12:59:28] (03CR) 10jenkins-bot: [V: 04-1] Remove WatchedItemStore::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/283683 (owner: 10Addshore) [13:07:37] (03CR) 10Addshore: "Okay, don't why gerrit is saying this cant merge.." [core] - 10https://gerrit.wikimedia.org/r/283463 (owner: 10Addshore) [13:08:52] (03CR) 10Addshore: "So as I understand it the main blocker here is thoroughly testing this with CentralAuth & login." [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [13:13:29] (03CR) 10Daniel Kinzler: "@addshore: yes. I'll try to look into that soon, but I'd appreciate any help, since I have no experience with CentralAuth, and session han" [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [13:14:11] (03CR) 10Addshore: "Yep, I'll setup CA and take a look" [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [13:20:43] (03PS4) 10Addshore: wfTempDir try harder to get a tmp dir on Windows [core] - 10https://gerrit.wikimedia.org/r/284528 (https://phabricator.wikimedia.org/T44730) [13:39:11] (03CR) 10Brion VIBBER: "Sounds feasible, though I wonder if it might also have problems if you end up running some scripts as a regular user and also run the wiki" [core] - 10https://gerrit.wikimedia.org/r/284528 (https://phabricator.wikimedia.org/T44730) (owner: 10Addshore) [13:43:20] (03CR) 10Addshore: [C: 04-1] "That is true, we would want this to be per user." [core] - 10https://gerrit.wikimedia.org/r/284528 (https://phabricator.wikimedia.org/T44730) (owner: 10Addshore) [13:57:33] (03CR) 10Anomie: "Note that authentication is soon to change too, see If89d2483 and followups, and also Ia60d92f9." [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [14:42:33] (03CR) 10JanZerebecki: [C: 032] SpecialRunJobs: delegate error handling to MWExceptionHandler [core] (wmf/1.27.0-wmf.21) - 10https://gerrit.wikimedia.org/r/283555 (https://phabricator.wikimedia.org/T89169) (owner: 10JanZerebecki) [14:42:54] (03CR) 10JanZerebecki: "SWAT" [core] (wmf/1.27.0-wmf.21) - 10https://gerrit.wikimedia.org/r/283555 (https://phabricator.wikimedia.org/T89169) (owner: 10JanZerebecki) [14:51:11] (03Merged) 10jenkins-bot: SpecialRunJobs: delegate error handling to MWExceptionHandler [core] (wmf/1.27.0-wmf.21) - 10https://gerrit.wikimedia.org/r/283555 (https://phabricator.wikimedia.org/T89169) (owner: 10JanZerebecki) [14:56:12] (03PS7) 10Addshore: [DNM] Allow reset of global services. [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [14:58:39] (03PS7) 10Zfilipin: Migration of browsertests* Jenkins jobs to selenium* jobs [core] - 10https://gerrit.wikimedia.org/r/279345 (https://phabricator.wikimedia.org/T128190) [14:58:42] (03PS4) 10Addshore: Make WatchedItemStore use MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/283463 [15:01:03] (03PS4) 10Addshore: Remove WatchedItemStore::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/283683 [15:08:36] (03PS3) 10WMDE-leszek: [WIP]Add tests for ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/282918 [15:08:44] (03CR) 10Zfilipin: [C: 032] Migration of browsertests* Jenkins jobs to selenium* jobs [core] - 10https://gerrit.wikimedia.org/r/279345 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [15:18:12] (03Merged) 10jenkins-bot: Migration of browsertests* Jenkins jobs to selenium* jobs [core] - 10https://gerrit.wikimedia.org/r/279345 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [15:23:06] (03CR) 10BryanDavis: "> I thought we ditched this whole way of using Composer?" [core] - 10https://gerrit.wikimedia.org/r/285000 (https://phabricator.wikimedia.org/T119590) (owner: 10Ori.livneh) [15:28:41] (03PS4) 10WMDE-leszek: [WIP]Refactor database-related code in ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/284169 (https://phabricator.wikimedia.org/T132565) [15:34:44] (03PS14) 10WMDE-leszek: [WIP]Use WatchedItemStore::getWatchedItemsForUser in ApiQueryWatchlistRaw [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T132566) [15:34:48] (03CR) 10Ori.livneh: "I don't understand. The RfC was declined; the GitHub issue is rife with comments from Composer maintainers affirming that this is the wron" [core] - 10https://gerrit.wikimedia.org/r/285000 (https://phabricator.wikimedia.org/T119590) (owner: 10Ori.livneh) [15:36:28] (03CR) 10Ori.livneh: "If it doesn't cost anyone anything to keep this in core, that'd be one thing. But now a pretty essential part of the installation / config" [core] - 10https://gerrit.wikimedia.org/r/285000 (https://phabricator.wikimedia.org/T119590) (owner: 10Ori.livneh) [15:37:49] (03CR) 10Anomie: "Should the same be done in HTMLFormField::getNearestFieldByName()?" [core] - 10https://gerrit.wikimedia.org/r/285013 (https://phabricator.wikimedia.org/T133163) (owner: 10Gergő Tisza) [16:22:07] (03CR) 10Bartosz Dziewoński: [C: 032] Bidi-isolate the comment in history pages [core] - 10https://gerrit.wikimedia.org/r/285089 (owner: 10Amire80) [16:25:51] (03CR) 10Addshore: [V: 031] "So the log in issue reported with CA installed does not happen for me with this patch." [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [16:30:27] (03Merged) 10jenkins-bot: Bidi-isolate the comment in history pages [core] - 10https://gerrit.wikimedia.org/r/285089 (owner: 10Amire80) [16:43:34] (03CR) 10Addshore: [WIP]Add tests for ApiQueryWatchlist (031 comment) [core] - 10https://gerrit.wikimedia.org/r/282918 (owner: 10WMDE-leszek) [16:54:30] (03PS3) 10Florianschmidtwelzow: Show "list of users" on PermissionsErrorPages [core] - 10https://gerrit.wikimedia.org/r/281199 (https://phabricator.wikimedia.org/T116351) [16:54:43] (03CR) 10Florianschmidtwelzow: "ping @legoktm :)" [core] - 10https://gerrit.wikimedia.org/r/281199 (https://phabricator.wikimedia.org/T116351) (owner: 10Florianschmidtwelzow) [16:57:57] (03CR) 10Anomie: "D'oh, I forgot the calls to securitySensitiveOperationStatus()." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [16:59:44] (03PS78) 10Anomie: Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [17:00:16] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.special.upload.js: Remove spinner in .always() instead of .done() [core] - 10https://gerrit.wikimedia.org/r/283594 (owner: 10Gerrit Patch Uploader) [17:00:55] (03PS36) 10Anomie: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) [17:01:07] (03PS37) 10Anomie: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) [17:06:44] (03CR) 10Legoktm: Show "list of users" on PermissionsErrorPages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/281199 (https://phabricator.wikimedia.org/T116351) (owner: 10Florianschmidtwelzow) [17:07:58] (03CR) 10Anomie: Add AuthManager (031 comment) [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie) [17:10:55] (03CR) 10Addshore: [C: 04-1] [WIP]Refactor database-related code in ApiQueryWatchlist (036 comments) [core] - 10https://gerrit.wikimedia.org/r/284169 (https://phabricator.wikimedia.org/T132565) (owner: 10WMDE-leszek) [17:15:20] (03Merged) 10jenkins-bot: mediawiki.special.upload.js: Remove spinner in .always() instead of .done() [core] - 10https://gerrit.wikimedia.org/r/283594 (owner: 10Gerrit Patch Uploader) [17:24:11] (03CR) 10Addshore: [WIP]Use WatchedItemStore::getWatchedItemsForUser in ApiQueryWatchlistRaw (032 comments) [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T132566) (owner: 10WMDE-leszek) [18:34:54] (03CR) 10Anomie: [WIP]Use WatchedItemStore::getWatchedItemsForUser in ApiQueryWatchlistRaw (031 comment) [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T132566) (owner: 10WMDE-leszek) [18:53:48] (03CR) 10Florianschmidtwelzow: Show "list of users" on PermissionsErrorPages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/281199 (https://phabricator.wikimedia.org/T116351) (owner: 10Florianschmidtwelzow) [19:02:10] (03PS4) 10Florianschmidtwelzow: Show "list of users" on PermissionsErrorPages [core] - 10https://gerrit.wikimedia.org/r/281199 (https://phabricator.wikimedia.org/T116351) [19:03:39] (03PS5) 10Florianschmidtwelzow: Show "list of users" on PermissionsErrorPages [core] - 10https://gerrit.wikimedia.org/r/281199 (https://phabricator.wikimedia.org/T116351) [19:08:12] (03PS8) 10Aaron Schulz: Make WAN cache config use $wgEventRelayerConfig [core] - 10https://gerrit.wikimedia.org/r/284939 [19:14:03] (03PS1) 10Aaron Schulz: Make $wgEventRelayerConfig docs less confusing [core] - 10https://gerrit.wikimedia.org/r/285232 [19:33:29] (03PS1) 10Jforrester: i18n: Provide new "publish" strings for extra translator time [core] - 10https://gerrit.wikimedia.org/r/285238 (https://phabricator.wikimedia.org/T131132) [19:47:43] (03PS2) 10Gerrit Patch Uploader: Remove dummy language codes from Names.php [core] - 10https://gerrit.wikimedia.org/r/279087 (https://phabricator.wikimedia.org/T118199) [19:47:47] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/279087 (https://phabricator.wikimedia.org/T118199) (owner: 10Gerrit Patch Uploader) [19:49:52] (03PS1) 10Jforrester: EditPage: Use 'publish' rather than 'save' for the publish button [core] - 10https://gerrit.wikimedia.org/r/285242 (https://phabricator.wikimedia.org/T131132) [19:50:51] (03CR) 10Jforrester: [C: 04-2] "Not yet! Needs time for translators to get the labels ready. Planning for 1.27.0 back-port." [core] - 10https://gerrit.wikimedia.org/r/285242 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [19:57:53] (03CR) 10Catrope: [C: 031] Make WAN cache config use $wgEventRelayerConfig [core] - 10https://gerrit.wikimedia.org/r/284939 (owner: 10Aaron Schulz) [19:58:34] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Ooooh, nooo, you definitely don't want to change the button's name and id. That would break so much stuff." [core] - 10https://gerrit.wikimedia.org/r/285242 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [20:04:30] (03CR) 10Bartosz Dziewoński: [C: 04-2] EditPage: Use 'publish' rather than 'save' for the publish button [core] - 10https://gerrit.wikimedia.org/r/285242 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [20:15:56] (03CR) 10Catrope: [C: 04-1] "Still broken for me :(" [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [20:18:06] (03CR) 10Fomafix: "rebased" [core] - 10https://gerrit.wikimedia.org/r/279087 (https://phabricator.wikimedia.org/T118199) (owner: 10Gerrit Patch Uploader) [20:25:10] (03CR) 10Catrope: "Looks like it's caused/triggered by MobileFrontend. Debug logs at https://gist.github.com/catrope/873a9741154edb5beeb6b68b50db2034" [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [20:28:36] (03CR) 10Daniel Kinzler: "@addshore @catrope thanks for investigating! I'll look into it tomorrow." [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [20:37:37] (03CR) 10Smalyshev: [C: 032] Make WAN cache config use $wgEventRelayerConfig [core] - 10https://gerrit.wikimedia.org/r/284939 (owner: 10Aaron Schulz) [20:48:24] (03Merged) 10jenkins-bot: Make WAN cache config use $wgEventRelayerConfig [core] - 10https://gerrit.wikimedia.org/r/284939 (owner: 10Aaron Schulz) [20:52:52] (03CR) 10Addshore: [V: 04-1] "Indeed I can also reproduce with MF." [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [20:53:18] (03CR) 10Addshore: "I guess it would also make sense to look for other extensions that may have copied the same pattern as MF" [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [20:58:42] (03CR) 10Zppix: [C: 031] "Besides breaking login I don't see any other issues" [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [21:07:41] (03CR) 10Zppix: [C: 031] EditPage: Use 'publish' rather than 'save' for the publish button [core] - 10https://gerrit.wikimedia.org/r/285242 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [21:19:24] (03CR) 10Florianschmidtwelzow: [C: 031] "I intend to merge this change, but I would love to see the -2 on Ibb808ce691ac437a6d4 resolved before that :)" [core] - 10https://gerrit.wikimedia.org/r/285238 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [21:20:34] (03CR) 10Smalyshev: Convert EventRelayerGroup to services infrastructure (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284993 (owner: 10Smalyshev) [21:22:49] (03PS6) 10Smalyshev: Convert EventRelayerGroup to services infrastructure [core] - 10https://gerrit.wikimedia.org/r/284993 [21:24:35] (03PS2) 10Jforrester: i18n: Provide new "publish" strings for extra translator time [core] - 10https://gerrit.wikimedia.org/r/285238 (https://phabricator.wikimedia.org/T131132) [21:24:38] (03PS1) 10Jforrester: EditPage: Switch out 'wpSave' for 'wpPublish' [core] - 10https://gerrit.wikimedia.org/r/285284 [21:25:17] (03CR) 10Daniel Kinzler: [C: 032] Convert EventRelayerGroup to services infrastructure [core] - 10https://gerrit.wikimedia.org/r/284993 (owner: 10Smalyshev) [21:25:54] (03PS3) 10Jforrester: i18n: Provide new "publish" strings for extra translator time [core] - 10https://gerrit.wikimedia.org/r/285238 (https://phabricator.wikimedia.org/T131132) [21:27:39] (03PS2) 10Jforrester: EditPage: Use 'publish' rather than 'save' for the publish button [core] - 10https://gerrit.wikimedia.org/r/285242 (https://phabricator.wikimedia.org/T131132) [21:28:26] (03PS2) 10Jforrester: EditPage: Switch out 'wpSave' for 'wpPublish' [core] - 10https://gerrit.wikimedia.org/r/285284 [21:28:53] (03CR) 10Jforrester: "@MatmaRex Fine, moved to I87d39ca." [core] - 10https://gerrit.wikimedia.org/r/285242 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [21:29:36] (03CR) 10Jforrester: "PS2: Mis-fire. PS3: Rebase." [core] - 10https://gerrit.wikimedia.org/r/285238 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [21:33:49] (03CR) 10jenkins-bot: [V: 04-1] EditPage: Switch out 'wpSave' for 'wpPublish' [core] - 10https://gerrit.wikimedia.org/r/285284 (owner: 10Jforrester) [21:34:12] (03Merged) 10jenkins-bot: Convert EventRelayerGroup to services infrastructure [core] - 10https://gerrit.wikimedia.org/r/284993 (owner: 10Smalyshev) [21:34:40] (03CR) 10jenkins-bot: [V: 04-1] EditPage: Use 'publish' rather than 'save' for the publish button [core] - 10https://gerrit.wikimedia.org/r/285242 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [21:35:53] (03CR) 10Bartosz Dziewoński: [C: 032] Check for global blocks [core] - 10https://gerrit.wikimedia.org/r/283189 (https://phabricator.wikimedia.org/T111229) (owner: 10Matthias Mullie) [21:42:56] (03PS3) 10Jforrester: EditPage: Use 'publish' rather than 'save' for the publish button [core] - 10https://gerrit.wikimedia.org/r/285242 (https://phabricator.wikimedia.org/T131132) [21:45:23] (03Merged) 10jenkins-bot: Check for global blocks [core] - 10https://gerrit.wikimedia.org/r/283189 (https://phabricator.wikimedia.org/T111229) (owner: 10Matthias Mullie) [21:55:02] (03PS2) 10Ori.livneh: Make $wgEventRelayerConfig docs less confusing [core] - 10https://gerrit.wikimedia.org/r/285232 (owner: 10Aaron Schulz) [21:55:08] (03CR) 10Ori.livneh: [C: 032] Make $wgEventRelayerConfig docs less confusing [core] - 10https://gerrit.wikimedia.org/r/285232 (owner: 10Aaron Schulz) [21:57:48] (03CR) 10Bartosz Dziewoński: "Thanks! I submitted two cleanup changes to make things use this function:" [core] - 10https://gerrit.wikimedia.org/r/283189 (https://phabricator.wikimedia.org/T111229) (owner: 10Matthias Mullie) [22:08:11] (03Merged) 10jenkins-bot: Make $wgEventRelayerConfig docs less confusing [core] - 10https://gerrit.wikimedia.org/r/285232 (owner: 10Aaron Schulz) [22:10:14] (03CR) 10Bartosz Dziewoński: "Any comments, anyone?" [core] - 10https://gerrit.wikimedia.org/r/282101 (owner: 10Bartosz Dziewoński) [22:10:33] (03PS18) 10Gergő Tisza: AuthManager release notes [core] - 10https://gerrit.wikimedia.org/r/282202 (owner: 10Anomie) [22:10:36] (03PS24) 10Gergő Tisza: Remove $wgDisableAuthManager [core] - 10https://gerrit.wikimedia.org/r/280945 [22:10:39] (03PS79) 10Gergő Tisza: Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) [22:10:42] (03PS132) 10Gergő Tisza: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie) [22:10:45] (03PS38) 10Gergő Tisza: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [22:13:35] (03CR) 10Catrope: [C: 032] Convert array() => [] in some comments [core] - 10https://gerrit.wikimedia.org/r/284979 (owner: 10Aaron Schulz) [22:17:09] (03PS2) 10Bartosz Dziewoński: Revert "Make APIEditBeforeSave give the whole revision" [core] - 10https://gerrit.wikimedia.org/r/282101 [22:17:18] (03CR) 10Bartosz Dziewoński: "PS2 is rebase + release notes." [core] - 10https://gerrit.wikimedia.org/r/282101 (owner: 10Bartosz Dziewoński) [22:21:03] (03CR) 10Bartosz Dziewoński: "So, anybody wants to merge? This is a very straightforward patch." [core] - 10https://gerrit.wikimedia.org/r/283487 (https://phabricator.wikimedia.org/T132612) (owner: 10Bartosz Dziewoński) [22:24:03] (03CR) 10jenkins-bot: [V: 04-1] Convert array() => [] in some comments [core] - 10https://gerrit.wikimedia.org/r/284979 (owner: 10Aaron Schulz) [22:27:07] (03CR) 10Bartosz Dziewoński: "I think it would be a lot less disruptive to keep using the old message. We have "Save" translated to hundreds of languages, it will proba" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/285242 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [22:27:46] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This is just asking for problems." [core] - 10https://gerrit.wikimedia.org/r/285284 (owner: 10Jforrester) [22:28:46] (03CR) 10Jforrester: EditPage: Use 'publish' rather than 'save' for the publish button (031 comment) [core] - 10https://gerrit.wikimedia.org/r/285242 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [22:31:38] (03PS19) 10Gergő Tisza: AuthManager release notes [core] - 10https://gerrit.wikimedia.org/r/282202 (owner: 10Anomie) [22:31:41] (03PS25) 10Gergő Tisza: Remove $wgDisableAuthManager [core] - 10https://gerrit.wikimedia.org/r/280945 [22:31:44] (03PS80) 10Gergő Tisza: Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) [22:31:47] (03PS39) 10Gergő Tisza: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [22:34:34] (03PS20) 10Gergő Tisza: AuthManager release notes [core] - 10https://gerrit.wikimedia.org/r/282202 (owner: 10Anomie) [22:34:37] (03PS26) 10Gergő Tisza: Remove $wgDisableAuthManager [core] - 10https://gerrit.wikimedia.org/r/280945 [22:34:40] (03PS40) 10Gergő Tisza: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [22:37:50] (03CR) 10Gergő Tisza: "PS 132: add hidden field type, add value field property, fix null field handling. Also, apparently an accidental revert of some of the pre" [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie) [22:38:45] (03CR) 10jenkins-bot: [V: 04-1] Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [22:38:53] (03PS2) 10Aaron Schulz: Convert array() => [] in some comments [core] - 10https://gerrit.wikimedia.org/r/284979 [22:39:24] (03CR) 10Legoktm: [C: 032] mw.ForeignApi: Percent-encode dots in the 'origin' parameter [core] - 10https://gerrit.wikimedia.org/r/283487 (https://phabricator.wikimedia.org/T132612) (owner: 10Bartosz Dziewoński) [22:40:34] (03CR) 10jenkins-bot: [V: 04-1] Remove $wgDisableAuthManager [core] - 10https://gerrit.wikimedia.org/r/280945 (owner: 10Gergő Tisza) [22:40:50] (03PS133) 10Gergő Tisza: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie) [22:41:16] (03PS81) 10Gergő Tisza: Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) [22:42:05] (03CR) 10jenkins-bot: [V: 04-1] API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [22:45:59] (03CR) 10Gergő Tisza: "PS 80: Try to avoid unnecessary AuthManager::getAuthenticationRequest calls, pass requests to AuthChangeFormFields hook, handle 'hidden' f" [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [22:46:28] (03PS41) 10Gergő Tisza: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [22:48:17] (03PS82) 10Gergő Tisza: Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) [22:48:48] (03PS42) 10Gergő Tisza: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [22:49:30] (03PS1) 10Legoktm: registration: Improve schema validation for some properties [core] - 10https://gerrit.wikimedia.org/r/285306 [22:49:45] (03CR) 10jenkins-bot: [V: 04-1] API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [22:49:48] (03CR) 10Gergő Tisza: "PS 40: handle 'value' field property. The rest are rebases." [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [22:50:14] (03PS21) 10Gergő Tisza: AuthManager release notes [core] - 10https://gerrit.wikimedia.org/r/282202 (owner: 10Anomie) [22:50:28] (03PS27) 10Gergő Tisza: Remove $wgDisableAuthManager [core] - 10https://gerrit.wikimedia.org/r/280945 [22:50:51] (03Merged) 10jenkins-bot: mw.ForeignApi: Percent-encode dots in the 'origin' parameter [core] - 10https://gerrit.wikimedia.org/r/283487 (https://phabricator.wikimedia.org/T132612) (owner: 10Bartosz Dziewoński) [22:59:43] (03PS83) 10Gergő Tisza: Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) [23:01:38] (03CR) 10Gergő Tisza: "> OTOH, maybe it should still use both messages in the right contexts." [core] - 10https://gerrit.wikimedia.org/r/280945 (owner: 10Gergő Tisza) [23:06:20] (03CR) 10Aaron Schulz: "recheck" [core] - 10https://gerrit.wikimedia.org/r/284979 (owner: 10Aaron Schulz) [23:11:49] (03CR) 10Jforrester: [C: 031] registration: Improve schema validation for some properties [core] - 10https://gerrit.wikimedia.org/r/285306 (owner: 10Legoktm) [23:14:11] (03PS16) 10Smalyshev: Convert SearchEngine to service containers [core] - 10https://gerrit.wikimedia.org/r/282217 [23:18:47] (03CR) 10jenkins-bot: [V: 04-1] Convert SearchEngine to service containers [core] - 10https://gerrit.wikimedia.org/r/282217 (owner: 10Smalyshev) [23:27:37] (03PS17) 10Smalyshev: Convert SearchEngine to service containers [core] - 10https://gerrit.wikimedia.org/r/282217 [23:27:57] (03PS2) 10Gergő Tisza: Handle null data return in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/285013 (https://phabricator.wikimedia.org/T133163)