[03:34:36] (03CR) 10Mattflaschen: "> From a built OOUI (where I've been fiddling), I just use `cp -r`; this seems like a lot more complication than is needed (as none of the" [core] - 10https://gerrit.wikimedia.org/r/283565 (owner: 10Mattflaschen) [07:15:27] (03CR) 10Legoktm: [C: 032] API: Allow subclassing ApiQueryImageInfo [core] - 10https://gerrit.wikimedia.org/r/283858 (owner: 10TheDJ) [07:16:17] (03CR) 10Legoktm: [C: 032] Modify documentation of select() method for Database. [core] - 10https://gerrit.wikimedia.org/r/283923 (owner: 10Brian Wolff) [07:16:32] (03CR) 10Legoktm: [C: 032] Remove dead code from CategoryPager [core] - 10https://gerrit.wikimedia.org/r/283766 (owner: 10Umherirrender) [07:17:22] (03CR) 10Legoktm: [C: 032] Adding param documentation for Parser::internalParse() [core] - 10https://gerrit.wikimedia.org/r/283510 (owner: 10Kaldari) [07:28:18] (03CR) 10Legoktm: [C: 032] search: getInterwikiResults returns array of SearchResultSets [core] - 10https://gerrit.wikimedia.org/r/283465 (https://phabricator.wikimedia.org/T132625) (owner: 10EBernhardson) [07:30:02] (03CR) 10Legoktm: "Does this need other schema change stuff like updater patches and whatnot?" [core] - 10https://gerrit.wikimedia.org/r/282807 (owner: 10Aaron Schulz) [07:30:39] (03Merged) 10jenkins-bot: API: Allow subclassing ApiQueryImageInfo [core] - 10https://gerrit.wikimedia.org/r/283858 (owner: 10TheDJ) [07:30:46] (03Merged) 10jenkins-bot: Modify documentation of select() method for Database. [core] - 10https://gerrit.wikimedia.org/r/283923 (owner: 10Brian Wolff) [07:30:49] (03CR) 10Legoktm: [C: 04-1] Improve HTMLSubmitField return value (031 comment) [core] - 10https://gerrit.wikimedia.org/r/280884 (owner: 10Gergő Tisza) [07:30:51] (03Merged) 10jenkins-bot: Remove dead code from CategoryPager [core] - 10https://gerrit.wikimedia.org/r/283766 (owner: 10Umherirrender) [07:30:55] (03Merged) 10jenkins-bot: Adding param documentation for Parser::internalParse() [core] - 10https://gerrit.wikimedia.org/r/283510 (owner: 10Kaldari) [07:32:29] (03CR) 10Legoktm: [C: 032] Rephrase watchlistedit-clear-title [core] - 10https://gerrit.wikimedia.org/r/282489 (owner: 10Amire80) [07:32:53] (03PS3) 10Legoktm: Allow tags in summary [core] - 10https://gerrit.wikimedia.org/r/282456 (https://phabricator.wikimedia.org/T109032) (owner: 10Eranroz) [07:33:27] (03CR) 10Legoktm: "(Multiple bugs go on different lines per https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Auto-linking_and_cross-referencin" [core] - 10https://gerrit.wikimedia.org/r/282456 (https://phabricator.wikimedia.org/T109032) (owner: 10Eranroz) [07:35:15] (03CR) 10Legoktm: "Should #hashtags be removed from the edit summary if they're being converted into tags?" [core] - 10https://gerrit.wikimedia.org/r/282456 (https://phabricator.wikimedia.org/T109032) (owner: 10Eranroz) [07:35:35] (03CR) 10Legoktm: [C: 032] Move disable of preference 'enotifminoredits' [core] - 10https://gerrit.wikimedia.org/r/282426 (owner: 10Umherirrender) [07:36:40] (03CR) 10Legoktm: [C: 032] parserTests.php: fix three bitrot bugs with --record [core] - 10https://gerrit.wikimedia.org/r/282097 (owner: 10Tim Starling) [07:39:00] (03CR) 10Legoktm: Show "list of users" on PermissionsErrorPages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/281199 (https://phabricator.wikimedia.org/T116351) (owner: 10Florianschmidtwelzow) [07:39:16] (03CR) 10Legoktm: [C: 04-1] Show "list of users" on PermissionsErrorPages [core] - 10https://gerrit.wikimedia.org/r/281199 (https://phabricator.wikimedia.org/T116351) (owner: 10Florianschmidtwelzow) [07:42:08] (03Merged) 10jenkins-bot: search: getInterwikiResults returns array of SearchResultSets [core] - 10https://gerrit.wikimedia.org/r/283465 (https://phabricator.wikimedia.org/T132625) (owner: 10EBernhardson) [07:42:12] (03Merged) 10jenkins-bot: Rephrase watchlistedit-clear-title [core] - 10https://gerrit.wikimedia.org/r/282489 (owner: 10Amire80) [07:43:35] (03Merged) 10jenkins-bot: Move disable of preference 'enotifminoredits' [core] - 10https://gerrit.wikimedia.org/r/282426 (owner: 10Umherirrender) [07:44:56] (03CR) 10Legoktm: [C: 032] mediawiki.special.upload: Use formatversion=2 for API requests [core] - 10https://gerrit.wikimedia.org/r/283595 (owner: 10Gerrit Patch Uploader) [07:45:41] (03Merged) 10jenkins-bot: parserTests.php: fix three bitrot bugs with --record [core] - 10https://gerrit.wikimedia.org/r/282097 (owner: 10Tim Starling) [07:47:57] (03CR) 10Legoktm: [C: 032] HTMLForm code style fixes [core] - 10https://gerrit.wikimedia.org/r/283845 (owner: 10Gergő Tisza) [08:05:37] (03Merged) 10jenkins-bot: mediawiki.special.upload: Use formatversion=2 for API requests [core] - 10https://gerrit.wikimedia.org/r/283595 (owner: 10Gerrit Patch Uploader) [08:05:44] (03Merged) 10jenkins-bot: HTMLForm code style fixes [core] - 10https://gerrit.wikimedia.org/r/283845 (owner: 10Gergő Tisza) [08:53:30] (03CR) 10Tobias Gritschacher: "recheck" [core] - 10https://gerrit.wikimedia.org/r/271502 (https://phabricator.wikimedia.org/T125991) (owner: 10Addshore) [08:58:14] (03PS1) 10Amire80: Unify the spaces before the comment in Names.php [core] - 10https://gerrit.wikimedia.org/r/283948 [09:00:26] (03PS7) 10Zhuyifei1999: Protection: Rework on how cascade-protection are applied to files [core] - 10https://gerrit.wikimedia.org/r/233207 (https://phabricator.wikimedia.org/T24521) [09:00:52] (03CR) 10jenkins-bot: [V: 04-1] Protection: Rework on how cascade-protection are applied to files [core] - 10https://gerrit.wikimedia.org/r/233207 (https://phabricator.wikimedia.org/T24521) (owner: 10Zhuyifei1999) [09:14:26] (03PS1) 10Amire80: Rephrase tog-norollbackdiff [core] - 10https://gerrit.wikimedia.org/r/283950 [10:11:24] (03PS1) 10Addshore: RecentChange::parseParams will never return null [core] - 10https://gerrit.wikimedia.org/r/283957 [10:11:56] (03PS2) 10Addshore: RecentChange::parseParams will never return null [core] - 10https://gerrit.wikimedia.org/r/283957 [10:13:02] (03PS3) 10Addshore: FIx RecentChange::parseParams @return docs [core] - 10https://gerrit.wikimedia.org/r/283957 [10:13:11] (03PS4) 10Addshore: Fix RecentChange::parseParams @return docs [core] - 10https://gerrit.wikimedia.org/r/283957 [10:15:04] (03CR) 10WMDE-Fisch: [C: 031] Fix RecentChange::parseParams @return docs [core] - 10https://gerrit.wikimedia.org/r/283957 (owner: 10Addshore) [11:02:49] (03CR) 10Addshore: [C: 04-1] Hide hiddencat catwatch changes in special changelists (038 comments) [core] - 10https://gerrit.wikimedia.org/r/283213 (https://phabricator.wikimedia.org/T127944) (owner: 10WMDE-Fisch) [11:08:18] (03PS8) 10Zhuyifei1999: Protection: Rework on how cascade-protection are applied to files [core] - 10https://gerrit.wikimedia.org/r/233207 (https://phabricator.wikimedia.org/T24521) [11:36:17] (03PS1) 10Addshore: Test coverage WatchedItemStore::addWatchBatchForUser to 100% [core] - 10https://gerrit.wikimedia.org/r/283962 [11:36:19] (03PS1) 10Addshore: Test coverage WatchedItemStore::duplicateAllAssociatedEntries to 100% [core] - 10https://gerrit.wikimedia.org/r/283963 [11:41:28] (03CR) 10jenkins-bot: [V: 04-1] Test coverage WatchedItemStore::addWatchBatchForUser to 100% [core] - 10https://gerrit.wikimedia.org/r/283962 (owner: 10Addshore) [11:42:34] (03PS2) 10Addshore: Test coverage WatchedItemStore::addWatchBatchForUser to 100% [core] - 10https://gerrit.wikimedia.org/r/283962 [11:42:41] (03PS2) 10Addshore: Test coverage WatchedItemStore::duplicateAllAssociatedEntries to 100% [core] - 10https://gerrit.wikimedia.org/r/283963 [11:47:37] (03CR) 10jenkins-bot: [V: 04-1] Test coverage WatchedItemStore::duplicateAllAssociatedEntries to 100% [core] - 10https://gerrit.wikimedia.org/r/283963 (owner: 10Addshore) [11:53:40] (03CR) 10Addshore: "recheck" [core] - 10https://gerrit.wikimedia.org/r/279367 (owner: 10Addshore) [12:06:27] (03CR) 10Nikerabbit: [C: 04-1] Unify the spaces before the comment in Names.php (032 comments) [core] - 10https://gerrit.wikimedia.org/r/283948 (owner: 10Amire80) [12:11:00] (03CR) 10Hoo man: [C: 032] "Could have also been a more narrow type hint like string|array|bool … but I guess this is the better solution given we don't really know a" [core] - 10https://gerrit.wikimedia.org/r/283957 (owner: 10Addshore) [12:16:32] (03CR) 10Addshore: "recheck" [core] - 10https://gerrit.wikimedia.org/r/283963 (owner: 10Addshore) [12:23:50] (03CR) 10Nikerabbit: Rephrase tog-norollbackdiff (031 comment) [core] - 10https://gerrit.wikimedia.org/r/283950 (owner: 10Amire80) [12:25:15] (03CR) 10Amire80: Rephrase tog-norollbackdiff (031 comment) [core] - 10https://gerrit.wikimedia.org/r/283950 (owner: 10Amire80) [12:25:32] (03Merged) 10jenkins-bot: Fix RecentChange::parseParams @return docs [core] - 10https://gerrit.wikimedia.org/r/283957 (owner: 10Addshore) [12:34:45] (03PS2) 10WMDE-Fisch: Hide hiddencat catwatch changes in special changelists [core] - 10https://gerrit.wikimedia.org/r/283213 (https://phabricator.wikimedia.org/T127944) [12:37:01] (03PS2) 10Amire80: Unify the spaces before the comment in Names.php [core] - 10https://gerrit.wikimedia.org/r/283948 [12:39:25] (03CR) 10jenkins-bot: [V: 04-1] Hide hiddencat catwatch changes in special changelists [core] - 10https://gerrit.wikimedia.org/r/283213 (https://phabricator.wikimedia.org/T127944) (owner: 10WMDE-Fisch) [12:40:11] (03PS3) 10WMDE-Fisch: Hide hiddencat catwatch changes in special changelists [core] - 10https://gerrit.wikimedia.org/r/283213 (https://phabricator.wikimedia.org/T127944) [12:42:19] (03CR) 10WMDE-Fisch: Hide hiddencat catwatch changes in special changelists (037 comments) [core] - 10https://gerrit.wikimedia.org/r/283213 (https://phabricator.wikimedia.org/T127944) (owner: 10WMDE-Fisch) [12:44:49] (03CR) 10jenkins-bot: [V: 04-1] Hide hiddencat catwatch changes in special changelists [core] - 10https://gerrit.wikimedia.org/r/283213 (https://phabricator.wikimedia.org/T127944) (owner: 10WMDE-Fisch) [12:52:58] (that was my action) [13:00:32] (03CR) 10Addshore: "recheck" [core] - 10https://gerrit.wikimedia.org/r/283213 (https://phabricator.wikimedia.org/T127944) (owner: 10WMDE-Fisch) [13:30:19] (03Draft1) 10Addshore: Require-dev "squizlabs/php_codesniffer": "~2.3" [core] - 10https://gerrit.wikimedia.org/r/283967 (https://phabricator.wikimedia.org/T100544) [13:36:13] (03CR) 10WMDE-Fisch: [C: 031] Test coverage WatchedItemStore::addWatchBatchForUser to 100% [core] - 10https://gerrit.wikimedia.org/r/283962 (owner: 10Addshore) [13:41:29] (03CR) 10WMDE-Fisch: [C: 031] Test coverage WatchedItemStore::duplicateAllAssociatedEntries to 100% [core] - 10https://gerrit.wikimedia.org/r/283963 (owner: 10Addshore) [14:12:42] (03CR) 10Paladox: [C: 04-1] "Why do we need that to be set here where as you are updating it here https://gerrit.wikimedia.org/r/#/c/283966/" [core] - 10https://gerrit.wikimedia.org/r/283967 (https://phabricator.wikimedia.org/T100544) (owner: 10Addshore) [14:15:12] (03CR) 10Addshore: "See the reason for needing 2.3 or higher in https://phabricator.wikimedia.org/T100544" [core] - 10https://gerrit.wikimedia.org/r/283967 (https://phabricator.wikimedia.org/T100544) (owner: 10Addshore) [14:17:52] (03CR) 10Paladox: "Oh but what happends if a future update breaks the tests because it has a breaking change." [core] - 10https://gerrit.wikimedia.org/r/283967 (https://phabricator.wikimedia.org/T100544) (owner: 10Addshore) [14:20:45] (03CR) 10Addshore: "See my last comment in https://gerrit.wikimedia.org/r/#/c/283966/" [core] - 10https://gerrit.wikimedia.org/r/283967 (https://phabricator.wikimedia.org/T100544) (owner: 10Addshore) [14:21:58] (03PS4) 10Gergő Tisza: Improve HTMLSubmitField return value [core] - 10https://gerrit.wikimedia.org/r/280884 [14:23:32] (03CR) 10Anomie: [C: 031] "Code seems sane. I'm going to try to check the logs to see whether this looks like the new error would break too many uses (I'm hoping not" [core] - 10https://gerrit.wikimedia.org/r/283777 (https://phabricator.wikimedia.org/T132852) (owner: 10Gergő Tisza) [14:37:02] (03CR) 10Addshore: [C: 04-1] Hide hiddencat catwatch changes in special changelists (031 comment) [core] - 10https://gerrit.wikimedia.org/r/283213 (https://phabricator.wikimedia.org/T127944) (owner: 10WMDE-Fisch) [14:37:15] (03CR) 10Addshore: [V: 031] Hide hiddencat catwatch changes in special changelists [core] - 10https://gerrit.wikimedia.org/r/283213 (https://phabricator.wikimedia.org/T127944) (owner: 10WMDE-Fisch) [14:42:13] (03PS4) 10WMDE-Fisch: Hide hiddencat catwatch changes in special changelists [core] - 10https://gerrit.wikimedia.org/r/283213 (https://phabricator.wikimedia.org/T127944) [14:43:17] (03CR) 10WMDE-Fisch: "PS 4 fixed commit message" [core] - 10https://gerrit.wikimedia.org/r/283213 (https://phabricator.wikimedia.org/T127944) (owner: 10WMDE-Fisch) [14:43:45] (03PS6) 10Gergő Tisza: Reject usernames with namespace or interwiki prefixes [core] - 10https://gerrit.wikimedia.org/r/283775 (https://phabricator.wikimedia.org/T94656) [14:44:20] (03CR) 10Addshore: [C: 031 V: 031] "Will give others a chance to look this over." [core] - 10https://gerrit.wikimedia.org/r/283213 (https://phabricator.wikimedia.org/T127944) (owner: 10WMDE-Fisch) [14:45:44] (03PS5) 10Addshore: Introduce SpecialPageFatalTest [core] - 10https://gerrit.wikimedia.org/r/279367 [14:55:28] (03CR) 10jenkins-bot: [V: 04-1] Introduce SpecialPageFatalTest [core] - 10https://gerrit.wikimedia.org/r/279367 (owner: 10Addshore) [15:04:06] (03CR) 10Anomie: [C: 032] "Doesn't look like it happens often enough to worry about." [core] - 10https://gerrit.wikimedia.org/r/283777 (https://phabricator.wikimedia.org/T132852) (owner: 10Gergő Tisza) [15:05:58] (03CR) 10Hoo man: [C: 032] Test coverage WatchedItemStore::addWatchBatchForUser to 100% [core] - 10https://gerrit.wikimedia.org/r/283962 (owner: 10Addshore) [15:07:13] (03CR) 10Addshore: "I'm guessing the failure is due to the page being cached in SpecialPageFactory::$pageObjectCache" [core] - 10https://gerrit.wikimedia.org/r/279367 (owner: 10Addshore) [15:08:47] (03PS6) 10Addshore: Introduce SpecialPageFatalTest [core] - 10https://gerrit.wikimedia.org/r/279367 [15:09:02] (03CR) 10Hoo man: [C: 032] Test coverage WatchedItemStore::duplicateAllAssociatedEntries to 100% [core] - 10https://gerrit.wikimedia.org/r/283963 (owner: 10Addshore) [15:14:58] (03CR) 10BryanDavis: "Shouldn't this be done in https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/master/composer.json#L9 instead?" [core] - 10https://gerrit.wikimedia.org/r/283967 (https://phabricator.wikimedia.org/T100544) (owner: 10Addshore) [15:16:19] (03CR) 10jenkins-bot: [V: 04-1] Introduce SpecialPageFatalTest [core] - 10https://gerrit.wikimedia.org/r/279367 (owner: 10Addshore) [15:16:37] (03CR) 10Addshore: "Well, no, as our code sniffer library works just fine with versions below 2.3!" [core] - 10https://gerrit.wikimedia.org/r/283967 (https://phabricator.wikimedia.org/T100544) (owner: 10Addshore) [15:17:01] (03Merged) 10jenkins-bot: Reject usernames with # as user-type API parameters [core] - 10https://gerrit.wikimedia.org/r/283777 (https://phabricator.wikimedia.org/T132852) (owner: 10Gergő Tisza) [15:17:05] (03Merged) 10jenkins-bot: Test coverage WatchedItemStore::addWatchBatchForUser to 100% [core] - 10https://gerrit.wikimedia.org/r/283962 (owner: 10Addshore) [15:17:10] (03Merged) 10jenkins-bot: Test coverage WatchedItemStore::duplicateAllAssociatedEntries to 100% [core] - 10https://gerrit.wikimedia.org/r/283963 (owner: 10Addshore) [15:25:28] (03CR) 10BryanDavis: "mediawiki/mediawiki-codesniffer v0.6.0 has very explicitly pinned squizlabs/php_codesniffer to v2.5.1. I'm not exactly understanding what " [core] - 10https://gerrit.wikimedia.org/r/283967 (https://phabricator.wikimedia.org/T100544) (owner: 10Addshore) [15:28:33] (03CR) 10Addshore: "The issue occours when other libraries want to use the mediawiki codesniffer library and they contain packages that have different require" [core] - 10https://gerrit.wikimedia.org/r/283967 (https://phabricator.wikimedia.org/T100544) (owner: 10Addshore) [15:30:06] (03CR) 10Jforrester: "> Are you saying you don't think there should be a script, or that you think it should be structured differently?" [core] - 10https://gerrit.wikimedia.org/r/283565 (owner: 10Mattflaschen) [15:36:44] (03CR) 10BryanDavis: "Commented on I22ec0a5 which is really the Depends-On for this change, not the other way around as currently described in gerrit." [core] - 10https://gerrit.wikimedia.org/r/283967 (https://phabricator.wikimedia.org/T100544) (owner: 10Addshore) [15:41:32] (03CR) 10Jforrester: [C: 031] resourceloader: Use feature test instead of UA sniffing [core] - 10https://gerrit.wikimedia.org/r/218955 (https://phabricator.wikimedia.org/T102318) (owner: 10Krinkle) [16:09:08] (03PS1) 10Aaron Schulz: Improve getErrorsByType() docs [core] - 10https://gerrit.wikimedia.org/r/283990 [16:13:37] (03PS7) 10Prtksxna: mw.ForeignStructuredUpload.BookletLayout: E/F test of 2 different interfaces [core] - 10https://gerrit.wikimedia.org/r/276136 (https://phabricator.wikimedia.org/T120867) [16:18:41] (03CR) 10jenkins-bot: [V: 04-1] mw.ForeignStructuredUpload.BookletLayout: E/F test of 2 different interfaces [core] - 10https://gerrit.wikimedia.org/r/276136 (https://phabricator.wikimedia.org/T120867) (owner: 10Prtksxna) [16:23:34] (03PS8) 10Prtksxna: mw.ForeignStructuredUpload.BookletLayout: E/F test of 2 different interfaces [core] - 10https://gerrit.wikimedia.org/r/276136 (https://phabricator.wikimedia.org/T120867) [16:37:39] (03CR) 10Anomie: [C: 031] "It looks like you'll still have the bug for trying to create a user named something like "User: Foo", though." [core] - 10https://gerrit.wikimedia.org/r/283775 (https://phabricator.wikimedia.org/T94656) (owner: 10Gergő Tisza) [16:41:32] (03CR) 10Florianschmidtwelzow: Show "list of users" on PermissionsErrorPages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/281199 (https://phabricator.wikimedia.org/T116351) (owner: 10Florianschmidtwelzow) [16:45:30] (03CR) 10Florianschmidtwelzow: [C: 032] Use new TWN template for log-action-filter-* qqq messages [core] - 10https://gerrit.wikimedia.org/r/283867 (owner: 10Alex Monk) [16:55:15] (03Merged) 10jenkins-bot: Use new TWN template for log-action-filter-* qqq messages [core] - 10https://gerrit.wikimedia.org/r/283867 (owner: 10Alex Monk) [17:05:06] (03CR) 10Florianschmidtwelzow: [C: 04-1] "I would be fine with OOUI, too :) (Or in a second change, if you want)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/283848 (https://phabricator.wikimedia.org/T117721) (owner: 1001tonythomas) [17:37:29] (03PS3) 1001tonythomas: Convert Special:WithoutInterwiki to HTMLForm [core] - 10https://gerrit.wikimedia.org/r/283848 (https://phabricator.wikimedia.org/T117721) [17:45:02] (03CR) 10Glaisher: Convert Special:WithoutInterwiki to HTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/283848 (https://phabricator.wikimedia.org/T117721) (owner: 1001tonythomas) [17:50:59] maybe we should quite grrrit-vm till the channel is full ready? What do you think? [17:56:11] (03PS1) 10MaxSem: WIP: Make wikidiff3 the only diff engine [core] - 10https://gerrit.wikimedia.org/r/284003 (https://phabricator.wikimedia.org/T128896) [17:56:25] (03PS2) 10Anomie: Fix i18n message parameter for 'keep me logged in' days. [core] - 10https://gerrit.wikimedia.org/r/283698 (https://phabricator.wikimedia.org/T109031) (owner: 10Gergő Tisza) [18:01:47] (03CR) 10jenkins-bot: [V: 04-1] Fix i18n message parameter for 'keep me logged in' days. [core] - 10https://gerrit.wikimedia.org/r/283698 (https://phabricator.wikimedia.org/T109031) (owner: 10Gergő Tisza) [18:04:31] (03PS1) 10Florianschmidtwelzow: Add special page to add sites to sites table [core] - 10https://gerrit.wikimedia.org/r/284005 (https://phabricator.wikimedia.org/T132937) [18:05:50] (03CR) 10Anomie: Fix i18n message parameter for 'keep me logged in' days. (034 comments) [core] - 10https://gerrit.wikimedia.org/r/283698 (https://phabricator.wikimedia.org/T109031) (owner: 10Gergő Tisza) [18:09:05] (03CR) 10Ori.livneh: [C: 04-1] "LGTM, but a brief summary of the rationale for the change should go in the commit message. You could probably just copy-paste from T102318" [core] - 10https://gerrit.wikimedia.org/r/218955 (https://phabricator.wikimedia.org/T102318) (owner: 10Krinkle) [18:09:32] (03PS2) 10Florianschmidtwelzow: Add maintenance script to add sites to sites table [core] - 10https://gerrit.wikimedia.org/r/284005 (https://phabricator.wikimedia.org/T132937) [18:23:27] (03CR) 10jenkins-bot: [V: 04-1] Add maintenance script to add sites to sites table [core] - 10https://gerrit.wikimedia.org/r/284005 (https://phabricator.wikimedia.org/T132937) (owner: 10Florianschmidtwelzow) [18:26:20] (03CR) 10Florianschmidtwelzow: Standardize html form by using OOUI in Special:Categories (033 comments) [core] - 10https://gerrit.wikimedia.org/r/276964 (https://phabricator.wikimedia.org/T117728) (owner: 10Sidakpal) [18:26:35] (03CR) 10Florianschmidtwelzow: "btw.: needs manual rebase :(" [core] - 10https://gerrit.wikimedia.org/r/276964 (https://phabricator.wikimedia.org/T117728) (owner: 10Sidakpal) [18:39:36] (03CR) 10Southparkfan: Add maintenance script to add sites to sites table (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284005 (https://phabricator.wikimedia.org/T132937) (owner: 10Florianschmidtwelzow) [18:47:08] (03PS1) 10Anomie: DateTimeInputWidget: Set type before calling parent constructor [core] - 10https://gerrit.wikimedia.org/r/284022 [18:53:21] (03CR) 10Florianschmidtwelzow: "Sorry for the late answer :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/264942 (https://phabricator.wikimedia.org/T122553) (owner: 10Devirk) [19:10:13] (03PS1) 10Aaron Schulz: Allow tag names for SqlBagOStuff consistent hashing [core] - 10https://gerrit.wikimedia.org/r/284023 [19:20:41] (03PS5) 10Smalyshev: Create Kafka event relayer [core] - 10https://gerrit.wikimedia.org/r/283750 (https://phabricator.wikimedia.org/T125138) [19:21:06] (03CR) 10jenkins-bot: [V: 04-1] Create Kafka event relayer [core] - 10https://gerrit.wikimedia.org/r/283750 (https://phabricator.wikimedia.org/T125138) (owner: 10Smalyshev) [19:31:52] (03PS6) 10Smalyshev: Create Kafka event relayer [core] - 10https://gerrit.wikimedia.org/r/283750 (https://phabricator.wikimedia.org/T125138) [19:52:48] (03CR) 10Addshore: Add getStatsdDataFactory to MediawikiServices (036 comments) [core] - 10https://gerrit.wikimedia.org/r/282740 (owner: 10Addshore) [19:53:03] (03PS2) 10Addshore: Add getStatsdDataFactory to MediawikiServices [core] - 10https://gerrit.wikimedia.org/r/282740 [19:53:39] (03CR) 10jenkins-bot: [V: 04-1] Add getStatsdDataFactory to MediawikiServices [core] - 10https://gerrit.wikimedia.org/r/282740 (owner: 10Addshore) [19:54:51] (03PS3) 10Addshore: Add getStatsdDataFactory to MediawikiServices [core] - 10https://gerrit.wikimedia.org/r/282740 [19:54:59] (03CR) 10Addshore: "PS3 is a rebase" [core] - 10https://gerrit.wikimedia.org/r/282740 (owner: 10Addshore) [19:55:58] (03PS12) 10Krinkle: resourceloader: Use feature test instead of UA sniffing [core] - 10https://gerrit.wikimedia.org/r/218955 (https://phabricator.wikimedia.org/T102318) [19:57:19] (03CR) 10Jforrester: resourceloader: Use feature test instead of UA sniffing (031 comment) [core] - 10https://gerrit.wikimedia.org/r/218955 (https://phabricator.wikimedia.org/T102318) (owner: 10Krinkle) [19:58:54] (03CR) 10jenkins-bot: [V: 04-1] Add getStatsdDataFactory to MediawikiServices [core] - 10https://gerrit.wikimedia.org/r/282740 (owner: 10Addshore) [19:59:40] (03PS13) 10Krinkle: resourceloader: Use feature test instead of UA sniffing [core] - 10https://gerrit.wikimedia.org/r/218955 (https://phabricator.wikimedia.org/T102318) [20:01:41] (03PS14) 10Krinkle: resourceloader: Use feature test instead of UA sniffing [core] - 10https://gerrit.wikimedia.org/r/218955 (https://phabricator.wikimedia.org/T102318) [20:01:50] (03CR) 10Krinkle: resourceloader: Use feature test instead of UA sniffing (031 comment) [core] - 10https://gerrit.wikimedia.org/r/218955 (https://phabricator.wikimedia.org/T102318) (owner: 10Krinkle) [20:02:42] (03CR) 10Jforrester: resourceloader: Use feature test instead of UA sniffing (031 comment) [core] - 10https://gerrit.wikimedia.org/r/218955 (https://phabricator.wikimedia.org/T102318) (owner: 10Krinkle) [20:25:30] (03CR) 10Jforrester: "Leaving to @ori to +2." [core] - 10https://gerrit.wikimedia.org/r/218955 (https://phabricator.wikimedia.org/T102318) (owner: 10Krinkle) [20:25:46] (03CR) 10Jforrester: resourceloader: Use feature test instead of UA sniffing (031 comment) [core] - 10https://gerrit.wikimedia.org/r/218955 (https://phabricator.wikimedia.org/T102318) (owner: 10Krinkle) [20:27:46] (03PS15) 10Ori.livneh: resourceloader: Use feature test instead of UA sniffing [core] - 10https://gerrit.wikimedia.org/r/218955 (https://phabricator.wikimedia.org/T102318) (owner: 10Krinkle) [20:27:52] (03CR) 10Ori.livneh: [C: 032] resourceloader: Use feature test instead of UA sniffing [core] - 10https://gerrit.wikimedia.org/r/218955 (https://phabricator.wikimedia.org/T102318) (owner: 10Krinkle) [20:42:34] (03Merged) 10jenkins-bot: resourceloader: Use feature test instead of UA sniffing [core] - 10https://gerrit.wikimedia.org/r/218955 (https://phabricator.wikimedia.org/T102318) (owner: 10Krinkle) [20:49:16] (03PS4) 10Addshore: Add getStatsdDataFactory to MediawikiServices [core] - 10https://gerrit.wikimedia.org/r/282740 [20:55:09] (03Abandoned) 10Anomie: Have load.php use the RL language, not the user's preference language [core] - 10https://gerrit.wikimedia.org/r/279122 (https://phabricator.wikimedia.org/T130720) (owner: 10Anomie) [20:56:55] (03PS3) 10Anomie: Enforce load.php's no-session constraint [core] - 10https://gerrit.wikimedia.org/r/273373 (https://phabricator.wikimedia.org/T127233) [20:57:22] (03CR) 10Ori.livneh: [C: 04-1] "Either I am misunderstanding something or this is broken. I tested this with https://dpaste.de/NkG8/raw . (Note you have to hack SqlBagOSt" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284023 (owner: 10Aaron Schulz) [20:58:18] (03CR) 10Anomie: "https://logstash.wikimedia.org/#dashboard/temp/AVQrKI_ojK4nptUtIQh- is showing clean for days now. We should do this." [core] - 10https://gerrit.wikimedia.org/r/273373 (https://phabricator.wikimedia.org/T127233) (owner: 10Anomie) [21:01:53] (03CR) 10Aaron Schulz: "Try using actual array values for $servers1 and $servers2. Otherwise the tags will be index for one bag and the tag names a,b,c for the" [core] - 10https://gerrit.wikimedia.org/r/284023 (owner: 10Aaron Schulz) [21:03:33] (03CR) 10Aaron Schulz: "The arrays needing 'host' of course." [core] - 10https://gerrit.wikimedia.org/r/284023 (owner: 10Aaron Schulz) [21:11:12] (03PS5) 10Krinkle: Enforce $wgReadOnly for job queues [core] - 10https://gerrit.wikimedia.org/r/279664 (https://phabricator.wikimedia.org/T130795) (owner: 10Aaron Schulz) [21:21:24] (03CR) 10Jforrester: [C: 032] DateTimeInputWidget: Set type before calling parent constructor [core] - 10https://gerrit.wikimedia.org/r/284022 (owner: 10Anomie) [21:22:10] (03CR) 10Jforrester: "Is this planned for MW1.27?" [core] - 10https://gerrit.wikimedia.org/r/273373 (https://phabricator.wikimedia.org/T127233) (owner: 10Anomie) [21:36:21] (03Merged) 10jenkins-bot: DateTimeInputWidget: Set type before calling parent constructor [core] - 10https://gerrit.wikimedia.org/r/284022 (owner: 10Anomie) [22:21:25] (03PS2) 10Ori.livneh: Allow tag names for SqlBagOStuff consistent hashing [core] - 10https://gerrit.wikimedia.org/r/284023 (owner: 10Aaron Schulz) [22:21:31] (03CR) 10Ori.livneh: [C: 032] Allow tag names for SqlBagOStuff consistent hashing [core] - 10https://gerrit.wikimedia.org/r/284023 (owner: 10Aaron Schulz) [22:24:33] (03CR) 10Aaron Schulz: Create Kafka event relayer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/283750 (https://phabricator.wikimedia.org/T125138) (owner: 10Smalyshev) [22:30:59] (03Merged) 10jenkins-bot: Allow tag names for SqlBagOStuff consistent hashing [core] - 10https://gerrit.wikimedia.org/r/284023 (owner: 10Aaron Schulz) [22:32:20] (03CR) 10Krinkle: Create Kafka event relayer (032 comments) [core] - 10https://gerrit.wikimedia.org/r/283750 (https://phabricator.wikimedia.org/T125138) (owner: 10Smalyshev) [22:32:44] (03CR) 10Krinkle: [C: 032] Enforce $wgReadOnly for job queues [core] - 10https://gerrit.wikimedia.org/r/279664 (https://phabricator.wikimedia.org/T130795) (owner: 10Aaron Schulz) [22:33:11] (03PS1) 10Ori.livneh: Allow tag names for SqlBagOStuff consistent hashing [core] (wmf/1.27.0-wmf.21) - 10https://gerrit.wikimedia.org/r/284095 [22:33:42] (03CR) 10Ori.livneh: [C: 032] Allow tag names for SqlBagOStuff consistent hashing [core] (wmf/1.27.0-wmf.21) - 10https://gerrit.wikimedia.org/r/284095 (owner: 10Ori.livneh) [22:34:56] (03CR) 10Krinkle: "I'd prefer to wait for the branch cut, so that third-parties have warnings before breakage for one release cycle. The warnings were only i" [core] - 10https://gerrit.wikimedia.org/r/273373 (https://phabricator.wikimedia.org/T127233) (owner: 10Anomie) [22:35:16] (03CR) 10Smalyshev: Create Kafka event relayer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/283750 (https://phabricator.wikimedia.org/T125138) (owner: 10Smalyshev) [22:41:54] (03Merged) 10jenkins-bot: Enforce $wgReadOnly for job queues [core] - 10https://gerrit.wikimedia.org/r/279664 (https://phabricator.wikimedia.org/T130795) (owner: 10Aaron Schulz) [22:43:29] (03Merged) 10jenkins-bot: Allow tag names for SqlBagOStuff consistent hashing [core] (wmf/1.27.0-wmf.21) - 10https://gerrit.wikimedia.org/r/284095 (owner: 10Ori.livneh) [23:06:45] (03CR) 10Jforrester: "recheck" [core] - 10https://gerrit.wikimedia.org/r/277457 (https://phabricator.wikimedia.org/T129976) (owner: 10Krinkle) [23:21:10] (03CR) 10Legoktm: [C: 032] Reject usernames with namespace or interwiki prefixes [core] - 10https://gerrit.wikimedia.org/r/283775 (https://phabricator.wikimedia.org/T94656) (owner: 10Gergő Tisza) [23:30:27] (03Merged) 10jenkins-bot: Reject usernames with namespace or interwiki prefixes [core] - 10https://gerrit.wikimedia.org/r/283775 (https://phabricator.wikimedia.org/T94656) (owner: 10Gergő Tisza) [23:46:39] (03PS7) 10Smalyshev: Create Kafka event relayer [core] - 10https://gerrit.wikimedia.org/r/283750 (https://phabricator.wikimedia.org/T125138) [23:52:17] (03CR) 10jenkins-bot: [V: 04-1] Create Kafka event relayer [core] - 10https://gerrit.wikimedia.org/r/283750 (https://phabricator.wikimedia.org/T125138) (owner: 10Smalyshev) [23:53:26] (03PS8) 10Smalyshev: Create Kafka event relayer [core] - 10https://gerrit.wikimedia.org/r/283750 (https://phabricator.wikimedia.org/T125138)