[01:46:57] bd808 i got it some what working now! [01:47:39] (auto provisions a gerrit install, i just need to fix the systemd unit, apparently it's not finding java_options thus is companing about java.options.each being nil) [02:05:15] paladox: ah. I know the problem that your hitting with the erb template! Puppet 4's scope rules won't pass your variable through to the define's code. The fix is to use an epp template and explicitly pass the variable through. Here's an example -- https://github.com/wikimedia/mediawiki-vagrant/blob/57ef729a34620611b170d88d56afc337f0813290/puppet/modules/thumbor/manifests/service.pp#L30-L52 [02:05:34] bd808 ah! (thanks!!) [02:13:41] bd808 works now! [02:15:21] paladox: cool. I'll try to make some time tomorrow or over the weekend to test it out [02:15:30] thanks :) [02:15:44] im just trying to figure out how to stop it provisioning gerrit after it's done it. [02:20:06] paladox: what part of it is happening again on a second puppet run? [02:20:20] both install_gerrit and reindex_gerrit [02:20:24] i think i know why [02:21:52] hmmm... file paths wrong for the 'creates' attributes you added? [02:22:43] fixed now :) [02:22:54] needed a test ! -f rather then test -e [02:23:29] published new change :) [02:48:45] bd808 https://gerrit-gitldap.wmflabs.org/r/#/q/status:open works! [10:33:15] There's a bit of a critical issue with the Quickstatements batch list - normally up to 16 batches can run simultaneously, but right now there's just 1 that's running, everything else with any "DONE" items on the list at https://tools.wmflabs.org/quickstatements/#/batches was last updated almost 2 hours ago. [10:33:23] Is everything else in Toolforge running properly? [12:35:29] !log tools.quickstatements stop webservice [12:35:30] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.quickstatements/SAL [16:57:06] !log tools.quickcategories deployed 3c58cc0810 (minor UI improvements) [16:57:08] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.quickcategories/SAL [18:01:06] Some recent revisions in Replica — particularly for wikidata — don't seem to have rev_user_text or rev_user fields set. Is that an expected thing as part of the actor table stuff? [18:05:37] bstorm_: ^ [18:06:31] ragesoss: *I* am not removing them on the replica views until Monday. They will error right out after that. If the data is not in them, that'd be upstream [18:07:47] Hmm, actually, the recent changes we did for that table to speed up the rev_actor field could have affected it a bit. In general, at this point, I'd recommend not using those fields at all. You'll get an error after the changes start Monday [18:08:05] only the much slower _compat tables will retain them [18:08:25] Everything should be backfilled to the actor storage [18:10:59] yeah, these missing values are happening for last two days of wikidata, but not for en.wiki, so I guess it's some upstream thing with wikidata replication. [18:11:02] :/ [18:14:44] bstorm_: I'm using revision_userindex.rev_user and .rev_user_text. Are those going away? [18:14:51] Yes [18:14:53] or just revision.rev_user [18:14:57] both [18:15:10] you have to use revision.rev_actor and data from the actor table [18:16:17] T223406 [18:16:18] T223406: Remove reference to fields replaced by the actor table from WMCS views - https://phabricator.wikimedia.org/T223406 [18:16:38] That provides a bit more context, ragesoss [18:16:47] Also the linked tasks might help [18:17:58] thanks. didn't realize this affected revision_userindex in addition to revision. [18:19:59] revision_userindex is a view of the revision table that takes advantage of another index a bit better. [18:20:16] But yeah, the only tables that won't be affected are like revision_compat [18:20:29] However, I expect those to be slow as well [18:26:31] bstorm_: the scratch mount on encoding01.video.eqiad.wmflabs is read-only. can I remount it read-write, considering your emails regarding scratch is 3 days ago? [18:26:56] uhhh...I may have set something incorrectly in my patch [18:27:04] You should be able to. Checking [18:27:23] ok I'll wait for you to check. I don't want to mess up :P [18:28:16] Yes, I screwed that up. My apologies. Putting up the patch to fix now [18:30:34] https://gerrit.wikimedia.org/r/c/operations/puppet/+/513666 [18:31:10] Going to merge right away and see if that fixes it. It should! [18:31:37] thanks much bstorm_! I think we've nearly got our tool sorted out, and actor had the usernames that disappeared for recent wikidata revisions. [18:33:43] Good :) [18:35:45] zhuyifei1999_: the puppet change I put up seems to be mounting rw correctly now [18:36:13] Whenever the change hits your server... [18:39:14] are the `.out` and `.err` files updated continuously or only at the end of a job run? [18:39:37] bstorm_: thanks ;) [18:39:55] Thank you! Everyone missed that on code review [18:40:43] bennofs[m]: Continuously appears to be the usual behavior [18:44:18] cool, thanks! one more question: do grid engine jobs have access to more than a single core? (i.e, does it make sense to parallelize my code?) [18:45:17] $ jsub -sync y nproc [18:45:21] $ cat ~/nproc.out [18:45:23] 4 [18:46:16] if it’s an easily parallelizable workload, I guess it could make sense [19:11:20] bennofs[m]: each grid engine exec node has 4 cores and grid engine doesn't apply any cgroups or other restrictions that would prevent you from using multiple cores, but ... using more than one core heavily for a long time might starve out other jobs scheduled on the same node. [19:11:35] so I guess experiment, but be careful :) [19:13:20] the lack of cgroup restrictions on grid jobs is one of the things I dislike about grid engine generally. The service expects everyone to be nice and play well with others, which is an easy social contract to break accidentally (and on purpose) [22:06:20] !log tools.quickcategories deployed ebfed74416 (minor error handling improvements) [22:06:22] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.quickcategories/SAL [22:59:40] !log automation-framework Increased quota for cores, ram, and instances (T224057) [22:59:42] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Automation-framework/SAL [22:59:43] T224057: Request increased quota for Automation Framework Cloud VPS project - https://phabricator.wikimedia.org/T224057 [23:07:01] !log sso Increased quota for floating ips (T224272) [23:07:03] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Sso/SAL [23:07:04] T224272: Request increased quota for sso Cloud VPS project - https://phabricator.wikimedia.org/T224272