[02:11:17] !log shinken After much fiddling around, shinken-wm should be working properly again. Puppet is disabled on the host until https://gerrit.wikimedia.org/r/455277 goes in [02:11:19] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Shinken/SAL [02:56:24] (03PS1) 10Dbarratt: Rewrite GraphQL server in JavaScript. [labs/tools/graphql] - 10https://gerrit.wikimedia.org/r/455278 [07:01:08] (03CR) 10Lokal Profil: "new to pipenv but:" [labs/tools/heritage] - 10https://gerrit.wikimedia.org/r/455015 (owner: 10Jean-Frédéric) [07:04:54] (03CR) 10Lokal Profil: "also. by keeping the requirements.txt, do we risk a situation where someone tries to bump a version in it rather than in the pipenv file?" [labs/tools/heritage] - 10https://gerrit.wikimedia.org/r/455015 (owner: 10Jean-Frédéric) [11:59:03] (03CR) 10Merlijn van Deen: [C: 032] Add examples extension to #wikimedia-dev-africa [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/454637 (owner: 10D3r1ck01) [11:59:39] (03Merged) 10jenkins-bot: Add examples extension to #wikimedia-dev-africa [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/454637 (owner: 10D3r1ck01) [11:59:48] (03CR) 10jenkins-bot: Add examples extension to #wikimedia-dev-africa [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/454637 (owner: 10D3r1ck01) [15:59:36] (03PS1) 10Merlijn van Deen: Replace fabfile with command line script to run remotely [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/455347 (https://phabricator.wikimedia.org/T201958) [16:00:07] (03CR) 10jerkins-bot: [V: 04-1] Replace fabfile with command line script to run remotely [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/455347 (https://phabricator.wikimedia.org/T201958) (owner: 10Merlijn van Deen) [16:11:50] @legoktm ^ & https://www.mediawiki.org/wiki/Wikibugs#Deploying_changes [16:12:39] I've killed fabric as deployment tool and moved to the python equivalent of a bash script [16:13:55] (03CR) 10Zhuyifei1999: Use flask.jsonify instead of json.dumps (036 comments) [analytics/quarry/web] - 10https://gerrit.wikimedia.org/r/455237 (owner: 10Framawiki) [16:16:42] (03PS2) 10Merlijn van Deen: Replace fabfile with command line script to run remotely [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/455347 (https://phabricator.wikimedia.org/T201958) [16:18:49] (03CR) 10Merlijn van Deen: [C: 032] Replace fabfile with command line script to run remotely [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/455347 (https://phabricator.wikimedia.org/T201958) (owner: 10Merlijn van Deen) [16:19:20] (03Merged) 10jenkins-bot: Replace fabfile with command line script to run remotely [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/455347 (https://phabricator.wikimedia.org/T201958) (owner: 10Merlijn van Deen) [16:19:22] (03CR) 10jenkins-bot: Replace fabfile with command line script to run remotely [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/455347 (https://phabricator.wikimedia.org/T201958) (owner: 10Merlijn van Deen) [19:21:55] (03CR) 10Merlijn van Deen: [C: 032] Extend manage.py to support dry-run mode to display commands [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/455362 (owner: 10Merlijn van Deen) [19:22:10] (03CR) 10Merlijn van Deen: [C: 032] Remove support for WIP reporting [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/455363 (https://phabricator.wikimedia.org/T202818) (owner: 10Merlijn van Deen) [19:22:36] (03Merged) 10jenkins-bot: Extend manage.py to support dry-run mode to display commands [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/455362 (owner: 10Merlijn van Deen) [19:22:38] (03Merged) 10jenkins-bot: Remove support for WIP reporting [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/455363 (https://phabricator.wikimedia.org/T202818) (owner: 10Merlijn van Deen) [19:22:44] (03CR) 10jenkins-bot: Extend manage.py to support dry-run mode to display commands [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/455362 (owner: 10Merlijn van Deen) [19:22:46] (03CR) 10jenkins-bot: Remove support for WIP reporting [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/455363 (https://phabricator.wikimedia.org/T202818) (owner: 10Merlijn van Deen) [19:51:23] valhallasw`cloud: click? alright :) [19:56:39] valhallasw`cloud: I think upstream fixed wip event, I will need to look to see if I did it correctly or if it was changed [19:56:51] Or if we are running a version that does not include the fix [19:57:12] Though currently in Lake District on holiday :) [21:02:20] legoktm: yep! Not completely happy with Click though, it's a bit too much black magic. Maybe I should just have optparsed the heck out of everything :-p [21:02:30] argparse!!! [21:03:01] I haven't used it in a project yet, but click really looks like flask but for CLI [21:04:07] Aye [21:04:24] But from what I've seen writing this, Flasks docs are much better [21:04:34] then again, I got it to work in the way that I wanted, so /shrug [21:16:23] valhallasw`cloud: do you think I can get +2 on the gerrit repo for wikibugs? I'm already added in the instance and can +2 as part of my mediawiki access, but I'm not sure I am permitted. [21:17:17] if you're already a member of the wikibugs tool then it's totally fine [21:17:40] I am [21:19:45] Hauskatze: according to gerrit you are in the labs-tools-wikibugs2 group, which should give you +2 on the repo already? [21:20:44] valhallasw`cloud: maybe somebody added me a while ago [21:21:05] so do you see the Code-Review+2 button on wikibugs changes? [21:21:08] cf. some messages above [21:21:55] Krenair: no, but if I click on "reply" then I can c2 v2 [21:22:12] checking on https://gerrit.wikimedia.org/r/#/c/labs/tools/wikibugs2/+/443220/ [21:23:16] anyway, I can trigger Code-Review+2 so should be good when there's a need for that [21:23:47] ok good [21:23:59] valhallasw`cloud: with the removal of fabfile, will the bot autoupdate the repo on labs itself or will we need to ssh and git pull? [21:24:57] I don't think the blue CR+2 button outside the reply area shows when a change already has a negative CR [21:25:22] to encourage you to go and give a reply explaining why you are approving anyway [21:25:28] Krenair: good point, I shall check that [21:25:52] indeed: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OATHAuth/+/452020/ [21:30:54] Hauskatze: autoupdate happens through jenkins [21:31:33] Hauskatze: but only channel changes for phabricator are detected, so other things still require parts of the bot to be restarted [21:32:04] valhallasw`cloud: aha, so if I update the channels.yaml file that doesn't need me to log in there? [21:32:32] right. Wikibugs should report that in this channel as well ('updated channels.yaml to ') [21:32:54] ack :D [21:33:03] you can still run the new deployment thing as a one-liner locally: ssh tools-login.wmflabs.org sudo -niu tools.wikibugs /data/project/wikibugs/py-wikibugs2/bin/python /data/project/wikibugs/wikibugs2/manage.py deploy [21:33:10] but that's a bit of a pita :D [21:33:30] I prefer to ssh, become wikibugs and then 'python manage.py deploy' [21:34:00] (and wait for the error message and the big boom) [21:34:41] Heh. Yeah, that should work well now.