[07:17:34] Hi! [07:17:54] I have got a new toolsadmin account. [07:18:04] but: You are not currently authorized to view the URI /tools/create/. [07:18:18] What do I have to do to get this permission? [07:19:55] Is this the correct way? https://toolsadmin.wikimedia.org/tools/membership/status/342 [07:44:02] sry have to leave [07:52:27] vgutierrez: hey! I've got your email regarding updating the TLS version of my tool (Fountain). Can you please clarify it a bit? I'm pretty sure the TLS version I use is dependent on the mono version installed on the web grid, and I didn't get the same notification regarding my other tool (chie-bot) which is using the same grid queue (webgrid-lighttpd@tools-webgrid). I don't do any special TLS handling in either of those tools, [12:02:18] (03PS1) 10Merlijn van Deen: Fix slugify for wmf.999 [labs/tools/forrestbot] - 10https://gerrit.wikimedia.org/r/443212 (https://phabricator.wikimedia.org/T198527) [12:02:43] (03CR) 10jerkins-bot: [V: 04-1] Fix slugify for wmf.999 [labs/tools/forrestbot] - 10https://gerrit.wikimedia.org/r/443212 (https://phabricator.wikimedia.org/T198527) (owner: 10Merlijn van Deen) [12:02:52] Love you too, jenkins [12:15:21] (03PS2) 10Merlijn van Deen: Fix slugify for wmf.999 [labs/tools/forrestbot] - 10https://gerrit.wikimedia.org/r/443212 (https://phabricator.wikimedia.org/T198527) [12:16:12] (03CR) 10Merlijn van Deen: [C: 032] Fix slugify for wmf.999 [labs/tools/forrestbot] - 10https://gerrit.wikimedia.org/r/443212 (https://phabricator.wikimedia.org/T198527) (owner: 10Merlijn van Deen) [12:16:37] (03Merged) 10jenkins-bot: Fix slugify for wmf.999 [labs/tools/forrestbot] - 10https://gerrit.wikimedia.org/r/443212 (https://phabricator.wikimedia.org/T198527) (owner: 10Merlijn van Deen) [12:46:17] valhallasw`cloud: I’ve updated my change to address your feedback! [12:46:35] Turns out there was already a function we could use to reduce duplication. [13:56:02] (03CR) 10Merlijn van Deen: [C: 032] "Nice, thanks!" (031 comment) [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/399386 (owner: 10Paladox) [13:56:29] (03Merged) 10jenkins-bot: Add support for gerrit 2.15 WIP feature, also remove support for drafts [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/399386 (owner: 10Paladox) [13:56:33] paladox: I've left one further suggestion inline. If you have some time to pick it up, that would be awesome, if not, no worries :-) [13:56:41] (03CR) 10jenkins-bot: Add support for gerrit 2.15 WIP feature, also remove support for drafts [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/399386 (owner: 10Paladox) [13:58:46] valhallasw`cloud: ah thanks, will do that later, currently in the car! [13:59:09] valhallasw`cloud: does it automatically deploy? [13:59:19] mmm, probably not [13:59:29] Ok [13:59:44] I think there's a magic fab deploy to do this... let me check [14:00:11] Ok thanks [14:15:26] (03PS1) 10Merlijn van Deen: Update contributors [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443216 [14:15:47] (03CR) 10jerkins-bot: [V: 04-1] Update contributors [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443216 (owner: 10Merlijn van Deen) [14:17:28] (03PS2) 10Merlijn van Deen: Update contributors [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443216 [14:17:59] (03CR) 10Merlijn van Deen: [C: 032] Update contributors [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443216 (owner: 10Merlijn van Deen) [14:18:22] (03Merged) 10jenkins-bot: Update contributors [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443216 (owner: 10Merlijn van Deen) [14:18:31] (03CR) 10jenkins-bot: Update contributors [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443216 (owner: 10Merlijn van Deen) [14:22:29] paladox: should be deployed now [14:23:33] (03PS1) 10Merlijn van Deen: fabfile: check correct job name(s) are used [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443218 [14:23:52] (03CR) 10Merlijn van Deen: [C: 032] fabfile: check correct job name(s) are used [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443218 (owner: 10Merlijn van Deen) [14:24:12] (03Merged) 10jenkins-bot: fabfile: check correct job name(s) are used [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443218 (owner: 10Merlijn van Deen) [14:24:18] (03CR) 10jenkins-bot: fabfile: check correct job name(s) are used [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443218 (owner: 10Merlijn van Deen) [14:26:01] valhallasw`cloud: thanks! [14:29:47] valhallasw`cloud: seems that wips are not being ignored [14:30:58] Guess I need to add the check in the patchset-created event too [14:31:59] (03PS1) 10Paladox: Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 [14:34:54] paladox: ah, right, your previous change only made sure WIP -> PS transitions were reported. I'm actually not 100% sure that WIP changes should not be reported -- it also makes sense to get early feedback, even if it cannot be merged yet, right? [14:39:54] (03PS2) 10Paladox: Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 [14:40:15] (03CR) 10jerkins-bot: [V: 04-1] Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 (owner: 10Paladox) [14:42:10] (03PS3) 10Paladox: Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 [14:42:30] (03CR) 10jerkins-bot: [V: 04-1] Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 (owner: 10Paladox) [14:45:45] (03PS4) 10Paladox: Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 [14:46:06] (03CR) 10jerkins-bot: [V: 04-1] Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 (owner: 10Paladox) [14:50:15] (03PS5) 10Paladox: Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 [14:50:36] (03CR) 10jerkins-bot: [V: 04-1] Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 (owner: 10Paladox) [14:52:10] (03PS6) 10Paladox: Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 [14:52:32] (03CR) 10jerkins-bot: [V: 04-1] Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 (owner: 10Paladox) [14:58:26] (03PS7) 10Paladox: Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 [14:58:48] (03CR) 10jerkins-bot: [V: 04-1] Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 (owner: 10Paladox) [15:00:35] (03PS8) 10Paladox: Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 [15:03:12] valhallasw`cloud: ^^ [15:03:43] (03PS1) 10Paladox: Ignore wips when creating a patchset or comments [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 [15:08:12] (03PS2) 10Paladox: Ignore wips when creating a patchset [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 [15:09:37] Im on mobile so couldn’t do the comments section to much to indent on mobile [15:12:40] (03PS3) 10Paladox: Ignore wips when creating a patchset [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 [15:15:43] (03PS4) 10Paladox: Ignore wips when creating a patchset [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 [15:16:45] (03PS5) 10Paladox: Ignore wips when creating a patchset [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 [15:24:13] (03PS6) 10Paladox: Ignore wips when creating a patchset [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 [15:32:02] (03PS7) 10Paladox: Ignore wips when creating a patchset [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 [15:33:26] (03CR) 10Paladox: "This should work now, I had a look on the rest api for how wip is set and it’s set like work_in_progress and not wip" [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 (owner: 10Paladox) [15:36:07] paladox: eh, the source is not the REST api, but gerrit stream-events. Those likely have a different format [15:37:36] so I think it's probably best to use stream-events to get an example WIP result, then create a unit test from that [15:39:26] (03PS8) 10Paladox: Ignore wips when creating a patchset [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 [15:39:45] (03PS9) 10Paladox: Ignore wips when creating a patchset [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 [15:40:06] valhallasw`cloud: ah just re read the doc [15:40:33] I’m not sure why it’s not working correctly at least when you press the start review button it no longer comments to irc [15:40:50] Which I suppose it should as that means it is not a WIP anymore [15:43:01] valhallasw`cloud: I meant I read the doc :) [15:43:07] And see the difference [15:52:34] valhallasw`cloud just tested on gerrit.git.wmflabs and i see "wip":true when it's a wip [15:54:30] valhallasw`cloud i wonder if i have caused a exepction now [15:54:40] when ever it is the wip state type [15:54:48] wip-state-changed [15:54:59] because it only has change and not patchSet [15:55:23] (03PS10) 10Paladox: Ignore wips when creating a patchset [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 [15:55:56] i think that fixes it all now! [15:56:09] paladox: could you copy the json and make a unit test out of it? [15:56:29] valhallasw`cloud uh, im not sure how to do unit tests in python [15:57:00] basically, a test that runs that json through process_event() and checks the returned json makes sense [15:57:04] here's the json i have https://phabricator.wikimedia.org/P7319 [15:57:12] (y) [15:58:21] I'm working on some other stuff right now, but I'll try to review + add the test later today [15:58:30] ok thanks valhallasw`cloud! [16:05:22] * paladox goes out into the hot hot sun [16:34:41] !log tools "sed -i '/labstore1006/d' /etc/fstab" everywhere [16:34:44] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/SAL [16:35:42] !log tools `root@tools-paws-master-01:~# sed -i 's/^labstore1006.wikimedia.org/#labstore1006.wikimedia.org/' /etc/fstab` [16:35:44] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/SAL [16:39:06] !log tools reboot tools-paws-master-01 [16:39:08] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/SAL [16:40:00] !log tools because tools-paws-master-01 was having ~1000 loadavg due to NFS having issues and processes stuck in D state [16:40:02] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/SAL [18:15:45] !log tools pushed new config to PAWS to fix dumps nfs mountpoint [18:15:48] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/SAL [18:50:37] (03PS1) 10Rosalieper: [WIP]Trying to use the async and await keywords for the download and twit [labs/tools/Commons-twitter-bot] - 10https://gerrit.wikimedia.org/r/443230 [19:32:53] paladox: in that list of stream-event messages, did you first upload a change and then set it to WIP? [19:33:07] Yep [19:34:06] valhallasw`cloud: thanks for clearing those logs :) [19:34:17] forrestbot working normaly now? [19:35:04] paladox: and then immediately set it off WIP? [19:35:09] Yep [19:35:15] it's kinda hard to interpret the messages without context of what you did :P [19:35:19] Hauskatze: I think so [19:35:20] Heh [19:35:23] Hauskatze: I __hope__ so :-p [19:35:38] valhallasw`cloud: will file tasks if it stops working again :) [19:40:02] Hauskatze: thanks@ [19:55:13] (03PS1) 10Merlijn van Deen: Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 [19:55:15] (03PS1) 10Merlijn van Deen: Update parsing for current Phab version [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443236 [19:55:17] (03PS1) 10Merlijn van Deen: Add basic grrrrit-wm test [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443237 [19:55:33] (03CR) 10jerkins-bot: [V: 04-1] Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 (owner: 10Merlijn van Deen) [19:55:36] (03CR) 10jerkins-bot: [V: 04-1] Add basic grrrrit-wm test [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443237 (owner: 10Merlijn van Deen) [19:55:38] (03CR) 10jerkins-bot: [V: 04-1] Update parsing for current Phab version [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443236 (owner: 10Merlijn van Deen) [19:55:40] that was to be expected [19:58:10] (03PS2) 10Merlijn van Deen: Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 [19:58:47] (03CR) 10jerkins-bot: [V: 04-1] Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 (owner: 10Merlijn van Deen) [20:00:52] valhallasw`cloud: I expect the wip test to fail I think as there is no patchsetSet attribute [20:00:56] Which I fixed in: [20:01:05] there is no wip test yet :-p [20:01:20] https://gerrit.wikimedia.org/r/#/c/labs/tools/wikibugs2/+/443220/ [20:04:52] (03PS3) 10Merlijn van Deen: Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 [20:05:27] (03CR) 10jerkins-bot: [V: 04-1] Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 (owner: 10Merlijn van Deen) [20:06:45] (03PS4) 10Merlijn van Deen: Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 [20:07:18] (03CR) 10jerkins-bot: [V: 04-1] Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 (owner: 10Merlijn van Deen) [20:08:25] (03PS5) 10Merlijn van Deen: Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 [20:08:34] (03CR) 10jerkins-bot: [V: 04-1] Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 (owner: 10Merlijn van Deen) [20:09:56] (03PS6) 10Merlijn van Deen: Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 [20:10:30] (03CR) 10jerkins-bot: [V: 04-1] Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 (owner: 10Merlijn van Deen) [20:11:39] (03PS7) 10Merlijn van Deen: Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 [20:11:45] I'm feeling better about this one [20:11:48] * valhallasw`cloud crosses fingers [20:12:30] [insert success kid here] [20:13:24] (03PS2) 10Merlijn van Deen: Update parsing for current Phab version [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443236 [20:13:26] (03PS2) 10Merlijn van Deen: Add basic grrrrit-wm test [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443237 [20:15:50] (03CR) 10Merlijn van Deen: [C: 032] Add basic grrrrit-wm test [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443237 (owner: 10Merlijn van Deen) [20:15:52] (03CR) 10Merlijn van Deen: [C: 032] Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 (owner: 10Merlijn van Deen) [20:15:54] (03CR) 10Merlijn van Deen: [C: 032] Update parsing for current Phab version [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443236 (owner: 10Merlijn van Deen) [20:16:16] (03Merged) 10jenkins-bot: Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 (owner: 10Merlijn van Deen) [20:16:18] (03Merged) 10jenkins-bot: Update parsing for current Phab version [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443236 (owner: 10Merlijn van Deen) [20:16:23] (03Merged) 10jenkins-bot: Add basic grrrrit-wm test [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443237 (owner: 10Merlijn van Deen) [20:16:28] (03CR) 10jenkins-bot: Clean up testing situation [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443235 (owner: 10Merlijn van Deen) [20:16:31] (03CR) 10jenkins-bot: Update parsing for current Phab version [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443236 (owner: 10Merlijn van Deen) [20:16:33] (03CR) 10jenkins-bot: Add basic grrrrit-wm test [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443237 (owner: 10Merlijn van Deen) [20:17:19] (03PS9) 10Paladox: Make check_owner a enum [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443219 [20:17:30] valhallasw`cloud: ^^ [20:17:43] That addresses your commit on the one merged earlier today [20:17:55] (03PS11) 10Paladox: Ignore wips when creating a patchset [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 [20:18:23] (03CR) 10jerkins-bot: [V: 04-1] Ignore wips when creating a patchset [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 (owner: 10Paladox) [20:18:31] Uh [20:19:17] I have no idea how to fix that one [20:20:57] paladox: the 'wip' key may not be present [20:23:20] Hmm [20:24:27] valhallasw`cloud: ah, I guess that’s because it will only show the wip field if it’s true [20:31:28] valhallasw`cloud: would event.get(‘wip’, False) work? [20:40:22] !log deployment-prep ran git gc on deployment-tin:/srv/mediawiki to free up space [20:40:28] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/SAL [20:40:53] (03PS12) 10Paladox: Ignore wips when creating a patchset [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 [20:41:19] (03CR) 10jerkins-bot: [V: 04-1] Ignore wips when creating a patchset [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 (owner: 10Paladox) [20:42:24] (03PS13) 10Paladox: Ignore wips when creating a patchset [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/443220 [23:08:44] Is python 3.6 available for tools on tool forge? [23:34:23] yurb, pretty sure it is [23:34:32] uh, sorry [23:34:41] brain skipped '.6' [23:34:46] there's 3.4 on the bastion [23:35:02] that's probably reflected on most other instances in there [23:35:04] do you really need .6? [23:36:44] Krenair: I was using the typing module, but I hear on #python that it has been backported to python 3.4. I still have some f-strings in the code thought. I think I could backport it to py3.4, but first I'd make sure py3.6 is not a possibility [23:39:06] to be honest even the wikimedia stretch servers have 3.5.3, and I don't know if tools has stretch anywhere yet [23:39:18] so probably not unless specifically requested [23:39:44] I see [23:41:02] Oh, they are still jessie [23:42:20] yeah the jessie machines will likely have 3.4.2