[11:47:53] can anyone help me with adding a simple config var from localsettings -> available in mw.config? I only know how to do it via extension.json/ResourceLoaderGetConfigVars hook but wikibase seems to have its own thing going for config vars [12:36:29] / Needs to be 1.26c because version_compare() works in confusing ways. [12:36:29] if ( version_compare( $GLOBALS['wgVersion'], '1.26c', '<' ) ) { [12:36:29] die( "Error: Wikibase requires MediaWiki 1.26 or above.\n" ); [12:36:29] }\ [12:36:40] * Reedy wonders if Wikibase master will actually run on MW 1.27. He suspects not [12:41:38] Reedy: repo/Wikibase.php compares against 1.34c [12:41:49] Sure, but Client and Lib don't [12:41:53] yeah [12:42:02] I can't imagine they're not using code in at least 1.33, if not master :) [12:42:14] It's ok anyway, 1.27 is going to die imminantly [12:42:16] perhaps we’ll be better at updating them when we’ve finally managed to migrate to extension.json [12:48:53] mvolz: Can you piece together something from what's in extensions/Wikibase/repo/resources/Resources.php [13:00:10] tarrow: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/514280/ ? doesn't work but on the right track? [13:00:55] * tarrow will look after lunch :) [13:01:00] ^-^ [13:01:16] that's cool, sounds like I was on the right track since correct file [13:03:57] mvolz: I would assume it doesn’t work because you export a variable $wbRefTabsEnabled which as far as I can see doesn’t exist? [13:04:26] I've set it in my localsettings, i take it that's not sufficent :P [13:04:36] oh right [13:04:38] wait nvm [13:05:46] then it would still need a `global` declaration, I think [13:06:18] so would $wbRefTags [14:02:27] mvolz: looks like the right track ish to me :)