[01:39:10] hi [06:37:42] !admin , Q4580256 and Q3907246 should have it's hewiki links moved between, but wikidata doesn't let me to do that [06:40:36] first saying that i cannot remove a sitelink, and the other saying the link already exist in the other item and it needs to be either removed there or items to be merged, but the items are about a bit different things [07:09:42] aude: I think I thought of a way to make the unit conversion data without backpatching, so I think no need to do it, it can wait for regular train [11:21:18] DanielK_WMDE: Hey, Around? [12:06:04] not really, i have to prepare a meeting. I'll be back around 15:30 [12:07:39] DanielK_WMDE: addshore: Does any of you have an api using entitylookup handy? [12:07:49] Like an actual EntityLookup implementation [12:09:14] *looks* [12:09:14] hoo: https://github.com/addwiki/wikibase-api/tree/master/src/Api/Lookup ? [12:09:14] https://github.com/addwiki/wikibase-api/blob/master/src/Api/Lookup/EntityApiLookup.php [12:10:49] hoo: like RevisionBasedEntityLookup? what do you mean? [12:11:23] addshore: Thanks :) [12:11:37] DanielK_WMDE: An EntityLookup that's using the getentities api to fetch entities [12:12:07] and hoo, if you see any api related interfaces missing let me know and I will attempt to knock them up for you! [12:12:16] * addshore lives the libraries for this! :D [12:12:19] *loves [12:12:32] hoo: oh, an api-using, not an api using ;) [12:12:56] oh, yes :P [12:18:09] composer the most fun thing to do on trains since mobile networks :/ [12:20:44] addshore: Your dependencies are not quite up to date :/ [12:27:01] hoo: :( [12:27:06] hoo: feel free to update them! :D [12:27:44] I'm going to lunch now but can merge any PR when I get back! [14:00:08] help [14:00:11] HELP [14:09:35] OttomanTr: "Fire, exclamation mark, fire. Looking forward to hearing from you." [16:41:15] leszek_wmde: please rebase https://github.com/wmde/WikibaseDataModelServices/pull/149 [16:41:17] i'll merge [16:43:02] leszek_wmde: one side effect is that the ID parser for the local wiki will have a '' => '' mapping. [16:44:42] DanielK_WMDE: rebased [16:44:46] thanks! [16:45:01] DanielK_wMDE: and true, this will be very silly [16:45:08] leszek_wmde: as to https://github.com/wmde/WikibaseDataModelServices/pull/150 - shall we wait for the assert thing to go in? that will then need a release... [16:45:18] or shall we just merge, and use the assert class later? [16:47:06] DanielK_WMDE: I dont know what would be better. Maybe let's say we would use the assert class later, to postpone the release in case we want to change something in the assert etc [16:47:40] just make addshore merge the assert stuff ;) [16:47:50] he just said no [16:47:55] DanielK_WMDE: I just took a look and gave it a +0 :p [16:48:21] it seems super odd to put it in there, but i cant think of a better place, but i hate it, but meh [16:48:31] but +0 is better than -0. We might be able to convince him :) [16:48:36] addshore: we all share that feeling. [16:48:42] hehe [16:48:57] Well, as we all share it maybe I'll +0.1 it and merge it then [16:49:00] addshore: it's not pretty, but it's useful, and the other options are not prettier [16:49:07] #newlibrary [16:49:09] ;) [16:49:13] DataModelAssertions [16:49:17] ;_; [16:49:34] infact, DataModel is probably missplace there, as they are kind of not DM assertions :p [16:49:35] i'll just merge. it's easy enough to change or kill [16:49:44] /wmde/MoreAssertionThingsThatDoStuff [16:50:56] * addshore is a fan of moving forward.. [16:51:29] jakob_WMDE: DanielK_WMDE leszek_wmde anything else on GitHub for me to stare and? [16:51:30] *at [16:52:16] addshore: nothing from me at the moment, thanks :) [16:52:44] addshore: so https://github.com/wmde/WikibaseDataModelServices/pull/149 and https://github.com/wmde/WikibaseDataModelServices/pull/150 are still open [16:52:57] but former might be merged by Daniel any minute [16:53:11] and the latter is also rather ready [16:58:47] leszek_wmde: can you make a release for DataModel now, and change the patches that need the assert stuff to require the new release? [16:59:58] DanielK_WMDE: let's see if I could do it in 15 mins. I'll first add @since tags to methods as @addshore just suggested [17:00:06] :D [17:00:42] hoo: fancy looking at the cognate stuff again ? ;) [17:01:09] addshore: send a link [17:01:17] DanielK_WMDE: http://i3.kym-cdn.com/photos/images/original/000/224/219/funny-pictures-kittens-code.jpg [17:01:34] leszek_wmde: too late, merged ;) [17:01:35] DanielK_WMDE: sorry I meant https://gerrit.wikimedia.org/r/#/c/314306/ (i think) [17:01:59] addshore: that's betetr than posting pornhub links by accident [17:02:34] addshore: Sure, nto sure today, though [17:02:52] addshore: https://github.com/wmde/WikibaseDataModel/pull/688 [17:03:12] hoo: okay! :D [17:34:02] longest objects in wikidata: http://tinyurl.com/h4m6m7d [17:34:39] DanielK_WMDE: converstion seem to be working fine ^^ [17:34:44] DanielK_WMDE: I've adjusted https://github.com/wmde/WikibaseDataModelServices/pull/150. I will do the same for the other dispatching service patch (the one on gerrit) tomorrow morning. Really gotta go now [17:34:57] thanks for moving all those things forward btw Daniel and Adam! [18:23:39] Lydia_WMDE: ping? [18:23:48] mobrovac: hey [18:23:57] Lydia_WMDE: hello [18:24:01] Lydia_WMDE: re https://phabricator.wikimedia.org/T149114#2769164 [18:24:19] ah yeah [18:24:21] Lydia_WMDE: would it be fair to say you want VE on all namespaces except the main one? [18:24:34] and the property namespace [18:24:52] do you happen to know the code for that one? [18:25:04] *numeric code [18:25:12] one sec [18:25:38] 120 [18:25:42] ok awesome [18:25:47] we'll get it back now [18:25:53] cool :) [18:25:55] Lydia_WMDE: sorry for that, my bad totally [18:25:55] thanks [18:26:00] it's ok [18:26:01] :) [18:26:03] :) [18:26:39] mobrovac: not sure if it affects anything else but that is what DanielK_WMDE could think of [18:27:37] Lydia_WMDE: it depends if you want to access the parsoid html for 0 and 120 too [18:27:42] if not, that'll be fine [18:28:38] but since WD has its own API for 0 and 120, that shouldn't be an issue [18:28:45] mobrovac: parsoid html for the wikibase-* content models is just
...some json...
, right? [18:28:53] yup [18:29:00] yea, we really don't need that [18:29:05] kk cool [18:30:46] mobrovac: we might add mroe entity namespaces in the future. i hope we remember to ping you guys about it... [18:31:02] ok cool [18:31:02] good to know :) [18:31:22] it's not a real issue, but the less events we have to process the better [18:31:31] as that means a slower storage growth [19:03:36] addshore: https://grafana.wikimedia.org/dashboard/db/wikidata-api seems broken :( [19:13:18] DanielK_WMDE: Around? [19:14:23] Amir1: about to leave the office... [19:14:33] what's up? [19:14:51] DanielK_WMDE: Quick question. Should LExeme implement fingerprintholder or not [19:15:10] I did it to make my localhost working but not very sure that we should do it [19:16:43] Amir1: very good question! the concept of "fingerprint" is pretty problematic. [19:17:04] so... Lexeme should be a holder of a saner fingerprint object... [19:17:10] but not the current fingerprint object [19:17:28] so... ok-ish for now, but please file a ticket, so we look into this again [19:17:35] Okay [19:17:36] sure [19:17:39] Thanks [23:31:53] Hi from Germany! [23:31:57] Looking forward to meet some colleagues tomorrow