[10:34:48] Lydia_WMDE: https://phabricator.wikimedia.org/diffusion/EWBA/ [11:33:32] Lydia_WMDE: ! [11:34:00] did any metric gathering stuff get added to article placeholder yet? [11:35:16] https://phabricator.wikimedia.org/T123087 [13:00:22] addshore: nope not yet [13:00:30] addshore: if you could add some that'd be amazing [13:00:47] :P [13:18:43] Lydia_WMDE: is the translate button already implemeted? [13:18:46] I can't find it! [13:18:56] addshore: patch in review [13:19:01] ahh okay [13:22:24] Lydia_WMDE: I made a patch for what is already merged and added comments and links to sample code to https://gerrit.wikimedia.org/r/#/c/280950/ [13:22:36] addshore: \o/ [13:22:38] sweet [13:26:20] addshore: If you need code review for article placeholder, feel free to poke me [13:26:34] We will deploy it to 4 Wikipedias on Wednesday [13:26:52] so we should move fast [13:27:57] oooh [13:28:06] yes then! the 1 liner patch I just made [13:28:18] https://gerrit.wikimedia.org/r/#/c/286839/ [13:29:56] addshore: counter.MediaWiki.wikibase.articleplaceholder hm [13:30:14] we already have MediaWiki.wikibase.repo and MediaWiki.wikibase.client [13:30:58] But AP is not Wikibase, is it? [13:32:01] mhhhm, i guess it could be seen as completely seperate, but without wikibase it wouldnt exist ;) [13:32:03] its wikibasey [13:34:36] hoo: counter.MediaWiki.wikibasey.articleplaceholder ? :D [13:35:52] +3 [13:46:55] * aude waves [13:49:36] hey aude :) [13:53:10] Catchable fatal error: Argument 1 passed to Message::setContext() must implement interface IContextSource, null given in /srv/mediawiki/php-1.27.0-wmf.23/includes/Message.php on line 676 [13:53:27] i see https://phabricator.wikimedia.org/T134351 [15:01:59] jzerebecki: want to fix the broken build? [15:02:21] otherwise i can since i have mediainfo setup [15:09:51] aude: sorry no time [15:15:48] jzerebecki: ok :/ [15:16:03] * aude *sighs* (that the build is broken again) but probably trivial fix [15:46:30] aude: what's wrong ewith the build? [15:47:39] DanielK_WMDE: compatilbity with mediainfo again [15:47:46] super sure it's trivial fix [15:47:56] https://phabricator.wikimedia.org/T134386 [15:48:26] just that right now i want to work ont he search-related tasks, but can look later if no one else does [15:51:57] addshore: RE the track patch... should we bother bikeshedding or whatever? [15:51:58] I don't really care much, but I still find it weird [15:51:59] maybe ask Lucie? [15:52:24] hoo: I also don't really mind :) [15:52:30] she isn't on irc :( [15:53:20] aude: fixing [15:53:47] DanielK_WMDE: aude: jzerebecki: Do you consider the ArticlePlaceholder extension part of Wikibase or not? [15:54:02] hoo: hu? [15:54:12] https://gerrit.wikimedia.org/r/#/c/286839/1 [15:54:34] We wonder about the topic name [15:54:42] I think it shouldn't probably include Wikibase [15:54:54] hoo: in that context, i would say yes [15:54:57] DanielK_WMDE: thanks [15:55:17] hoo: it's an extension of wikibase, like property suggester [15:55:41] not like wikibase is an optional dependency [15:55:58] DanielK_WMDE: I think lego & I would be keen to get your reset thing in again super soon (I thought there was meant to be a branch cut on core yesterday).... [15:56:18] just a couple of tiny things to poke there I think [15:57:59] hoo: when will you arrive? [15:58:32] jzerebecki: That's a good question... we have 30M+ delay by now [15:58:56] addshore: yes, it's next on my list [15:59:01] awesome [15:59:39] Probably shortly before 8pm [15:59:43] k [15:59:51] aude: i can't reproduce the issue on master. the line numbers from the stack trace don't line up either... [15:59:51] Depending on how long the Biergarten thing lasts we might join [16:00:33] mmmmmmmmmmmmmmmmmmm beer [16:01:27] DanielK_WMDE: perhaps it was fixed and we just need to trigger a new build? [16:01:36] i have no idea... [16:03:14] aude: Yes! :) [16:03:30] jzerebecki: Will you be there? [16:03:32] hoo: are you coming to wikicite? [16:04:21] hoo: yes. will give status updates via signal if requested. [16:05:45] jzerebecki: can you backport https://gerrit.wikimedia.org/r/#/c/286409/ ? [16:05:48] that should fix the build [16:05:58] aude: No... but it's interesting for sure [16:05:58] jzerebecki: Great, will let you know whether we're coming [16:06:41] hoo: :/ [17:11:46] wikimedia/mediawiki-extensions-WikibaseQuery#167 (REL1_27 - 61bc833 : Translation updater bot): The build has errored. [17:11:46] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/824a18686655^...61bc833eb0a5 [17:11:46] Build details : https://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/127846243 [19:55:38] Lydia_WMDE: around? [19:56:04] aude: jep [19:56:16] waaaaasup? :) [19:57:30] we deployed and purged parser cache [19:57:46] can you check https://www.wikidata.org/wiki/Q18749268 -- does it have labels etc for you? [19:57:52] looking [19:58:11] clicking random and other items, they do [19:58:52] aude: there is one label in french and one description in dutch which only show up after clicking more languages [19:58:56] should i purge? [19:58:59] edit? [19:59:32] i purged many times [19:59:35] ok [20:00:02] tried editing alredy? [20:00:38] trying [20:00:45] ok [20:01:18] it has a label in english (obviosuly and according to the json) [20:01:26] * Lydia_WMDE looks at a few other items [20:01:57] other items look ok [20:02:54] https://www.wikidata.org/wiki/Q18746571 is empty [20:03:06] strange [20:03:13] the ones i looked at were ok [20:03:16] checking a few more [20:03:26] https://www.wikidata.org/wiki/Q7954831 misses english [20:03:54] most are ok though [20:04:16] yeah it seems so [20:04:17] -.- [20:04:24] wth [20:04:36] purging does nothing :( [20:05:33] https://www.wikidata.org/wiki/Q2009573 also doesn't look good [20:05:50] that one looks ok to me [20:06:04] oh, i am logged out now [20:06:20] it has english but version history indicates it should also have german for example [20:06:50] oh [20:09:28] https://www.wikidata.org/wiki/Q4643818 [20:09:54] am investigating [20:10:20] ok edit and purge doesn't seem to do anything either [20:10:35] oh, i see the issue on my own wiki now :( [20:10:43] narf [20:11:08] don't know how we missed this but shall see if there is an easy fix [20:11:28] ok thank you! [20:11:32] else i guess revert to the old branch we had deployed if can't fix quick [20:11:45] (and not sure who would review at this time, if they are all at the biergarden) [20:12:52] i don't think all are [20:12:54] but yeah [20:13:01] we can go back to old branch if needed [20:13:30] i think we'll revert and then fix [20:13:37] ok [20:13:46] a bit not ok to leave things broken [20:13:55] *nod* [20:14:06] and i can reproduce, so should be fixable [20:14:25] :) [20:32:59] " i can reproduce" <--- 80% of the work done_ [20:33:19] aude: Chad is doing the train tomorrow [20:36:58] ok [20:37:11] we can probably put wikiata back to wmf.23 in the morning [20:37:32] i suspect the issue might even be fixed in master already [20:38:07] in which case, i could backport and fix today (if i am sure) [20:43:43] maybe not fixed in master [21:51:21] i have a fix. now looking the code it's obvious (and that php is sometimes strange :/) [21:51:35] aude: what issue? [21:52:51] https://gerrit.wikimedia.org/r/#/c/287005/ [21:53:05] maybe you can review and we can re-deploy the new code on wikidata [21:54:06] i would leave the bug open until we have proper tests for this, but maybe someone else can help with that [22:01:05] it's ok to wait until the morning, if that's better [22:05:34] DanielK_WMDE: is it too late or you've got a minute to talk about https://phabricator.wikimedia.org/T117493 ? [22:05:38] i'm traveling tomorrow, with my kids. eithe ri do it now, or i won't ;) [22:05:59] Or let the kids do it. Win win! [22:06:11] SMalyshev: yea, past midnight, and i'm supposedly on vacation. sorry, no big new topics today. [22:06:18] SMalyshev: monday :) [22:06:25] guillom: :D [22:06:25] DanielK_WMDE: ok, so monday it is :) [22:08:46] aude: sorry, my bad. i should have caught that during review. it *looks* so right. [22:09:01] aude: we should have a code sniffer rule against using + and += with arrays. [22:09:56] DanielK_WMDE: thanks [22:10:08] i would like the code split with more proper tests [22:10:33] but maybe someone else can help with that tomorrow [22:11:25] * aude eats [22:15:17] * DanielK_WMDE sleeps [23:27:35] PROBLEM - Response time of WDQS on wdqs1001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [300000.0] [23:29:44] RECOVERY - Response time of WDQS on wdqs1001 is OK: OK: Less than 5.00% above the threshold [120000.0]