[10:46:02] folks am i going crazy or is there something fishy going on here: https://www.wikidata.org/w/index.php?title=Special%3AWhatLinksHere&target=Property%3AP675&namespace=0 [10:46:26] i tried a few and they didn't actually have the google books identifier on it anywhere [10:46:31] alaska for example [10:46:41] i finally found one now that has but... [10:47:46] used in references [10:47:55] ahhhhhhhhhhhhhhh [10:48:01] thank you sjoerddebruin :D [10:48:08] it's monday, I forgive you [10:48:10] np [10:48:10] that explains why a search on the page didn't find it... [10:48:14] hehe thank you [10:49:07] weren't references expanded when viewing diffs? [10:49:52] yes [10:50:41] well, that's broken then [10:50:55] meh [10:50:57] ok [10:51:00] probably after the recent modifications [10:51:08] will create task then [10:51:17] thanks [10:51:33] also created https://phabricator.wikimedia.org/T129779 this weekend btw [10:53:03] ah yeah [10:55:06] here you go https://phabricator.wikimedia.org/T129836 [11:00:54] merci! [11:15:17] Lydia_WMDE: jzerebecki: Jonas_WMDE: are we actually planning to fix this in this sprint? https://phabricator.wikimedia.org/T128828 [11:15:30] wasn't this what we've talked about in story time? [11:16:10] This is new to me [11:36:08] Tobi_WMDE_SW: thx for the reminder that there was an unbreak now task [11:38:25] after seeing the test results on the the cherry pick, I remember there were more problems... [15:34:42] We're at 451 external identifiers now [15:35:10] great [15:45:35] hoo: Burn them! [15:46:08] I'm burning strings [15:46:12] :P [15:46:31] hoo: How long are they? [15:49:01] I dun\0 [16:29:03] Jonas_WMDE, hoo, jzerebecki, Thiemo_WMDE: https://imgur.com/yj62gCl [16:48:11] hey @all :) [16:52:41] jzerebecki: yey, we managed to create another component breaking the build \o/ [16:59:26] :) [17:13:20] benestar: hey! what about https://gerrit.wikimedia.org/r/#/c/276219/ ? Do you want us to take that over, or do you prefer to work on it yourself? [17:13:38] Any thoughts on my comments? [17:14:09] just wanted to look into it [17:14:56] I'm about to implement most of your comments [17:17:15] benestar: any [17:17:53] ...any idea when? looks like it's the last bis missing for a first test of MediaInfo [17:20:54] DanielK_WMDE_: can do it right now if that helps [17:21:33] benestar: tomorrow would be soon enough, but next week would suck... [17:22:38] will start working on it in ~10 min [17:23:41] benestar: didn't mean to rush you. but i'll be happe to see this move :) [17:36:58] Hey. I'm new to Wikidata and have some questions [17:37:07] Is there some sort of inheritance for items? [17:37:22] E.g. if an item has "instance of" street, mandatory properties like "country" are suggested? [17:53:10] I've looked at the article about basic membership properties on the wikidata-wiki: https://www.wikidata.org/wiki/Help:Basic_membership_properties [18:01:57] I guess I'm looking for property inference [18:02:22] there's a property suggestor which suggests "likely" properties based on commonly used combinations when editing [18:02:36] (sometimes it works well, sometimes it suggests ridiculous things) [18:03:01] I think there are also properties to use on properties to say which other properties should be used, but I don't think the interface uses those at all [18:04:06] ah, I think I'm thinking of https://www.wikidata.org/wiki/Property:P1963 [18:04:40] orgs: no, there is no inheritance or inference. There cannot be, since the class system is nothing the software knows about. And what something is an instance of may be disputed (is palestine a country?...) [18:05:26] orgs: since wikidata only records what people claim, not what is true, there is no way to diretly apply inference of any kind. You can apply inference when running queries against wikidata though. But you have to define the rules yourself. [18:05:47] The idea is that different rules of inference are "correct" for different purposes. [18:18:46] DanielK_WMDE_: meh, I messed a bit with the repo tests (and some were already messy) [18:19:07] EntityContentFactoryTest uses global state for some stuff but defines local arrays for other things [18:19:41] basically the question is: do we want to test *all* defined entity types in those tests or only the ones defined inside of Wikibase.git [18:32:35] benestar: well, the unit test should test a handful of fakes, and the integration test should test all configured types... [18:33:00] but I don't think we want to be blocked on this right now [18:33:06] yeah :S [18:33:31] benestar: so just do whatever best fits with the code we already have there, to keep the patch small. maybe add a TODO or five. [18:57:30] DanielK_WMDE_: won't work :S [19:07:30] DanielK_WMDE_: I created https://gerrit.wikimedia.org/r/#/c/277319/1 which should fix our issues [19:07:48] not sure if it would be better to make the tests integration tests.. [19:08:28] we definitely should have separate folders for unit and integration tests in our code base [19:31:47] DanielK_WMDE_: I'm getting a bit confused with all my patches :P [19:32:31] benestar: these tests already are integration tests... [19:33:41] DanielK_WMDE_: so just call WikibaseRepo::getDefaultInstance()->getEntityFactory() ? [19:33:57] *Content [19:42:02] and now jenkins seems to be broken as well :#( [19:46:44] nikki, DanielK_WMDE_: Thanks for the answer! :) [19:56:54] DanielK_WMDE_: still around? [19:59:36] benestar: was in a meeting, available now. But will leave the office soon. [19:59:47] jzerebecki: jenkins is broken :S [20:00:09] DanielK_WMDE_: I uploaded a lot of patches which should move us forward with commons but jenkins is broken and doesn't approve [20:00:13] benestar: jzerebecki has left a while ago [20:00:30] hmm, what about aude? [20:00:35] in the US [20:00:48] what's up with jenkins? Broken on master? [20:01:34] benestar: ^ [20:02:10] hoo: yes, jobs are failing [20:02:17] unrecognized option --with-phpunitdir [20:02:22] ah [20:02:27] let me have a look [20:02:31] thx [20:02:57] Who would have thought that would get merged [20:13:17] So billing address=used by the credit card, shipping address what goes on the box. So no separate billing address for bitcoin? [20:14:40] hoo: ugh, that option should have stayed as a no-op. [20:15:59] DanielK_WMDE_: got time for discussing about EntityFactory? [20:16:45] Should be fine again, but not sure [20:18:11] yes, seems to work [20:18:12] thanks hoo :) [20:44:46] hoo: would you mind merging https://gerrit.wikimedia.org/r/#/c/276249/5 ? [20:46:22] looking [20:49:32] That's one high impact change :S [21:55:41] hi [21:55:58] https://www.wikidata.org/wiki/Q23050168 autority control?