[02:56:30] is someone here? [02:56:55] I am, but am busy [02:57:32] https://www.wikidata.org/wiki/Q1506288 i can't delete en english interwiki (it's a false merge) the link stay gray [02:58:39] weird [02:58:43] yes [02:58:54] I can reproduce it [02:59:19] rah, I hoped it was me and that I could repair the false merge [02:59:37] You can [02:59:54] just enter a new sitelink that can't be saved (like Berlin on the Spanish Wikipedia or something) [02:59:56] and then hit save [03:00:04] it should remove the one link, but it wont save the new one [03:00:12] best workaround I can come up iwht [03:00:29] hoo|busy: doesn't work [03:00:41] it become orange saying it's impossible to save [03:01:05] and if i delete the new false link then i can't save, it's grey [03:01:09] You did it: https://www.wikidata.org/w/index.php?title=Q1506288&action=history [03:01:22] wow [03:01:28] stranger and stranger [03:01:35] Well, not really [03:01:50] yes, if I charge again the page, now I see it [03:01:50] the error you see is because it couldn't save the garbage link, I guess [03:02:01] but I still saw the old link [03:02:03] but you should still file a bug [03:02:10] yeah, it's weird [03:02:10] :s [03:02:33] I dn't know how to file bugs :s [03:08:08] :O [03:08:37] it's fairly easy, if you got a phabricator account: https://phabricator.wikimedia.org/maniphest/task/edit/form/1/ [03:11:25] i think I have one [03:12:08] https://phabricator.wikimedia.org/p/Harmonia_Amanda/ [03:13:19] but seems like my password is wrong [03:13:22] yay [03:17:58] well, seems like i don't remember my password and I don't understand how to change it [03:18:06] so, no, sorry, no bug filing [09:43:41] Adrian_WMDE: https://integration.wikimedia.org/ci/job/composer-php55/4573/console [09:44:07] the bug with deleting interwiki links is still here [09:47:12] this bug is frustrating :s [09:56:55] Harmonia_Amanda: is it the same problem people are mentioning on https://www.wikidata.org/wiki/Wikidata:Project_chat#Cannot_remove_an_entry? [09:57:05] nikki: yes [10:01:02] * nikki created https://phabricator.wikimedia.org/T129450 [10:01:24] nikki: thank you [10:01:38] no problem :) [10:19:41] Thiemo_WMDE: https://github.com/wmde/WikibaseDataModel/pull/632 [10:28:43] Thiemo_WMDE: what does this have to do with your patch & diff refactoring? https://phabricator.wikimedia.org/T126231 [11:41:22] hello [11:41:54] what's the best way to search only location entities? [12:01:34] Adrian_WMDE: Lydia_WMDE Thiemo_WMDE can someone please look at https://phabricator.wikimedia.org/T129450 [12:01:45] it's probably a one line fix [12:02:14] just not entirely obvious to me where that line is [12:10:29] think i'm getting close though [12:15:38] aude: ok :) [12:56:13] think i might have a fix [12:56:50] hi [12:56:53] hi [13:00:06] Lydia_WMDE: submitted patch [13:00:16] adding tests for this would be nice (and could do later) [13:00:30] but i'm running out of battery + would like to eat breakfast :) [13:00:37] could someone here do a merge for me? [13:02:29] it's [13:02:29] https://de.wikipedia.org/wiki/Garam_Masala_(Begriffsklärung) [13:02:29] https://en.wikipedia.org/wiki/Garam_Masala_(disambiguation) [13:05:25] ttip: done [13:06:58] thx [13:11:04] * aude adding test [13:52:14] aude: do you know why the test fails? [13:52:30] 13:03:39 Verified isInitialValue() still returning false after adding another unchanged value [13:52:30] 13:03:39 Expected: true [13:52:30] 13:03:39 Actual: false [13:52:30] 1 [13:53:32] it still fails? [13:54:06] benestar: i think the expected is wrong [13:54:45] maybe the description of the test case is not good [13:55:00] oh, you changed the assertion now? [13:55:24] how could it pass before?? [13:55:45] because o fthe bug [13:56:13] if the number of site links changed, we didn't check that for isInitialValue but used to check that [13:56:35] maybe thiemo knows why it was done like that and there is a reason? [13:57:14] see https://gerrit.wikimedia.org/r/#/c/266727/6/view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js [13:59:52] benestar: anyway, i'm heading out for breakfast now :) [14:01:46] aude: ok, if the tests succeed are you going to backport the change? [14:02:16] someone needs to review the patch and merge it [14:02:50] preferably thiemo looks at it, since he touched the code last [14:05:59] Adrian_WMDE: so it should be $nonEmptyItems ? [14:07:04] * aude really is off for food now :) [14:07:18] Yes [14:07:27] Adrian_WMDE: ok, changed it back [14:09:16] aude Adrian_WMDE: sorry for confusion :S [14:10:03] Adrian_WMDE: btw is the other sitelink regression already fixed? [14:10:24] Which one? [14:13:08] aude: \o/ [14:16:08] jzerebecki: https://gerrit.wikimedia.org/r/#/c/276425/ [15:44:20] benestar: what is the other regression? [15:55:11] aude: long sitelinks don't break in some langauges [15:57:35] oh [16:29:52] If it hasn't been noticed already: Wikidata crossed the milestone of 1.000.000.000 Triples yesterday evening :) [16:31:48] \o/ [16:42:01] Isn't there something wrong when you begin your mails with "Apologies for cross-posting"? [17:45:25] Nudin: yay! [21:44:11] Adrian_WMDE: the sitelinks patches are deployed now [21:44:43] Nice [21:44:50] word breaking works [21:48:40] :) [21:49:01] * aude off to a meetup :)