[00:02:50] Passes on PHPUnit 3.7 but fails on 4.x [00:02:52] Ah, found it [00:03:02] the assertEquals() method had a minor change [00:03:20] previously it tolerated applying deltas to number-ish strings [00:03:27] now it only applies it to proper numbers [00:04:26] Probably quite a few things that need cleaning up as a result of upgrading phpunit [00:05:20] I looked through all the change logs [00:05:25] nothing I found that should affect us [00:05:28] https://gerrit.wikimedia.org/r/#/c/270485/ [00:09:23] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/270877/ [00:10:07] or Reedy ^ :) [00:28:00] Krinkle: +2 [00:28:12] thx [00:56:56] DanielK_WMDE: When will it be in the Wikidata repo? (Which is what Jenkins' extension-group test job uses) [00:58:15] Krinkle: uh... usually we only do a build every two weeks, for deployment. I'm off work this week... [00:58:24] ping aude or jzerebecki about that [00:58:26] the repo shows almost daily builds [00:58:27] OK [00:58:46] oh right, for beta, i guess [00:59:00] i'm a bit blurry on the build/deploy process [09:31:52] Lydia_WMDE: https://phabricator.wikimedia.org/T126349 [09:41:28] https://phabricator.wikimedia.org/T126349 [09:41:51] https://gerrit.wikimedia.org/r/269386 [09:52:24] Gutten Tag. I will cut the wmf branches this afternoon starting around 14:00 cet (poke aude) [09:54:25] hashar: Thanks for the notice, not sure we will be ready with Wikibase in time [09:54:42] But we can amend later on, if needed (before the deploy) [09:55:31] hoo: guess I will cut wmf.14 including wikidata wmf.13 :D [09:55:57] and we can always push the new Wikidata code later in the evening. I am not too worried [09:58:49] Lydia_WMDE: :O https://nl.wikipedia.org/w/index.php?title=Overleg_gebruiker:Sjoerddebruin&action=history [10:00:44] sjoerddebruin: yeah -.- [10:00:49] stupid internet connection [10:01:54] Are you at the office? Still no improvements? [10:05:16] yeah :( [10:20:20] hashar: I'd greatly appreciate if you could look at my gerrit changes for deploying Capiunto [10:20:49] I'll start the deploy at around 12 CET [10:35:19] !merge 270580 [10:35:19] merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/270580/ [10:35:26] (We want that in the branch) [11:07:14] hoo: don't forget to add Capiunto to https://git.wikimedia.org/summary/?r=mediawiki/tools/release.git [11:07:25] oh, i see it there [11:07:27] aude: Already done :) [11:07:34] :) [11:09:53] per https://www.mediawiki.org/wiki/User:Aude/Git#Deployment_stuff and https://wikitech.wikimedia.org/wiki/How_to_deploy_code, think all the steps are covered [11:09:56] for a new extension [11:10:11] https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Add_new_extension_to_extension-list_and_default.conf [11:14:43] \o/ [11:17:31] aude: https://wikitech.wikimedia.org/wiki/Deployments#Week_of_February_15th [11:17:39] Scheduled us, but not yet complete [11:18:00] we'll just need to be ready before our meeting [11:18:06] and end the meeting on time(ish) [11:18:11] True [11:18:11] but ok [11:18:25] I have a meeting at 5 as well, so can't move it back :S [11:18:31] and be done before swat [11:21:38] aude: hoo: can't look at Capiunto stuff [11:21:58] aude: hoo: but please go ahead and deploy it as needed :-} [11:21:58] hashar: Aude did, so it should be fine [11:22:24] you are more used to deployment than me anyway [11:22:44] gotta rush for lunch sorry [11:24:25] jzerebecki: https://gerrit.wikimedia.org/r/#/c/266730/ [11:27:22] jzerebecki: https://gerrit.wikimedia.org/r/270580 [12:08:44] WOOOHOOO: https://test.wikipedia.org/wiki/Page244 :D [13:45:54] Why can't I add P2534 to Q51501? It says it's deleted, but I don't find any clues about it beeing deleted� [13:49:01] also editing existing formulars doesn't work� [13:54:33] hmm, works when logged out [14:33:22] aude: When is the next Wikidata ext build? [14:35:51] Krinkle: for beta? [14:35:55] why? [14:35:58] master branch [14:36:11] https://gerrit.wikimedia.org/r/#/c/270907/ is stuck in gerrit [14:36:12] aude: because mediawiki-extension jobs include Wikidata [14:36:18] soon as we fix that [14:36:19] and I fixed something in Wikibase [14:36:23] ok [14:36:28] and I can't do anything until that is pulled through to Wikidata extension [14:36:31] ok :/ [14:36:38] ah there is a build [14:36:39] but not passing [14:36:51] let me take a look at why jenkinds doesn't approve [14:37:03] (it's external quality thing, afaik) [14:37:42] > Failed asserting that exception message 'A parameter that is required was missing. (Either provide the ids of entities or ids of claims, that should be cross-checked.)' contains 'A parameter that is required was missing (Either provide the ids of entities or ids of claims, that should be cross-checked.)' [14:38:02] Probably the message was changed and someone hardcoded the whole thing in the test [14:38:35] A dot was added after "missing" [14:38:36] :) [14:39:01] hmm ok [14:59:01] Krinkle: https://gerrit.wikimedia.org/r/#/c/270964/ [14:59:38] thanks [14:59:45] i'll make a new build [15:04:38] hoo: jzerebecki https://gerrit.wikimedia.org/r/#/c/270965/ [15:04:51] and https://gerrit.wikimedia.org/r/#/c/270939/ [15:04:58] would prefer someone review these [15:14:37] jzerebecki: can you make a new wikidata build for beta? [15:14:45] it should pass jenkins now [15:35:45] can someone help take a look at https://phabricator.wikimedia.org/T127077 [15:35:58] (fatal error on wikidata or somewhere due our code) [15:38:53] Lydia_WMDE: did you do something about the showcases items? (sorry I'm not very active right now, but it's complicated for me right now) [15:47:38] hoo: aude: I am cutting the wmf.14 branch [15:48:00] hoo: aude: not we might delay the deployment train this week due to some unidentified error we found with .13 [15:48:06] s/not/note/ [15:48:20] havent took any decision yet. Pending coffee/commute time on SF side [15:48:28] hashar: i finished preparing wikidata .14 branch a while ago [15:48:36] oh [15:48:51] thx for checking in [15:49:16] hoo: hmmm [15:49:19] hopefully I got the patch "Wikidata wmf branch to wmf/1.27.0-wmf.14 " :-} [15:49:52] suppose there is nothing super urgent in our new branch, except one patch that would be nice (and can be backported) [15:50:08] also performance improvements that would be nice [15:50:09] hashar: the tool checks gerrit if it is up to date (if nobody broke that ;) ) [15:50:26] hashar: is there a phabricator ticket for the issue? [15:50:53] jzerebecki: there are two trustiness issues in your last sentence: "tools" and "if nobody broke that" <-- too many assumption ! [15:51:00] aude: not that I know of [15:51:04] aude: err there is [15:51:06] hashar: ok [15:51:13] hashar: this one?: https://phabricator.wikimedia.org/T126700 [15:51:21] yeah [15:51:49] something magically appeared around midnight of Feb 10th-Feb 11th [15:51:55] aude: it seems there is a deployment blockers taks for each train now [15:52:01] jzerebecki: ok [15:52:10] that bump the saving latency 75 percentile from 450ms to 900ms ... [15:52:21] :( [15:52:35] and it went down a bit. The lame 7 days board is https://grafana.wikimedia.org/dashboard/db/t126700 [15:54:19] 'git' 'submodule' 'add' '-b' 'wmf/1.27.0-wmf.14' '-q' 'https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Wikidata.git' 'extensions/Wikidata' [15:54:42] hashar: i was specifically talking about mediawiki/tools/release.git make-wmf-branch ; the code to check if the checkout is in sync with the remote looks like it will still work [16:13:17] hashar: the branch is cut now? [16:13:32] * aude sees it [16:17:18] hoo|away can you have a look at https://gerrit.wikimedia.org/r/#/c/270976/ [16:17:41] or maybe aude [16:20:04] physikerwelt: replied [16:21:48] and yay, we have math properties now :) [16:26:28] Hi everyone! I'm supporting a gender thematized Wikidata editathon and the girls from the organizing committee are asking me about labels, titles and descriptions missing but just only women [16:27:01] I found this link: https://tools.wmflabs.org/wikidata-terminator/?list&lang=en [16:27:37] But I don't know if there is any other resource to find these same elements without descriptions but only for women [16:28:01] ProtoplasmaKid: probably with the query service [16:28:02] * aude looks [16:29:07] aude: https://query.wikidata.org/ ? [16:29:12] yeah [16:29:23] Oh great I will try it. Thanks! [16:29:24] let's see if i can make an example [16:29:33] it's not that easy except using the examples to start [16:29:51] maybe magnus' query (autolist) could do this also [16:36:19] I'm trying to use the examples, changing parameters, but I don't know how to add the missing label or description variable. [16:37:41] https://phabricator.wikimedia.org/P2622 are items without spanish labels [16:37:52] now i need to adjust for descriptions [16:40:15] still looking [16:42:07] Thank you :) [16:44:26] ProtoplasmaKid: https://phabricator.wikimedia.org/P2624 [16:44:29] i think that works [16:45:21] yes! It works. [16:45:24] Thanks a lot [16:46:14] sure [16:46:27] (helpful for me to also figure these out, and can add it to the examples) [16:53:04] ProtoplasmaKid: added an example (made it slightly complex... filter for occupation = actor also) [16:55:40] aude: hoo so wmf branch is not deployed to day due to perf issue [16:55:55] Ah, ok [16:56:10] I got so many over things right now that I don't even know what the state is [16:56:14] * ther [16:56:17] * other [16:56:21] (on our side) [17:01:53] hoo: I finished our side before 1300 UTC [17:02:08] ah, ok [17:03:40] Jonas_WMDE: https://phabricator.wikimedia.org/P2625 [17:03:44] hashar: ok [17:04:08] * aude thinks we deployed enough things (new data type, other projects sidebar out of beta...) [17:04:12] today* [17:04:24] soo looks like the delay is a good thing for you as well ;) [17:04:41] * aude doesn't mind [17:07:56] Jonas_WMDE: is the query gui code in a separate git repo now? [17:08:21] yes got my own repo ^^ ;) [17:08:27] \o/ [17:08:57] found it [17:09:50] aude, the last example are not functioning :P [17:09:55] ah [17:10:11] it's missing the prefix [17:11:59] ProtoplasmaKid: try again :) [17:12:25] https://shop.confoo.ca/white-elephpant [17:12:30] I try to add "defining formula" to an item and get this: It is not possible to define a new value for a deleted property. [17:12:37] on wikidata.org [17:12:38] SMalyshev: still? [17:12:43] aude: yes, right now [17:14:54] e.g. on https://www.wikidata.org/wiki/Q133871 [17:14:57] nice! [17:24:10] jzerebecki: hey, do you know why WikibaseJavaScriptApi tests are broken? [17:24:16] https://gerrit.wikimedia.org/r/#/c/266730/6 [17:24:56] SMalyshev: i have no idea but was able to add defining formula on the item [17:25:05] i'm sure it's a real issue though [17:25:20] benestar: my fault, didn't finish the patch that makes the new CI jobs work, I'm on it [17:25:35] ok, thanks! [17:26:16] aude: hmm.... maybe some caching? weird [17:26:22] I still can't add it [17:26:42] tried from 2 browsers logged in and logged out [17:27:54] i don't see anything in the server logs [17:28:23] are you using russian or something? [17:28:33] aude: nope, english UI [17:28:39] hmmm [17:29:11] * benestar also gets that error message @aude [17:29:27] ok, so I'm not crazy yet :) [17:29:30] benestar: o_) [17:29:35] O [17:29:58] logged in? [17:30:27] oh logged out, i see [17:31:04] in firefox which i don't normally use [17:35:10] ok with debug=true [17:37:31] aude: I see it in Chrome and Safari [17:51:06] SMalyshev: do we have a phabricator ticket for this? [17:51:09] do you know? [17:51:50] aude: not as far as I know [17:51:52] I can make one [17:52:03] i am creatign one [17:52:08] ok :) [17:53:12] https://phabricator.wikimedia.org/T127095 [17:53:28] i only get this in non-debug mode so it's not as easy for me to debug [17:56:10] if I can help with anything please tell me [17:56:27] do you get the error with debug=true? [17:57:29] i would try adding breakpoint(s) in https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/view/resources/jquery/wikibase/snakview/snakview.variations.Value.js#L338-L371 [17:57:30] benestar: https://gerrit.wikimedia.org/r/#/c/270761/ [17:58:01] i assume !dataType [17:59:43] there is a dataTypeStore [18:00:12] it has no math (duh) [18:00:40] (we coudl try touching + sync the file) [18:00:49] aude: works with debug [18:01:14] pretty obvious this is the problem [18:01:41] we should make this module invalidate when a new property is added [18:01:44] err data type [18:01:59] (it has no external-id, as well) [20:28:33] jzerebecki: what is the command to run the qunit tests in WikibaseDataModelJavascript? [20:31:19] benestar: probably, have it installed and active in a mediawiki install, then exectue the mediawiki qunit tests normally (possibly filter for only those if you don't want run the rest) [20:31:48] jzerebecki: but how do we run them in ci? [20:32:32] benestar: probably not in travis. if it where in WMCI, with karma [20:33:19] so we don't actually run tests at all? =o [20:33:22] benestar: see https://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing#From_the_command_line [20:35:28] benestar: just verified, yes for that repository no qunit tests are executed by travis [20:36:01] it would be nice if we had a test runner that doesn't depend on mediawiki setup :S [20:38:57] benestar: the testrunner doesn't. we depend on ResourceLoader in that component. [20:39:26] can resource loader be used independently from mediawiki? [20:45:26] benestar: I don't think so, though it probably could be made to. but instead one should evaluate integrateable projects that do similar things, then replace ResourceLoader with one. [20:59:32] jzerebecki: are there some concrete plans to either do so or run the tests within mediawiki? [21:01:02] benestar: think you also should poke Adrian about that [21:01:50] benestar: I know of no one who is planning to do that with travis. if we move the repo to gerrit it is easy to enable the existing qunit jobs on them. not sure if that is ticket to do that to that repo... [21:02:52] what is the state of moving the whole thing to gerrit? [21:06:07] benestar: what do you mean with "the whole thing"? [21:06:21] for now the javascript data model [21:09:39] benestar: don't know from my head. maybe there is a ticket, maybe there is a gerrit repo created. maybe not. start with the ticket please. [21:13:52] k :) and thanks [21:44:35] How did the deployment go? :) [21:45:06] Oh, are we hit be wmf.14 being on hold? [21:45:41] Adrian_WMDE: yeah :/ [21:46:00] seems there was a performance regression with page save timings [21:46:20] but external identifiers and the other project sidebar are enabled :) [21:53:00] Because that was only config, not code? [21:54:10] Adrian_WMDE: yeah [22:03:55] Adrian_WMDE: fixed the whitespace :) [22:04:25] Great [22:04:33] Ah, another thing: you have to bump jsapi dependency [22:05:49] ah, true [22:06:06] needs to be released first though [22:06:13] Nah, first dependency bump [22:06:22] Otherwise someone might merge it accidentally [22:07:46] will be 1.1, right? [22:11:22] if someone wants to review my pull requests https://github.com/wmde/DataTypes/pulls (would be appreciated) [22:11:37] you need to run tests manually though (through mediawiki) [22:12:11] i am trying to fix https://phabricator.wikimedia.org/T127095 and then found other issues [22:21:19] benestar: rebase needed :/ [22:28:44] aude: Thanks for looking into the math stuff [22:28:48] ok [22:29:04] it was obvious once i could reproduce and understand the problem [22:29:09] somewhat obvious* [22:30:03] the patches work best when cherry picked against 0.5.1 (since i think https://github.com/wmde/DataTypes/commit/dba99b8e52285206a590973ef6c4141c1b483cac is a breaking change) [22:31:20] The patch is marked as WIP [22:31:30] still? [22:32:11] oh, now it isn't [22:32:16] fixed it :) [22:32:16] but it was like two minutes ago [22:32:23] ah :) [22:32:23] yeah [22:34:50] are the keys (data type ids enough)? [22:35:51] i think so, though suppose the values can change [22:35:54] value types [22:36:26] yeah, that's why I wonder [22:36:54] but probably good enough for now [22:37:44] yeah [22:38:06] tested it manually and it works fine [22:38:17] when i disable or reenable types [22:42:20] travis... y u so slow -.- [22:42:41] travis doesn't test these things [22:42:50] not the module [22:43:07] but still polite to wait for travis :) [22:44:04] huh… why? [22:44:12] And how even... travis runs phpunit [22:44:45] it runs some of the tests but not DataTypesModuleTest [22:44:49] since it depends on mediawiki [22:45:11] hence why i'm having them at least registered with mediawiki so they are run with the build [22:55:19] ugh, that's ugly... could have rather easily test doubled the three classes from core it uses [22:55:45] not sure that's better, though [22:57:26] i don't think that's nice [22:57:54] DataTypesModule extends ResourceLoaderModule [22:58:03] how do you test double that? [23:00:29] aude: Create that class, only define getDefinitionSummary in it [23:00:39] that's the only function we use from thhe parent AFAICT [23:01:51] :/ [23:01:54] not sure that's very nice [23:03:50] hey aude and hoo :) [23:04:00] hi benestar ! [23:04:05] it would be very nice have less dependencies on ResourceLoader imo [23:04:09] *to [23:05:43] sure, but not really feasible easily, I guess [23:08:01] this thing could be moved to wikibase [23:08:35] the module is only (afaik) registered in wikibase repo [23:09:55] or maybe it's used alsoin the client [23:13:53] aude: https://github.com/wmde/DataTypes/pull/44/files [23:13:59] that breaks master for me [23:14:01] does it also for you? [23:14:13] (it should because of how RL work) [23:16:10] hmm [23:16:28] yeah it is a breaking change and not sure we ened to change wikibase [23:16:56] for my bug fixes, i would make a rel-0.5.2 branch, cherry pick my things and make a tag from it [23:17:34] sounds good [23:17:47] other changes might be breaking changes [23:22:02] aude: Shouldn't (looked through all of them), but I still think we should play it safe [23:22:11] especially if you target tonights SWAT [23:22:46] i'll probably wait until tomorrow [23:22:56] maybe can see about a deploy slot earlier than swat [23:23:16] (just needs to be before we convert any properties to new data type) [23:23:31] and might stay up for the math backports [23:23:49] I'm half asleep already [23:24:04] will merge the last patch in data types, then go to sleep [23:24:10] ok [23:24:27] the math patches are ready for swat [23:24:46] ah, nice :) [23:25:02] you still at the office? [23:25:14] No, we went for food and then I went "home" [23:25:20] ah, good [23:25:37] I'm tethering right now... works surprisingly well [23:25:49] but I'm burning through my 1gb/ month [23:26:00] :/ [23:37:46] good night [23:54:56] successfully created my own entity type in Wikibase :D