[08:32:15] hi, is it normal that it is not possible to edit wikidata with the mobile site anymore? [08:34:13] ash_kiwiirc: what are you trying to do? [08:38:07] edit any item with a smartphone... [08:38:38] there is only one edit link on the page, for the label/decription/alias [08:38:42] Yep, but what? Label, description and aliasses, sitelinks or statements. The last thing is not possible yet AFAIK [08:38:51] but none for the statements [08:38:57] hashar: awake? :P [08:39:22] why is there no link for the statements ? [08:39:33] Because they can't be edited yet. [08:39:42] ... [08:39:45] why ? [08:39:56] Because it's not added yet. [08:40:04] addshore: yeah [08:40:19] I have a patch with an issue :P [08:40:28] cumbersome [08:40:36] https://gerrit.wikimedia.org/r/#/c/267259/ which needs 3 patches in extensions to make the tests pass [08:40:48] but those patches also need the patch in core to make their tests pass :P [08:41:06] so of course, I put depends-on everywhere, but apparently zuul doesnt like that? :D [08:41:11] whats the best course of action? ;) [08:43:36] ash_kiwiirc: https://phabricator.wikimedia.org/T95878#1989124 [08:44:36] addshore: do you have a cycle ? [08:44:48] a cycle? :P as in time? :P [08:44:57] addshore: if you have changes A -> B -> C -> D -> A ... that is a cycle and Zuul entirely ignores everything [08:45:11] hmmm, no there should be no cycle [08:45:28] just A -> BCD and B -> A and C -> A and D -> A [08:45:43] yeah [08:45:46] that is not going to work [08:45:51] :D [08:46:01] sjoerddebruin: thanks :) [08:46:10] surly it should resolve a simple loop like that though :/ [08:46:19] addshore: in this case Zuul protect itself from infinite loop or something. It should ignore them all [08:46:19] silly zuul! :D [08:46:37] okay, so the solution would be to remove the depends-on from the extensions? [08:46:44] but then those tests will fail :/ [08:46:54] or they probably will :P [08:47:21] and as the extension would never be tested with the correct version of core I would thus never be able to merge anything eithout something failing :P [08:47:38] as the core thing wouldnt get merged until the extension thing had +2 as it depended on it :P [08:48:41] addshore: what are the changes? [08:48:57] https://gerrit.wikimedia.org/r/#/c/267259/ and the 3 things linked in the commit message [08:49:53] we had an example recently when the ApiDocumentationTest has been introduced to core. [08:50:27] but I guess in that case you could go and fix the extensions and merge that without the patch in core [08:50:47] yup [08:51:04] :/ mhhhm [08:51:06] where as in the case of "Move WatchedItem logic to WatchedItemStore" it is not back compatible [08:51:12] nope [08:51:35] though apparently Zuul process the changes hey! [08:51:53] ?? :p [08:52:05] oh, in the other case? not mine? :p [08:52:32] * hashar digs in logs [08:52:47] how hard would it be to implement 1 check and if the changeId matches the changeId of the thing bring tested dont die due to being scared of looping? :P [08:52:59] but just dont load depends-on from that change ;) [08:54:10] addshore: the rational is at the bottom of http://docs.openstack.org/infra/zuul/gating.html#cycles [08:54:23] (where CRD stands for "Cross repositories dependencies" [08:54:49] and Zuul bails out with: zuul.log:Exception: Dependency cycle detected: 267259 in [u'267259', u'267682'] [08:54:59] so fi I only did A -> BCD when B was tested would it pull in A? [08:56:00] maybe ???? [08:56:04] I have no idea to be honest [08:56:08] *goes to try :D [08:56:38] maybe when Zuul triggers B (which has no depends-on: header) it actually query Gerrit to check whether another change might depends on B [08:56:46] and might magically pick A [08:56:50] yeah gotta try [08:57:06] right, think I just triggered it all [08:59:38] doesn't look like my recheck on the core patch worked [09:00:51] *facepalms* [09:01:04] hashar: apparnelty I copied the wrong changeId into the core commit message twice... [09:01:10] so it literally depends on itself... [09:01:21] oh [09:01:55] hashar: https://gerrit.wikimedia.org/r/#/c/267259/8..9//COMMIT_MSG [09:02:29] I wonder now if the depends-on things would work in both directions xD [09:07:35] harej: they will move into their own section [09:07:40] below statements [09:07:56] The statement section would be so much better <3 [09:08:04] addshore: no clue :D [09:08:14] sjoerddebruin: yes! :D [09:08:29] addshore: or more seriously: doing something else and I am lacking the envy to context switch into how Zuul actually deals with dependencies :D [09:09:51] addshore: in the jobs using zuul-cloner (such as mediawiki-extensions-hhvm ) , the zuul-cloner has some logs that mention when it managed to fetch a reference crafted by Zuul. extensions/Flow should have one [09:10:03] addshore: and you can look at https://integration.wikimedia.org/zuul/ [09:11:30] addshore: looks like https://phabricator.wikimedia.org/F3302123 [09:11:47] so your mediawiki/core change depends on the other extensions changes [09:12:10] well, it only does because otherwise the extensions tests we do on core will break [09:12:28] so depends on for the purpose of testing [09:12:31] and on the zuul-cloner logs at https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/48466/consoleFull you get to see stuff like: [09:12:37] DEBUG:zuul.Cloner:Fetched ref refs/zuul/master/Zebb26ca045ee42bd90302e38c27e5f1c from mediawiki/extensions/Flow [09:13:06] so even if the change got triggered on mediawiki/core , a ref has been created for Flow with the same UID and Zuul-cloner manage to find it and check it out [09:17:05] ahh balls [09:17:10] hashar: this gets even messier... [09:17:40] the core extension tests of course use the Wikidata build not the Wikibase extension, thus depending-on my change to Wikibase makes no difference and the tests still fail [09:18:00] So I'll have to create a patch on Wikidata for it to depend on xD [09:18:20] oh my god [09:18:23] :D [09:33:11] hashar: such fun [09:34:29] Jenkins is restarting [09:34:38] and gerrit has died [09:34:41] bwahaaaa [09:35:39] addshore: would it be possible to add a list of string properties which currently aren't going to become identifiers, to make it easier to see if there are any missing? [09:35:57] (asking you 'cause they're under your user page :P) [09:36:25] nikki: yup! I got pinged about that last night too! [09:36:28] I'll try and do it today! [09:36:55] cool [09:57:00] nikki: https://www.wikidata.org/wiki/User:Addshore/Strings [09:57:09] aude: will you take care that branching happens? [09:57:38] i'll be at the airport during the train [09:58:06] addshore: that seems to include dates and items and stuff too [09:58:17] nikki: oh yeh... HAH [09:58:22] :) [10:39:53] Lydia_WMDE: where did you start the discussion for ordering statements? [10:40:21] benestar: project chat - already archived [10:40:27] oh... [10:40:32] so it's already some time ago? [10:40:41] 2 or 3 weeks [10:40:52] where's the lydia hiding? :) [10:41:00] aude: at home :( got the sniffles [10:41:05] oh noes :( [10:41:10] yeah [10:41:28] hey aude :) [10:45:10] not much reactions if I can remember. [10:45:45] Some pointed to a script that sorts them, but that list is arbitrary AFAIK. [10:46:29] Think you should come with some options and have a community vote. Not sure if we can serve different options via a user preference. [10:47:17] "alphabet", "property ID", etc. [11:01:00] nikki: I updated the page [11:01:23] its a rather small list [11:04:30] jzerebecki: i can take care of branching and be around this evening [11:24:31] addshore: interestingly, it looks like your changes caused Zuul to enter a death loop :-} [11:24:41] xD [11:25:27] I gues that was when I added https://gerrit.wikimedia.org/r/#/c/267683/3//COMMIT_MSG [12:01:30] DanielK_WMDE: 404 Logged in item views out of 5514 total (629 hits, 142 passes, 4743 misses) for 2016-02-02 02:00 to 03:00 [12:04:22] think I have to refine that slightyly more [12:34:15] DanielK_WMDE: https://docs.google.com/spreadsheets/d/1hXwFiNFhaMqIF4p3myiVlsQpbiyDvyX_GGHLgPc_I9o/edit?usp=sharing [12:36:08] Jonas_WMDE: Adrian_WMDE: shouldn't https://phabricator.wikimedia.org/T124783 be blocked on https://phabricator.wikimedia.org/T125502? [12:50:04] DanielK_WMDE: someone asked if we can worst case convert a property back from identifier to string [12:50:10] Lydia_WMDE: hangout is ready [12:50:20] Tobi_WMDE_SW: thx will join in a sec [12:50:35] Lydia_WMDE: you still have some minutes [12:50:52] k ;-) [12:51:05] Tobi_WMDE_SW: I don't think so, they are really about different things [12:53:57] Lydia_WMDE: i think the script can do that [12:54:26] aude: so things should not blow up if we really have to do it? [12:54:27] but not update all usages [12:54:35] ok [12:56:42] but property info lookup would then say it's a string and i think would be handled as a string [12:56:48] we can probably test this [12:57:09] *nod* [14:56:41] Amir1: are you there? [15:22:26] Lydia_WMDE: is it ok for you if I add the more langauge ordering stuff to the sprint and work on that? [15:22:38] benestar: yeah [15:23:02] Jonas_WMDE: https://netzpolitik.org/2016/45-netzpolitischer-abend-am-2-februar-in-berlin/ [15:23:21] hey DanielK_WMDE, sorry for the confusion [15:23:38] i hope with the additional ticket it becomes clear who is working on what [15:45:41] https://www.mediawiki.org/wiki/Wikidata_deployment#1.27.0-wmf.12 :) [15:46:08] Lydia_WMDE: is anything important not mentioned there? [15:48:50] Lydia_WMDE: and there's a chance that we aren't deploying at all today, also [15:53:02] aude: in call atm - will check in a bit [16:01:42] aude: looks good [16:08:56] <3 [17:04:35] Lydia_WMDE: no deploys today :( [17:05:22] aude: :( ok [17:05:56] i made the branch, but we'll have to wait and see if we can actually deploy it this week [17:07:14] ok [17:07:19] no huge issue if not [17:07:25] as long as we can next week [17:07:26] (includes no formula data type on test) [17:07:36] maybe we can do that tomorrow, hopefully [17:08:17] deployment servers are in a state where bad things would happen if anyone tried to deploy something :( [17:12:10] outsch [17:12:11] ok [18:46:25] * aude needs more properties in order to add https://en.wikipedia.org/wiki/Groundhog_Day#Predictions_of_various_groundhogs_since_2008 to wikidata :P [18:48:54] Can't you just use https://www.wikidata.org/wiki/Property:P793 for that? [18:49:04] maybe [18:49:41] "prediction of early spring" on the item of the groundhog [18:50:08] * aude tries :) [19:01:27] Lydia_WMDE: fyi https://www.wikidata.org/wiki/User:Bene*/Ordering_by_properties [22:05:50] fyi, I just marked a task as a wiki creation blocker: https://phabricator.wikimedia.org/T122512 [22:07:12] yikes [22:08:20] classic