[03:02:56] <Amir1>	 aude: hey, around?
[10:56:57] <addshore>	 Lydia_WMDE: done
[12:06:02] <Thiemo_WMDE>	 Jonas_WMDE:  https://phabricator.wikimedia.org/T117886#1969370
[12:17:00] <Lydia_WMDE>	 addshore: \o/
[12:17:02] <Lydia_WMDE>	 thanks!
[12:18:12] <sjoerddebruin>	 :)
[12:44:43] <Thiemo_WMDE>	 Jonas_WMDE: https://www.wikidata.org/wiki/Q5939824
[12:47:00] <Thiemo_WMDE>	 Jonas_WMDE: https://www.wikidata.org/wiki/Special:EntityData/Q5939824.json
[13:00:36] <benestar>	 Lydia_WMDE: is there a way to distinguish between blocking tasks and connected but not really blocking tasks?
[13:00:41] <benestar>	 in phabricator
[13:01:23] <Lydia_WMDE>	 benestar: unfortunately not. i tend to add more blockers than are strictly blockers
[13:01:31] <Lydia_WMDE>	 because it is more important for me to keep tasks together
[13:02:11] <benestar>	 hmm, k
[13:02:27] <benestar>	 i checked again and https://phabricator.wikimedia.org/T85368 really only has that one single patch as a blocker
[13:02:41] <benestar>	 so I need someone from mobile (perhaps jon) to merge it and then we can finally close that
[13:02:56] <Lydia_WMDE>	 \o/
[13:03:00] <Lydia_WMDE>	 that'd be awesome
[13:07:54] <benestar>	 Lydia_WMDE: can you give me an update on identifiers so far? I see that the formatting stuff is still in the current sprint but what about the infrastructure behind?
[13:08:09] <benestar>	 When will the new datatype be deployed for example?
[13:32:05] * benestar is confused
[13:32:29] <benestar>	 WikibaseLib defines PT:external-id while WikibaseRepo says PT:id
[13:32:43] <benestar>	 aude addshore --^
[13:32:50] <benestar>	 any idea if that is a mistake or intended?
[13:54:59] <aude>	 benestar: you need to ask daniel
[13:57:18] <benestar>	 is he in the office right now?
[14:03:28] <aude>	 benestar: no idea
[14:03:42] * aude guess he is in meetings
[14:13:34] <benestar>	 DanielK_WMDE: :D
[14:59:01] <benestar>	 Lydia_WMDE: is daniel around?
[14:59:42] <Lydia_WMDE>	 benestar: we're in a meeting right now together. so yes but no :D
[15:00:53] <benestar>	 haha
[15:01:06] <benestar>	 tell him i found some big issues in the identifier formatting code
[15:01:16] <sjoerddebruin>	 :O
[15:01:21] <benestar>	 took me an hour to understand it but now I think i found the problems
[15:01:26] <hoo>	 There is identifier formatting code?
[15:01:31] <benestar>	 there is
[15:01:37] <sjoerddebruin>	 benestar: nice work on the mobilefrontend stuff
[15:01:45] <hoo>	 Oh nice, didn't notice that getting picked up
[15:01:46] <benestar>	 and at one place it is defined as PT:id and at another point PT:external-id
[15:01:57] <benestar>	 it even works with my fixes :D
[15:02:04] <benestar>	 and hey hoo ^^
[15:02:04] <hoo>	 Oh, that
[15:02:10] <hoo>	 hey benestar :)
[15:02:17] <hoo>	 We messed so many times now with the definitions
[15:02:29] <benestar>	 true -.-
[15:02:51] <hoo>	 Only in hte last maybe 6 weeks, we rendered property link statements uneditable
[15:03:07] <hoo>	 and also broke commons media data validation in August and didn't notice until recently
[15:03:13] <hoo>	 because of lacking tests
[15:03:37] <hoo>	 (not surprising given it's plain definitions)
[15:03:50] <hoo>	 Anyway, I got to go
[15:03:53] <hoo>	 cu o/
[15:03:56] <benestar>	 bye
[15:08:14] <matej_suchanek>	 sjoerddebruin: answered by edit filters
[15:08:36] <sjoerddebruin>	 matej_suchanek: okay, yikes.
[15:08:42] <benestar>	 sjoerddebruin: hopefully the search will work as well soon
[15:08:45] <sjoerddebruin>	 Wish we had better edit filters for Wikidata
[15:08:55] <benestar>	 what's the problem?
[15:09:00] <sjoerddebruin>	 https://www.wikidata.org/w/index.php?title=Wikidata_talk:Abuse_filter&curid=20173611&diff=296561108&oldid=296548350
[15:09:09] <matej_suchanek>	 ORES could help us
[15:09:33] <matej_suchanek>	 or the quality extensions
[15:10:13] <benestar>	 quality extensions perhaps
[15:10:22] <benestar>	 but ui integration is still completely missing
[15:12:03] <sjoerddebruin>	 Yeah, would love some higher priority due to the increase of vandalism.
[15:12:35] <benestar>	 there is still a lot of stuff missing though
[15:12:41] <benestar>	 only basic checks are implemented afiak
[15:13:04] <sjoerddebruin>	 Yeah, saw that mentioned in the translations.
[15:16:08] <sjoerddebruin>	 I don't want to be rude, but the vandalism would be much lower if we ban Spanish IP ranges.
[15:21:02] <Harmonia_Amanda>	 do we have numbers?
[15:21:21] <Harmonia_Amanda>	 how many of the vandalism is committed by SpanishIP
[15:21:22] <Harmonia_Amanda>	 ?
[15:21:47] <Harmonia_Amanda>	 if it's really that major, we could talk of it on the sysop page
[15:22:01] <HakanIST>	 its alot, I got fond of the ip ranges by now
[15:22:28] <benestar>	 isn't the spanish wikipedia allowing to edit wikidata from wikipedia?
[15:22:32] <Harmonia_Amanda>	 with a ban of IP but with authorization to create an account
[15:22:39] <Harmonia_Amanda>	 ah maybe
[15:22:58] <Harmonia_Amanda>	 can we see if it's direct editions or tools/gadgets ones?
[15:24:13] <matej_suchanek>	 https://www.wikidata.org/wiki/Wikidata:Project_chat/Archive/2015/06#Revert analysis
[15:24:40] <Base-w>	 yo
[15:24:42] <sjoerddebruin>	 That was last year, but I feel we have more now.
[15:24:53] <Base-w>	 any sparql guru around?
[15:25:06] <Base-w>	 how do I filter by project rather than by language?
[15:25:25] <Base-w>	     schema:inLanguage "en" ;
[15:25:25] <Base-w>	 is useless since it filters by language
[15:25:44] <Base-w>	 thus it includes for instance both enwiki and enwikivoyage
[15:26:21] <Base-w>	 I wanted to look for enwiki's ga and it mixes it with enwikivoyage's
[15:26:58] <Base-w>	 is there something like whatever:inWiki "enwiki" ?
[15:28:30] <matej_suchanek>	 Base-w: try FILTER(SUBSTR(str(?article), 1, 30) = "https://en.wikipedia.org/wiki/")
[15:30:10] <Base-w>	 I inserted it but probably into a wrong place since it does not work. But damn it is so stupid to count url's length manually and use such things instead of having a prepared filtering method
[15:30:30] <Base-w>	 lemmi find a pastie to show the code
[15:31:58] <matej_suchanek>	 just generate a short URL for me
[15:32:57] <Base-w>	 https://dpaste.de/UHQc
[15:33:36] <Base-w>	 ah indeed i could have generated an url. didn't realise that it reflects the code in url
[15:34:10] <Base-w>	 https://goo.gl/nZySul
[15:34:47] <Base-w>	 e.g. wd:Q870844 Sentosa is a ga in wikivoyage
[15:34:51] <Base-w>	 not in wikipedia
[15:35:50] <Base-w>	 It could be that I am doing some stupid mistake in there, since it is my first time querying anything in SPARQL and I was just going on to find some articles for myself to translate, not to learn the language
[15:36:08] <matej_suchanek>	 I think I can see problem... just a minute
[15:39:15] <matej_suchanek>	 Base-w: http://tinyurl.com/je6y2ay (there is a dedicated tool to generate the short url under the edit window)
[15:43:29] <Base-w>	 oh that filter thing could be included one into another, cool. thank you. and for the tip concerning the url too :)
[16:42:45] <benestar>	 Lydia_WMDE: do we have a ticket for the list of properties that should be converted to identifier datatype?
[16:43:03] <Lydia_WMDE>	 benestar: that is ongoing on-wiki
[16:43:12] <Lydia_WMDE>	 we created a list that is being groomed
[16:43:14] <benestar>	 but is it tracked on phabricator somewhere?
[16:43:24] <Lydia_WMDE>	 let me check
[16:45:16] <Lydia_WMDE>	 benestar: nope
[16:45:50] <benestar>	 i think I'll create one than just so that it is complete on phabricator
[16:46:01] <benestar>	 btw I created some tickets and added them to the sprint
[16:46:29] <benestar>	 if patches get merged, the ui editing and formatting is perhaps already finished
[16:47:38] <Lydia_WMDE>	 \o/
[16:49:23] <benestar>	 DanielK_WMDE: around now? :)
[16:51:10] <benestar>	 Lydia_WMDE: do you know if he is still in the office?
[16:51:39] <Lydia_WMDE>	 benestar: i think so but i am in another room
[16:51:41] <Lydia_WMDE>	 frimelle: ^
[16:52:03] <frimelle>	 Yes, still here
[16:52:32] <benestar>	 nice, can you ping him ^^
[16:52:57] <frimelle>	 Yes, I did :)
[16:53:24] <DanielK_WMDE>	 benestar: hm?
[16:54:02] <benestar>	 hey DanielK_WMDE :)
[16:54:05] <benestar>	 just have a look at https://gerrit.wikimedia.org/r/#/c/266746/
[16:54:21] <benestar>	 i wonder if it is intended as it is or if I actually found a crucial bug
[16:54:27] <benestar>	 or rather two bugs
[16:54:38] <DanielK_WMDE>	 benestar: that explains why it doesn't work :)
[16:54:43] <DanielK_WMDE>	 i was just investiagting that
[16:54:53] <benestar>	 hah xD
[16:54:57] <DanielK_WMDE>	 benestar: jenkins doesn't like the patch, though
[16:55:07] <benestar>	 yes, need to adjust the test still
[16:55:21] <benestar>	 however, do you like the solution with adding PT: in the dispatcher?
[16:55:27] <benestar>	 or should that rather be trimmed elsewhere?
[16:56:12] <sjoerddebruin>	 Ugh, is there a OOjs UI guide for gadgets yet?
[16:56:17] <DanielK_WMDE>	 benestar: no, it's correct there
[16:56:26] <DanielK_WMDE>	 i wonder why this didn't show up earlier
[16:56:39] <benestar>	 fine, so with the fixed test it should be ready to get merged ^^
[16:56:46] <DanielK_WMDE>	 i guess i changed stuff around after i did some integration test manually
[16:56:55] <DanielK_WMDE>	 benestar: indeed
[16:57:18] <DanielK_WMDE>	 Jonas_WMDE: benestar found the problem :)
[16:57:21] <benestar>	 DanielK_WMDE: I also worked on the javascript stuff and I think I've done most of the work
[16:57:35] <benestar>	 at least everything works fine on my local machine :D
[16:57:38] <James_F>	 sjoerddebruin: Like https://www.mediawiki.org/wiki/Using_OOjs_UI_in_MediaWiki#Gadgets ?
[16:57:42] <DanielK_WMDE>	 benestar: the one big thing that is missing is formatting after edit. there is no way to do that yet.
[16:57:52] <benestar>	 DanielK_WMDE: i fixed that as well
[16:57:58] <DanielK_WMDE>	 oh really? how?
[16:58:04] <benestar>	 by adding the propertyId param to the RepoApi
[16:58:07] <benestar>	 there are some patches up
[16:58:15] <DanielK_WMDE>	 hm.... ok. i'll have a look.
[16:58:31] <benestar>	 I basically just pass the property id to the valueview where the datatype is already present
[16:58:39] <sjoerddebruin>	 James_F: Hm, could work. Wish there was a example with modal dialog...
[16:58:45] <benestar>	 it can then be used for wbformatvalue instead of the datatype id
[16:59:21] <DanielK_WMDE>	 benestar: and on the server side, you just contruct a PropertyValueSnak, and format that?
[16:59:36] <DanielK_WMDE>	 that module is a real mess now :/
[17:00:18] <James_F>	 sjoerddebruin: Sorry.
[17:01:05] <benestar>	 DanielK_WMDE: I didn't change the server side
[17:01:07] <benestar>	 it just worked
[17:01:29] <benestar>	 I assumed you already did that because all tickets concerning that were closed as resolved
[17:01:34] <benestar>	 the only open ticket is "use that in js"
[17:01:37] <benestar>	 which I just did 
[17:01:52] <DanielK_WMDE>	 benestar: OutputFormatSnakFormatterFactoryTest also fails
[17:01:56] <DanielK_WMDE>	 huh, maybe I did?...
[17:02:16] <matej_suchanek>	 and... my first patch for core is merged: https://gerrit.wikimedia.org/r/#/c/266701/
[17:02:35] <benestar>	 DanielK_WMDE: weird, the test works on my local machine...
[17:02:39] <DanielK_WMDE>	 matej_suchanek: congratulations!
[17:02:54] <Lydia_WMDE>	 matej_suchanek: yay!
[17:03:15] <matej_suchanek>	 Lydia_WMDE: as I promised months ago :)
[17:03:20] <benestar>	 ah no, it doesnt^^
[17:03:25] <Lydia_WMDE>	 ;-)
[17:03:43] <DanielK_WMDE>	 benestar: hehe, well, at least it's consistent!
[17:03:58] <benestar>	 just needed to add PT: at another place as well
[17:04:07] <DanielK_WMDE>	 \o/
[17:04:22] <DanielK_WMDE>	 can we now rename all occurrances of "data type" to "proeprty type"?
[17:04:55] <DanielK_WMDE>	 benestar: ping me when it passes, i'll +2
[17:05:19] <benestar>	 k
[17:05:46] <benestar>	 DanielK_WMDE: renaming those would perhaps help to avoid confusion, yes
[17:06:14] <sjoerddebruin>	 Ugh, the documentation is worser than before.
[17:06:23] <DanielK_WMDE>	 hehe...
[17:50:14] <aude>	 oh, wow... formatting identifiers works :D
[17:52:39] <benestar>	 aude: :DDD#
[18:27:06] <addshore>	 woo!
[18:29:58] <sjoerddebruin>	 ugh I want to get rid of those ugly dialogs but OOjs UI is too complicated for me
[19:06:06] <hoo>	 DanielK_WMDE: re https://phabricator.wikimedia.org/T124737
[19:06:22] <hoo>	 Unless there are strong reasons not to do it, I'll implement that step by step
[19:06:34] <hoo>	 We are blocking the migration to row based replication with that
[20:06:15] <Alphos>	 multichill : haven't had much time since yesterday to see what were the differences in results between your query and mine, but for what i saw, yours has lots of false positives - tbh, haven't seen a true positive in the first 10 ^^'
[20:07:06] <eurodyne>	 Amir1: around?
[20:07:14] <Alphos>	 and probably won't be able to do much tonight, my usual headsplitting headache has kicked in right before dinner :-(
[21:24:38] <DanielK_WMDE>	 addshore: hey! do you want the "expire watchlist" thing to be discussed on IRC soon?
[21:24:53] <addshore>	 mhhhhm, would be cool
[21:25:05] <addshore>	 so we can move on with it :D
[21:26:29] <DanielK_WMDE>	 ok, i'll see what i can do
[21:33:23] <addshore>	 DanielK_WMDE: epic!
[21:33:41] <addshore>	 DanielK_WMDE: For the time being I'm just gonna keep poking things, throwing small patches up and see what sticks ;)
[21:58:18] <DanielK_WMDE>	 addshore: looks like you are up next week, then!
[22:00:54] <addshore>	 When exactly? :p
[22:02:24] <DanielK_WMDE>	 addshore: in exactly 7*24 hours. 
[22:02:43] <DanielK_WMDE>	 this week's rfc meeting on #wikimedia-office is about to start.
[22:02:44] <addshore>	 Cool :)
[22:07:52] <Alphos>	 what is this one about ?
[22:07:56] <Alphos>	 DanielK_WMDE ?
[22:13:06] <DanielK_WMDE>	 Alphos: dropping support for php 5.3 and 5.4
[22:13:36] <Alphos>	 yay \o/
[22:13:56] <Alphos>	 (got there, but wasn't sure from reading)
[23:16:34] <multichill>	 Alphos: Hmm, maybe do a null edit run to get rid of the false positives?
[23:18:20] <Alphos>	 multichill headache got better for some time while reading today's wm office talk, but just got worse - going to sleep now before it's too serious, i'll keep you posted tomorrow for sure
[23:19:06] <Alphos>	 (as for intensity, think "really bad tooth ache", multiply by 10, apply to my left eye - this is not a joke, and i'm not exaggerating -_-° )
[23:19:35] <multichill>	 Take it easy
[23:19:48] <Alphos>	 thanks :)
[23:20:10] <edoderoo>	 try ibuprofen, or a good night's sleep!
[23:20:51] <Alphos>	 edoderoo https://en.wikipedia.org/wiki/Cluster_headache your run-of-the-mill pain meds won't work - neither will opiates or heavy doses of migraine meds