[07:45:26] nikki: it seems no ticket exists. feel free to create one as a subtask of https://phabricator.wikimedia.org/T87316 [08:56:12] Going to rip out ChangesTable next... and hope that nothing except for the tests will explode [09:10:54] hoo: when are we deploying capiunto? [09:11:05] https://en.wikipedia.org/wiki/Template_talk:Infobox_road#Luafication :) [09:11:45] aude: Uhm... right before Wikimania :P [09:11:51] But we missed that point [09:12:18] yeah [09:12:22] as far as I know the extension is ready for production [09:12:41] Additional infobox ideas wont require any changes that will break b/c AFAIR [09:12:54] then we should schedule a date and communicate it [09:13:10] in tech news, weekly summary etc [09:13:27] Yeah, that sounds like a plan [09:13:32] :) [09:14:23] Not sure how much time I have for WMDE next week... and then I'll fly to San Francisco... and then there's the birthday [09:14:51] would be a nice birthday present :) [09:14:53] So not sure I can find a lot of time for it during October :/ [09:14:59] hehe, that's true [09:16:19] We could try to get it onto test next week [09:16:24] wouldn't be hard [09:16:50] and then we can target whatever production wikis we want the week fater (or two weeks after) [09:17:26] sounds good [09:17:36] * aude can help with test, if needed [09:18:45] I don't have my schedule for next week handy [09:18:56] but AFAIR Tuesday afternoon was good for me [09:20:41] * hoo rages about the ORM stuff -.- [09:21:22] * aude also rages :) [09:28:50] aude: https://gerrit.wikimedia.org/r/244587 in case you feel like doing CR [09:30:11] * aude looks [09:30:30] but am leaving for my conference soon :) [09:30:49] Ah :) [09:30:57] Hope you have fun there [09:31:19] and can make people enthusiastic for Wikidata :D [09:31:41] wooooh [09:32:01] * aude sure they are enthusiastic [09:32:23] if you know of examples where lua / wikidata is used, let me know [09:32:28] but think i have enough examples [09:32:55] all tests passing and only very few pieces of the code still use ChangeTable (mostly the ORM test stuff itself) [09:34:06] * aude not convinced we have enough tests [09:35:14] Mh... I guess you already know most of the interesting stuff from the English Wikipedia [09:35:41] there's a lot of interesting stuff on ruwiki, but that's not that good if you can't read it at all [09:35:42] hoo: i'm especially interested in non-english, since the audience is unaware of that [09:35:55] i am aware of ruwiki, generally, and huwiki [09:36:27] and cheese infoboxes on frwiki :) [09:36:36] What I often like to show is: Go to ruwiki, select a rather well known city, see that the mayor is outdated (very likely it will be), demo to the audience that the new mayor will appear if you remove the old one [09:36:47] cool :) [09:37:29] As part of theses demos I already fixed several city articles on ruwiki I think :D [09:37:32] * aude wants to fix the place infoboxes on eswiki and haitian kreyol if i get the time [09:37:38] heh [09:40:32] hi [09:41:10] hi [09:41:16] * benestar waves :D [09:41:43] I'm looking for some numbers: total number of statements on WD, total number with a source, and with a source that is not Wikipedia... Does someone know where I can get this data ? [09:46:55] benestar: https://phabricator.wikimedia.org/T115014 [09:47:14] Ash_Crow: magnus has something for that [09:47:17] one sec... [09:47:25] https://tools.wmflabs.org/wikidata-todo/stats.php [09:47:39] aude: just add me as a subscriber if you want me to have a look at somehting [09:47:55] ok [09:47:55] I'm not able to write code atm but review and comments are possible :) [09:48:04] you are [09:48:15] I just added me :P [09:48:18] oh [09:48:31] i would be happier to choose a solution that you are ok with [09:48:40] * benestar 's busy at university currently ;) [09:48:44] based on your experience already [09:48:46] yeah [09:49:10] the replacement search module would not really help with the nearby usecase (and mobile watchlist, etc) [09:50:12] seriously... phpcs looks into my .git and fails -.- [09:50:46] aude: well, in mobile I just added the displayText thing to the api output [09:50:54] benestar: yeah [09:50:59] but we could also store all the labels in the page_props [09:51:08] that's what i was thinking [09:51:12] not sure if that works with the current implementation though :S [09:51:21] we already also have pageterms, but that might be weird and not the right thing [09:51:25] would be Q123-en => "foo" and Q123-de => "bar" then? [09:51:44] pageprops can take a parameter [09:52:08] I wonder if we run into performance problems then because our terms table is huge and lots of them are labels [09:52:23] benestar: thought about that [09:52:43] we can probably batch the lookup [09:53:13] and we already do this anyway for entity suggester anyway [09:53:28] (albeit with some performance issues sometimes) [09:54:51] aude: entity suggester stores the stuff in page props? [09:55:58] benestar: not page props but it uses terms table [09:56:29] aude: can't we just hook into that and insert our displayText using the terms table? [09:56:37] or define some global "DisplayText" lookup? [09:56:55] what is that? [09:56:58] storing all the stuff twice sounds not so nice :/ [09:57:14] oh, i see [09:57:20] i wouldn't store our stuff in page props [09:57:26] just hook in [09:57:30] oh, sorry, than I misinterpreted it :( [09:57:31] it's an api prop [09:57:51] for things like iPhone, that potentially could be a page prop similar to display title [09:58:08] if we want tomake something generic in core to hook into [09:58:36] else, just something wikibase specific for now which is okayish (espe. mobile already has stuff specific to wikibase) [09:58:37] yes, I see. So for core you want to introduce an alternative to {{DISPLAYTEXT}} that we can then hook into from Wikibase? [09:58:41] 10[1] 04https://www.wikidata.org/wiki/Template:DISPLAYTEXT [09:58:53] benestar: what i am thinking [09:59:25] that sounds like a nice approach though I'm not sure how hard it will be to introduce that in core [09:59:30] we want to get nearby done, so whatever works for now [09:59:33] yeah [09:59:46] i'd say something in wikibase then try to generalize it and put something in core [09:59:49] for now we can hook into the pageimages stuff or where the display text comes form [09:59:58] *nod* agree [10:00:12] this is not so much related to pageimages [10:00:25] what does pageimages return? [10:00:28] pageids or page titles? [10:00:33] only the file title [10:00:36] commonsmedia thing [10:00:43] no problem there [10:00:52] ah, sorry, I meant nearby api ;) [10:00:58] <- confused :P [10:01:02] nearby returns Q ids (page title text) [10:01:16] like https://phabricator.wikimedia.org/F2658352 [10:01:18] :( [10:01:33] and mobile watchlist is almost same code for presentation [10:01:42] https://phabricator.wikimedia.org/F2666241 [10:02:11] aude: Hi. I'm pretty happy with the Special:Nearby related patches now. [10:02:20] Thiemo_WMDE: great [10:02:35] there will be follow ups to do, but would be nice to get an initial version [10:03:08] My idea is to rebase your patch on to of my 2 patches. Is this ok for you? [10:03:22] suppose so [10:03:51] not sure i totally like the way it's split, but if it works and jonas is happy etc [10:04:02] aude, thanks [10:04:05] to get this moving [10:04:08] Ash_Crow: sure [10:04:22] aude: You can compare PS1 and PS2 in https://gerrit.wikimedia.org/r/244643 to see what I did to your classes. [10:04:49] Would be cool to get a +1 from you for that. I will do the rebase then. [10:05:49] errrr [10:07:27] it's a lot more than split [10:07:40] * aude needs to take time to review and really don't have much time right now [10:13:28] Thiemo_WMDE: if jonas can review and is happy, then i am happy enough [10:13:42] and fix the naming issues please [10:13:56] * aude needs to go [10:19:18] About a problem i found - https://www.wikidata.org/wiki/Wikidata:Project_chat#Problem_with_Qualifers [10:19:26] How do you flatten a graph ? [10:19:32] into a tree :) [10:20:23] I'm using Baker Street Station as an example :) [10:25:42] "Currently the qualifiers are collapsed"? [10:27:44] In that the are all group together [10:28:12] rather than being seperate instances of the same qualifer property with a different value [10:29:14] i..e the interface does connecting line ; X,Y rather than connectingline:X , connectingline:Y [10:29:44] I suppose it's a Data normalisation porblem [10:29:47] *problem [10:31:47] I gave some examples on the project chat post [10:32:31] Ah yes, now I understand. Mostly I just create another statement. [10:33:02] * aude off :) [10:35:01] ShakespeareFan00: It's allowed to add the same value but with different qualifier values: https://www.wikidata.org/wiki/Q5308880#P39 [10:35:50] and in respect of Chalfont and latimer I thought I'd done that [10:35:57] Hmm [10:36:37] sjoerddebruin: There's also the consideration that between Amersham and chalfont the two connecting lines listed are the SAME physical rail tracks [10:36:56] even though the connecting line tags at present could infer/imply otherwise [10:37:35] maybe connecting_line needs a clarification as to its application to "physical rail track configuration" or " logical service pattern"? [10:38:34] In a lot of cases the "physical connecting line" and "connecting passanger service" will be the same entity, but .... [10:40:57] in others what the "connecting passanger service" could be completly different from the track configuration... an example being the North London Line, London Overground or various Subway "Trains" in New York City [10:42:06] Feeedback in the relevant thread would be apreciated [11:15:20] Hmm - https://www.wikidata.org/w/index.php?title=Q800623&action=history - Currently I can't leave edit summaries to explain changes [11:15:27] I just get generic ones [11:15:51] On some changes I'd like to leave a fuller explanation [11:16:09] There is a script to do that somewhere. [11:16:57] https://www.wikidata.org/wiki/User:Bene*/summary.js [11:20:35] Thanks [11:24:23] DanielK_WMDE: I got a couple more changes up to remove the ORM stuff [11:24:34] ChangesTable is only being used in tests with the last one [11:25:10] reviews appreciated [11:53:06] DanielK_WMDE: Yes, please test the whole chain at once [11:53:32] I did some basic testing after each patch (change stuff, make sure it dispatches and the client handling works) [11:53:35] but not much more [12:02:22] Not much needed to remove the dependency to ORMRow from ChangeRow [12:02:26] now [12:02:35] but I think I'll only touch that after the other stuff got in [12:03:12] After taht is done, we can actually start to make these things sane :D [12:08:45] * aude waves again :) [12:09:31] aude: o/ [12:10:26] second breakfast :) [12:36:09] hey aude! did you guys figure out how to work around githubs limits when viewing a large diff? also, how are things? [12:38:43] bye [12:40:16] hi manybubbles [12:40:27] not that i know [12:42:51] awe! [12:42:54] oh well. [12:42:58] how are you then? [12:43:02] i'm good [12:43:07] you might as JeroenDeDauw [12:43:08] ask* [12:43:28] how's it going at elastic? [12:45:15] The misuse of p140 has finally reached the point where we have to change the label: https://www.wikidata.org/wiki/Property:P140 500+ links to atheism! [12:47:09] Oh? [12:47:28] Constraints are still the same. [12:50:01] Yeah, but the label is the important thing "religion = atheism" is wrong. But people keep adding these values. That means that the property is not about religion in the normal sense of the word. [12:53:16] tobias47n9e__: nice. I every time you see P140 atheism you can replace it with "no value"? [12:53:51] aude: its going. lots to do that feels very far out to users- I'm writing code in master which won't be released for 6 or 9 months. [12:54:19] other stuff I'm doing in the 2.0 branch which will be released in, well, RC.1 is just out [12:54:47] Lydia_WMDE: done :) https://phabricator.wikimedia.org/T115112 [13:17:55] manybubbles: sounds cool [13:18:18] even if it takes times for the release [13:18:58] aude: its something. It neat working in a team with more similar skills. I was pretty alone at WMF in that regard. it was hard to get reviews on hard things. [13:21:04] yeah :/ [13:21:39] * aude adding arbitrary kitten to my conference slides :) [13:41:13] nikki: thx :) [13:42:53] <3 [13:57:38] Lydia_WMDE: around? [13:57:40] hey :) [14:06:21] Amir1: hey [14:06:35] Hey! [14:41:40] DanielK_WMDE: around? [15:15:32] aude: yea. i'm hacking up PageTerms to support this. [15:15:38] Jonas_WMDE: https://de.wikipedia.org/w/api.php?action=query&prop=pageterms&titles=London [15:15:54] aude: it just needs a small nudge to also work on the repo [15:22:21] DanielK_WMDE: ok :/ [15:23:20] i don't want to special case to request the api prop [15:23:28] ideally, but let's see [15:41:05] aude: you'd also need that if we were to use page_props. [15:41:34] Jonas_WMDE, Thiemo_WMDE, aude: https://gerrit.wikimedia.org/r/#/c/244698/ [15:41:36] i would prefer something generic, 'displaytext' [15:41:43] ideally [15:42:00] that's pretty much what prop=pageterms is [15:42:09] "give me the description for this page" [15:42:14] "give me a label for that page" [15:42:15] does it return titletext for wikitext pages? [15:42:28] no, it returns the label of the associated item [15:42:42] (currently without fallback, that sucks) [15:42:55] JS would decide what to do if it is or isn't there [15:42:59] :( [15:43:03] Jonas is working on that end [15:43:34] aude: i actually think this is the Right Thing, except that it doesn't integrate with displaytext [15:43:36] what js? [15:43:39] err, displaytitle [15:43:47] displaytitle is not the right thing also [15:43:47] Nearby.js [15:44:06] well, displaytitle is the right thing for wikipedia pages, if there is no item [15:44:09] displaytitle can be crazy htmls stuff [15:44:13] yea, i know [15:44:25] for searchdisplaytext, it would be stuff like "iPhone" :) [15:44:33] when we started to set the displaytitle on the parseroutput, it didn't get written to pageprops yet [15:44:34] as i envision, w/o crazy html [15:44:38] for wikibase, displaytitle doesn't work [15:45:00] aude: untangeling that is going to be tricky. we need it for actual display. [15:45:10] sure [15:45:30] displaytext would be useful not just for nearby, but generally in all the places we search/query [15:46:31] since mobile already uses pageterms, maybe it's not so bad [15:46:55] but want it to work in the right way for wikitext pages vs. entities [15:50:37] DanielK_WMDE: do you mind if i poke more at pageterms to make it less hacky? [17:55:14] hello [17:55:47] !admin [17:55:52] Carlos73: hi [17:56:09] hello John [17:56:19] what can I do for you? :) [17:57:02] I am curious about how a friend of mine got listed in Wikipedia? [17:57:14] can you [17:57:24] help me figure out [17:58:02] It might be best to ask the community of the Wikipedia rather than Wikidata as they'll be able to give you more indepth answers than we can likely :) [18:00:25] thanks [18:00:31] see y'all [19:17:51] aude: I like how your Wikipedia-cupcakes are still used as stock imagery in presentations [19:18:14] ...That were served *in this building*, no less! [19:18:18] It all goes back to NARA. [20:08:31] harej: and the cupcake logo! :) [20:08:37] on t-shirts [20:48:42] I love the cupcake logo [20:49:02] :) [20:49:14] so I hope it gets many more years of use! (with alterations to the candles, obviously) [20:49:20] * aude wishes for wikidata cupcakes! [20:52:05] * aude off [23:18:53] How can I remove "+/- 1" from the population value at https://www.wikidata.org/wiki/Q61#P1082 ? "Population: 658,893±1" looks bad. [23:20:57] Emw: Looks like the answer is edit it, and remove the +/- 1 [23:23:36] Reedy, that doesn't work for me. When I go to https://www.wikidata.org/wiki/Q61#P1082, click "edit" for the 658,893±1 claim, and remove the +/- 1 , the "save" link remains disabled [23:24:09] That's interesting [23:24:11] * Reedy logs in [23:24:38] Emw: you have to set it to +-0 [23:24:51] it seems awkward but yeah... :) [23:25:01] heh [23:25:38] Wow. That's very unintuitive. Thanks though, JohnFLewis. [23:35:45] JohnFLewis: what's your favorite game on https://tools.wmflabs.org/wikidata-game/# [23:36:19] mutante: occupation [23:37:10] JohnFLewis: :) check stats [23:40:44] JohnFLewis: 4th? :o [23:41:03] mutante: ^ bah [23:43:01] haha, i noticed and of course i have to fix that [23:45:55] a common suggestion that's weird for occupation but keeps coming back [23:46:00] "art of sculpture" [23:46:34] i get it but it still sounds a bit wrong [23:46:45] "sculpturist" rather [23:50:52] category: "clowns" vs. "serial killers"