[02:47:45] dennyvrandecic: am I being blind, or does this freebase converter thing you mailed about not have a single test? [06:45:12] hey all [06:45:26] who wants to write some articles about our favorite tv shows? aw heck [06:46:40] * injest slaps tommorris around a bit with a large fishbot [07:37:41] =o [08:03:03] * JeroenDeDauw looks suspiciously at addshore [08:03:10] o/ [08:04:16] addshore: upgraded to PHPUnit yet? It's been out for hours at this point... [08:04:22] I have not :p [08:05:14] Step 1: be happy to have upgraded to 5.0. step 2: realize some colleagues refuse to upgrade away from 3.7 >_> [08:06:21] im on 4.5 currently [08:07:12] the question is JeroenDeDauw have you updated to 5.0.1? ;) [08:07:38] >_> [08:08:12] Fatal error: Trait 'PHPUnit_Extensions_Database_TestCase_Trait' not found in phar://phpunit.phar [08:08:48] wtf [08:08:57] okay, 5.0 didnt work for me, I upgraded to 4.8.10 though ;) [08:09:00] I just changed from 5.0.0 to 5.0.1 and got that [08:09:07] oooooohhh [08:09:10] addshore: its your fault [08:09:13] *looks on github [08:09:20] so they made an "unfix" release???? [08:09:26] hrhrhr [08:10:53] https://github.com/sebastianbergmann/phpunit/issues/1887 [08:15:17] hahaha, that bug title [08:15:53] Might be a glitch in the tarball build, rather than an actual defect in the release [08:15:56] err, phar build [08:18:07] addshore: well, all the more reason to just switch to 5.1 beta :D [08:18:12] Working fine for me [08:18:29] And DM and DMS tests pass on it [08:21:14] :D [08:27:57] haha, people on twitter are now raging at me for praising PHPUnit dropping obsolete PHP version support [08:28:19] but that's a good thing. [08:32:10] aude: do you have your slides / links from https://twitter.com/wikidata/status/622832881946091521 ? [09:04:34] addshore: there are no slides [09:04:54] * aude wants to put this stuff on labs [09:05:08] next beer & cake day :) [09:49:02] :D [09:55:03] The patch I talked about: https://gerrit.wikimedia.org/r/#/c/234485/ [09:55:28] I'll try to have a look at that later on [10:00:28] Lydia_WMDE: hey. i'm not coming in today, got the crud. i'll work a bit from home, though. [10:00:47] DanielK_WMDE: ohnoes. Gute Besserung! [10:01:06] thanks. not too horrible yet. i hope it will stay that way. [10:01:28] Lydia_WMDE: regarding the birthday party: there's the regular Open Editing session on that day. we sould integrate the editathon! [10:01:51] already done ;-) [10:02:19] Lydia_WMDE: DanielK_WMDE fyi https://phabricator.wikimedia.org/T114330 [10:02:29] not urgent but just something i noticed [10:02:31] Lydia_WMDE: \o/ [10:02:50] DanielK_WMDE: and get well soon ... [10:04:09] thanks :) [10:09:39] Lydia_WMDE: can you give access to wmde/Assert to wikidata devs? https://github.com/wmde/Assert/settings/collaboration [10:09:54] idunno [10:09:56] let me try [10:09:56] :D [10:09:56] apparently, i can't, for some reason. [10:10:12] i have a box for adding teams, but it never finds any teams, no matter what i enter [10:10:25] why do people say github is easy to use? i find it totally confusing [10:11:04] done [10:11:06] and yeah [10:11:20] so... any idea how this makes sense? [10:11:46] nope [10:12:01] actually, can you also add teams from other organizations? [10:12:03] like wmf? [10:12:43] DanielK_WMDE: adding people is good for the short term [10:12:45] no [10:12:56] * aude found it odd that as wmde staff + core developer, i didn't have rights there [10:13:08] aude: i'm fine with moving to gerrit [10:13:10] also nice how https://github.com/wmde/Assert/settings/collaboration gives a 404 when not logged in [10:13:11] -.- [10:13:13] DanielK_WMDE: cool [10:18:33] benestar|cloud: you broke PHP5! NAAAAAAAAAAAW! https://github.com/wmde/WikibaseDataModelServices/pull/72 [10:18:36] addshore: ^ panic [10:18:45] *PHPUnit 5 [10:18:47] #derp [10:19:13] an experimental timeline in the Knowledge Graph https://plus.google.com/+FlorianKiersch/posts/iUm4FNcQWNs [10:31:41] DanielK_WMDE: Lydia_WMDE https://phabricator.wikimedia.org/T114474 (what i want to focus on for the summit) [10:32:09] still working to update and would want some time to code something that demonstrates the ideas [10:32:26] (also interested in working on the search topic, together with whoever is interested) [11:19:25] aude: regarding RC code, i'd like to talk to you about the nex hooks some times. [11:19:38] is it possible that the new hooks would Just Work with enhanced RC? [12:05:36] DanielK_WMDE: no [12:05:50] the hooks you talk about are regarding filtering which is no problem either way [12:06:09] problems are with grouping and most importantly formatting of the variosu bits [12:06:34] the flow people did introduce some hooks though, but 1) not sure they are sufficient 2) it's hacky [12:15:17] aude: there are several new hooks... and several of the ones we use are deprecated. we should look into that in any case. [12:15:23] grouping... yea. ugh. [12:17:00] DanielK_WMDE: i'd like to try again at implementing the integration and poke at the recentchanges code [12:18:17] I wonder whether I should submit https://gist.github.com/mariushoch/72bb5edeca5ccd5c2eca [12:22:53] can someone help me make https://www.wikidata.org/wiki/Wikidata:Third_Birthday/Party translatable? martin has created the german version without the translate extension [12:34:45] hoo: sure, why not? sounds useful. [12:35:03] what do you think, hashar? [12:35:35] addshore: poke [12:35:43] addshore: how good are you with translate? [12:38:37] :/ hate it, so not very :D [12:42:06] addshore: We "solved" it [12:43:35] Lydia_WMDE: I just realized that the " datatype specific Snak rendering" tracking ticket already has a nice breakdown. [12:44:13] Lydia_WMDE: in particular, we have https://phabricator.wikimedia.org/T112754 and the three tickets that block it [12:45:38] I'll add all of them to this sprint's "proposed" column, and commit to two of the "lowest" blockers, ok? [12:48:19] not sure what to do with the tracking ticket. it's not actionable by itself. since tobis comment calls for a breakdown, i'll move it to the done column, but keep it open. [13:00:16] ok [13:00:29] sorry - fighting with translations [13:01:08] hi, someone investigating the issue with sitelinks not showing up on the clients? [13:01:55] matej_suchanek: hoo|away was looking into ot [13:01:58] *it [13:02:09] I have a new case [13:02:15] and not purged [13:02:19] so still without them [13:02:23] plz remind me of the bot policy - is running unapproved bot prohibited? [13:02:50] bot not went through WD:RFP/Bot [13:04:02] revi: I suppose it should not edit fast if it's not approved [13:04:21] hmmmm so unapproved bot not strictly prohibited? [13:05:37] I am not sure either [13:06:16] Lydia_WMDE: I updated the weekly document. [13:06:19] my interpretation of https://www.wikidata.org/wiki/Wikidata:Bots is that they are, but it could be clearer [13:07:06] since it says people should create an account for the bot, and the bot account shouldn't make contributions that don't fall within the scope of the approved tasks [13:07:19] (and you need it to be approved to get a bot flag) [13:08:35] Lydia_WMDE: I would like to notify translators about the party page, could you provide a short message to send? [13:09:14] matej_suchanek: tbh not sure how useful it is to translate this page... i think it is a waste of time. the real page with the birthday wishes etc is more important later [13:09:19] DanielK_WMDE: sorry missed the ping. I am thinking about YAML right now :-} [13:09:25] i am just doing this one because someone in the office already did it (wrong) [13:09:39] and the local editors might want it [13:09:55] so no need to send a notification? [13:10:31] yeah imho not [13:11:17] hoo|away: DanielK_WMDE regarding phpunit profiling ( https://gist.github.com/mariushoch/72bb5edeca5ccd5c2eca ) phpunit.php is a Maintenance script and already has: --profiler: Profiler output format (usually "text") [13:12:22] commented on the gist [13:13:43] meh [13:13:45] hashar_: don't think about yaml right now, it's not healthy [13:13:57] Then it's better to change the policy [13:14:04] DanielK_WMDE: at least it supports inline comments :-} [13:14:06] * revi closes Special:Block page [13:22:42] matej_suchanek: Saving the translation failed: Unknown error: "tpt-unknown-page" <- i get this error when translating [13:23:46] this problem comes back regularly, I will do a dummy edit and re-mark [13:27:18] thx [13:28:26] Lydia_WMDE: does work? [13:28:36] trying in a sec [13:29:05] matej_suchanek: yes. thanks! [14:05:23] hashar: phpunit profiling? what did I miss? [14:07:36] JeroenDeDauw: mediawiki/core tests/phpunit.php is a Maintenance script, so it has a --profiler switch [14:07:41] that rely on mw/core profiler [14:08:00] hoo was proposing to add something similar solely to phpunit.php ( https://gist.github.com/mariushoch/72bb5edeca5ccd5c2eca ) [14:08:08] neither used it to be honest [14:56:54] JeroenDeDauw: yes, that's true. it's a one-off script basically, not a tool to be used repeatedly. [14:59:00] hashar: That option doesn't work for phpunit.php [14:59:26] Because it does insane special stuff [15:01:30] :( [15:06:54] Jonas_WMDE: Around? Will you add a test for https://gerrit.wikimedia.org/r/243135 ? Or should I do this? [15:07:31] I think marius will, but you are welcome to do it if you like [17:02:01] Lydia_WMDE: https://phabricator.wikimedia.org/T111780 [21:42:02] Hi [21:42:38] Does anybody know how to use entity:getSiteLink()? [21:43:30] I'm trying to do something on ukwq but my lua is to low to determine whether I do it wrong or it does not work anyway [21:44:16] !lua [21:44:18] :( [22:07:11] Base: hm, I don't know anything about lua and it seems like nobody else is around :( have you looked at how other wikis are using it? [22:09:43] and if you can't figure it out and nobody shows up here, I would suggest asking on the project chat page, that doesn't depend on people being awake and on irc at the same time as you to get an answer :) [22:13:36] Base: still there? I may be able to help [22:25:31] Jens_WMDE still here but I got it [22:25:41] Base: cool! [22:25:54] Base: care to share the module? [22:29:26] Mm irc from mobile and edit from pc - hard copypaste. Lemmi add the func to enwiki module so that guys improve it [22:30:16] Base: no need to stress out. [22:31:38] Base: just curious. I always like to see the wikidata lua functions being used, as I originally wrote that :) (but haven't worked on it for years now) [22:34:50] Oh cool) well adding to enwiki in my case would probably be useful as my lua really sucks) though you might just take a look at it at [[q:uk:Module:Wikidata]], last but one function. Some "profread" before posting to enwiki will be definitely good [22:34:51] 10[1] 10https://uk.wikiquote.org/wiki/Module:Wikidata [22:35:54] The simplemost function actually but with my level of lua it is not the easiest thing to do [22:38:08] Base: function p.getSiteLinks(frame)? [22:38:23] Yep [22:38:26] Base: There's nothing I would add to it :) [22:39:03] Base: well, except the indention for the first "return", maybe. [22:41:04] Base: looks good, and if it works, there's nothing to improve. [22:42:29] Looks like working [[uk:q:Стівен Гокінг]] [22:42:30] 10[2] 10https://uk.wikiquote.org/wiki/%D0%A1%D1%82%D1%96%D0%B2%D0%B5%D0%BD_%D0%93%D0%BE%D0%BA%D1%96%D0%BD%D0%B3 [22:43:19] Ok thanks you for reviewing [22:57:26] Base: actually, it's kind of amazing that this function wasn't in the wikidata module before. it's pretty basic and much needed. [23:00:20] Yes it is. It was surprizing to not find it. I was almost sure that it wouldn't work and that just was forgotten to be reflected in the docs. But it did work :) [23:02:13] Oh but I see a window to improve the func. An argument for any entity id, not just connected to the caller page should be added) [23:02:32] Edited the module on enwiki btw [23:36:55] Jens_WMDE how do I do so that I don't get errors because of trying to get entity when page is still not connected to wd? Can I check whether a page is connected somehow? [23:38:20] Base: I think that you cannot :( [23:43:07] Oh but if not entity then return end helped [23:43:17] At least error disappeared